Code review comment for ~sahnaseredini/ubuntu-cve-tracker:amir-dev
Revision history for this message
| Amir Naseredini (sahnaseredini) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Alex:
Thanks for the review. I agree that the check is a bit invasive, so I applied and pushed one of the Steve's suggestions. Now it's trying to get the staged files and checks if:
1- they're in UTC/active
2- they've got any unstaged changes
Also regarding moving the checks to pre-push hooks, when possible I generally like to see commits stable on themselves as opposed to in groups e.g. just in case someone needed to go back and checkout one of them. that's why I think having pre-commit hooks can still be a good idea. So I agree with Steve regarding having them.
Please let me know what you think.
Steve:
Thanks for the review. The new commit should mitigate the situation a lot more based on one of your suggestions and as explained above.
Please let me know what you think.