Code review comment for ~sahnaseredini/ubuntu-cve-tracker:amir-dev

Revision history for this message
Alex Murray (alexmurray) wrote :

Whilst I like the purpose of this change, I wonder if it may be too invasive as it breaks the ability to easily break up one large change into multiple smaller commits (without then having to 'ignore' each until the last one is reached).

I wonder if we should instead move our hooks to `pre-push` rathar than `pre-commit` since then we can try and ensure the entire set of changes is consistent?

« Back to merge proposal