Merge lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests into lp:ubuntu-manual-tests
Proposed by
Rohan Garg
Status: | Merged |
---|---|
Merged at revision: | 272 |
Proposed branch: | lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests |
Merge into: | lp:ubuntu-manual-tests |
Diff against target: |
56 lines (+52/-0) 1 file modified
testcases/image/1311_Non-English Installation Full Network Support (Kubuntu) (+52/-0) |
To merge this branch: | bzr merge lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicholas Skaggs (community) | Needs Fixing | ||
Review via email: mp+207882@code.launchpad.net |
Description of the change
Add a foreign language testcase for Kubuntu
To post a comment you must log in.
Rohan, thank you much for your contribution. There's a couple small tweaks we need before we can merge this. First can you run this tool against your merge to fix the html formatting issues?
https:/ /wiki.ubuntu. com/QATeam/ ContributingTes tcases/ ManualStyleGuid e#Check_ format_ script
Atm, it's returning the following issues:
line 52 column 139 - Error: unexpected </dt> in <dd>
line 60 column 40 - Warning: unescaped & which should be written as &
line 100 column 1 - Error: unexpected </dl> in <dd>
2 warnings, 2 errors were found!
Next, the first part of the test is a copy of the existing test for Non-english installs. This works for all flavors. I see you want to add a check for specific kubuntu issues that might appear during a non-english install? In general we try and avoid specifying too many things, but if you want to keep it as kubuntu specific it can work. I would recommend removing the first part of the testcase which is a copy of 1311_Non-English\ Installation\ Full\ Network\ Support, and simply add the second half as a new testcase for kubuntu that will check for translation issues. Does this make sense?
Anyone else have a thought on this merge?