Merge lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests into lp:ubuntu-manual-tests

Proposed by Rohan Garg
Status: Merged
Merged at revision: 272
Proposed branch: lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests
Merge into: lp:ubuntu-manual-tests
Diff against target: 56 lines (+52/-0)
1 file modified
testcases/image/1311_Non-English Installation Full Network Support (Kubuntu) (+52/-0)
To merge this branch: bzr merge lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+207882@code.launchpad.net

Description of the change

Add a foreign language testcase for Kubuntu

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Rohan, thank you much for your contribution. There's a couple small tweaks we need before we can merge this. First can you run this tool against your merge to fix the html formatting issues?

https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide#Check_format_script

Atm, it's returning the following issues:
line 52 column 139 - Error: unexpected </dt> in <dd>
line 60 column 40 - Warning: unescaped & which should be written as &amp;
line 100 column 1 - Error: unexpected </dl> in <dd>
2 warnings, 2 errors were found!

Next, the first part of the test is a copy of the existing test for Non-english installs. This works for all flavors. I see you want to add a check for specific kubuntu issues that might appear during a non-english install? In general we try and avoid specifying too many things, but if you want to keep it as kubuntu specific it can work. I would recommend removing the first part of the testcase which is a copy of 1311_Non-English\ Installation\ Full\ Network\ Support, and simply add the second half as a new testcase for kubuntu that will check for translation issues. Does this make sense?

Anyone else have a thought on this merge?

Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Needs Fixing
Revision history for this message
Rohan Garg (rohangarg) wrote :

> Rohan, thank you much for your contribution. There's a couple small tweaks we
> need before we can merge this. First can you run this tool against your merge
> to fix the html formatting issues?
>
> https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide#Check_fo
> rmat_script
>
> Atm, it's returning the following issues:
> line 52 column 139 - Error: unexpected </dt> in <dd>
> line 60 column 40 - Warning: unescaped & which should be written as &amp;
> line 100 column 1 - Error: unexpected </dl> in <dd>
> 2 warnings, 2 errors were found!
>

Ah, I'll do that first thing tomorrow.

> Next, the first part of the test is a copy of the existing test for Non-
> english installs. This works for all flavors. I see you want to add a check
> for specific kubuntu issues that might appear during a non-english install? In
> general we try and avoid specifying too many things, but if you want to keep
> it as kubuntu specific it can work. I would recommend removing the first part
> of the testcase which is a copy of 1311_Non-English\ Installation\ Full\
> Network\ Support, and simply add the second half as a new testcase for kubuntu
> that will check for translation issues. Does this make sense?
>

You're right, the purpose of the test is to catch regressions in KDE Applications with incomplete l10n since we've seen regressions cropping up in specific applications right before release and this test case will help close some holes and improve QA. Your suggestion makes perfect sense and I'll fix my test appropriately.

272. By Rohan Garg

Drop duplicated information, fix errors

Revision history for this message
Rohan Garg (rohangarg) wrote :

Fixed up as per suggestions, please re review

Revision history for this message
Elfy (elfy) wrote :

I too would prefer to see this as a seperate testcase for Kubuntu, echoing Nick's earlier comments.

In general I think it better to keep agnostic testcases as such and add extra's for those flavours requiring more from a testcase.

Revision history for this message
Elfy (elfy) wrote :

Approved and merged.

Thanks Rohan

Revision history for this message
Rohan Garg (rohangarg) wrote :

Thanks for your time :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'testcases/image/1311_Non-English Installation Full Network Support (Kubuntu)'
2--- testcases/image/1311_Non-English Installation Full Network Support (Kubuntu) 1970-01-01 00:00:00 +0000
3+++ testcases/image/1311_Non-English Installation Full Network Support (Kubuntu) 2014-02-27 19:20:30 +0000
4@@ -0,0 +1,52 @@
5+The goal of this test case is to check that localization support is functional during the installation and that language packs are downloaded and installed correctly from the Internet for Kubuntu.
6+<dl>
7+ <dt>Boot up the image. Follow the steps listed in the Non-English Installation Full Network Support test before proceeding.</dt>
8+ <dt>Click on the launcher, are all the entries localized?</dt>
9+ <dt>Click on the entry labeled 'System Settings', are all the entries in the new window that appears localized?</dt>
10+ <dt>Open the entry marked as 'Locale' in the new window, is the correct language selected in the settings?</dt>
11+ <dt>Click the tab labeled 'Numbers', is the correct decimal separator chosen for your region?</dt>
12+ <dt>In the same tab, has the correct Digit set been chosen for your region?</dt>
13+ <dt>Click the tab labeled 'Money', has the correct currency been chosen for your region?</dt>
14+ <dt>Click on the tab labeled 'Date &amp; Time', has the correct time format been chosen for your system?</dt>
15+ <dt>Click on the tab labeled 'Other', has the correct measurement system been chosen for your system?</dt>
16+ <dt>Click on the 'Overview button to go back to System Settings, and open the entry marked as "User Manager"</dt>
17+ <dd>Are all the text labels localized?</dd>
18+ <dt>Click on the 'Overview button to go back to System Settings, and open the entry marked as "Login Screen"</dt>
19+ <dd>Is the text in the ui localized?</dd>
20+ <dd>Click on the tab labelled "General", are all labels localized?</dd>
21+ <dt>Click on the 'Overview button to go back to System Settings, and open the entry marked as "About System"</dt>
22+ <dd>Are all the labels localized?</dd>
23+ <dt>Click on the 'Overview button to go back to System Settings, and open the entry marked as "Instant Messaging and VOIP", is the UI localized?</dt>
24+ <dt>Click on the button marked as "Add Account" and complete the process to add a IM account, was entire process localized?</dt>
25+ <dt>Click on the launcher and then click on the entry marked as "Instant Messenger Contacts" to open your contact list, has the contact list UI been localized?</dt>
26+ <dt>Open a conversation window with a friend and send them some messages</dt>
27+ <dd>The keyboard layout should be correctly set</dd>
28+ <dd>The language that appears on the screen should be localized</dd>
29+ <dd>Direction of text should be correct (RTL vs LTR)</dd>
30+ <dt>Close/Minimize all windows, right click on the desktop, is the context menu localized?</dt>
31+ <dt>Click on the "Default desktop settings" entry, is the new window that appears localized?</dt>
32+ <dt>Click on the launcher, launch "Muon Discover" via Applications > System > Muon Discover</dt>
33+ <dd>Is the toolbar localized?</dd>
34+ <dd>Is all the text in the featured application slideshow localized?</dd>
35+ <dd>Are all the application category names localized?</dd>
36+ <dt>Open an application entry to see it's description in Muon Discover</dt>
37+ <dd>Is the application description localized? (This is currently known not to work)</dd>
38+ <dt>Click on the launcher, launch "Dolphin"</dt>
39+ <dd>Is the "Places" panel on the left localized?</dd>
40+ <dd>Are the entries on the top panel localized?</dd>
41+ <dd>Are the entries in the "Control" menu localized?</dd>
42+ <dd>Launch the "Dolphin" settings via the "Control" menu</dd>
43+ <dt>Click on the launcher, search for "Kamoso" via the search bar and launch it</dt>
44+ <dd>Click on the wrench icon, are the entries localized?</dd>
45+ <dd>Click on the entry marked "Settings", is the "Settings" window localized?</dd>
46+ <dt>Click on the launcher, search for "Gwenview" via the search bar and launch it</dt>
47+ <dd>Is the "Places" tab on the right localized?</dd>
48+ <dd>Is the "Tags" tab on the right localized?</dd>
49+ <dd>Click on the menu item labeled "Edit", are the entries localized?</dd>
50+ <dt>Click on the launcher, search for "Muon Update Manager" via the search bar and launch it</dt>
51+ <dd>Make sure all the strings are localized</dd>
52+ <dd>Try and upgrade your system, is the "Download Rate" at the bottom left correctly localized?</dd>
53+ <dd>Are all the authentication dialogs correctly localized?</dd>
54+</dl>
55+<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
56+ If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>

Subscribers

People subscribed via source and target branches