Code review comment for lp:~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests

Revision history for this message
Rohan Garg (rohangarg) wrote :

> Rohan, thank you much for your contribution. There's a couple small tweaks we
> need before we can merge this. First can you run this tool against your merge
> to fix the html formatting issues?
>
> https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide#Check_fo
> rmat_script
>
> Atm, it's returning the following issues:
> line 52 column 139 - Error: unexpected </dt> in <dd>
> line 60 column 40 - Warning: unescaped & which should be written as &amp;
> line 100 column 1 - Error: unexpected </dl> in <dd>
> 2 warnings, 2 errors were found!
>

Ah, I'll do that first thing tomorrow.

> Next, the first part of the test is a copy of the existing test for Non-
> english installs. This works for all flavors. I see you want to add a check
> for specific kubuntu issues that might appear during a non-english install? In
> general we try and avoid specifying too many things, but if you want to keep
> it as kubuntu specific it can work. I would recommend removing the first part
> of the testcase which is a copy of 1311_Non-English\ Installation\ Full\
> Network\ Support, and simply add the second half as a new testcase for kubuntu
> that will check for translation issues. Does this make sense?
>

You're right, the purpose of the test is to catch regressions in KDE Applications with incomplete l10n since we've seen regressions cropping up in specific applications right before release and this test case will help close some holes and improve QA. Your suggestion makes perfect sense and I'll fix my test appropriately.

« Back to merge proposal