Merge lp:~roadmr/checkbox/packaging-canonical-certification-server-updates into lp:~checkbox-dev/checkbox/checkbox-packaging

[Daniel Manrique]

Removes the canonical-cert-server binary from canonical-cert-server, as it's now part of checkbox-ng. c-c-s depends on the proper version of checkbox-ng to contain the binary. checkbox-ng breaks versions of canonical-cert-server older than this one (fuzzy since I don't know the exact version yet) so that installing checkbox-ng on a system with older c-c-s properly upgrades that one, rather than exploding due to conflicting files.

Removes the canonical-cert-server binary from canonical-cert-server, as it's now part of checkbox-ng. c-c-s depends on the proper version of checkbox-ng to contain the binary. checkbox-ng breaks versions of canonical-cert-server older than this one (fuzzy since I don't know the exact version yet) so that installing checkbox-ng on a system with older c-c-s properly upgrades that one, rather than exploding due to conflicting files.

[Jeff Lane  (bladernr)]

I'm confused... does this mean the providers will no longer provide the binaries to launch plainbox? So anyone who wishes to create a provider and provide a binary to launch the harness will also need to submit code to checkbox-ng?

Or is this just to work around a temporary issue?

review: Needs Information

[Ara Pulido (ara)]

I agree with Jeff, I think canonical-cert-server binary should be part of of canonical-cert-server.

A provider should not only provide whitelists and tests, but the ability to quickly run those.

I am thinking here about the CE QA use case, for example.

Let's think this way:

Elsa, who is the QA lead for Lenovo, works for a while in creating the Sutton provider with the specific tests for Sutton (plus she knows all certification tests need to run as well).
She creates a new provider with a whitelist with the lenovo tests and pointing to all cert tests.
She creates a binary that runs checkbox-gui with that whitelist
She packages the provider (including the binary) and adds extra dependencies if needed (i.e. certification provider)

Then, all CE QA members testing a Lenovo system, only need to do:

$ sudo apt-add-repository ppa:sutton-2014-testing
$ sudo apt-get update
$ sudo apt-get install sutton-2014-testing
$ sutton-2014-testing

withtout knowing anything about the complexity of dependencies.

[Daniel Manrique (roadmr)]

Apparently this merge request goes against the current of existing plans:

09:39 <@spineau> roadmr: I really want to delete the binaries from checkbox-ng
                 so that we can host them in the relevant providers

This is what Ara and Jeff want, and apparently it's the intended plan. Sylvain said:

09:44 <@spineau> roadmr: for short term I'd vote for your MR to restore ccs
                 installation but ideally checkbox-ng should support profiles
                 like checkbox-gui, not positional arguments

So having c-c-s be installable and depend on correct stuff (for the time being) is a desirable goal. A possibility is this:

09:46 < roadmr> spineau: ok, I'll see if I can find another alternative. Maybe
                even introducing another package (c-c-s-interim) that installs
                checkbox-ng and the provider would be cleaner and easier to
                revert later
09:46 < roadmr> c-c-s-interim could Breaks: c-c-s (so it gets removed for the
                time being) and Depends: checkbox-ng provider
09:47 < roadmr> then when we make everything right again, c-c-s Breaks:
                c-c-s-interim to start deprecating it

I'll read a bit on debian packaging and think about the implications of this interim package (to be clear, it'd be a very temporary solution while everything else coalesces and stabilizes) and come up with a better fix.

[Daniel Manrique (roadmr)]

Rejecting per above conversation.

review: Disapprove

Unmerged revisions

71. By Daniel Manrique on 2014-03-18

Make checkbox-ng Breaks older versions of canonical-certification-server to ensure it's properly upgraded

70. By Daniel Manrique on 2014-03-18

canonical-cert-server should depend on checkbox-ng which contains the binary (so c-c-s contains only config files and dependencies). Minimum checkbox-ng version is 0.17.

69. By Daniel Manrique on 2014-03-18

canonical-certification-server shouldn't install the binary which is now in checkbox-ng

=== modified file 'debian/canonical-certification-server.install'
--- debian/canonical-certification-server.install	2013-12-11 17:28:11 +0000
+++ debian/canonical-certification-server.install	2014-03-18 21:18:35 +0000
@@ -1,3 +1,2 @@
 checkbox-ng/contrib/canonical-certification-server.conf etc/init
 debian/extras/canonical-certification-config/canonical-certification.conf /etc/xdg
-usr/bin/canonical-certification-server
 
=== modified file 'debian/control'
--- debian/control	2014-03-18 16:56:38 +0000
+++ debian/control	2014-03-18 21:18:35 +0000
@@ -8,8 +8,8 @@
 Build-Depends: debhelper (>= 9.2),
                dh-translations,
                libnl-genl-3-dev,
+               libqt4-dev,
                libqt5sql5-sqlite,
-               libqt4-dev,
                po-debconf,
                python,
                python-distutils-extra,
@@ -311,8 +311,8 @@
 
 Package: checkbox-ng
 Architecture: all
-Depends: python3-checkbox-ng
-         ${misc:Depends}, ${python3:Depends}
+Depends: python3-checkbox-ng, ${misc:Depends}, ${python3:Depends}
+Breaks: canonical-certification-server (<< 0.17.9+bzr2802)
 Description: Simple replacement for CheckBox
  CheckBox command line tool
 
@@ -405,7 +405,8 @@
 
 Package: canonical-certification-server
 Architecture: all
-Depends: plainbox-provider-certification-server,
+Depends: checkbox-ng (>>0.17),
+         plainbox-provider-certification-server,
          python3-checkbox-ng,
          ${misc:Depends},
          ${python3:Depends}
@@ -426,7 +427,7 @@
 Provides: checkbox-qt
 Replaces: checkbox-qt
 Description: QML based interface for system testing based on Plainbox.
- Provides an interface for executing system tests. The results can be 
+ Provides an interface for executing system tests. The results can be
  viewed at the end.
  .
  This package provides the checkbox-gui binary.