Merge lp:~roadmr/checkbox/cmdline-subparser into lp:checkbox
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 3775 |
Merged at revision: | 3774 |
Proposed branch: | lp:~roadmr/checkbox/cmdline-subparser |
Merge into: | lp:checkbox |
Diff against target: |
216 lines (+129/-0) 4 files modified
checkbox-support/checkbox_support/parsers/kernel_cmdline.py (+37/-0) checkbox-support/checkbox_support/parsers/submission.py (+72/-0) checkbox-support/checkbox_support/parsers/tests/fixtures/submission_info_kernel_cmdline.xml (+10/-0) checkbox-support/checkbox_support/parsers/tests/test_submission.py (+10/-0) |
To merge this branch: | bzr merge lp:~roadmr/checkbox/cmdline-subparser |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+258666@code.launchpad.net |
Commit message
checkbox-
This includes the kernel commandline parser as well as the changes to SubmissionParser and the TestRun class to actually invoke the subparser when needed and gather the data, data files and tests.
Description of the change
checkbox-
This includes the kernel commandline parser as well as the changes to SubmissionParser and the TestRun class to actually invoke the subparser when needed and gather the data, data files and tests.
The parser is purposefully trivial since I was mostly trying to understand how to add and connect a new subparser in the SubmissionParser.
Just minor nitpicks below. I'd put commits in different order though:
- docstring for test run
- new parser _with_ tests