Code review comment for lp:~roadmr/checkbox/cmdline-subparser
Revision history for this message
| Daniel Manrique (roadmr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Applied the fixes as suggested and changed the commits too.
Exceptions:
- I didn't change the TestRun name as that is also used in Hexr and I want to be consistent, this is scary enough as it is :)
- I didn't change the camelcase for the setKernelCmdline method for the same reason. Let me know if you feel strongly about this and I can change it.
- I still haven't figured out the DeferredParser thing, once I got this parser working I'm investigating *why* it works so I'll be able to answer this later, hopefully...