Code review comment for lp:~roadmr/checkbox/cmdline-subparser
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I'm fine with the first two as it's more of a long-term change. The
last thing is okay if you feel that this is the way things work. I was
more curious than anything and I assumed you know why you've used it
:-)
+1
On Fri, May 8, 2015 at 9:56 PM, Daniel Manrique
<email address hidden> wrote:
> Applied the fixes as suggested and changed the commits too.
>
> Exceptions:
>
> - I didn't change the TestRun name as that is also used in Hexr and I want to be consistent, this is scary enough as it is :)
> - I didn't change the camelcase for the setKernelCmdline method for the same reason. Let me know if you feel strongly about this and I can change it.
> - I still haven't figured out the DeferredParser thing, once I got this parser working I'm investigating *why* it works so I'll be able to answer this later, hopefully...
> --
> https:/
> You are subscribed to branch lp:checkbox.