Merge lp:~reedobrien/charmworld/es-migration into lp:charmworld
Status: | Merged |
---|---|
Approved by: | Reed O'Brien |
Approved revision: | 517 |
Merged at revision: | 512 |
Proposed branch: | lp:~reedobrien/charmworld/es-migration |
Merge into: | lp:charmworld |
Diff against target: |
370 lines (+281/-41) 5 files modified
charmworld/migrations/versions/027_use_ngrams.py (+35/-0) charmworld/migrations/versions/tests/__init__.py (+1/-0) charmworld/migrations/versions/tests/data/migration_027.py (+166/-0) charmworld/migrations/versions/tests/test_migrations.py (+79/-4) charmworld/search.py (+0/-37) |
To merge this branch: | bzr merge lp:~reedobrien/charmworld/es-migration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Gui Bot | continuous-integration | Approve | |
Brad Crittenden (community) | Approve | ||
Review via email: mp+220144@code.launchpad.net |
Commit message
This makes the ngram work migrate cleanly.
Description of the change
Hopefully this makes the ngram work migrate cleanly.
QA:
Go back to r508
$ bzr revert -r 508
Drop the version and delte the index:
$ mongo juju --eval "db.migration_
$ curl -XDELETE http://
Create the r508 index:
$ bin/es-update
Setup the migration system and update to r508 version (026)
$ bin/migrations current
$ bin/migrations prepare-upgrade -i
$ bin/migrations upgrade
$ bin/migrations latest
Reindex the stuff...without ngrams
$ bin/sync-index
Go back to tip (r515)
$ bzr revert
Do the migration...
$ bin/migrations latest
$ bin/migrations current
$ bin/es-update
$ bin/migrations upgrade
Verify it worked
$ curl localhost:
$ curl localhost:
$ curl localhost:
Make sure the tests all pass...
$ make test
Reed this branch looks great, modulo some stylistic issues.
The QA steps you provide are fantastic. The last two steps do make assumptions about what charms have been ingested locally.
Note this review is based on the version of your code as of 8:00am, not the branch you subsequently pushed.
I've marked the branch as approved, which means you are free to land after making (or discussing) the suggested changes. Had I wanted to see the changes made before you land I would've used 'needs fixing' but I don't, so I didn't.
Thanks for persevering and getting this in so we can do the deploy.