Code review comment for lp:~reedobrien/charmworld/es-migration

> Actually you should pass the kind in the exists method:
>
> def exists_in_index(self, id_, kind=CHARM):
> client = self.index_client
> return client.get(id_, kind) is not None

This shrank to:

def exists_in_index(self, id_):
    return self.index_client.get(id_) is not None

in this test I am only inserting a charm, so adding a specifier seems like noise. If adding a charm let's you find something else, there is a problem and that should be tested elsewhere, IMO. Unless we are aiming to test that bundles upgrade as well, which AFAIU we are not.