Code review comment for lp:~reedobrien/charmworld/es-migration

Revision history for this message
Reed O'Brien (reedobrien) wrote :

> Reed this branch looks great, modulo some stylistic issues.
>
> The QA steps you provide are fantastic. The last two steps do make
> assumptions about what charms have been ingested locally.

Thanks. I thought I had put some ingest bits at the top. I missed that I guess -- nearly fantastic...

> I've marked the branch as approved, which means you are free to land after
> making (or discussing) the suggested changes. Had I wanted to see the changes
> made before you land I would've used 'needs fixing' but I don't, so I didn't.

I'll resubmit for sanity check.

« Back to merge proposal