Code review comment for lp:~reedobrien/charmworld/es-migration

Revision history for this message
Brad Crittenden (bac) wrote :

Reed this branch looks great, modulo some stylistic issues.

The QA steps you provide are fantastic. The last two steps do make assumptions about what charms have been ingested locally.

Note this review is based on the version of your code as of 8:00am, not the branch you subsequently pushed.

I've marked the branch as approved, which means you are free to land after making (or discussing) the suggested changes. Had I wanted to see the changes made before you land I would've used 'needs fixing' but I don't, so I didn't.

Thanks for persevering and getting this in so we can do the deploy.

review: Approve (bac)

« Back to merge proposal