Merge ~powersj/cloud-init:make-tox-revamp into cloud-init:master
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | 490cb302f6dd2e0c09471be3ff4944f1f7e2e1b9 |
Merged at revision: | 3bcb72c593f13915a81272778809dd8e71e2c7b7 |
Proposed branch: | ~powersj/cloud-init:make-tox-revamp |
Merge into: | cloud-init:master |
Diff against target: |
36 lines (+12/-1) 2 files modified
Makefile (+4/-1) tox.ini (+8/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
cloud-init Commiters | Pending | ||
Review via email: mp+315940@code.launchpad.net |
Commit message
Remove style checking during build and add latest style checks to tox
- make check will no longer run the style checks
- created style-check make file target to continue to run pep8 and pyflakes
- added tox envs 'tip-pycodestyle' and 'tip-pyflakes' to run latest style checking
LP: #1652329
Description of the change
Remove style checking during build and add latest style checks to tox
- make check will no longer run the style checks
- created style-check make file target to continue to run pep8 and pyflakes
- added tox envs 'tip-pycodestyle' and 'tip-pyflakes' to run latest style checking
Example tox run with the tip envs:
https:/
Did look into adding docs to default tox run, but the test reaches out to an external website (http://
Also looked into running pylint against cloud-init:
With Errors, Warnings, Refactors, and Conventions
https:/
With only errors:
https:/
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
(I wrote this stuff as I thought through it... so largely pasting here for my own review later).
summary: looks good. thanks.
- flake8 integrates pyflakes and pycodestyle and McCabe tool.
I think having separate tip-pyflakes and tip-pycodestyle seems
like the right thing to do, compared to having just a tip-flake8.
One reason for this is that currently flake8 pins the version
of pep8 to 1.5.X, and the goal of 'tip-' is to let that flow.
- The other thing we have specifically for flake8 is the [flake8] section
in tox.
This has 2 things
a.) 'ignore=H...'
these specify to ignore warnings raised by 'hacking's integration
with flake8 specifically (not pyflakes or pycodestyle).
Since tip-* wont ave hacking (i'm fine with that), we dont need it.
summary: we can leave the ignore= lines safely as they are.
b.) exclude =
this does not seem problematic. i guess this is useful if you
ran 'flake8' with no arguments, but tox passes arguments and i'm fine
with that.
summary: not a problem.