Merge ~pfsmorigo/review-tools:pfsmorigo/add_core22-desktop_back into review-tools:master

Proposed by Paulo Flabiano Smorigo
Status: Merged
Merged at revision: 52e5b818d2978e26f808d7c291ade0b6f4cc36fa
Proposed branch: ~pfsmorigo/review-tools:pfsmorigo/add_core22-desktop_back
Merge into: review-tools:master
Diff against target: 16 lines (+2/-1)
1 file modified
reviewtools/sr_lint.py (+2/-1)
Reviewer Review Type Date Requested Status
Emilia Torino Approve
David Lane (community) Needs Information
Review via email: mp+451914@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Emilia Torino (emitorino) wrote :

Thanks Paulo! this LGTM.

For context, this is the MP that mistakenly removed core22-desktop: https://code.launchpad.net/~pfsmorigo/review-tools/+git/review-tools/+merge/446424

review: Approve
Revision history for this message
David Lane (dclane) wrote :

Looking back at the commit which removed core22-desktop, I see that godot-bare was also removed. Was that deliberate also?

review: Needs Information
Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

Added godot-bare back too. Thanks David!

Revision history for this message
Emilia Torino (emitorino) wrote :

> Added godot-bare back too. Thanks David!

Thanks for the follow up change!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/reviewtools/sr_lint.py b/reviewtools/sr_lint.py
index 36c185a..d8cdca4 100644
--- a/reviewtools/sr_lint.py
+++ b/reviewtools/sr_lint.py
@@ -66,9 +66,10 @@ class SnapReviewLint(SnapReview):
66 "core18",66 "core18",
67 "core20",67 "core20",
68 "core22",68 "core22",
69 "core22-desktop",
69 "core24",70 "core24",
70 "core24-desktop",71 "core24-desktop",
71 "test-snapd-refresh-control-base",72 "godot-bare",
72 "keepstock-base-scot",73 "keepstock-base-scot",
73 "nix-base",74 "nix-base",
74 "test-snapd-base-bare",75 "test-snapd-base-bare",

Subscribers

People subscribed via source and target branches