review-tools:master

Last commit made on 2024-04-19
Get this branch:
git clone -b master https://git.launchpad.net/review-tools
Members of MyApps reviewers can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
master
Repository:
lp:review-tools

Recent commits

da5276d... by Evan Caville

reviewtools/overrides.py: add public snaps and update redflagged kernel snaps

Signed-off-by: Evan Caville <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
12 of 2 results
38c1077... by Alex Murray

Merge branch 'validate-parsed-plugs-slots-json-for-bare-scalars'

Signed-off-by: Alex Murray <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
12 of 2 results
d3e08b4... by Alex Murray

tests: add integration test for bare scalars and fix expected output

Signed-off-by: Alex Murray <email address hidden>

ace8ea0... by Alex Murray

reviewtools/sr_declaration.py: improve error output on invalid json

Signed-off-by: Alex Murray <email address hidden>

bc1469b... by Alex Murray

bin/snap{review,verify-declaration}: fix error handling on invalid json

Signed-off-by: Alex Murray <email address hidden>

76d0522... by Alex Murray

many: when parsing plugs/slots json validate for bare scalars

The store will raise an error if the provided plugs/slots json contains bare
scalars - instead these need to be strings. So when parsing these from the user,
validate them against this condition so we can warn the user before they go and
try to update the declaration in the store using something that would ultimately
fail.

Signed-off-by: Alex Murray <email address hidden>

de1816d... by Emilia Torino

Adding missing comma after gadget override

Signed-off-by: Maria Emilia Torino <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
12 of 2 results
Merged branch ~emitorino/review-tools:override_for_gadget_snap
d2c07ef... by Emilia Torino

update redflagged_snap_types_overrides

Signed-off-by: Maria Emilia Torino <email address hidden>

a918613... by Emilia Torino

add public snap

Signed-off-by: Maria Emilia Torino <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
12 of 2 results
Merged branch ~emitorino/review-tools:add_gadget_override
b0ae2b4... by Emilia Torino

update redflagged_snap_types_overrides

Signed-off-by: Maria Emilia Torino <email address hidden>