review-tools

Merge ~pfsmorigo/review-tools:pfsmorigo/add_core22-desktop_back into review-tools:master

  1. Git
  2. lp:~pfsmorigo/review-tools
  3. pfsmorigo/add_core22-desktop_back
  4. Merge into master
Proposed by Paulo Flabiano Smorigo
Status: Merged
Merged at revision: 52e5b818d2978e26f808d7c291ade0b6f4cc36fa
Proposed branch: ~pfsmorigo/review-tools:pfsmorigo/add_core22-desktop_back
Merge into: review-tools:master
Diff against target: 16 lines (+2/-1)
1 file modified
reviewtools/sr_lint.py (+2/-1)
Reviewer Review Type Date Requested Status
Emilia Torino Approve
David Lane (community) Needs Information
Review via email: mp+451914@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Emilia Torino (emitorino) wrote :

Thanks Paulo! this LGTM.

For context, this is the MP that mistakenly removed core22-desktop: https://code.launchpad.net/~pfsmorigo/review-tools/+git/review-tools/+merge/446424

review: Approve
Revision history for this message
David Lane (dclane) wrote :

Looking back at the commit which removed core22-desktop, I see that godot-bare was also removed. Was that deliberate also?

review: Needs Information
Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

Added godot-bare back too. Thanks David!

Revision history for this message
Emilia Torino (emitorino) wrote :

> Added godot-bare back too. Thanks David!

Thanks for the follow up change!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/sr_lint.py b/reviewtools/sr_lint.py
2index 36c185a..d8cdca4 100644
3--- a/reviewtools/sr_lint.py
4+++ b/reviewtools/sr_lint.py
5@@ -66,9 +66,10 @@ class SnapReviewLint(SnapReview):
6 "core18",
7 "core20",
8 "core22",
9+ "core22-desktop",
10 "core24",
11 "core24-desktop",
12- "test-snapd-refresh-control-base",
13+ "godot-bare",
14 "keepstock-base-scot",
15 "nix-base",
16 "test-snapd-base-bare",

Subscribers

People subscribed via source and target branches