Code review comment for ~paride/ubuntu/+source/strongswan:lp1940079-tss2-hirsute

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

* Changelog:
  - [+] changelog entry correct version and targeted codename
  - [+] changelog entries correct
  - [+] bug references correct
  - [+] update-maintainer has been run (before)

* New Delta:
  - [+] change is upstreamed

* Git/Maintenance
  - [+] extra testcases added or not needed for this
  - [+] commits are properly split (more important on -dev than on SRUs)

* Build/Test:
  - [+] build is ok
  - [+] verified PPA package installs/uninstalls
  - [+] sanity checks test fine

The one thing I'm unsure is that strongswan usually has .conf file for almost all of their plugins. It is likely that this is ok here as it isn't a pluging but a lib for a plugin.
I'm double checking the build log ...
I see ./usr/share/strongswan/templates/config/plugins/tpm.conf but there is no new unhandled tss*.conf AFAICS.

The SRU template looks great well outlined why we think this can be fixed via an SRU!.

+1

review: Approve

« Back to merge proposal