Merge ~paride/ubuntu/+source/strongswan:lp1940079-tss2-hirsute into ubuntu/+source/strongswan:ubuntu/hirsute-devel

Proposed by Paride Legovini
Status: Merged
Merge reported by: Paride Legovini
Merged at revision: a55879770415ae1a21a09394b74ce962e901ddb4
Proposed branch: ~paride/ubuntu/+source/strongswan:lp1940079-tss2-hirsute
Merge into: ubuntu/+source/strongswan:ubuntu/hirsute-devel
Diff against target: 41 lines (+11/-0)
3 files modified
debian/changelog (+9/-0)
debian/control (+1/-0)
debian/rules (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+408929@code.launchpad.net

Commit message

Hirsute SRU fix for LP #1940079. This is the same change that landed in the Debian packaging (git) and in Impish, applied to Hirsute.

Test Plan: see the SRU template.
Test PPA: https://launchpad.net/~paride/+archive/ubuntu/strongswan

Fix verified on Focal by the bug submitter using the Focal PPA package.

Please review; no sponsorship needed.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

* Changelog:
  - [+] changelog entry correct version and targeted codename
  - [+] changelog entries correct
  - [+] bug references correct
  - [+] update-maintainer has been run (before)

* New Delta:
  - [+] change is upstreamed

* Git/Maintenance
  - [+] extra testcases added or not needed for this
  - [+] commits are properly split (more important on -dev than on SRUs)

* Build/Test:
  - [+] build is ok
  - [+] verified PPA package installs/uninstalls
  - [+] sanity checks test fine

The one thing I'm unsure is that strongswan usually has .conf file for almost all of their plugins. It is likely that this is ok here as it isn't a pluging but a lib for a plugin.
I'm double checking the build log ...
I see ./usr/share/strongswan/templates/config/plugins/tpm.conf but there is no new unhandled tss*.conf AFAICS.

The SRU template looks great well outlined why we think this can be fixed via an SRU!.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index cc0057d..19036ab 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+strongswan (5.9.1-1ubuntu1.1) hirsute; urgency=medium
7+
8+ * Compile the tpm plugin against the tpm2 software stack (tss2)
9+ (Debian packaging cherry-pick, LP: #1940079)
10+ - d/rules: add the --enable-tss-tss2 configure flag
11+ - d/control: add Build-Depends: libtss2-dev
12+
13+ -- Paride Legovini <paride@ubuntu.com> Fri, 17 Sep 2021 12:15:40 +0200
14+
15 strongswan (5.9.1-1ubuntu1) hirsute; urgency=medium
16
17 * Merge with Debian unstable. Remaining changes:
18diff --git a/debian/control b/debian/control
19index fbd59a0..a64a176 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -27,6 +27,7 @@ Build-Depends: bison,
23 libssl-dev (>= 0.9.8),
24 libsystemd-dev [linux-any],
25 libtool,
26+ libtss2-dev,
27 libxml2-dev,
28 pkg-config,
29 po-debconf,
30diff --git a/debian/rules b/debian/rules
31index 25cbede..3d32107 100755
32--- a/debian/rules
33+++ b/debian/rules
34@@ -38,6 +38,7 @@ CONFIGUREARGS := --libdir=/usr/lib --libexecdir=/usr/lib \
35 --enable-pkcs11 \
36 --enable-test-vectors \
37 --enable-tpm \
38+ --enable-tss-tss2 \
39 --enable-unity \
40 --enable-xauth-eap \
41 --enable-xauth-pam \

Subscribers

People subscribed via source and target branches