Merge ~oddbloke/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master
Proposed by
Dan Watkins
Status: | Merged |
---|---|
Approved by: | Dan Watkins |
Approved revision: | 46e6ee541bf4cc7943d76db95f79fb145c7a2226 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~oddbloke/cloud-init/+git/cloud-init:lp1843276 |
Merge into: | cloud-init:master |
Diff against target: |
29 lines (+6/-0) 1 file modified
cloudinit/atomic_helper.py (+6/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Scott Moser | Approve | ||
Review via email: mp+372491@code.launchpad.net |
Commit message
atomic_helper: add DEBUG logging to write_file
LP: #1843276
To post a comment you must log in.
Your successful log path would not even include the final location for the file, which is ultimately the useful thing (except in the write-failed case, which is probably rare).
I think I'd prefer logging with a message that included the target file (filename), not just the temporary file name. And hopefully a way to differentiate in the log message between atomic_ helpers. write_file and write_file.