Code review comment for ~oddbloke/cloud-init/+git/cloud-init:lp1843276

Revision history for this message
Scott Moser (smoser) wrote :

Your successful log path would not even include the final location for the file, which is ultimately the useful thing (except in the write-failed case, which is probably rare).

I think I'd prefer logging with a message that included the target file (filename), not just the temporary file name. And hopefully a way to differentiate in the log message between atomic_helpers.write_file and write_file.

« Back to merge proposal