Mir

Merge lp:~mir-team/mir/privatize-event into lp:mir

Proposed by Robert Carr
Status: Merged
Approved by: Chris Halse Rogers
Approved revision: no longer in the source branch.
Merged at revision: 2473
Proposed branch: lp:~mir-team/mir/privatize-event
Merge into: lp:mir
Prerequisite: lp:~mir-team/mir/prepare-to-privatize-event
Diff against target: 1099 lines (+85/-155)
58 files modified
CMakeLists.txt (+0/-2)
include/client/mir/events/event_builders.h (+0/-2)
include/client/mir_toolkit/events/event.h (+0/-9)
playground/demo-shell/window_manager.cpp (+1/-2)
src/client/event.cpp (+1/-1)
src/client/events/event_builders.cpp (+1/-2)
src/client/input/android/android_input_lexicon.cpp (+1/-2)
src/client/input/android/android_input_receiver.cpp (+1/-2)
src/client/input/input_event.cpp (+1/-2)
src/client/input/xkb_mapper.cpp (+1/-2)
src/client/mir_connection.cpp (+0/-2)
src/client/rpc/mir_protobuf_rpc_channel.cpp (+1/-2)
src/include/common/mir/events/event_private.h (+6/-5)
src/include/common/mir/input/xkb_mapper.h (+0/-2)
src/server/display_server.cpp (+0/-4)
src/server/frontend/event_sender.cpp (+1/-2)
src/server/graphics/nested/display_buffer.cpp (+2/-2)
src/server/input/android/android_input_dispatcher.cpp (+2/-2)
src/server/input/android/android_input_manager.cpp (+0/-2)
src/server/input/android/event_filter_dispatcher_policy.cpp (+1/-2)
src/server/input/android/event_filter_dispatcher_policy.h (+4/-3)
src/server/input/android/input_sender.cpp (+1/-1)
src/server/input/android/input_translator.cpp (+2/-2)
src/server/input/default_configuration.cpp (+1/-2)
src/server/input/default_input_device_hub.cpp (+1/-0)
src/server/input/null_input_dispatcher.cpp (+0/-2)
src/server/input/vt_filter.cpp (+1/-2)
src/server/report/lttng/message_processor_report.cpp (+0/-2)
src/server/scene/application_session.cpp (+0/-2)
tests/acceptance-tests/test_client_surface_events.cpp (+26/-37)
tests/acceptance-tests/throwback/test_client_input.cpp (+2/-3)
tests/acceptance-tests/throwback/test_custom_input_dispatcher.cpp (+1/-2)
tests/include/mir_test_doubles/mock_event_filter.h (+0/-2)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-2)
tests/integration-tests/input/android/test_android_input_manager.cpp (+1/-1)
tests/integration-tests/input/test_nested_input.cpp (+1/-2)
tests/integration-tests/test_display_server_main_loop_events.cpp (+1/-2)
tests/mir_test_doubles/test_protobuf_client.cpp (+1/-2)
tests/mir_test_framework/stubbed_server_configuration.cpp (+0/-2)
tests/unit-tests/client/input/test_android_input_receiver.cpp (+2/-2)
tests/unit-tests/client/input/test_xkb_mapper.cpp (+1/-0)
tests/unit-tests/client/test_event_distributor.cpp (+2/-2)
tests/unit-tests/frontend/test_published_socket_connector.cpp (+1/-2)
tests/unit-tests/input/android/test_android_input_application_handle.cpp (+1/-2)
tests/unit-tests/input/android/test_android_input_dispatcher.cpp (+1/-2)
tests/unit-tests/input/android/test_android_input_lexicon.cpp (+1/-3)
tests/unit-tests/input/android/test_android_input_sender.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_window_handle.cpp (+1/-2)
tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp (+1/-2)
tests/unit-tests/input/android/test_input_translator.cpp (+2/-1)
tests/unit-tests/input/test_default_input_device_hub.cpp (+1/-0)
tests/unit-tests/input/test_event_builders.cpp (+0/-2)
tests/unit-tests/input/test_event_filter_chain.cpp (+1/-2)
tests/unit-tests/input/test_input_event.cpp (+1/-3)
tests/unit-tests/scene/test_application_session.cpp (+1/-2)
tests/unit-tests/scene/test_basic_surface.cpp (+1/-1)
tests/unit-tests/scene/test_surface.cpp (+1/-2)
tests/unit-tests/scene/test_surface_impl.cpp (+1/-2)
To merge this branch: bzr merge lp:~mir-team/mir/privatize-event
Reviewer Review Type Date Requested Status
Chris Halse Rogers Approve
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Review via email: mp+254149@code.launchpad.net

Commit message

Privatize event definition header.

Description of the change

Privatize event definition header.

To post a comment you must log in.
Revision history for this message
Robert Carr (robertcarr) wrote :
Revision history for this message
Robert Carr (robertcarr) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

You seem to hamve moved event_deprecated.h to event_private.h without changing any of the compile guards and such; they should probably match the new filename.

Also, I think you can still cut the diff down substantially by doing bzr mv --after event_deprecated.h event_private.h to get bzr to record that as a move.

1055 - memset(&last_event, 0, sizeof last_event);
1056 + last_event = nullptr;

Shouldn't this unref last_event if it wasn't nullptr

Otherwise, WOOT!

review: Needs Fixing
Revision history for this message
Robert Carr (robertcarr) wrote :

Thanks Chris, fixed up.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

600 - EXPECT_THAT(last_event_surface, Eq(surface));
601 - EXPECT_THAT(last_event.type, Eq(mir_event_type_surface));
602 - EXPECT_THAT(last_event.surface.id, Eq(surface_id));
603 - EXPECT_THAT(last_event.surface.attrib, Eq(mir_surface_attrib_state));
604 - EXPECT_THAT(last_event.surface.value, Eq(mir_surface_state_minimized));
605 - }
606 -
607 - reset_last_event();
608 -
609 - {
610 - mir_wait_for(mir_surface_set_state(surface, static_cast<MirSurfaceState>(777)));
611 - mir_wait_for(mir_surface_set_state(other_surface, mir_surface_state_maximized));
612 -
613 - std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
614 -
615 - EXPECT_THAT(last_event_surface, IsNull());
616 - EXPECT_THAT(last_event.type, Eq(0));
617 - EXPECT_THAT(last_event.surface.id, Eq(0));
618 - EXPECT_THAT(last_event.surface.attrib, Eq(0));
619 - EXPECT_THAT(last_event.surface.value, Eq(0));
620 + EXPECT_THAT(last_event, mt::SurfaceEvent(mir_surface_attrib_state, mir_surface_state_minimized));

this test has been weakened to deal with fewer state changes.

review: Needs Fixing
Revision history for this message
Robert Carr (robertcarr) wrote :

Merged trunk and fixed 'weakened' test while resolving conflict in same.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Ok

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-03-31 02:35:42 +0000
+++ CMakeLists.txt 2015-04-07 21:28:28 +0000
@@ -120,8 +120,6 @@
120# consume CPU time...120# consume CPU time...
121add_definitions(-DLOG_NDEBUG=1)121add_definitions(-DLOG_NDEBUG=1)
122122
123add_definitions(-DMIR_REQUIRE_DEPRECATED_EVENT_OPT_IN=1)
124
125enable_testing()123enable_testing()
126124
127include_directories(include/common)125include_directories(include/common)
128126
=== modified file 'include/client/mir/events/event_builders.h'
--- include/client/mir/events/event_builders.h 2015-03-31 02:35:42 +0000
+++ include/client/mir/events/event_builders.h 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Author: Robert Carr <robert.carr@canonical.com>16 * Author: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#ifndef MIR_EVENT_BUILDERS_H_19#ifndef MIR_EVENT_BUILDERS_H_
22#define MIR_EVENT_BUILDERS_H_20#define MIR_EVENT_BUILDERS_H_
2321
2422
=== modified file 'include/client/mir_toolkit/events/event.h'
--- include/client/mir_toolkit/events/event.h 2015-03-31 02:35:42 +0000
+++ include/client/mir_toolkit/events/event.h 2015-04-07 21:28:28 +0000
@@ -61,15 +61,6 @@
61/**@}*/61/**@}*/
62#endif62#endif
6363
64#ifdef MIR_REQUIRE_DEPRECATED_EVENT_OPT_IN
65 #ifdef MIR_INCLUDE_DEPRECATED_EVENT_HEADER
66 #include "mir_toolkit/events/event_deprecated.h"
67 #endif // MIR_INCLUDE_DEPRECATED_EVENT_HEADER
68#else
69 #include "mir_toolkit/events/event_deprecated.h"
70#endif // MIR_REQUIRE_DEPRECATED_EVENT_OPT_IN
71
72
73#include "mir_toolkit/events/input/input_event.h"64#include "mir_toolkit/events/input/input_event.h"
74#include "mir_toolkit/events/resize_event.h"65#include "mir_toolkit/events/resize_event.h"
75#include "mir_toolkit/events/surface_event.h"66#include "mir_toolkit/events/surface_event.h"
7667
=== modified file 'playground/demo-shell/window_manager.cpp'
--- playground/demo-shell/window_manager.cpp 2015-03-31 02:35:42 +0000
+++ playground/demo-shell/window_manager.cpp 2015-04-07 21:28:28 +0000
@@ -17,8 +17,6 @@
17 * Daniel van Vugt <daniel.van.vugt@canonical.com>17 * Daniel van Vugt <daniel.van.vugt@canonical.com>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
21
22#include "window_manager.h"20#include "window_manager.h"
23#include "demo_compositor.h"21#include "demo_compositor.h"
2422
@@ -28,6 +26,7 @@
28#include "mir/graphics/display.h"26#include "mir/graphics/display.h"
29#include "mir/graphics/display_configuration.h"27#include "mir/graphics/display_configuration.h"
30#include "mir/compositor/compositor.h"28#include "mir/compositor/compositor.h"
29#include "mir/events/event_private.h"
3130
32#include <linux/input.h>31#include <linux/input.h>
3332
3433
=== modified file 'src/client/event.cpp'
--- src/client/event.cpp 2015-03-31 02:35:42 +0000
+++ src/client/event.cpp 2015-04-07 21:28:28 +0000
@@ -22,7 +22,7 @@
22#include "mir/log.h"22#include "mir/log.h"
2323
24#include "mir_toolkit/events/event.h"24#include "mir_toolkit/events/event.h"
25#include "mir_toolkit/events/event_deprecated.h"25#include "mir/events/event_private.h"
2626
27#include "mir_toolkit/events/surface_event.h"27#include "mir_toolkit/events/surface_event.h"
28#include "mir_toolkit/events/resize_event.h"28#include "mir_toolkit/events/resize_event.h"
2929
=== modified file 'src/client/events/event_builders.cpp'
--- src/client/events/event_builders.cpp 2015-03-31 02:35:42 +0000
+++ src/client/events/event_builders.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,8 @@
16 * Author: Robert Carr <robert.carr@canonical.com>16 * Author: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/events/event_builders.h"19#include "mir/events/event_builders.h"
20#include "mir/events/event_private.h"
2221
23#include <string.h>22#include <string.h>
2423
2524
=== modified file 'src/client/input/android/android_input_lexicon.cpp'
--- src/client/input/android/android_input_lexicon.cpp 2015-03-31 02:35:42 +0000
+++ src/client/input/android/android_input_lexicon.cpp 2015-04-07 21:28:28 +0000
@@ -17,9 +17,8 @@
17 * Robert Carr <robert.carr@canonical.com>17 * Robert Carr <robert.carr@canonical.com>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
21
22#include "mir/input/android/android_input_lexicon.h"20#include "mir/input/android/android_input_lexicon.h"
21#include "mir/events/event_private.h"
2322
24#include <androidfw/Input.h>23#include <androidfw/Input.h>
2524
2625
=== modified file 'src/client/input/android/android_input_receiver.cpp'
--- src/client/input/android/android_input_receiver.cpp 2015-04-01 03:19:39 +0000
+++ src/client/input/android/android_input_receiver.cpp 2015-04-07 21:28:28 +0000
@@ -16,14 +16,13 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "android_input_receiver.h"19#include "android_input_receiver.h"
2220
23#include "mir/dispatch/multiplexing_dispatchable.h"21#include "mir/dispatch/multiplexing_dispatchable.h"
24#include "mir/input/xkb_mapper.h"22#include "mir/input/xkb_mapper.h"
25#include "mir/input/input_receiver_report.h"23#include "mir/input/input_receiver_report.h"
26#include "mir/input/android/android_input_lexicon.h"24#include "mir/input/android/android_input_lexicon.h"
25#include "mir/events/event_private.h"
2726
28#include <boost/throw_exception.hpp>27#include <boost/throw_exception.hpp>
2928
3029
=== modified file 'src/client/input/input_event.cpp'
--- src/client/input/input_event.cpp 2015-03-31 02:35:42 +0000
+++ src/client/input/input_event.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,10 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#define MIR_LOG_COMPONENT "input-event-access"19#define MIR_LOG_COMPONENT "input-event-access"
2220
23#include "mir/event_type_to_string.h"21#include "mir/event_type_to_string.h"
22#include "mir/events/event_private.h"
24#include "mir/log.h"23#include "mir/log.h"
2524
26#include "mir_toolkit/events/input/input_event.h"25#include "mir_toolkit/events/input/input_event.h"
2726
=== modified file 'src/client/input/xkb_mapper.cpp'
--- src/client/input/xkb_mapper.cpp 2015-03-31 02:35:42 +0000
+++ src/client/input/xkb_mapper.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,8 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/input/xkb_mapper.h"19#include "mir/input/xkb_mapper.h"
20#include "mir/events/event_private.h"
2221
23#include <string.h>22#include <string.h>
2423
2524
=== modified file 'src/client/mir_connection.cpp'
--- src/client/mir_connection.cpp 2015-03-31 02:35:42 +0000
+++ src/client/mir_connection.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Thomas Guest <thomas.guest@canonical.com>16 * Authored by: Thomas Guest <thomas.guest@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir_connection.h"19#include "mir_connection.h"
22#include "mir_surface.h"20#include "mir_surface.h"
23#include "mir_prompt_session.h"21#include "mir_prompt_session.h"
2422
=== modified file 'src/client/rpc/mir_protobuf_rpc_channel.cpp'
--- src/client/rpc/mir_protobuf_rpc_channel.cpp 2015-03-31 02:35:42 +0000
+++ src/client/rpc/mir_protobuf_rpc_channel.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER // Required until wire format changes
20
21#include "mir_protobuf_rpc_channel.h"19#include "mir_protobuf_rpc_channel.h"
22#include "rpc_report.h"20#include "rpc_report.h"
2321
@@ -28,6 +26,7 @@
28#include "../lifecycle_control.h"26#include "../lifecycle_control.h"
29#include "../event_sink.h"27#include "../event_sink.h"
30#include "mir/variable_length_array.h"28#include "mir/variable_length_array.h"
29#include "mir/events/event_private.h"
3130
32#include "mir_protobuf.pb.h" // For Buffer frig31#include "mir_protobuf.pb.h" // For Buffer frig
33#include "mir_protobuf_wire.pb.h"32#include "mir_protobuf_wire.pb.h"
3433
=== added directory 'src/include/common/mir/events'
=== renamed file 'include/client/mir_toolkit/events/event_deprecated.h' => 'src/include/common/mir/events/event_private.h'
--- include/client/mir_toolkit/events/event_deprecated.h 2015-03-31 02:35:42 +0000
+++ src/include/common/mir/events/event_private.h 2015-04-07 21:28:28 +0000
@@ -22,11 +22,12 @@
22//22//
23// ==================================23// ==================================
2424
25#ifndef MIR_TOOLKIT_EVENT_DEPRECATED_H_25#ifndef MIR_COMMON_EVENT_PRIVATE_H_
26#define MIR_TOOLKIT_EVENT_DEPRECATED_H_26#define MIR_COMMON_EVENT_PRIVATE_H_
2727
28#include <stddef.h>28#include <stddef.h>
29#include <stdint.h>29#include <stdint.h>
30#include "mir_toolkit/event.h"
30#include "mir_toolkit/common.h"31#include "mir_toolkit/common.h"
3132
32#include <xkbcommon/xkbcommon.h>33#include <xkbcommon/xkbcommon.h>
@@ -118,7 +119,7 @@
118 mir_motion_tool_type_eraser = 4119 mir_motion_tool_type_eraser = 4
119} MirMotionToolType;120} MirMotionToolType;
120121
121// DEPRECATED122// PRIVATE
122// Direct access to MirKeyEvent is deprecated. Please use mir_event_get_input_event123// Direct access to MirKeyEvent is deprecated. Please use mir_event_get_input_event
123// and the mir_input_event* family of functions.124// and the mir_input_event* family of functions.
124typedef struct125typedef struct
@@ -158,7 +159,7 @@
158 int unused3;159 int unused3;
159} MirMotionPointer;160} MirMotionPointer;
160161
161// DEPRECATED162// PRIVATE
162// Direct access to MirMotionEvent is deprecated. Please use mir_event_get_input_event163// Direct access to MirMotionEvent is deprecated. Please use mir_event_get_input_event
163// and the mir_input_event* family of functions.164// and the mir_input_event* family of functions.
164typedef struct165typedef struct
@@ -263,4 +264,4 @@
263/**@}*/264/**@}*/
264#endif265#endif
265266
266#endif /* MIR_TOOLKIT_EVENT_DEPRECATED_H_ */267#endif /* MIR_COMMON_EVENT_PRIVATE_H_ */
267268
=== modified file 'src/include/common/mir/input/xkb_mapper.h'
--- src/include/common/mir/input/xkb_mapper.h 2015-03-31 02:35:42 +0000
+++ src/include/common/mir/input/xkb_mapper.h 2015-04-07 21:28:28 +0000
@@ -19,8 +19,6 @@
19#ifndef MIR_INPUT_RECEIVER_XKB_MAPPER_H_19#ifndef MIR_INPUT_RECEIVER_XKB_MAPPER_H_
20#define MIR_INPUT_RECEIVER_XKB_MAPPER_H_20#define MIR_INPUT_RECEIVER_XKB_MAPPER_H_
2121
22#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
23
24#include "mir_toolkit/event.h"22#include "mir_toolkit/event.h"
2523
26#include <xkbcommon/xkbcommon.h>24#include <xkbcommon/xkbcommon.h>
2725
=== modified file 'src/server/display_server.cpp'
--- src/server/display_server.cpp 2015-04-06 11:54:36 +0000
+++ src/server/display_server.cpp 2015-04-07 21:28:28 +0000
@@ -18,10 +18,6 @@
18 * Thomas Voss <thomas.voss@canonical.com>18 * Thomas Voss <thomas.voss@canonical.com>
19 */19 */
2020
21// TODO: Eliminate usage of std::chrono::nanoseconds in input_dispatcher.h
22// to remove this.
23#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
24
25#define MIR_LOG_COMPONENT "DisplayServer"21#define MIR_LOG_COMPONENT "DisplayServer"
26#include "mir/display_server.h"22#include "mir/display_server.h"
27#include "mir/server_configuration.h"23#include "mir/server_configuration.h"
2824
=== modified file 'src/server/frontend/event_sender.cpp'
--- src/server/frontend/event_sender.cpp 2015-03-31 02:35:42 +0000
+++ src/server/frontend/event_sender.cpp 2015-04-07 21:28:28 +0000
@@ -16,12 +16,11 @@
16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/frontend/client_constants.h"19#include "mir/frontend/client_constants.h"
22#include "mir/graphics/display_configuration.h"20#include "mir/graphics/display_configuration.h"
23#include "mir/variable_length_array.h"21#include "mir/variable_length_array.h"
24#include "event_sender.h"22#include "event_sender.h"
23#include "mir/events/event_private.h"
25#include "message_sender.h"24#include "message_sender.h"
26#include "protobuf_buffer_packer.h"25#include "protobuf_buffer_packer.h"
2726
2827
=== modified file 'src/server/graphics/nested/display_buffer.cpp'
--- src/server/graphics/nested/display_buffer.cpp 2015-04-03 19:27:44 +0000
+++ src/server/graphics/nested/display_buffer.cpp 2015-04-07 21:28:28 +0000
@@ -16,12 +16,12 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "display_buffer.h"19#include "display_buffer.h"
20
22#include "host_connection.h"21#include "host_connection.h"
23#include "mir/input/input_dispatcher.h"22#include "mir/input/input_dispatcher.h"
24#include "mir/graphics/pixel_format_utils.h"23#include "mir/graphics/pixel_format_utils.h"
24#include "mir/events/event_private.h"
2525
26#include <boost/throw_exception.hpp>26#include <boost/throw_exception.hpp>
27#include <stdexcept>27#include <stdexcept>
2828
=== modified file 'src/server/input/android/android_input_dispatcher.cpp'
--- src/server/input/android/android_input_dispatcher.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/android/android_input_dispatcher.cpp 2015-04-07 21:28:28 +0000
@@ -17,12 +17,12 @@
17 * Alan Griffiths <alan@octopull.co.uk>17 * Alan Griffiths <alan@octopull.co.uk>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
21
22#include "android_input_dispatcher.h"20#include "android_input_dispatcher.h"
23#include "android_input_constants.h"21#include "android_input_constants.h"
24#include "android_input_thread.h"22#include "android_input_thread.h"
2523
24#include "mir/events/event_private.h"
25
26#include <InputListener.h> // NotifyArgs26#include <InputListener.h> // NotifyArgs
27#include <InputDispatcher.h>27#include <InputDispatcher.h>
2828
2929
=== modified file 'src/server/input/android/android_input_manager.cpp'
--- src/server/input/android/android_input_manager.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/android/android_input_manager.cpp 2015-04-07 21:28:28 +0000
@@ -17,8 +17,6 @@
17 * Daniel d'Andradra <daniel.dandrada@canonical.com>17 * Daniel d'Andradra <daniel.dandrada@canonical.com>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
21
22#include "mir/input/input_dispatcher.h"20#include "mir/input/input_dispatcher.h"
23#include "android_input_manager.h"21#include "android_input_manager.h"
24#include "android_input_constants.h"22#include "android_input_constants.h"
2523
=== modified file 'src/server/input/android/event_filter_dispatcher_policy.cpp'
--- src/server/input/android/event_filter_dispatcher_policy.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/android/event_filter_dispatcher_policy.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,9 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "event_filter_dispatcher_policy.h"19#include "event_filter_dispatcher_policy.h"
22#include "mir/input/android/android_input_lexicon.h"20#include "mir/input/android/android_input_lexicon.h"
21#include "mir/events/event_private.h"
2322
24namespace mi = mir::input;23namespace mi = mir::input;
25namespace mia = mi::android;24namespace mia = mi::android;
2625
=== modified file 'src/server/input/android/event_filter_dispatcher_policy.h'
--- src/server/input/android/event_filter_dispatcher_policy.h 2015-03-31 02:35:42 +0000
+++ src/server/input/android/event_filter_dispatcher_policy.h 2015-04-07 21:28:28 +0000
@@ -15,8 +15,9 @@
15 *15 *
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
18#ifndef MIR_EVENT_FILTER_DISPATCHER_POLICY_H_18
19#define MIR_EVENT_FILTER_DISPATCHER_POLICY_H_19#ifndef MIR_INPUT_ANDROID_EVENT_FILTER_DISPATCHER_POLICY_H_
20#define MIR_INPUT_ANDROID_EVENT_FILTER_DISPATCHER_POLICY_H_
2021
21#include "mir/input/event_filter.h"22#include "mir/input/event_filter.h"
2223
@@ -78,4 +79,4 @@
78}79}
79}80}
8081
81#endif // MIR_DUMMY_INPUT_DISPATCHER_POLICY_H_82#endif // MIR_INPUT_ANDROID_EVENT_FILTER_DISPATCHER_POLICY_H_
8283
=== modified file 'src/server/input/android/input_sender.cpp'
--- src/server/input/android/input_sender.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/android/input_sender.cpp 2015-04-07 21:28:28 +0000
@@ -16,7 +16,7 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER 19#include "mir/events/event_private.h"
2020
21#include "input_sender.h"21#include "input_sender.h"
22#include "input_send_entry.h"22#include "input_send_entry.h"
2323
=== modified file 'src/server/input/android/input_translator.cpp'
--- src/server/input/android/input_translator.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/android/input_translator.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,10 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "input_translator.h"19#include "input_translator.h"
2220
21#include "mir/events/event_private.h"
22
23#include "androidfw/Input.h"23#include "androidfw/Input.h"
2424
25#include <unordered_set>25#include <unordered_set>
2626
=== modified file 'src/server/input/default_configuration.cpp'
--- src/server/input/default_configuration.cpp 2015-04-02 10:12:31 +0000
+++ src/server/input/default_configuration.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,9 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/default_server_configuration.h"19#include "mir/default_server_configuration.h"
2220
21#include "mir/events/event_private.h"
23#include "android/android_input_dispatcher.h"22#include "android/android_input_dispatcher.h"
24#include "android/android_input_targeter.h"23#include "android/android_input_targeter.h"
25#include "android/android_input_reader_policy.h"24#include "android/android_input_reader_policy.h"
2625
=== modified file 'src/server/input/default_input_device_hub.cpp'
--- src/server/input/default_input_device_hub.cpp 2015-03-30 18:41:05 +0000
+++ src/server/input/default_input_device_hub.cpp 2015-04-07 21:28:28 +0000
@@ -24,6 +24,7 @@
24#include "mir/input/input_device.h"24#include "mir/input/input_device.h"
25#include "mir/input/input_device_info.h"25#include "mir/input/input_device_info.h"
26#include "mir/input/input_sink.h"26#include "mir/input/input_sink.h"
27#include "mir/events/event_private.h"
27#include "mir/dispatch/multiplexing_dispatchable.h"28#include "mir/dispatch/multiplexing_dispatchable.h"
28#include "mir/server_action_queue.h"29#include "mir/server_action_queue.h"
29#include "mir/log.h"30#include "mir/log.h"
3031
=== modified file 'src/server/input/null_input_dispatcher.cpp'
--- src/server/input/null_input_dispatcher.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/null_input_dispatcher.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "null_input_dispatcher.h"19#include "null_input_dispatcher.h"
2220
23namespace mi = mir::input;21namespace mi = mir::input;
2422
=== modified file 'src/server/input/vt_filter.cpp'
--- src/server/input/vt_filter.cpp 2015-03-31 02:35:42 +0000
+++ src/server/input/vt_filter.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,8 @@
16 * Authored by: Robert Ancell <robert.ancell@canonical.com>16 * Authored by: Robert Ancell <robert.ancell@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/input/vt_filter.h"19#include "mir/input/vt_filter.h"
20#include "mir/events/event_private.h"
2221
23#include <linux/input.h>22#include <linux/input.h>
24#include <linux/vt.h>23#include <linux/vt.h>
2524
=== modified file 'src/server/report/lttng/message_processor_report.cpp'
--- src/server/report/lttng/message_processor_report.cpp 2015-03-31 02:35:42 +0000
+++ src/server/report/lttng/message_processor_report.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "message_processor_report.h"19#include "message_processor_report.h"
2220
23#include "mir/report/lttng/mir_tracepoint.h"21#include "mir/report/lttng/mir_tracepoint.h"
2422
=== modified file 'src/server/scene/application_session.cpp'
--- src/server/scene/application_session.cpp 2015-03-31 02:35:42 +0000
+++ src/server/scene/application_session.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Robert Carr <racarr@canonical.com>16 * Authored by: Robert Carr <racarr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "application_session.h"19#include "application_session.h"
22#include "snapshot_strategy.h"20#include "snapshot_strategy.h"
23#include "default_session_container.h"21#include "default_session_container.h"
2422
=== modified file 'tests/acceptance-tests/test_client_surface_events.cpp'
--- tests/acceptance-tests/test_client_surface_events.cpp 2015-03-31 02:35:42 +0000
+++ tests/acceptance-tests/test_client_surface_events.cpp 2015-04-07 21:28:28 +0000
@@ -16,17 +16,14 @@
16 * Authored by: Nick Dedekind <nick.dedekind@canonical.com>16 * Authored by: Nick Dedekind <nick.dedekind@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir_toolkit/mir_client_library.h"19#include "mir_toolkit/mir_client_library.h"
22#include "mir_toolkit/debug/surface.h"
2320
24#include "mir/shell/shell_wrapper.h"21#include "mir/shell/shell_wrapper.h"
25
26#include "mir/scene/session.h"22#include "mir/scene/session.h"
27#include "mir/scene/surface.h"23#include "mir/scene/surface.h"
28#include "mir/scene/surface_creation_parameters.h"24#include "mir/scene/surface_creation_parameters.h"
2925
26#include "mir_test/event_matchers.h"
30#include "mir_test_framework/connected_client_with_a_surface.h"27#include "mir_test_framework/connected_client_with_a_surface.h"
31#include "mir_test_framework/any_surface.h"28#include "mir_test_framework/any_surface.h"
3229
@@ -38,9 +35,10 @@
38#include <mutex>35#include <mutex>
3936
40namespace mf = mir::frontend;37namespace mf = mir::frontend;
41namespace mtf = mir_test_framework;
42namespace ms = mir::scene;38namespace ms = mir::scene;
43namespace msh = mir::shell;39namespace msh = mir::shell;
40namespace mt = mir::test;
41namespace mtf = mir_test_framework;
4442
45using namespace testing;43using namespace testing;
4644
@@ -69,18 +67,28 @@
69 std::mutex last_event_mutex;67 std::mutex last_event_mutex;
70 MirEventType event_filter{mir_event_type_surface};68 MirEventType event_filter{mir_event_type_surface};
71 std::condition_variable last_event_cv;69 std::condition_variable last_event_cv;
72 MirEvent last_event{};70 MirEvent const* last_event = nullptr;
73 MirSurface* last_event_surface = nullptr;71 MirSurface* last_event_surface = nullptr;
7472
75 std::shared_ptr<ms::Surface> scene_surface;73 std::shared_ptr<ms::Surface> scene_surface;
7674
75 ~ClientSurfaceEvents()
76 {
77 if (last_event)
78 mir_event_unref(last_event);
79 }
80
77 static void event_callback(MirSurface* surface, MirEvent const* event, void* ctx)81 static void event_callback(MirSurface* surface, MirEvent const* event, void* ctx)
78 {82 {
79 ClientSurfaceEvents* self = static_cast<ClientSurfaceEvents*>(ctx);83 ClientSurfaceEvents* self = static_cast<ClientSurfaceEvents*>(ctx);
80 std::lock_guard<decltype(self->last_event_mutex)> last_event_lock{self->last_event_mutex};84 std::lock_guard<decltype(self->last_event_mutex)> last_event_lock{self->last_event_mutex};
81 // Don't overwrite an interesting event with an uninteresting one!85 // Don't overwrite an interesting event with an uninteresting one!
82 if (event->type != self->event_filter) return;86 if (mir_event_get_type(event) != self->event_filter) return;
83 self->last_event = *event;87
88 if (self->last_event)
89 mir_event_unref(self->last_event);
90
91 self->last_event = mir_event_ref(event);
84 self->last_event_surface = surface;92 self->last_event_surface = surface;
85 self->last_event_cv.notify_one();93 self->last_event_cv.notify_one();
86 }94 }
@@ -89,7 +97,7 @@
89 {97 {
90 std::unique_lock<decltype(last_event_mutex)> last_event_lock{last_event_mutex};98 std::unique_lock<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
91 return last_event_cv.wait_for(last_event_lock, delay,99 return last_event_cv.wait_for(last_event_lock, delay,
92 [&] { return last_event_surface == surface && last_event.type == event_filter; });100 [&] { return last_event_surface == surface && mir_event_get_type(last_event) == event_filter; });
93 }101 }
94102
95 void set_event_filter(MirEventType type)103 void set_event_filter(MirEventType type)
@@ -101,7 +109,9 @@
101 void reset_last_event()109 void reset_last_event()
102 {110 {
103 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};111 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
104 memset(&last_event, 0, sizeof last_event);112 if (last_event != nullptr)
113 mir_event_unref(last_event);
114 last_event = nullptr;
105 last_event_surface = nullptr;115 last_event_surface = nullptr;
106 }116 }
107117
@@ -151,31 +161,20 @@
151161
152TEST_F(ClientSurfaceEvents, surface_receives_state_events)162TEST_F(ClientSurfaceEvents, surface_receives_state_events)
153{163{
154 int surface_id = mir_debug_surface_id(surface);
155
156 {164 {
157 mir_wait_for(mir_surface_set_state(surface, mir_surface_state_fullscreen));165 mir_wait_for(mir_surface_set_state(surface, mir_surface_state_fullscreen));
158 mir_wait_for(mir_surface_set_state(other_surface, mir_surface_state_vertmaximized));166 mir_wait_for(mir_surface_set_state(other_surface, mir_surface_state_vertmaximized));
159167
160 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};168 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
161169
162 EXPECT_THAT(last_event_surface, Eq(surface));170 EXPECT_THAT(last_event, mt::SurfaceEvent(mir_surface_attrib_state, mir_surface_state_fullscreen));
163 EXPECT_THAT(last_event.type, Eq(mir_event_type_surface));
164 EXPECT_THAT(last_event.surface.id, Eq(surface_id));
165 EXPECT_THAT(last_event.surface.attrib, Eq(mir_surface_attrib_state));
166 EXPECT_THAT(last_event.surface.value, Eq(mir_surface_state_fullscreen));
167 }171 }
168172
169 {173 {
170 mir_wait_for(mir_surface_set_state(surface, static_cast<MirSurfaceState>(999)));174 mir_wait_for(mir_surface_set_state(surface, static_cast<MirSurfaceState>(999)));
171175
172 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};176 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
173177 EXPECT_THAT(last_event, mt::SurfaceEvent(mir_surface_attrib_state, mir_surface_state_fullscreen));
174 EXPECT_THAT(last_event_surface, Eq(surface));
175 EXPECT_THAT(last_event.type, Eq(mir_event_type_surface));
176 EXPECT_THAT(last_event.surface.id, Eq(surface_id));
177 EXPECT_THAT(last_event.surface.attrib, Eq(mir_surface_attrib_state));
178 EXPECT_THAT(last_event.surface.value, Eq(mir_surface_state_fullscreen));
179 }178 }
180179
181 reset_last_event();180 reset_last_event();
@@ -185,11 +184,7 @@
185184
186 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};185 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
187186
188 EXPECT_THAT(last_event_surface, Eq(surface));187 EXPECT_THAT(last_event, mt::SurfaceEvent(mir_surface_attrib_state, mir_surface_state_vertmaximized));
189 EXPECT_THAT(last_event.type, Eq(mir_event_type_surface));
190 EXPECT_THAT(last_event.surface.id, Eq(surface_id));
191 EXPECT_THAT(last_event.surface.attrib, Eq(mir_surface_attrib_state));
192 EXPECT_THAT(last_event.surface.value, Eq(mir_surface_state_vertmaximized));
193 }188 }
194189
195 reset_last_event();190 reset_last_event();
@@ -200,11 +195,7 @@
200195
201 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};196 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
202197
203 EXPECT_THAT(last_event_surface, IsNull());198 EXPECT_EQ(nullptr, last_event);
204 EXPECT_THAT(last_event.type, Eq(0));
205 EXPECT_THAT(last_event.surface.id, Eq(0));
206 EXPECT_THAT(last_event.surface.attrib, Eq(0));
207 EXPECT_THAT(last_event.surface.value, Eq(0));
208 }199 }
209}200}
210201
@@ -222,9 +213,7 @@
222213
223 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};214 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
224215
225 EXPECT_THAT(last_event_surface, Eq(surface));216 EXPECT_THAT(last_event, mt::OrientationEvent(direction));
226 EXPECT_THAT(last_event.type, Eq(mir_event_type_orientation));
227 EXPECT_THAT(last_event.orientation.direction, Eq(direction));
228}217}
229218
230INSTANTIATE_TEST_CASE_P(ClientSurfaceEvents,219INSTANTIATE_TEST_CASE_P(ClientSurfaceEvents,
@@ -261,7 +250,7 @@
261 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};250 std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
262251
263 EXPECT_THAT(last_event_surface, Eq(surface));252 EXPECT_THAT(last_event_surface, Eq(surface));
264 EXPECT_THAT(last_event.type, Eq(mir_event_type_close_surface));253 EXPECT_THAT(mir_event_get_type(last_event), Eq(mir_event_type_close_surface));
265}254}
266255
267TEST_F(ClientSurfaceEvents, client_can_query_preferred_orientation)256TEST_F(ClientSurfaceEvents, client_can_query_preferred_orientation)
268257
=== modified file 'tests/acceptance-tests/throwback/test_client_input.cpp'
--- tests/acceptance-tests/throwback/test_client_input.cpp 2015-03-31 02:35:42 +0000
+++ tests/acceptance-tests/throwback/test_client_input.cpp 2015-04-07 21:28:28 +0000
@@ -18,8 +18,7 @@
18 * Alexandros Frantzis <alexandros.frantzis@canonical.com>18 * Alexandros Frantzis <alexandros.frantzis@canonical.com>
19 */19 */
2020
21#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER 21#include "mir/events/event_private.h"
22
23#include "mir/shell/shell_wrapper.h"22#include "mir/shell/shell_wrapper.h"
24#include "mir/scene/surface_creation_parameters.h"23#include "mir/scene/surface_creation_parameters.h"
25#include "mir/scene/surface.h"24#include "mir/scene/surface.h"
@@ -108,7 +107,7 @@
108 {107 {
109 auto const client = static_cast<InputClient*>(context);108 auto const client = static_cast<InputClient*>(context);
110109
111 if (ev->type == mir_event_type_surface)110 if (mir_event_get_type(ev) == mir_event_type_surface)
112 return;111 return;
113112
114 client->handler.handle_input(ev);113 client->handler.handle_input(ev);
115114
=== modified file 'tests/acceptance-tests/throwback/test_custom_input_dispatcher.cpp'
--- tests/acceptance-tests/throwback/test_custom_input_dispatcher.cpp 2015-03-31 02:35:42 +0000
+++ tests/acceptance-tests/throwback/test_custom_input_dispatcher.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/input/input_dispatcher.h"19#include "mir/input/input_dispatcher.h"
2220
23#include "clients.h"21#include "clients.h"
@@ -34,6 +32,7 @@
34#include "mir/compositor/scene.h"32#include "mir/compositor/scene.h"
35#include "mir/shell/input_targeter.h"33#include "mir/shell/input_targeter.h"
36#include "mir/scene/observer.h"34#include "mir/scene/observer.h"
35#include "mir/events/event_private.h"
3736
38#include "mir_toolkit/event.h"37#include "mir_toolkit/event.h"
3938
4039
=== modified file 'tests/include/mir_test_doubles/mock_event_filter.h'
--- tests/include/mir_test_doubles/mock_event_filter.h 2015-03-31 02:35:42 +0000
+++ tests/include/mir_test_doubles/mock_event_filter.h 2015-04-07 21:28:28 +0000
@@ -19,8 +19,6 @@
19#ifndef MIR_TEST_DOUBLES_MOCK_EVENT_FILTER_H_19#ifndef MIR_TEST_DOUBLES_MOCK_EVENT_FILTER_H_
20#define MIR_TEST_DOUBLES_MOCK_EVENT_FILTER_H_20#define MIR_TEST_DOUBLES_MOCK_EVENT_FILTER_H_
2121
22#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
23
24#include "mir/input/event_filter.h"22#include "mir/input/event_filter.h"
2523
26#include <gmock/gmock.h>24#include <gmock/gmock.h>
2725
=== modified file 'tests/integration-tests/input/android/test_android_cursor_listener.cpp'
--- tests/integration-tests/input/android/test_android_cursor_listener.cpp 2015-03-31 02:35:42 +0000
+++ tests/integration-tests/input/android/test_android_cursor_listener.cpp 2015-04-07 21:28:28 +0000
@@ -17,8 +17,7 @@
17 * Daniel d'Andrada <daniel.dandrada@canonical.com>17 * Daniel d'Andrada <daniel.dandrada@canonical.com>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER20#include "mir/events/event_private.h"
21
22#include "src/server/input/event_filter_chain.h"21#include "src/server/input/event_filter_chain.h"
2322
24#include "mir_test/fake_shared.h"23#include "mir_test/fake_shared.h"
2524
=== modified file 'tests/integration-tests/input/android/test_android_input_manager.cpp'
--- tests/integration-tests/input/android/test_android_input_manager.cpp 2015-03-31 02:35:42 +0000
+++ tests/integration-tests/input/android/test_android_input_manager.cpp 2015-04-07 21:28:28 +0000
@@ -17,7 +17,7 @@
17 * Daniel d'Andrada <daniel.dandrada@canonical.com>17 * Daniel d'Andrada <daniel.dandrada@canonical.com>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER20#include "mir/events/event_private.h"
2121
22#include "src/server/input/android/android_input_targeter.h"22#include "src/server/input/android/android_input_targeter.h"
23#include "src/server/input/android/android_input_registrar.h"23#include "src/server/input/android/android_input_registrar.h"
2424
=== modified file 'tests/integration-tests/input/test_nested_input.cpp'
--- tests/integration-tests/input/test_nested_input.cpp 2015-03-31 02:35:42 +0000
+++ tests/integration-tests/input/test_nested_input.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,10 @@
16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/server/report/null/input_report.h"19#include "src/server/report/null/input_report.h"
22#include "mir/input/input_manager.h"20#include "mir/input/input_manager.h"
23#include "mir/input/input_dispatcher.h"21#include "mir/input/input_dispatcher.h"
22#include "mir/events/event_private.h"
24#include "src/server/input/android/android_input_dispatcher.h"23#include "src/server/input/android/android_input_dispatcher.h"
25#include "src/server/input/android/event_filter_dispatcher_policy.h"24#include "src/server/input/android/event_filter_dispatcher_policy.h"
26#include "src/server/input/android/common_input_thread.h"25#include "src/server/input/android/common_input_thread.h"
2726
=== modified file 'tests/integration-tests/test_display_server_main_loop_events.cpp'
--- tests/integration-tests/test_display_server_main_loop_events.cpp 2015-04-06 11:54:36 +0000
+++ tests/integration-tests/test_display_server_main_loop_events.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>16 * Authored by: Alexandros Frantzis <alexandros.frantzis@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/compositor/compositor.h"19#include "mir/compositor/compositor.h"
22#include "mir/frontend/connector.h"20#include "mir/frontend/connector.h"
23#include "mir/graphics/display_configuration.h"21#include "mir/graphics/display_configuration.h"
@@ -25,6 +23,7 @@
25#include "mir/server_action_queue.h"23#include "mir/server_action_queue.h"
26#include "mir/graphics/event_handler_register.h"24#include "mir/graphics/event_handler_register.h"
27#include "mir/server_status_listener.h"25#include "mir/server_status_listener.h"
26#include "mir/events/event_private.h"
2827
29#include "mir_test/pipe.h"28#include "mir_test/pipe.h"
30#include "mir_test/wait_condition.h"29#include "mir_test/wait_condition.h"
3130
=== modified file 'tests/mir_test_doubles/test_protobuf_client.cpp'
--- tests/mir_test_doubles/test_protobuf_client.cpp 2015-03-31 02:35:42 +0000
+++ tests/mir_test_doubles/test_protobuf_client.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir_test/test_protobuf_client.h"19#include "mir_test/test_protobuf_client.h"
22#include "mir_test_doubles/mock_rpc_report.h"20#include "mir_test_doubles/mock_rpc_report.h"
23#include "mir_test_doubles/null_client_event_sink.h"21#include "mir_test_doubles/null_client_event_sink.h"
@@ -29,6 +27,7 @@
29#include "src/client/rpc/mir_basic_rpc_channel.h"27#include "src/client/rpc/mir_basic_rpc_channel.h"
30#include "mir/dispatch/dispatchable.h"28#include "mir/dispatch/dispatchable.h"
31#include "mir/dispatch/simple_dispatch_thread.h"29#include "mir/dispatch/simple_dispatch_thread.h"
30#include "mir/events/event_private.h"
3231
33#include <thread>32#include <thread>
3433
3534
=== modified file 'tests/mir_test_framework/stubbed_server_configuration.cpp'
--- tests/mir_test_framework/stubbed_server_configuration.cpp 2015-03-31 02:35:42 +0000
+++ tests/mir_test_framework/stubbed_server_configuration.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir_test_framework/stubbed_server_configuration.h"19#include "mir_test_framework/stubbed_server_configuration.h"
22#include "mir_test_framework/command_line_server_configuration.h"20#include "mir_test_framework/command_line_server_configuration.h"
2321
2422
=== modified file 'tests/unit-tests/client/input/test_android_input_receiver.cpp'
--- tests/unit-tests/client/input/test_android_input_receiver.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/client/input/test_android_input_receiver.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,11 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/client/input/android/android_input_receiver.h"19#include "src/client/input/android/android_input_receiver.h"
22#include "mir/input/null_input_receiver_report.h"20#include "mir/input/null_input_receiver_report.h"
23#include "mir/input/xkb_mapper.h"21#include "mir/input/xkb_mapper.h"
22#include "mir/events/event_private.h"
23
24#include "mir_toolkit/event.h"24#include "mir_toolkit/event.h"
2525
26#include "mir_test/fd_utils.h"26#include "mir_test/fd_utils.h"
2727
=== modified file 'tests/unit-tests/client/input/test_xkb_mapper.cpp'
--- tests/unit-tests/client/input/test_xkb_mapper.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/client/input/test_xkb_mapper.cpp 2015-04-07 21:28:28 +0000
@@ -17,6 +17,7 @@
17 */17 */
1818
19#include "mir/input/xkb_mapper.h"19#include "mir/input/xkb_mapper.h"
20#include "mir/events/event_private.h"
2021
21#include <xkbcommon/xkbcommon-keysyms.h>22#include <xkbcommon/xkbcommon-keysyms.h>
22#include <xkbcommon/xkbcommon.h>23#include <xkbcommon/xkbcommon.h>
2324
=== modified file 'tests/unit-tests/client/test_event_distributor.cpp'
--- tests/unit-tests/client/test_event_distributor.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/client/test_event_distributor.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,10 @@
16 * Authored by: Nick Dedekind <nick.dedekind <nick.dedekind@canonical.com>16 * Authored by: Nick Dedekind <nick.dedekind <nick.dedekind@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/client/mir_event_distributor.h"19#include "src/client/mir_event_distributor.h"
2220
21#include "mir/events/event_private.h"
22
23#include <gtest/gtest.h>23#include <gtest/gtest.h>
24#include <gmock/gmock.h>24#include <gmock/gmock.h>
25#include <mir_test/wait_condition.h>25#include <mir_test/wait_condition.h>
2626
=== modified file 'tests/unit-tests/frontend/test_published_socket_connector.cpp'
--- tests/unit-tests/frontend/test_published_socket_connector.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/frontend/test_published_socket_connector.cpp 2015-04-07 21:28:28 +0000
@@ -17,9 +17,8 @@
17 * Alan Griffiths <alan@octopull.co.uk>17 * Alan Griffiths <alan@octopull.co.uk>
18 */18 */
1919
20#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
21
22#include "mir/frontend/connector.h"20#include "mir/frontend/connector.h"
21#include "mir/events/event_private.h"
2322
24#include "src/server/report/null_report_factory.h"23#include "src/server/report/null_report_factory.h"
25#include "src/server/frontend/resource_cache.h"24#include "src/server/frontend/resource_cache.h"
2625
=== modified file 'tests/unit-tests/input/android/test_android_input_application_handle.cpp'
--- tests/unit-tests/input/android/test_android_input_application_handle.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_android_input_application_handle.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,9 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/server/input/android/android_input_application_handle.h"19#include "src/server/input/android/android_input_application_handle.h"
2220
21#include "mir/events/event_private.h"
23#include "mir/input/input_channel.h"22#include "mir/input/input_channel.h"
2423
25#include "mir_test_doubles/mock_input_surface.h"24#include "mir_test_doubles/mock_input_surface.h"
2625
=== modified file 'tests/unit-tests/input/android/test_android_input_dispatcher.cpp'
--- tests/unit-tests/input/android/test_android_input_dispatcher.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_android_input_dispatcher.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,7 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER19#include "mir/events/event_private.h"
20
21#include "src/server/input/android/android_input_dispatcher.h"20#include "src/server/input/android/android_input_dispatcher.h"
22#include "src/server/input/android/android_input_thread.h"21#include "src/server/input/android/android_input_thread.h"
23#include "src/server/input/android/android_input_constants.h"22#include "src/server/input/android/android_input_constants.h"
2423
=== modified file 'tests/unit-tests/input/android/test_android_input_lexicon.cpp'
--- tests/unit-tests/input/android/test_android_input_lexicon.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_android_input_lexicon.cpp 2015-04-07 21:28:28 +0000
@@ -16,10 +16,8 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/input/android/android_input_lexicon.h"19#include "mir/input/android/android_input_lexicon.h"
22#include "mir_toolkit/event.h"20#include "mir/events/event_private.h"
2321
24#include <androidfw/Input.h>22#include <androidfw/Input.h>
2523
2624
=== modified file 'tests/unit-tests/input/android/test_android_input_sender.cpp'
--- tests/unit-tests/input/android/test_android_input_sender.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_android_input_sender.cpp 2015-04-07 21:28:28 +0000
@@ -16,7 +16,7 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER19#include "mir/events/event_private.h"
2020
21#include "src/server/input/android/android_input_channel.h"21#include "src/server/input/android/android_input_channel.h"
22#include "src/server/input/android/input_sender.h"22#include "src/server/input/android/input_sender.h"
2323
=== modified file 'tests/unit-tests/input/android/test_android_input_window_handle.cpp'
--- tests/unit-tests/input/android/test_android_input_window_handle.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_android_input_window_handle.cpp 2015-04-07 21:28:28 +0000
@@ -16,13 +16,12 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/server/input/android/android_input_window_handle.h"19#include "src/server/input/android/android_input_window_handle.h"
2220
23#include "mir/frontend/surface.h"21#include "mir/frontend/surface.h"
24#include "mir/geometry/size.h"22#include "mir/geometry/size.h"
25#include "mir/input/input_channel.h"23#include "mir/input/input_channel.h"
24#include "mir/events/event_private.h"
2625
27#include "mir_test/fake_shared.h"26#include "mir_test/fake_shared.h"
28#include "mir_test_doubles/mock_input_surface.h"27#include "mir_test_doubles/mock_input_surface.h"
2928
=== modified file 'tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp'
--- tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_event_filter_input_dispatcher_policy.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,8 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/input/event_filter.h"19#include "mir/input/event_filter.h"
20#include "mir/events/event_private.h"
22#include "src/server/input/android/event_filter_dispatcher_policy.h"21#include "src/server/input/android/event_filter_dispatcher_policy.h"
2322
24#include "mir_test/fake_shared.h"23#include "mir_test/fake_shared.h"
2524
=== modified file 'tests/unit-tests/input/android/test_input_translator.cpp'
--- tests/unit-tests/input/android/test_input_translator.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/android/test_input_translator.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,10 @@
16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>16 * Authored by: Andreas Pokorny <andreas.pokorny@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
2019
21#include "src/server/input/android/input_translator.h"20#include "src/server/input/android/input_translator.h"
21#include "mir/events/event_private.h"
22
22#include "mir_test_doubles/mock_input_dispatcher.h"23#include "mir_test_doubles/mock_input_dispatcher.h"
23#include "mir_test/fake_shared.h"24#include "mir_test/fake_shared.h"
24#include "mir_test/event_matchers.h"25#include "mir_test/event_matchers.h"
2526
=== modified file 'tests/unit-tests/input/test_default_input_device_hub.cpp'
--- tests/unit-tests/input/test_default_input_device_hub.cpp 2015-03-30 18:41:05 +0000
+++ tests/unit-tests/input/test_default_input_device_hub.cpp 2015-04-07 21:28:28 +0000
@@ -26,6 +26,7 @@
2626
27#include "mir/input/input_device.h"27#include "mir/input/input_device.h"
28#include "mir/input/input_device_info.h"28#include "mir/input/input_device_info.h"
29#include "mir/events/event_private.h"
29#include "mir/dispatch/multiplexing_dispatchable.h"30#include "mir/dispatch/multiplexing_dispatchable.h"
30#include "mir/dispatch/action_queue.h"31#include "mir/dispatch/action_queue.h"
3132
3233
=== modified file 'tests/unit-tests/input/test_event_builders.cpp'
--- tests/unit-tests/input/test_event_builders.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/test_event_builders.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,6 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "mir/events/event_builders.h"19#include "mir/events/event_builders.h"
2220
23#include <gtest/gtest.h>21#include <gtest/gtest.h>
2422
=== modified file 'tests/unit-tests/input/test_event_filter_chain.cpp'
--- tests/unit-tests/input/test_event_filter_chain.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/test_event_filter_chain.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,10 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/server/input/event_filter_chain.h"19#include "src/server/input/event_filter_chain.h"
22#include "mir_test_doubles/mock_event_filter.h"20#include "mir_test_doubles/mock_event_filter.h"
23#include "mir/events/event_builders.h"21#include "mir/events/event_builders.h"
22#include "mir/events/event_private.h"
2423
25#include <androidfw/Input.h>24#include <androidfw/Input.h>
2625
2726
=== modified file 'tests/unit-tests/input/test_input_event.cpp'
--- tests/unit-tests/input/test_input_event.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/input/test_input_event.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,9 @@
16 * Authored by: Robert Carr <robert.carr@canonical.com>16 * Authored by: Robert Carr <robert.carr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include <gtest/gtest.h>19#include <gtest/gtest.h>
2220
23#include "mir_toolkit/event.h"21#include "mir/events/event_private.h"
24#include "mir_toolkit/events/input/input_event.h"22#include "mir_toolkit/events/input/input_event.h"
2523
26// See: https://bugs.launchpad.net/mir/+bug/131169924// See: https://bugs.launchpad.net/mir/+bug/1311699
2725
=== modified file 'tests/unit-tests/scene/test_application_session.cpp'
--- tests/unit-tests/scene/test_application_session.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/scene/test_application_session.cpp 2015-04-07 21:28:28 +0000
@@ -16,9 +16,8 @@
16 * Authored By: Robert Carr <racarr@canonical.com>16 * Authored By: Robert Carr <racarr@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
20
21#include "src/server/scene/application_session.h"19#include "src/server/scene/application_session.h"
20#include "mir/events/event_private.h"
22#include "mir/graphics/buffer.h"21#include "mir/graphics/buffer.h"
23#include "mir/scene/surface_creation_parameters.h"22#include "mir/scene/surface_creation_parameters.h"
24#include "mir/scene/null_session_listener.h"23#include "mir/scene/null_session_listener.h"
2524
=== modified file 'tests/unit-tests/scene/test_basic_surface.cpp'
--- tests/unit-tests/scene/test_basic_surface.cpp 2015-04-02 14:07:26 +0000
+++ tests/unit-tests/scene/test_basic_surface.cpp 2015-04-07 21:28:28 +0000
@@ -16,11 +16,11 @@
16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER
2019
21#include "src/server/scene/basic_surface.h"20#include "src/server/scene/basic_surface.h"
22#include "src/server/scene/legacy_surface_change_notification.h"21#include "src/server/scene/legacy_surface_change_notification.h"
2322
23#include "mir/events/event_private.h"
24#include "mir/frontend/event_sink.h"24#include "mir/frontend/event_sink.h"
25#include "mir/geometry/rectangle.h"25#include "mir/geometry/rectangle.h"
26#include "mir/geometry/displacement.h"26#include "mir/geometry/displacement.h"
2727
=== modified file 'tests/unit-tests/scene/test_surface.cpp'
--- tests/unit-tests/scene/test_surface.cpp 2015-03-31 16:38:02 +0000
+++ tests/unit-tests/scene/test_surface.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,7 @@
16 * Authored by: Thomas Voss <thomas.voss@canonical.com>16 * Authored by: Thomas Voss <thomas.voss@canonical.com>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER19#include "mir/events/event_private.h"
20
21#include "src/server/scene/basic_surface.h"20#include "src/server/scene/basic_surface.h"
22#include "src/server/scene/legacy_surface_change_notification.h"21#include "src/server/scene/legacy_surface_change_notification.h"
23#include "src/server/report/null_report_factory.h"22#include "src/server/report/null_report_factory.h"
2423
=== modified file 'tests/unit-tests/scene/test_surface_impl.cpp'
--- tests/unit-tests/scene/test_surface_impl.cpp 2015-03-31 02:35:42 +0000
+++ tests/unit-tests/scene/test_surface_impl.cpp 2015-04-07 21:28:28 +0000
@@ -16,8 +16,7 @@
16 * Authored by: Alan Griffiths <alan@octopull.co.uk>16 * Authored by: Alan Griffiths <alan@octopull.co.uk>
17 */17 */
1818
19#define MIR_INCLUDE_DEPRECATED_EVENT_HEADER19#include "mir/events/event_private.h"
20
21#include "src/server/scene/basic_surface.h"20#include "src/server/scene/basic_surface.h"
22#include "mir/scene/surface_observer.h"21#include "mir/scene/surface_observer.h"
23#include "mir/scene/surface_event_source.h"22#include "mir/scene/surface_event_source.h"

Subscribers

People subscribed via source and target branches