Mir

Code review comment for lp:~mir-team/mir/privatize-event

Revision history for this message
Chris Halse Rogers (raof) wrote :

You seem to hamve moved event_deprecated.h to event_private.h without changing any of the compile guards and such; they should probably match the new filename.

Also, I think you can still cut the diff down substantially by doing bzr mv --after event_deprecated.h event_private.h to get bzr to record that as a move.

1055 - memset(&last_event, 0, sizeof last_event);
1056 + last_event = nullptr;

Shouldn't this unref last_event if it wasn't nullptr

Otherwise, WOOT!

review: Needs Fixing

« Back to merge proposal