Mir

Code review comment for lp:~mir-team/mir/privatize-event

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

600 - EXPECT_THAT(last_event_surface, Eq(surface));
601 - EXPECT_THAT(last_event.type, Eq(mir_event_type_surface));
602 - EXPECT_THAT(last_event.surface.id, Eq(surface_id));
603 - EXPECT_THAT(last_event.surface.attrib, Eq(mir_surface_attrib_state));
604 - EXPECT_THAT(last_event.surface.value, Eq(mir_surface_state_minimized));
605 - }
606 -
607 - reset_last_event();
608 -
609 - {
610 - mir_wait_for(mir_surface_set_state(surface, static_cast<MirSurfaceState>(777)));
611 - mir_wait_for(mir_surface_set_state(other_surface, mir_surface_state_maximized));
612 -
613 - std::lock_guard<decltype(last_event_mutex)> last_event_lock{last_event_mutex};
614 -
615 - EXPECT_THAT(last_event_surface, IsNull());
616 - EXPECT_THAT(last_event.type, Eq(0));
617 - EXPECT_THAT(last_event.surface.id, Eq(0));
618 - EXPECT_THAT(last_event.surface.attrib, Eq(0));
619 - EXPECT_THAT(last_event.surface.value, Eq(0));
620 + EXPECT_THAT(last_event, mt::SurfaceEvent(mir_surface_attrib_state, mir_surface_state_minimized));

this test has been weakened to deal with fewer state changes.

review: Needs Fixing

« Back to merge proposal