Code review comment for ~mertkirpici/juju-lint:topic/coverage

Revision history for this message
Robert Gildein (rgildein) wrote :

> Hi there Robert, thanks for the review! This snap recently seems to have
> received the template update but the coverage relation sections in tox and
> pyproject.toml were missing. I assumed they were also missing in the bootstack
> templates. Turns out they're not. Maybe they were skipped due to the sys.argv
> bug I tried to explain in the description. Passing arguments to pytest in
> tox.ini was broken.

Maybe it was related with tox 4.* issue? Not sure here.

> I am thinking of applying both your suggestions and align pyproject.toml and
> tox.ini posargs in this MP, I think it is a better solution rather than
> diverging more. What are your thoughts?

It's up to you, I'm trying to suggest templates everywhere, because it's easier
to work on multiple project with similar dev behavior and also using them in various
projects helps to improve them. I think that using separate MP is better, because
you can add/update more templates at once (recently we add .gitignore).

Also feel free to update our templates if it's needed. Recently I removed
`addopts` [1] from `juju-spell`, because it was more annoying than helpful.

---
[1]: https://git.launchpad.net/bootstack-charms-spec/tree/source/snap-pytest/pyproject.toml#n38

them also.

« Back to merge proposal