~mertkirpici/juju-lint:topic/coverage

Branch merges

Propose for merging

Merged into juju-lint:master at revision ce5d33a2b39e4a133eb6abbabc5105c1c9e0ea55

Sudeep Bhandari: Approve on 2023-01-25

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-01-25

Ramesh Sattaru (community): Approve on 2023-01-24

Robert Gildein: Approve on 2023-01-24

Diff: 83 lines (+24/-3)

3 files modified

pyproject.toml (+15/-0)
tests/unit/test_config.py (+7/-2)
tox.ini (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

fca2a52... by Mert Kirpici on 2023-01-24

tests/unit: apply bootstack template

Add sections for coverage in pyproject.toml as well

Signed-off-by: Mert Kırpıcı <email address hidden>

f50f5dd... by Mert Kirpici on 2023-01-24

tests/unit: fail under %100 coverage

This was missed during the snap template update, we expect %100 test
coverage in this project.

This also revealed a sneaky bug in the process. When the
jujulint.config.Config class got initialized it was using the sys.argv
of the pytest process, causing a testing error and not being able to
pass arguments to pytest.

Signed-off-by: Mert Kırpıcı <email address hidden>

5ad8fb1... by Gabriel Cocenza on 2022-12-05

fix setup.py to include non python files

- add config_default.yaml into the snap package

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/434015
Reviewed-by: Ramesh Sattaru <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

80e073e... by Gabriel Cocenza on 2022-12-03

fix setup.py to include non python files

- add config_default.yaml into the snap package

1a1351f... by Marcus Boden on 2022-12-02

use values in config file

Values set in $HOME/.config/juju-lint/config.yaml were ignored, due to
the default values of the ArgumentParser. This patch
- removes the default values from the parser
- adds default values to the config_default.yaml
- adds tests to check if the config files are read correctly

Closes-Bug: #1939438

Reviewed-on: https://code.launchpad.net/~marcusboden/juju-lint/+git/juju-lint/+merge/433574
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

c57bb55... by Marcus Boden on 2022-12-02

removed unnecessary return and fixed two typos

fffc38c... by Marcus Boden on 2022-12-02

Change comment to regular funciton definition.

b30ed0b... by Gabriel Cocenza on 2022-12-01

add subdirectories and fixed functional tests

- fixed setup.py to accept subdirectories under the jujulint project
  folder.
- changed the working directory when running functional tests with
  the snap to not use local modules.
- updated contributing for func-smoke and func-dev to run functional
  tests during development.

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/433889
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Tianqi Xiao <email address hidden>

36f4a66... by Gabriel Cocenza on 2022-11-30

add subdirectories and fixed functional tests

- fixed setup.py to accept subdirectories under the jujulint project
  folder.
- changed the working directory when running functional tests with
  the snap to not use local modules.
- updated contributing for func-smoke and func-dev to run functional
  tests during development.

493cc40... by Marcus Boden on 2022-12-01

Added cli-parsing tests and fixed some smaller issues

- config-file mocking packed into its own function.
- mocking argv to check if cli values are read
- makes sure test_default_config doesnt read user-config