Code review comment for ~mertkirpici/juju-lint:topic/coverage

Revision history for this message
Mert Kirpici (mertkirpici) wrote (last edit ):

> LGTM
>
> Maybe we can use our templates [1] in juju-lint, not in this MP.
>
> ---
> [1]: https://git.launchpad.net/bootstack-charms-spec/tree/source/snap-pytest

Hi there Robert, thanks for the review! This snap recently seems to have received the template update but the coverage relation sections in tox and pyproject.toml were missing. I assumed they were also missing in the bootstack templates. Turns out they're not. Maybe they were skipped due to the sys.argv bug I tried to explain in the description. Passing arguments to pytest in tox.ini was broken.

I am thinking of applying both your suggestions and align pyproject.toml and tox.ini posargs in this MP, I think it is a better solution rather than diverging more. What are your thoughts?

« Back to merge proposal