Merge lp:~mefrio-g/scratch/bug-139057 into lp:~elementary-apps/scratch/scratch
Proposed by
Mario Guerriero
Status: | Rejected |
---|---|
Rejected by: | Gero.Bare |
Proposed branch: | lp:~mefrio-g/scratch/bug-139057 |
Merge into: | lp:~elementary-apps/scratch/scratch |
Diff against target: |
165 lines (+122/-0) 4 files modified
CMakeLists.txt (+2/-0) data/language-specs/mustache.lang (+109/-0) src/Services/Document.vala (+10/-0) src/config.vala.cmake (+1/-0) |
To merge this branch: | bzr merge lp:~mefrio-g/scratch/bug-139057 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gero.Bare (community) | Disapprove | ||
Review via email:
|
Description of the change
Fix bug #139057
Make adding support for new languages easier. You just need to add the .lang file in the data/language-specs if you want to add support for a new language.
To post a comment you must log in.
Unmerged revisions
- 1594. By Mario Guerriero
-
using personal language-specs folder
- 1593. By Mario Guerriero
-
fixed #1390577
Ok this seems to work fine, but it's missing something important.
A license.
The first time I saw it, I missed it, but there's no license.
The license needs to be free software (or equivalent that allow redistribution, modify, etc).
Contact the creator, we don't need a permission, that wont work we need a free license (or equivalent, MIT, apache, lgpl, gpl3, BSD).
The lang spec, needs to have the copyright notice, and if the license is not gpl 2, it should be packed with scratch... that part goes beyond my knowledge so you will need to ask ric*tz, or c*dy, or daniel.
Also I didn't know you only need it to copy the lang spec file to /home/< user>/. local/share/ gtksourceview- 3.0/language- specs
Which defeat most of the purpose of this. I don't know, we might need to discuss this part further.