Code review comment for lp:~mefrio-g/scratch/bug-139057

Revision history for this message
Gero.Bare (gero-bare) wrote :

Ok this seems to work fine, but it's missing something important.
A license.

The first time I saw it, I missed it, but there's no license.
The license needs to be free software (or equivalent that allow redistribution, modify, etc).

Contact the creator, we don't need a permission, that wont work we need a free license (or equivalent, MIT, apache, lgpl, gpl3, BSD).

The lang spec, needs to have the copyright notice, and if the license is not gpl 2, it should be packed with scratch... that part goes beyond my knowledge so you will need to ask ric*tz, or c*dy, or daniel.

Also I didn't know you only need it to copy the lang spec file to /home/<user>/.local/share/gtksourceview-3.0/language-specs

Which defeat most of the purpose of this. I don't know, we might need to discuss this part further.

review: Needs Fixing

« Back to merge proposal