Code review comment for lp:~mefrio-g/scratch/bug-139057

Revision history for this message
Gero.Bare (gero-bare) wrote :

Ok, I don't think this is a good Idea.

I discussed this, the proper action is to add the file to GtkSourceView, and not here.

The license issue remains, so if you want to add it to Gtksourceview you have 2 path.
Contact the people of GtkSourceview, or convince some one that is responsible to pack Gtksourceview for elementary to be added there.

Ideally this should be fixed upstream.

I need to disapprove this.

review: Disapprove

« Back to merge proposal