MariaDB

maria:bb-10.11-vicentiu-cleanups

  1. Git
  2. lp:maria
  3. bb-10.11-vicentiu-cleanups
Last commit made on 2023-07-19
Get this branch:
git clone -b bb-10.11-vicentiu-cleanups https://git.launchpad.net/maria

Branch merges

Branch information

Name:
bb-10.11-vicentiu-cleanups
Repository:
lp:maria

Recent commits

290e53a... by Vicențiu Ciorbaru

bugfix: userstat uses acl code, it must be recompiled for embedded

22dfe43... by Vicențiu Ciorbaru

bugfix: Fix warning in perfschema

The *ptr could end up dereferencing to an invalid memory address
if the function's parameter is ill-formed.

Adjust the where clause to ensure that can not happen.

c3d2e1b... by Vicențiu Ciorbaru

cleanup: check_grant_db takes in const LEX_CSTRING

8997905... by Vicențiu Ciorbaru

cleanup: Extract the printing of routine grants to separate function

No logic changes.

b184a49... by Vicențiu Ciorbaru

cleanup: sp_grant_privileges - More strightforward implementation

194618d... by Vicențiu Ciorbaru

cleanup: TABLE_LIST::get_{db|table}_name() return `const LEX_CSTRING &`

We already have the LEX_CSTRING computed within TABLE_LIST. This can eliminate
the need for some strlen calls. The patch currently only fixes immediate strlen
occurences. A follow-up patch is needed to optimize / clean-up call
sites.

8d3b3b7... by Vicențiu Ciorbaru

cleanup: check_some_routine_access take in LEX_CSTRING& and Sp_handler&

This is an intermediate cleanup commit, aimed at removing the need for strlens
by passing in already computed LEX_CSTRINGS.

c9765ae... by Vicențiu Ciorbaru

cleanup: Fix translation for ILLEGAL_GRANT_FOR_TABLE

Update string to match DENY clause too.

832abf3... by Vicențiu Ciorbaru

cleanup: make_table_name_list does not use LEX parameter

69114e4... by Vicențiu Ciorbaru

cleanup: get_cached_{schema|table}_access is not part of sql_acl.h interface

The functions are only used internally in the sql_acl.cc module. Mark
them as static.

TODO: The GRANT_INFO structure inside table could be encapsulated so we do not
      have code that access it like
      table_list->grant.m_internal.<member>