View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/maria

MariaDB has 18 active reviews. See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://github.com/MariaDB/server.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 4 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 5 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 5 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 5 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 4 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 8 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 6 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 6 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 4 minutes — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 3 minutes — see the log

Branches

Name Last Modified Last Commit
bb-MDEV-21092-21095-29997-optimizer-trace-updates 2022-11-30 22:54:45 UTC
MDEV-21092,MDEV-21095,MDEV-29997: Optimizer Trace for index condition pushdow...

Author: Rex
Author Date: 2022-11-30 22:01:36 UTC

MDEV-21092,MDEV-21095,MDEV-29997: Optimizer Trace for index condition pushdown, partition pruning, exists-to-in

Add Optimizer Tracing for:
- Index Condition Pushdown
- Partition Pruning
- Exists-to-IN optimization

bb-10.5-serg 2022-11-30 22:20:42 UTC
ADD CONSTRAINT IF NOT EXISTS didn't work in SP

Author: Sergei Golubchik
Author Date: 2022-11-03 18:17:25 UTC

ADD CONSTRAINT IF NOT EXISTS didn't work in SP

"if not exists" must be stored in a separate read-only property

bb-10.3-serg 2022-11-30 21:49:44 UTC
fix more sporadic failures on main.kill

Author: Sergei Golubchik
Author Date: 2022-11-30 21:49:44 UTC

fix more sporadic failures on main.kill

sometimes `KILL QUERY ID @id` was executed before the previous
`send SELECT SLEEP(1000)` has reached the parser. As the statement
resets the kill status before execution, the effect of the KILL
was ignored.

bb-11.0 2022-11-30 21:20:01 UTC
Changed some startup warnings to notes

Author: Monty
Author Date: 2022-11-28 13:02:34 UTC

Changed some startup warnings to notes

- Changed 'WARNING' of type "You need to use --log-bin to make ... work"
  to 'Note'
- Only print startup Notes if log_warnings >= 4

bb-10.3-vicentiu 2022-11-30 20:33:20 UTC
MDEV-30023 Revoking Privilege on the Column Yields the Error

Author: Vicențiu Ciorbaru
Author Date: 2022-11-24 17:50:14 UTC

MDEV-30023 Revoking Privilege on the Column Yields the Error

The change from MDEV-29465 exposed a flaw in replace_column_table
where again we were not properly updating the column-level bits.

replace_table_table was changed in MDEV-29465 to properly update
grant_table->init_cols, however replace_column_table still only
modified grant_column->rights when the GRANT_COLUMN already existed.

This lead to a missmatch between GRANT_COLUMN::init_rights and
GRANT_COLUMN::rights, *if* the GRANT_COLUMN already existed.

As an example:

GRANT SELECT (col1) ...
Here:
For col1
GRANT_COLUMN::init_rights and GRANT_COLUMN::rights are set to 1 (SELECT) in
replace_column_table.

GRANT INSERT (col1) ...
Here, without this patch GRANT_COLUMN::init_rights is still 1 and
GRANT_COLUMN::rights is 3 (SELECT_PRIV | INSERT_PRIV)

Finally, if before this patch, one does:

REVOKE SELECT (col1) ...

replace_table_table will see that init_rights loses bit 1 thus it
considers there are no more rights granted on that particular table.

This prompts the whole GRANT_TABLE to be removed via the first revoke,
when the GRANT_COLUMN corresponding to it should still have init_rights == 2.

By also updating replace_column_table to keep init_rights in sync
properly, the issue is resolved.

Reviewed by <serg@mariadb.com>

10.3 2022-11-30 20:33:20 UTC
MDEV-30023 Revoking Privilege on the Column Yields the Error

Author: Vicențiu Ciorbaru
Author Date: 2022-11-24 17:50:14 UTC

MDEV-30023 Revoking Privilege on the Column Yields the Error

The change from MDEV-29465 exposed a flaw in replace_column_table
where again we were not properly updating the column-level bits.

replace_table_table was changed in MDEV-29465 to properly update
grant_table->init_cols, however replace_column_table still only
modified grant_column->rights when the GRANT_COLUMN already existed.

This lead to a missmatch between GRANT_COLUMN::init_rights and
GRANT_COLUMN::rights, *if* the GRANT_COLUMN already existed.

As an example:

GRANT SELECT (col1) ...
Here:
For col1
GRANT_COLUMN::init_rights and GRANT_COLUMN::rights are set to 1 (SELECT) in
replace_column_table.

GRANT INSERT (col1) ...
Here, without this patch GRANT_COLUMN::init_rights is still 1 and
GRANT_COLUMN::rights is 3 (SELECT_PRIV | INSERT_PRIV)

Finally, if before this patch, one does:

REVOKE SELECT (col1) ...

replace_table_table will see that init_rights loses bit 1 thus it
considers there are no more rights granted on that particular table.

This prompts the whole GRANT_TABLE to be removed via the first revoke,
when the GRANT_COLUMN corresponding to it should still have init_rights == 2.

By also updating replace_column_table to keep init_rights in sync
properly, the issue is resolved.

Reviewed by <serg@mariadb.com>

bb-10.5-monty 2022-11-30 19:18:47 UTC
Fixed a crash during automatic zerofill of moved Aria table

Author: Monty
Author Date: 2022-11-30 19:18:47 UTC

Fixed a crash during automatic zerofill of moved Aria table

This could happen if one did a DML with a moved table that one had done
an external zerofill on.
The crash happend because a message that was supposed to be sent to
a repair report was instead sent to the result, which caused an ASSERT

bb-10.5-MDEV-29981-log-headers 2022-11-30 18:59:40 UTC
MDEV-29981: Replica stops with 'Found invalid event in binary log'

Author: Brandon Nesterenko
Author Date: 2022-11-30 18:59:38 UTC

MDEV-29981: Replica stops with 'Found invalid event in binary log'

Prototype commit for a primary to print certain event's
headers before sending to replica to facilitate debugging
a release build. Specifically, it will output the header
of a fake rotate event, the following format description
event, and the next event.

bb-10.11-MDEV-29694 2022-11-30 14:24:32 UTC
MDEV-29694 Remove the InnoDB change buffer

Author: Marko Mäkelä
Author Date: 2022-11-30 14:24:32 UTC

MDEV-29694 Remove the InnoDB change buffer

The purpose of the change buffer was to reduce random disk access,
which could be useful on rotational storage, but maybe less so on
solid-state storage.
When we wished to
(1) insert a record into a non-unique secondary index,
(2) delete-mark a secondary index record,
(3) delete a secondary index record as part of purge (but not ROLLBACK),
and the B-tree leaf page where the record belongs to is not in the buffer
pool, we inserted a record into the change buffer B-tree, indexed by
the page identifier. When the page was eventually read into the buffer
pool, we looked up the change buffer B-tree for any modifications to the
page, applied these upon the completion of the read operation. This
was called the insert buffer merge.

We remove the change buffer, because it has been the source of
various hard-to-reproduce corruption bugs: see
commit 5b9ee8d8193a8c7a8ebdd35eedcadc3ae78e7fc1 and
commit 165564d3c33ae3d677d70644a83afcb744bdbf65 for some examples.

A downgrade will fail with a clear message starting with
commit db14eb16f9977453467ec4765f481bb2f71814ba (MDEV-30106).

ibuf_cleanup(): Merge and discard the change buffer on server startup
if it exists. TODO: implement all of this!

btr_cur_open_at_rnd_pos(): Specialize for use in persistent statistics.
The change buffer merge does not need this function anymore.

ibuf_cleanup(): Refuse an upgrade unless the change buffer is empty.
Free any pages consumed by the change buffer, and zero out the
change buffer root page to mark the upgrade completed.

FIXME: Fix the locking of SPATIAL INDEX, and do not disable any tests:
innodb.innodb_defrag_concurrent
innodb_gis.point_big
innodb_gis.rtree_purge

bb-10.11-new-innodb-defaults 2022-11-30 13:20:55 UTC
MDEV-29986 Set innodb_undo_log_truncate=ON and innodb_undo_tablespaces=3

Author: Marko Mäkelä
Author Date: 2022-11-30 13:20:55 UTC

MDEV-29986 Set innodb_undo_log_truncate=ON and innodb_undo_tablespaces=3

Starting with commit baf276e6d4a44fe7cdf3b435c0153da0a42af2b6 (MDEV-19229)
the parameter innodb_undo_tablespaces can be increased from its
previous default value 0 while allowing an upgrade from old databases.

We will change the default settings to innodb_undo_tablespaces=3
and innodb_undo_log_truncate=ON, so that the space occupied by
possible bursts of undo log records will be eventually reclaimed.

bb-10.5-jan-merge-galera 2022-11-30 11:10:52 UTC
Merge 10.4 into 10.5

Author: Jan Lindström
Author Date: 2022-11-30 11:10:52 UTC

Merge 10.4 into 10.5

10.5 2022-11-30 11:10:52 UTC
Merge 10.4 into 10.5

Author: Jan Lindström
Author Date: 2022-11-30 11:10:52 UTC

Merge 10.4 into 10.5

10.11 2022-11-30 10:59:57 UTC
Merge 10.10 into 10.11

Author: Marko Mäkelä
Author Date: 2022-11-30 10:59:57 UTC

Merge 10.10 into 10.11

10.10 2022-11-30 10:34:45 UTC
Merge 10.9 into 10.10

Author: Marko Mäkelä
Author Date: 2022-11-30 10:34:45 UTC

Merge 10.9 into 10.10

10.9 2022-11-30 10:21:10 UTC
Merge 10.8 into 10.9

Author: Marko Mäkelä
Author Date: 2022-11-30 10:21:10 UTC

Merge 10.8 into 10.9

10.8 2022-11-30 10:12:07 UTC
Merge 10.7 into 10.8

Author: Marko Mäkelä
Author Date: 2022-11-30 10:12:07 UTC

Merge 10.7 into 10.8

10.7 2022-11-30 10:09:01 UTC
Merge 10.6 into 10.7

Author: Marko Mäkelä
Author Date: 2022-11-30 10:09:01 UTC

Merge 10.6 into 10.7

10.6 2022-11-30 10:06:52 UTC
MDEV-30069 fixup: Do not truncate files on recovery

Author: Marko Mäkelä
Author Date: 2022-11-30 10:06:52 UTC

MDEV-30069 fixup: Do not truncate files on recovery

recv_sys_t::recover_deferred(): If the file has been determined
to be large enough, skip the call to os_file_set_size(), which
would use the current value of FSP_SIZE, which during a multi-batch
recovery can be smaller than the actual file size.

os_file_io(): Also display the file offset in the warning message about
partial I/O.

bb-10.5-merge-galera 2022-11-30 07:10:02 UTC
Merge 10.4 into 10.5

Author: Jan Lindström
Author Date: 2022-11-30 07:10:02 UTC

Merge 10.4 into 10.5

bb-10.10-danielblack-MDEV-30118-pkgtest-aria-extra-segv 2022-11-29 23:44:38 UTC
MDEV-30118 ha_maria::extra exception

Author: Daniel Black
Author Date: 2022-11-29 23:44:35 UTC

MDEV-30118 ha_maria::extra exception

The exception in the bug report seems to be that ha_maria::file is null.

The causes of this are via a previous call to ha_maria::close or
ha_maria::drop_table.

ha_maria::drop_table is used for temporary tables called at the
sql layer by the function free_tmp_table.

To improve the safety of pointers lets set entry->file= NULL in
free_tmp_table (where file is the hander). Also like the
other callers to free_tmp_table, assign the table pointer argument
to NULL after use.

While this might not necessary solve the original issue, its an
improvement in pointer safety that should prevent accidential/
incidential user after the table is freed.

bb-10.11-oalter 2022-11-29 19:44:05 UTC
MDEV-29069 follow-up: improve DEFAULT rules

Author: Nikita Malyavin
Author Date: 2022-11-29 19:40:07 UTC

MDEV-29069 follow-up: improve DEFAULT rules

previously, fields with DEFAULTs were allowed just when expression is
deterministic. In case of online alter, we should recursively check that
underlying fields of expression also either have explicit values, or
have DEFAULT following this validity rule.

bb-10.11-wlad-MDEV-26714 2022-11-29 16:37:08 UTC
MDEV-26714 - Allow credential manager in installer

Author: Vladislav Vaintroub
Author Date: 2022-11-29 09:26:04 UTC

MDEV-26714 - Allow credential manager in installer

Add a checkbox in the MSI, and parameter in mysql_install_db.exe
The effect is adding credential_manager=1 to the [client] section

bb-10.6-MDEV-30119 2022-11-29 14:19:53 UTC
MDEV-30119 INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION.NAME is NULL for ...

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-29 11:49:30 UTC

MDEV-30119 INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION.NAME is NULL for undo tablespaces

- Information_schema.innodb_tablespaces_encryption should print
undo tablespace name as innodb_undo001, innodb_undo002 and soon.

- Encryption test should include undo tablespaces count when
the tests are waiting for the condition to check whether all
tables are encrypted or decrypted.

bb-10.6-mdev29129 2022-11-29 13:51:11 UTC
MDEV-29129: Performance regression: "select order by limit" always using temp...

Author: Sergey Petrunia
Author Date: 2022-11-29 13:51:11 UTC

MDEV-29129: Performance regression: "select order by limit" always using temporary

(Conservative variant of the fix) (TODO: add testcase)

When adding support for ROWNUM(), the following logic was added:

if (the select list has a function with RAND_TABLE_BIT) then {
  Store select output in temporary table before sorting it;
  // This also causes all stored functions in the
  // select list to be computed before sorting (and applying LIMIT)
}

This is necessary for ROWNUM() but not for other functions.
Limit this handling to ROWNUM().

bb-10.6-MDEV-29880-galera 2022-11-29 11:50:36 UTC
MDEV-29878 Galera test failure on MDEV-26575

Author: Daniele Sciascia
Author Date: 2022-11-11 12:08:20 UTC

MDEV-29878 Galera test failure on MDEV-26575

Test MDEV-26575 fails when it runs after MDEV-25389. This is because
the latter simulates a failure while an applier thread is
created in `start_wsrep_THD()`. The failure was not handled correctly
and would not cleanup the created THD from the global
`server_threads`. A subsequent shutdown would hang and eventually fail
trying to close this THD.

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

bb-10.5-MDEV-29880-galera 2022-11-29 11:40:48 UTC
MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

Author: sjaakola
Author Date: 2022-11-08 14:36:34 UTC

MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

This commit contains only a mtr test for reproducing the issue in MDEV-29512
The actual fix will be pushed in wsrep-lib repository

The hanging in MDEV-29512 happens when binlog purging is attempted, and there is
one local BF aborted transaction waiting for commit monitor.

The test will launch two node cluster and enable binlogging with expire log days,
to force binlog purging to happen.
A local transaction is executed so that will become BF abort victim, and has advanced
to replication stage waiting for commit monitor for final cleanup (to mark position in innodb)
after that, applier is released to complete the BF abort and due to binlog configuration,
starting the binlog purging. This is where the hanging would occur, if code is buggy

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

bb-10.5-MDEV-29693 2022-11-29 11:36:21 UTC
MDEV-29693 Fix Leak Sanitizer error

Author: Oleg Smirnov
Author Date: 2022-11-29 11:36:21 UTC

MDEV-29693 Fix Leak Sanitizer error

bb-10.11-partexp-hf 2022-11-29 11:10:51 UTC
partition_ht() modified.

Author: Alexey Botchkov
Author Date: 2022-11-29 11:10:51 UTC

partition_ht() modified.

bb-10.11-MDEV-30122 2022-11-29 10:58:40 UTC
MDEV-30122 mariabackup.skip_innodb crashes when innodb_undo_tablespaces > 0

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-29 10:53:46 UTC

MDEV-30122 mariabackup.skip_innodb crashes when innodb_undo_tablespaces > 0

- Assign srv_undo_space_id_start when InnoDB opens extra unused
InnoDB undo tablespaces in srv_all_undo_tablespaces_open().
Mariabackup can detect the undo tablespaces using
srv_undo_space_id_start variable

bb-10.12-MDEV-27128 2022-11-29 09:00:22 UTC
MDEV-27128: Implement JSON Schema Validation FUNCTION

Author: Rucha Deodhar
Author Date: 2022-10-28 07:33:13 UTC

MDEV-27128: Implement JSON Schema Validation FUNCTION

Implementation:
Implementation is made according to json schema validation draft 2019
(https://json-schema.org/draft/2019-09/json-schema-validation.html)

JSON schema basically has same structure as that of json object, consisting
of key-value pairs. So it can be parsed in the same manner as any json
object. Json schema of any type has some common validation keywords
(type, enum, const and annotation keyword).
So all these common key words can be put into one class Json_schema and json
schemas with specific type can be derived from this class
(like Json_schema_number, Json_schema_string, Json_schema_array and
Json_schema_object). Objects of appropriate type can be constructed based
on the type of json_schema_type_info. And appropriate functions can be
called to handle keywords and validate them against document.

bb-10.4-MDEV-29880-galera 2022-11-29 06:44:23 UTC
MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

Author: sjaakola
Author Date: 2022-11-08 14:36:34 UTC

MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

This commit contains only a mtr test for reproducing the issue in MDEV-29512
The actual fix will be pushed in wsrep-lib repository

The hanging in MDEV-29512 happens when binlog purging is attempted, and there is
one local BF aborted transaction waiting for commit monitor.

The test will launch two node cluster and enable binlogging with expire log days,
to force binlog purging to happen.
A local transaction is executed so that will become BF abort victim, and has advanced
to replication stage waiting for commit monitor for final cleanup (to mark position in innodb)
after that, applier is released to complete the BF abort and due to binlog configuration,
starting the binlog purging. This is where the hanging would occur, if code is buggy

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

10.4 2022-11-29 06:44:23 UTC
MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

Author: sjaakola
Author Date: 2022-11-08 14:36:34 UTC

MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

This commit contains only a mtr test for reproducing the issue in MDEV-29512
The actual fix will be pushed in wsrep-lib repository

The hanging in MDEV-29512 happens when binlog purging is attempted, and there is
one local BF aborted transaction waiting for commit monitor.

The test will launch two node cluster and enable binlogging with expire log days,
to force binlog purging to happen.
A local transaction is executed so that will become BF abort victim, and has advanced
to replication stage waiting for commit monitor for final cleanup (to mark position in innodb)
after that, applier is released to complete the BF abort and due to binlog configuration,
starting the binlog purging. This is where the hanging would occur, if code is buggy

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

bb-10.12-MDEV-28891 2022-11-29 05:46:53 UTC
MDEV-28891 Spider: remove #ifdef SPIDER_FIELD_FIELDPTR_REQUIRES_THDPTR

Author: Yuchen Pei
Author Date: 2022-11-29 05:46:53 UTC

MDEV-28891 Spider: remove #ifdef SPIDER_FIELD_FIELDPTR_REQUIRES_THDPTR

unifdef -DSPIDER_FIELD_FIELDPTR_REQUIRES_THDPTR -m
storage/spider/*.{cc,h}

and removing the definition manually.

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>
Reviewed-by: Nayuta Yanagisawa <nayuta.yanagisawa@mariadb.com>

bb-10.5-merge-jan 2022-11-29 05:21:08 UTC
Galera test case cleanup

Author: Jan Lindström
Author Date: 2022-11-29 05:21:08 UTC

Galera test case cleanup

 * Delete tests that are not supported and not going to be supported
   any time soon
 * Fix result set on tests that are not run on bb
 * Fix tests that fail because of auto increment offset
 * Make sure that disabled tests have open bug report

10.11-MDEV-5816-1 2022-11-29 04:17:39 UTC
MDEV-5816: Stored programs: validation of stored program statements

Author: Dmitry Shulga
Author Date: 2022-11-29 02:58:48 UTC

MDEV-5816: Stored programs: validation of stored program statements

Introduced the new data member new_query_arena_is_set of the class sp_head.
This data member is used as a protection against double invocation of
the method restore_thd_mem_root that is called for restoration of the
current query arena. Previously, the data member sp_head::m_thd
is used for this goal but after support for recompilation
of failed stored routine statement has been added the data member
sp_head::m_thd can't be used for this goal. The reason is that
on statement recompilation after the method restore_thd_mem_root()
is called the method sp_head::add_instr() invoked to add a new instruction
for just recompiled statement. The method sp_head::add_instr()
de-references m_thd to access the free_list data member.
If m_thd was used as a guard against double invocation it would result in
a crash on dereferncing null pointer.

bb-10.12-MDEV-29269 2022-11-29 02:43:37 UTC
MDEV-29269 Spider: remove #ifdef ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC

Author: Yuchen Pei
Author Date: 2022-11-29 01:08:27 UTC

MDEV-29269 Spider: remove #ifdef ITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC

Produced using the following command

unifdef -UITEM_FUNC_TIMESTAMPDIFF_ARE_PUBLIC -m storage/spider/spd_*

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>
Reviewed-by: nayuta.yanagisawa@mariadb.com

bb-10.3-monty 2022-11-29 01:34:35 UTC
Fixed warning from innodb.create_isl_with_direct if have_symlink is disabled

Author: Monty
Author Date: 2022-11-28 16:37:55 UTC

Fixed warning from innodb.create_isl_with_direct if have_symlink is disabled

bb-MDEV-28958-sigsegv-in-item-clear_extraction_flag-on-select 2022-11-28 22:48:20 UTC
bb-MDEV-28958-sigsegv-in-item-clear_extraction_flag-on-select patch from mont...

Author: Rex
Author Date: 2022-11-28 22:20:37 UTC

bb-MDEV-28958-sigsegv-in-item-clear_extraction_flag-on-select patch from monty, new mysql-test

bb-10.3-midenok 2022-11-28 22:01:26 UTC
MDEV-30112 ASAN errors in Item_ident::print / generate_partition_syntax

Author: midenok
Author Date: 2022-11-28 22:01:26 UTC

MDEV-30112 ASAN errors in Item_ident::print / generate_partition_syntax

Like in MDEV-16110 we must release items allocated on thd->mem_root by
reopening the table.

MDEV-16290 relocated MDEV-16110 fix in 10.5 so it works for MDEV-28576
as well. 10.3 without MDEV-16290 now duplicates this fix.

bb-10.3-MDEV-26831-fallout 2022-11-25 12:37:07 UTC
MDEV-26831 fallout: name resolution cache simple test

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-25 12:37:07 UTC

MDEV-26831 fallout: name resolution cache simple test

bb-10.7-serg 2022-11-24 21:09:14 UTC
fix password_reuse_check plugin to link in embedded

Author: Sergei Golubchik
Author Date: 2022-11-24 21:09:14 UTC

fix password_reuse_check plugin to link in embedded

it uses C client API, so needs RECOMPILE_FOR_EMBEDDED

bb-10.6-monty 2022-11-24 00:28:36 UTC
Fixed a memory leak in aria_read_log

Author: Monty
Author Date: 2022-11-23 15:20:59 UTC

Fixed a memory leak in aria_read_log

bb-10.11-MDEV-7487-MDEV-29390-tests 2022-11-23 17:33:38 UTC
MDEV-29390: Improve coverage for UPDATE and DELETE statements in MTR test suites

Author: Lena Startseva
Author Date: 2022-11-21 09:59:48 UTC

MDEV-29390: Improve coverage for UPDATE and DELETE statements in MTR test suites

For the update_use_source.test tests, data recovery in the table has been changed
from a rollback transaction to a complete delete and re-insert of the data with
optimaze table. Cases are now being checked on three engines.

bb-10.4-MDEV-29817 2022-11-22 14:16:12 UTC
MDEV-29817: Issues with handling options for SSL CRLs (and some others)

Author: Julius Goryavsky
Author Date: 2022-10-19 00:51:01 UTC

MDEV-29817: Issues with handling options for SSL CRLs (and some others)

This patch adds the correct setting of the "--tls-version" and
"--ssl-verify-server-cert" options in the client-side utilities
such as mysqltest, mysqlcheck and mysqlslap, as well as the correct
setting of the "--ssl-crl" option when executing queries on the
slave side, and also the correct option codes in the "sslopts-logopts.h"
file (in the latter case, incorrect values are not a problem right
now, but may cause subtle test failures in the future, if the option
handling code changes).

bb-10.3-MDEV-29817 2022-11-22 13:07:39 UTC
MDEV-29817: Issues with handling options for SSL CRLs (and some others)

Author: Julius Goryavsky
Author Date: 2022-10-19 00:51:01 UTC

MDEV-29817: Issues with handling options for SSL CRLs (and some others)

This patch adds the correct setting of the "--ssl-verify-server-cert"
option in the client-side utilities such as mysqlcheck and mysqlslap,
as well as the correct setting of the "--ssl-crl" option when executing
queries on the slave side, and also add the correct option codes in
the "sslopts-logopts.h" file (in the latter case, incorrect values
are not a problem right now, but may cause subtle test failures in
the future, if the option handling code changes).

bb-10.11-mdev-22168-hf 2022-11-22 11:57:42 UTC
MDEV-22168 Supporting multiple engines with table partitioning.

Author: Alexey Botchkov
Author Date: 2022-11-20 19:36:32 UTC

MDEV-22168 Supporting multiple engines with table partitioning.

bb-10.9-sysprg-hashicorp-stats 2022-11-22 11:11:49 UTC
hashicorp vault plugin: added statistics variables

Author: Julius Goryavsky
Author Date: 2022-11-22 11:11:49 UTC

hashicorp vault plugin: added statistics variables

bb-10.4-bar-MDEV-27670 2022-11-22 10:03:23 UTC
MDEV-27670 Assertion `(cs->state & 0x20000) == 0' failed in my_strnncollsp_nc...

Author: Alexander Barkov
Author Date: 2022-11-22 10:03:23 UTC

MDEV-27670 Assertion `(cs->state & 0x20000) == 0' failed in my_strnncollsp_nchars_generic_8bit

Also fixes:

MDEV-27768 MDEV-25440: Assertion `(cs->state & 0x20000) == 0' failed in my_strnncollsp_nchars_generic_8bit

The "strnncollsp_nchars" virtual function pointer for tis620_thai_nopad_ci
was incorrectly initialized to a generic function
my_strnncollsp_nchars_generic_8bit(), which crashed on assert.

Implementing a tis620 specific function version.

bb-10.6-MDEV-29835 2022-11-21 17:08:02 UTC
squash! 87976174001c651bcf965a6d48979d8401c620ce

Author: Marko Mäkelä
Author Date: 2022-11-21 17:08:02 UTC

squash! 87976174001c651bcf965a6d48979d8401c620ce

btr_cur_t::search_leaf(): Only instantiate for B-tree search modes.

bb-10.6-MDEV-29181 2022-11-21 15:49:08 UTC
MDEV-30021 FK actions are ignored after tc_purge and COMMIT

Author: Nikita Malyavin
Author Date: 2022-11-21 15:49:08 UTC

MDEV-30021 FK actions are ignored after tc_purge and COMMIT

When a table is evicted, do not delete all relations from
referenced tables' set, but just NULL itself in a foreign key
structure.

bb-11.0-MDEV-30032 2022-11-21 15:22:56 UTC
MDEV-30059: Optimizer Trace: plan_prefix should be a comma-separated-list

Author: Sergey Petrunia
Author Date: 2022-11-21 14:28:43 UTC

MDEV-30059: Optimizer Trace: plan_prefix should be a comma-separated-list

bb-11.0-MDEV-30059 2022-11-21 14:28:43 UTC
MDEV-30059: Optimizer Trace: plan_prefix should be a comma-separated-list

Author: Sergey Petrunia
Author Date: 2022-11-21 14:28:43 UTC

MDEV-30059: Optimizer Trace: plan_prefix should be a comma-separated-list

bb-10.6-MDEV-28462 2022-11-21 06:56:26 UTC
MDEV-28462 Race condition between instant alter and AHI access

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-17 06:29:06 UTC

MDEV-28462 Race condition between instant alter and AHI access

- InnoDB AHI tries to access the concurrent instant alter column,
leads to asan failure. Instant alter column should acquire the
clustered index search latch in exclusive mode before changing
the table cache definition.

bb-10.7-thiru 2022-11-18 17:20:38 UTC
- Fixes the innodb.insert_into_empty test case failure

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-18 17:20:38 UTC

- Fixes the innodb.insert_into_empty test case failure

bb-10.4-serg 2022-11-17 19:45:09 UTC
MDEV-17869 AddressSanitizer: use-after-poison in Item_change_list::rollback_i...

Author: Sergei Golubchik
Author Date: 2022-11-17 18:23:08 UTC

MDEV-17869 AddressSanitizer: use-after-poison in Item_change_list::rollback_item_tree_changes

it's incorrect to use change_item_tree() to replace arguments
of top-level AND/OR, because they (arguments) are stored in a List,
so a pointer to an argument is in the list_node, and individual
list_node's of top-level AND/OR can be deleted in Item_cond::build_equal_items().
In that case rollback_item_tree_changes() will modify the deleted object.

Luckily, it's not needed to use change_item_tree() for top-level
AND/OR, because the whole top-level item is copied and preserved
in prep_where and prep_on, and restored from there.

So, just don't.

Additionally to the test case in the commit it fixes
* ASAN failure of main.opt_tvc --ps
* ASAN failure of main.having_cond_pushdown --ps

bb-10.3-bar-MDEV-29473 2022-11-17 13:51:01 UTC
MDEV-29473 UBSAN: Signed integer overflow: X * Y cannot be represented in typ...

Author: Alexander Barkov
Author Date: 2022-11-17 13:51:01 UTC

MDEV-29473 UBSAN: Signed integer overflow: X * Y cannot be represented in type 'int' in strings/dtoa.c

Fixing a few problems relealed by UBSAN in type_float.test

- multiplication overflow in dtoa.c

- uninitialized Field::geom_type (and Field::srid as well)

- Wrong call-back function types used in combination with SHOW_FUNC.
  Changes in the mysql_show_var_func data type definition were not
  properly addressed all around the code by the following commits:
    b4ff64568c88ab3ce559e7bd39853d9cbf86704a
    18feb62feeb833494d003615861b9c78ec008a90
    0ee879ff8ac1b80cd9a963015344f5698a81f309

  Adding a helper SHOW_FUNC_ENTRY() function and replacing
  all mysql_show_var_func declarations using SHOW_FUNC
  to SHOW_FUNC_ENTRY, to catch mysql_show_var_func in the future
  at compilation time.

bb-10.3-MDEV-28462 2022-11-17 11:54:32 UTC
MDEV-28462 Race condition between instant alter and AHI access

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-17 11:54:13 UTC

MDEV-28462 Race condition between instant alter and AHI access

- InnoDB AHI tries to access the concurrent instant alter column,
leads to asan failure. Instant alter column should acquire all
search latches in shared mode before changing the table cache
definition.

bb-10.11-selectivity-rebase-nov 2022-11-16 13:48:57 UTC
Fixed bug in Aria with aria_log files that are exactly 8K

Author: Monty
Author Date: 2022-11-14 15:08:09 UTC

Fixed bug in Aria with aria_log files that are exactly 8K

In the case one has an old Aria log file that ands with a Aria checkpoint
and the server restarts after next recovery, just after created a
new Aria log file (of 8K), the Aria recovery code would abort.
If one would try to delete all Aria log files after this (but not the
aria_control_file), the server would crash during recovery.

The problem was that translog_get_last_page_addr() would regard a log file
of exactly 8K as illegal and the rest of the code could not handle this
case.

Another issue was that if there was a crash directly after the log file
head was written to the next page, the code in translog_get_next_chunk()
would crash.

This patch fixes most of the issues, but not all. For Sanja to look at!

Things fixed:
- Added code to ignore 8K log files.
- Removed ASSERT in translog_get_next_chunk() that checks if page only
  contains the log page header.

bb-10.10-release 2022-11-16 12:26:37 UTC
Merge branch '10.10' into bb-10.10-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-16 12:26:37 UTC

Merge branch '10.10' into bb-10.10-release

bb-10.11-selectivity 2022-11-15 16:55:39 UTC
fixed test result

Author: Monty
Author Date: 2022-11-15 16:55:39 UTC

fixed test result

bb-10.3-MDEV-29144 2022-11-15 09:36:22 UTC
MDEV-29144 ER_TABLE_SCHEMA_MISMATCH or crash on DISCARD/IMPORT

Author: Marko Mäkelä
Author Date: 2022-11-15 09:36:22 UTC

MDEV-29144 ER_TABLE_SCHEMA_MISMATCH or crash on DISCARD/IMPORT

mysql_discard_or_import_tablespace(): On successful
ALTER TABLE...DISCARD TABLESPACE, evict the table handle from the
table definition cache, so that ha_innobase::close() will be invoked,
like InnoDB expects to be the case. This will avoid an assertion failure
ut_a(table->get_ref_count() == 0) during IMPORT TABLESPACE.

ha_innobase::open(): Do not issue any ER_TABLESPACE_DISCARDED warning.
Member functions for DML will do that.

ha_innobase::truncate(), ha_innobase::check_if_supported_inplace_alter():
Issue ER_TABLESPACE_DISCARDED warnings, to compensate for the removal of
the warning in ha_innobase::open().

row_quiesce_write_indexes(): Only write information about committed
indexes. The ALTER TABLE t NOWAIT ADD INDEX(c) in the nondeterministic
test case will most of the time fail due to a metadata lock (MDL) timeout
and leave behind an uncommitted index.

bb-10.4-MDEV-29684-galera 2022-11-15 08:27:40 UTC
MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

Author: sjaakola
Author Date: 2022-11-08 14:36:34 UTC

MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex

This commit contains only a mtr test for reproducing the issue in MDEV-29512
The actual fix will be pushed in wsrep-lib repository

The hanging in MDEV-29512 happens when binlog purging is attempted, and there is
one local BF aborted transaction waiting for commit monitor.

The test will launch two node cluster and enable binlogging with expire log days,
to force binlog purging to happen.
A local transaction is executed so that will become BF abort victim, and has advanced
to replication stage waiting for commit monitor for final cleanup (to mark position in innodb)
after that, applier is released to complete the BF abort and due to binlog configuration,
starting the binlog purging. This is where the hanging would occur, if code is buggy

bb-10.6-MDEV-25948-MDEV-25611 2022-11-15 06:59:30 UTC
Merge 10.6

Author: Marko Mäkelä
Author Date: 2022-11-15 06:59:30 UTC

Merge 10.6

Interesting test failures:

./mtr --parallel=auto --mysqld=--debug-dbug=d,ib_log_checkpoint_avoid \
--max-test-fail=0 --big-test --force \
binlog{,_encryption}.binlog_incident rpl.rpl_skip_incident \
binlog.binlog_killed_simulate rpl.rpl_loaddata_fatal

bb-10.10-midenok-MDEV-20865-wip 2022-11-14 18:33:51 UTC
do_rename() signature cleanup

Author: midenok
Author Date: 2022-11-14 18:22:00 UTC

do_rename() signature cleanup

FIXME:

innodb.foreign_key_not_windows fails?
See kvm-bintar-freebsd130-amd64

bb-10.11-release 2022-11-14 18:10:21 UTC
Merge branch '10.10' into 10.11

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-14 18:10:21 UTC

Merge branch '10.10' into 10.11

bb-10.5-bar-MDEV-25765 2022-11-14 12:43:33 UTC
MDEV-25765 Mariabackup reduced verbosity option for log output

Author: Alexander Barkov
Author Date: 2022-11-14 12:43:33 UTC

MDEV-25765 Mariabackup reduced verbosity option for log output

bb-10.5-bar-MDEV-29244 2022-11-14 12:17:03 UTC
MDEV-29244 mariabackup --help output still referst to innobackupex

Author: Alexander Barkov
Author Date: 2022-11-14 12:17:03 UTC

MDEV-29244 mariabackup --help output still referst to innobackupex

Changing the tool name in the "mariadb-backup --help" output
from "innobackupex" to "mariadb-backup".

bb-10.7-midenok 2022-11-11 17:54:20 UTC
MDEV-29841 More descriptive text for ER_PARTITION_WRONG_TYPE

Author: midenok
Author Date: 2022-11-11 11:37:40 UTC

MDEV-29841 More descriptive text for ER_PARTITION_WRONG_TYPE

For commands

  (1) alter table t1 add partition (partition p2);
  (2) alter table t1 add partition (partition px history);

It printed the same error message:

   Wrong partitioning type, expected type: `SYSTEM_TIME`

For (1) it is not clear from the syntax that we are trying to add
HASH partition. For (2) it is not clear that the table partitioning is
different than SYSTEM_TIME. Now it prints what type we are trying to
add to what type of partitioning.

Fixed warning unused function rename_field_in_list() for compilation
without partitioning.

bb-10.10-MDEV-29947 2022-11-11 16:47:23 UTC
MDEV-29947 Spider doesn't return all rows when doing a join of two tables wit...

Author: Nayuta Yanagisawa
Author Date: 2022-11-11 16:47:23 UTC

MDEV-29947 Spider doesn't return all rows when doing a join of two tables with no usable keys

The present commit only has a MTR test case because the bug has been
fixed by reverting the commits that caused it.

bb-10.11-mdev-25080-fix1 2022-11-10 21:21:45 UTC
update columnstore to 22.08.4-1

Author: Sergei Golubchik
Author Date: 2022-11-10 21:21:45 UTC

update columnstore to 22.08.4-1

bb-10.3-bar-MDEV-23335 2022-11-10 10:57:46 UTC
MDEV-23335 MariaBackup Incremental Does Not Reflect Dropped/Created Databases

Author: Alexander Barkov
Author Date: 2022-11-09 12:41:19 UTC

MDEV-23335 MariaBackup Incremental Does Not Reflect Dropped/Created Databases

bb-10.3-MDEV-29977 2022-11-10 06:39:46 UTC
MDEV-29977 Memory leak in row_log_table_apply_update

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-10 06:39:16 UTC

MDEV-29977 Memory leak in row_log_table_apply_update

- InnoDB fails to free the persistent cursor for the clustered index
when InnoDB replays the update operation on the table that is
being rebuild.

bb-10.6-MDEV-29849 2022-11-08 11:49:55 UTC
MDEV-29504/MDEV-29849 TRUNCATE breaks FOREIGN KEY locking

Author: Marko Mäkelä
Author Date: 2022-11-08 11:49:55 UTC

MDEV-29504/MDEV-29849 TRUNCATE breaks FOREIGN KEY locking

ha_innobase::referenced_by_foreign_key(): Protect the check with
dict_sys.freeze(), to prevent races with TRUNCATE TABLE.
The test innodb.instant_alter_crash has been adjusted for this
additional locking.

dict_table_is_referenced_by_foreign_key(): Removed (merged to
the only caller).

create_table_info_t::create_table(): Ignore missing indexes for
FOREIGN KEY constraints if foreign_key_checks=0.

create_table_info_t::create_table_update_dict(): Rewritten as
a static function. Do not return any error.

ha_innobase::create(): When trx!=nullptr and we are operating
on a persistent table, do not rollback, commit, or release the
data dictionary latch.

ha_innobase::truncate(): Protect the entire critical section
with an exclusive dict_sys.latch, so that
ha_innobase::referenced_by_foreign_key() on referenced tables
will return a consistent result. In case of a failure,
invoke dict_load_foreigns() to restore also any FOREIGN KEY
constraints.

ha_innobase::free_foreign_key_create_info(): Define inline.

lock_release(): Disregard innodb_evict_tables_on_commit_debug=ON
when dict_sys.locked() holds. It would hold when fts_load_stopword()
is invoked by create_table_info_t::create_table_update_dict().

dict_sys_t::locked(): Return whether the current thread is holding
the exclusive dict_sys.latch.

dict_sys_t::frozen_not_locked(): Return whether any thread is
holding a shared dict_sys.latch.

bb-10.9-release 2022-11-07 18:16:32 UTC
Merge branch '10.9' into bb-10.9-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 18:16:32 UTC

Merge branch '10.9' into bb-10.9-release

bb-10.8-release 2022-11-07 18:14:04 UTC
Merge branch '10.8' into bb-10.8-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 18:14:04 UTC

Merge branch '10.8' into bb-10.8-release

bb-10.7-release 2022-11-07 17:53:30 UTC
Merge branch '10.7' into bb-10.7-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 17:53:30 UTC

Merge branch '10.7' into bb-10.7-release

bb-10.6-release 2022-11-07 15:33:00 UTC
Merge branch '10.6' into bb-10.6-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 15:33:00 UTC

Merge branch '10.6' into bb-10.6-release

bb-10.5-release 2022-11-07 15:14:35 UTC
Merge branch '10.5' into bb-10.5-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 15:14:35 UTC

Merge branch '10.5' into bb-10.5-release

bb-10.4-release 2022-11-07 14:49:14 UTC
Merge branch '10.4' into bb-10.4-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 14:49:14 UTC

Merge branch '10.4' into bb-10.4-release

bb-10.3-release 2022-11-07 14:32:35 UTC
Merge branch '10.3' into bb-10.3-release

Author: Oleksandr "Sanja" Byelkin
Author Date: 2022-11-07 14:32:35 UTC

Merge branch '10.3' into bb-10.3-release

bb-10.6-MDEV-29518 2022-11-07 11:44:07 UTC
MDEV-28797 Assertion `page_rec_is_user_rec(rec)' failed in PageBulk::getSpli...

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-07 11:44:07 UTC

MDEV-28797 Assertion `page_rec_is_user_rec(rec)' failed in PageBulk::getSplitRec

- During alter operation of compressed table, page split operation
chooses the first record of the page as split record and it leads
to empty left page. This issue caused by the commit 77b3959b5c1528f33ada7aa4445cccf5b5e197b0 (MDEV-28457).

page_rec_is_second(), page_rec_is_second_last(): Removed the functions
since it is a deadcode.

bb-10.6-MDEV-25611 2022-11-07 07:21:29 UTC
MDEV-25611: Dummy commit to test again

Author: Angelique Sklavounos
Author Date: 2022-11-07 07:21:29 UTC

MDEV-25611: Dummy commit to test again

bb-10.3-danielblack-alloca_h_service-pkgtest 2022-11-07 03:35:47 UTC
service_encryption.h HAVE_ALLOC_H was global

Author: Daniel Black
Author Date: 2022-11-07 03:13:46 UTC

service_encryption.h HAVE_ALLOC_H was global

Rather than global include for header files, we use
cmake to make service_encryption.h a generated file
and populate it with the discovery of ALLOCA_H or not.

Fixes: #2289
Closes: #2321

bb-10.11-serg 2022-11-06 15:53:21 UTC
Fix recalculation of vcols in binlog_row_image=minimal

Author: Sergei Golubchik
Author Date: 2022-11-06 10:26:28 UTC

Fix recalculation of vcols in binlog_row_image=minimal

unpack_row() must calculate all stored and indexed vcols
(in fill_extra_persistent_columns()).

Also Update and Delete row events must mark in read_set
all columns needed for calculating all stored and indexed vcols.

If it's done properly in do_apply_event(), it no longer needs
to be repeated per row.

bb-10.9-georg 2022-11-06 14:03:04 UTC
Updated libmariadb

Author: Georg Richter
Author Date: 2022-11-06 14:03:04 UTC

Updated libmariadb

bb-10.3-MDEV-27121 2022-11-04 06:50:23 UTC
MDEV-27121 mariabackup incompatible with disabled dedicated undo log tablesp...

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2022-11-04 06:49:12 UTC

MDEV-27121 mariabackup incompatible with disabled dedicated undo log tablespaces

- mariabackup fails to assign srv_undo_space_id_start when the
dedicated undo tablespaces are disabled

bb-10.3-MDEV-29639 2022-11-03 20:57:08 UTC
MDEV-29639: Seconds_Behind_Master is incorrect for Delayed, Parallel Replicas

Author: Brandon Nesterenko
Author Date: 2022-11-03 20:56:57 UTC

MDEV-29639: Seconds_Behind_Master is incorrect for Delayed, Parallel Replicas

Problem:
========
On a parallel, delayed replica, Seconds_Behind_Master will not be
calculated until after MASTER_DELAY seconds have passed and the
event has finished executing, resulting in potentially very large
values of Seconds_Behind_Master for the entire duration of
MASTER_DELAY. This is especially prevalent for workloads with
infrequent transactions.

Solution:
========
Treat replicas using both parallelization and master_delay as an
edge case to force the serial method of updating
Seconds_Behind_Master. Effectively, this means the value will seem
more recent than the true state of the replica for both long running
transactions and workers with long queues. This will be fixed after
MDEV-17516.

Reviewed By:
============
<TODO>

bb-10.11-ddl-nikita 2022-11-02 14:16:08 UTC
MDEV-29068 Cascade foreign key updates do not apply in online alter

Author: Nikita Malyavin
Author Date: 2022-10-21 12:08:26 UTC

MDEV-29068 Cascade foreign key updates do not apply in online alter

bb-10.10-MDEV-28839 2022-10-31 16:47:22 UTC
MDEV-28839: remove current_pos where not intentionally being tested

Author: Angelique Sklavounos
Author Date: 2022-10-31 16:47:22 UTC

MDEV-28839: remove current_pos where not intentionally being tested

bb-10.3-midenok-MDEV-25004 2022-10-31 08:57:10 UTC
Tests update

Author: midenok
Author Date: 2022-10-27 17:22:51 UTC

Tests update

- Upgrade test without tar, binaries reduced to 64K;

- vers combination for basic.test, stopword.test and versioning.test
  works without debug. For other tests vers combination is debug-only.

bb-10.11-midenok 2022-10-31 08:54:29 UTC
MDEV-29831 Galera crashes when running CoR for a locked table after

Author: midenok
Author Date: 2022-10-30 23:03:34 UTC

MDEV-29831 Galera crashes when running CoR for a locked table after
    setting the minimum memory for a user session.

Failure happens when finalize_atomic_replace() was already finished
and we removed the table from locked tables list.
finalize_locked_tables() doesn't know about that, it doesn't add back
last deleted lock because operation_failed == true.
reopen_tables() doesn't reopen table and as a result we have NULL in
pos_in_locked_tables->table.

The fix adds the knowledge that the locked_tables_count changed since
the start of the command. And if that happened we
add_back_last_deleted_lock(). That makes MDEV-29544 fix with
locked_tables_decremented deprecated.

Alternative fix would add atomic_replace_finished to Atomic_info and
updated it on successful finalize_atomic_replace(). Then the condition
would look like this:

  if (atomic_replace_finished || !operation_failed)
  {
    /*
      Add back the deleted table and re-created table as a locked table
      This should always work as we have a meta lock on the table.
    */
    thd->locked_tables_list.add_back_last_deleted_lock(pos_in_locked_tables);
  }

bb-10.11-midenok-MDEV-25292-fixes 2022-10-31 08:54:29 UTC
MDEV-29831 Galera crashes when running CoR for a locked table after

Author: midenok
Author Date: 2022-10-30 23:03:34 UTC

MDEV-29831 Galera crashes when running CoR for a locked table after
    setting the minimum memory for a user session.

Failure happens when finalize_atomic_replace() was already finished
and we removed the table from locked tables list.
finalize_locked_tables() doesn't know about that, it doesn't add back
last deleted lock because operation_failed == true.
reopen_tables() doesn't reopen table and as a result we have NULL in
pos_in_locked_tables->table.

The fix adds the knowledge that the locked_tables_count changed since
the start of the command. And if that happened we
add_back_last_deleted_lock(). That makes MDEV-29544 fix with
locked_tables_decremented deprecated.

Alternative fix would add atomic_replace_finished to Atomic_info and
updated it on successful finalize_atomic_replace(). Then the condition
would look like this:

  if (atomic_replace_finished || !operation_failed)
  {
    /*
      Add back the deleted table and re-created table as a locked table
      This should always work as we have a meta lock on the table.
    */
    thd->locked_tables_list.add_back_last_deleted_lock(pos_in_locked_tables);
  }

bb-10.5-MDEV-16232 2022-10-31 07:38:59 UTC
MDEV-16232 preparation: Disable row_prebuilt_t::fetch_cache

Author: Marko Mäkelä
Author Date: 2022-10-31 07:38:59 UTC

MDEV-16232 preparation: Disable row_prebuilt_t::fetch_cache

The minimal change to disable the use of the fetch_cache is the 2 hunks
#if 1/#else/#endif in row_search_mvcc(). The rest is disabling dead code
and data.

bb-10.4-merge-jan 2022-10-31 06:05:39 UTC
Galera test case cleanup

Author: Jan Lindström
Author Date: 2022-10-26 05:08:06 UTC

Galera test case cleanup

* Delete tests that are not supported and not going to be supported
  any time soon
* Fix result set on tests that are not run on bb
* Fix tests that fail because of auto increment offset
* Make sure that disabled tests have open bug report

bb-10.5-andrei 2022-10-28 16:46:58 UTC
MDEV-29898 rpl.rpl_parallel_optimistic_xa fail in BB with Slave SQL: XAER_DUP...

Author: Andrei
Author Date: 2022-10-28 16:46:58 UTC

MDEV-29898 rpl.rpl_parallel_optimistic_xa fail in BB with Slave SQL: XAER_DUPID: The XID already exist

The test failure exposed an incorrect logging of XA COMMIT/ROLLBACK's
GTID events. They were marked with `trans` flag which allowed their
optimistic out of order execution on the slave.

Fixed with removing the flag at GTID event instantiation in
the XA-completion case.

bb-10.6-serg 2022-10-28 15:09:12 UTC
followup: fix ASAN failure of main.having_cond_pushdown --ps

Author: Sergei Golubchik
Author Date: 2022-10-28 15:06:00 UTC

followup: fix ASAN failure of main.having_cond_pushdown --ps

also call top_level_transform() recursively for

(a OR b) AND (c OR d)

bb-10.4-bar-MDEV-27653 2022-10-28 11:37:44 UTC
MDEV-27653 long uniques don't work with unicode collations

Author: Alexander Barkov
Author Date: 2022-10-28 09:43:51 UTC

MDEV-27653 long uniques don't work with unicode collations

bb-10.3-MDEV-29814-galera 2022-10-28 09:21:48 UTC
MDEV-29814: galera_var_notify_ssl_ipv6 causes testing system to hang

Author: Julius Goryavsky
Author Date: 2022-10-28 09:16:25 UTC

MDEV-29814: galera_var_notify_ssl_ipv6 causes testing system to hang

This commit fixes the test system hanging due to
the galera_var_notify_ssl_ipv6 test and also brings
the wsrep_notify[_ssl].sh files in line with each other
between the user template and the mtr suite.

Quotes are also added here to avoid problems if the
user specifies the value of one of the variables at the
beginning of the file containing shell-specific characters,
for example, if the password or username specified in the
PSWD and USER variables will contain the "$" character.

Also fixed an issue with automatic --ssl-verify-server-cert
option substitution when the corresponding value is set
by the user to "1" or "on".

Also fixed some tests here to avoid joining one of the nodes
to another cluster when the nodes are restarted from the mtr
side, which can lead to random failures when testing with
buildbot.

bb-10.4-MDEV-29814-galera 2022-10-28 09:16:25 UTC
MDEV-29814: galera_var_notify_ssl_ipv6 causes testing system to hang

Author: Julius Goryavsky
Author Date: 2022-10-28 09:16:25 UTC

MDEV-29814: galera_var_notify_ssl_ipv6 causes testing system to hang

This commit fixes the test system hanging due to
the galera_var_notify_ssl_ipv6 test and also brings
the wsrep_notify[_ssl].sh files in line with each other
between the user template and the mtr suite.

Quotes are also added here to avoid problems if the
user specifies the value of one of the variables at the
beginning of the file containing shell-specific characters,
for example, if the password or username specified in the
PSWD and USER variables will contain the "$" character.

Also fixed an issue with automatic --ssl-verify-server-cert
option substitution when the corresponding value is set
by the user to "1" or "on".

Also fixed some tests here to avoid joining one of the nodes
to another cluster when the nodes are restarted from the mtr
side, which can lead to random failures when testing with
buildbot.

bb-10.6-MDEV-28709-post-push-fix 2022-10-27 20:35:34 UTC
MDEV-28709 unexpected X lock on Supremum in READ COMMITTED

Author: Vlad Lesin
Author Date: 2022-10-27 20:35:34 UTC

MDEV-28709 unexpected X lock on Supremum in READ COMMITTED

Post-push fix. The flag of transaction which indicates that it's necessary
to forbid gap lock inheritance after XA PREPARE could be inverted if
lock_release_on_prepare_try() is invoked several times. The fix is to
toggle it on lock_release_on_prepare() exit.

1100 of 1422 results

Other repositories

Name Last Modified
lp:maria 2 hours ago
lp:~maria-captains/maria/+git/connector-c 2018-01-08
12 of 2 results
You can't create new repositories for MariaDB.