Author: Sergei Golubchik
Author Date: 2018-06-21 21:49:37 UTC

don't crash on innodb_undo_tablespaces=1

Author: Sergei Golubchik
Author Date: 2018-06-21 17:27:05 UTC

followup

Author: Sergei Golubchik
Author Date: 2018-06-21 16:31:20 UTC

disable galera.galera_sst_xtrabackup-v2 for now

Author: Alexey Botchkov
Author Date: 2018-06-21 12:27:47 UTC

PING

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-06-21 11:50:17 UTC

MDEV-16365 Setting a column NOT NULL fails to return error for
  NULL values when there is no DEFAULT

Copy and inplace algorithm works similarly for
NULL to NOT NULL conversion for the following cases:
(1) strict sql mode - Should give error.
(2) non-strict sql mode - Should give warnings alone
(3) alter ignore table command. - Should give warnings alone.

Author: Sachin Setiya
Author Date: 2018-05-14 06:45:38 UTC

MDEV-14472 Assertion `is_current_stmt_binlog_format_row()' failed...
in THD::binlog_write_table_map

Problem:- So the issue is when the test case (mdev_14472) is run with debug
  build , Assert DBUG_ASSERT(is_current_stmt_binlog_format_row()); is fired
  in binlog_write_table_map.

Analysis:- When we lock table t1, and if t1 has some trigger which updates
  another table then all other tables are also locked. So in the case of lock
  t1(in mdev_14472 test case) we will lock t1, t2, t3 and t4. In next insert
  command (t2 insert), we call handler->check_table_row_based from
  write_locked_table_maps which updates the table handler
  check_table_binlog_row_based_done to 1 and check_table_binlog_row_based_result
  to 1 , it is set to one because this particular insert stmt is unsafe(because
  of trigger on t4). The next insert stmt(insert t3) is safe so we will write
  that in stmt format , but since we havent cleared the previous
  check_table_binlog_row_based_result so it is logged in row format while
  thd->is_current_stmt_binlog_format_row() is still 0, and this fires the
  assert. So the question is why check_table_binlog_row_based_result is not
  reseted because mark_used_tables_as_free_for_reuse skips locked tables

Solution:- We make mark_used_tables_as_free_for_reuse to reset
  check_table_binlog_row_based_result even when table is locked

Author: Alexey Botchkov
Author Date: 2018-06-21 09:47:11 UTC

MDEV-14024 PCRE2.

ping.

Author: Alexander Barkov
Author Date: 2018-06-21 08:54:28 UTC

MDEV-16471 mysqldump throws "Variable 'sql_mode' can't be set to the value of 'NULL' (1231)"

Author: Marko Mäkelä
Author Date: 2018-02-23 20:26:26 UTC

MDEV-15058: Allocate buf_pool statically

buf_pool_t::create(): Replaces buf_pool_init().

buf_pool_t::close(): Replaces buf_pool_free().

FIXME: Do not add buf_pool_t::is_initialised()

Author: Andrei Elkin
Author Date: 2018-03-18 19:01:41 UTC

MDEV-14014 Multi-Slave Replication Fail: bogus data in log event

MDEV-7257 made a dump thread to read from binlog concurrently with
writers as long as the read bytes are below a water-mark
(MYSQL_BIN_LOG::binlog_end_pos). However it appeared to be possible a
dump thread reader reach out for bytes past the water mark through a
feature of IO_CACHE that fills in the internal buffer and while doing
so it could read what the reader is not supposed to see (the bytes
above MYSQL_BIN_LOG::binlog_end_pos).

The issue is fixed with constraining the IO_CACHE buffer fill to respect
the watermark.

An added unit test proves reading from file is bound to an external
parameter
passed to {IO_CACHE::end_of_file} cache member.

Author: Sergei Golubchik
Author Date: 2018-06-21 06:34:35 UTC

Merge branch '10.0' into 10.1

Author: Sergei Golubchik
Author Date: 2018-06-20 22:44:10 UTC

Merge branch '5.5' into 10.0

Author: Sergei Golubchik
Author Date: 2018-06-20 22:44:10 UTC

Merge branch '5.5' into 10.0

Author: Sergei Golubchik
Author Date: 2018-06-20 21:30:49 UTC

Fix unit suite on Windows and in out-of-source builds

Author: Sergei Golubchik
Author Date: 2018-06-20 21:30:49 UTC

Fix unit suite on Windows and in out-of-source builds

Author: Sergei Golubchik
Author Date: 2018-06-13 12:24:42 UTC

MDEV-16485 Insert rows unable to execute correctly on slave's System-Versioned Tables

RBR not versioned -> versioned

do it for all write_row events, not only for WRITE_ROWS_EVENT_V1

Author: Oleksandr Byelkin
Author Date: 2018-03-12 13:46:00 UTC

Optimize charset tracking a bit.

Author: Marko Mäkelä
Author Date: 2018-06-19 09:04:06 UTC

Disable MyRocks packaging

Author: Monty
Author Date: 2018-06-18 19:44:58 UTC

Fixed failing test acl_load_mutex-5170

Added flush tables to ensure that MyISAM tables are
properly flushed before reboot

Author: Galina Shalygina
Author Date: 2018-06-17 17:48:00 UTC

MDEV-7486: Condition pushdown from HAVING into WHERE

Condition can be pushed from the HAVING clause into the WHERE clause
if it depends only on the fields that are used in the GROUP BY 'grouping_fields'
or depends on the fields that are equal to 'grouping_fields'.
Aggregate functions can't be pushed down.

How the pushdown is made on the example:

SELECT t1.a,MAX(t1.b)
FROM t1
GROUP BY t1.a
HAVING (t1.a>2) AND (MAX(c)>12);

=>

SELECT t1.a,MAX(t1.b)
FROM t1
WHERE (t1.a>2)
GROUP BY t1.a
HAVING (MAX(c)>12);

The implementation scheme:

1. Search for the condition cond in the HAVING clause of the select that
   depends only on the fields that are used in the GROUP BY of the select
2. Save it as a condition that can be pushed into the WHERE clause
   of the select
3. Remove cond from the HAVING clause

The optimization is made in the
st_select_lex::pushdown_from_having_into_where() and is controlled by the
variable 'condition_pushdown_from_having_into_where'.

New test file having_cond_pushdown.test is created.

optimize_cond() for the HAVING clause was moved so now it is called before
optimize_cond() call for the WHERE clause in JOIN::optimize_inner().
check_simple_equality() was also changed in the way that after the work of
optimize_cond() for the HAVING clause all equalities there are transformed into
the multiple equalities.

Author: varun
Author Date: 2018-06-18 09:15:38 UTC

MDEV-15247: Crash when SET NAMES 'utf8' is set

In this case we are accessing incorrect memory when we have mergeable semi-joins.
In the case when we have mergeable semi joins parent select will have a table count
of all the tables in that select plus all the tables involved in the IN-subquery.
But this table count does not include the "sjm table" (only includes the inner and outer tables)
denotes as <subquery#> in explain.

Author: Alice Sherepa
Author Date: 2018-06-18 09:00:58 UTC

CTE tests (from MySQL 8.0)

Author: Monty
Author Date: 2018-06-17 11:19:51 UTC

MDEV-15114 ASAN heap-use-after-free in mem_heap_dup or dfield_data_is_binary_equal

The bug was that innobase_get_computed_value() trashed record[0] and data
in Field_blob::value

Fixed by using a record on the heap for innobase_get_computed_value()

Author: Sergei Golubchik
Author Date: 2018-06-15 23:20:44 UTC

fix dependencies on bionic

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-06-15 14:01:23 UTC

MDEV-16087 Inconsistent SELECT results when query cache is enabled

 The following conditions will decide the query cache retrieval or
 storing inside innodb:
    (1) There should not be any locks on the table.
    (2) Some other trx shouldn't invalidated the cache before the
    transaction started.
    (3) Read view shouldn't exist. If exists then the view
    low_limit_id should be greater than or equal to the transaction that
    invalidates the cache for the particular table.

 For read-only transaction: should satisfy the above (1) and (3)
 For read-write transaction: should satisfy the above (1), (2), (3).

- Changed the variable from query_cache_inv_id to query_cache_inv_trx_id.

- Moved the function row_search_check_if_query_cache_permitted from
    row0sel.h and made it as static function in ha_innodb.cc

Author: Sergei Golubchik
Author Date: 2018-06-14 13:12:13 UTC

fix galera sst tests

note that ${A#foo} is $A if there's no prefix foo. That's why
galera nodes tried to connect to 127.0.0.1:127.0.0.1 if there was
no port in the address

Followup for 2b35db5ac4e

Author: Jan Lindström
Author Date: 2018-06-14 12:47:39 UTC

MDEV-15611 Due to the failure of foreign key detection, Galera slave node killed himself.

Merge following change from 10.2

revision-id: d52cff9f10aeea208a1058f7b5527e602125584c (mariadb-10.2.14-25-gd52cff9)
parent(s): bc2501453c3ab9a2cf3516bc3557de8665bc2776
author: Sachin Setiya
committer: Sachin Setiya
timestamp: 2018-04-04 12:26:06 +0530
message:

MDEV-15611 Due to the failure of foreign key detection, Galera...
slave node killed himself.

Problem:- If we try to delete table with foreign key and table whom it is
referring with wsrep_slave_threads>1 then galera tries to execute both
Delete_rows_log-event in parallel, which should not happen.

Solution:- This is happening because we do not have foreign key info in
write set. Upto version 10.2.7 it used to work fine. Actually it happening
because of issue in commit 2f342c4. wsrep_must_process_fk should be used
with negation.

Author: Marko Mäkelä
Author Date: 2018-06-13 13:15:21 UTC

MDEV-13103 Deal with page_compressed page corruption

fil_page_decompress(): Replaces fil_decompress_page().
Allow the caller detect errors. Remove
duplicated code. Use the "safe" instead of "fast" variants of
decompression routines.

fil_page_compress(): Replaces fil_compress_page().
The length of the input buffer always was srv_page_size (innodb_page_size).
Remove printouts, and remove the fil_space_t* parameter.

buf_tmp_buffer_t::reserved: Make private; the accessors acquire()
and release() will use atomic memory access.

buf_pool_reserve_tmp_slot(): Make static. Remove the second parameter.
Do not acquire any mutex. Remove the allocation of the buffers.

buf_tmp_reserve_crypt_buf(), buf_tmp_reserve_compression_buf():
Refactored away from buf_pool_reserve_tmp_slot().

buf_page_decrypt_after_read(): Make static, and simplify the logic.
Use the encryption buffer also for decompressing.

buf_page_io_complete(), buf_dblwr_process(): Check more failures.

fil_space_encrypt(): Simplify the debug checks.

fil_space_t::printed_compression_failure: Remove.

fil_get_compression_alg_name(): Remove.

fil_iterate(): Allocate a buffer for compression and decompression
only once, instead of allocating and freeing it for every page
that uses compression, during IMPORT TABLESPACE.

fil_node_get_space_id(), fil_page_is_index_page(),
fil_page_is_lzo_compressed(): Remove (unused code).

Author: Marko Mäkelä
Author Date: 2018-06-13 13:15:21 UTC

MDEV-13103 Deal with page_compressed page corruption

fil_page_decompress(): Replaces fil_decompress_page().
Allow the caller detect errors. Remove
duplicated code. Use the "safe" instead of "fast" variants of
decompression routines.

fil_page_compress(): Replaces fil_compress_page().
The length of the input buffer always was srv_page_size (innodb_page_size).
Remove printouts, and remove the fil_space_t* parameter.

buf_tmp_buffer_t::reserved: Make private; the accessors acquire()
and release() will use atomic memory access.

buf_pool_reserve_tmp_slot(): Make static. Remove the second parameter.
Do not acquire any mutex. Remove the allocation of the buffers.

buf_tmp_reserve_crypt_buf(), buf_tmp_reserve_compression_buf():
Refactored away from buf_pool_reserve_tmp_slot().

buf_page_decrypt_after_read(): Make static, and simplify the logic.
Use the encryption buffer also for decompressing.

buf_page_io_complete(), buf_dblwr_process(): Check more failures.

fil_space_encrypt(): Simplify the debug checks.

fil_space_t::printed_compression_failure: Remove.

fil_get_compression_alg_name(): Remove.

fil_iterate(): Allocate a buffer for compression and decompression
only once, instead of allocating and freeing it for every page
that uses compression, during IMPORT TABLESPACE.

fil_page_is_index_page(), fil_page_is_lzo_compressed(): Remove (unused code).

Author: Andrei Elkin
Author Date: 2018-03-18 19:01:41 UTC

MDEV-14014 Multi-Slave Replication Fail: bogus data in log event

MDEV-7257 made a dump thread to read from binlog concurrently with
writers as long as the read bytes are below a water-mark
(MYSQL_BIN_LOG::binlog_end_pos). However it appeared to be possible a
dump thread reader reach out for bytes past the water mark through a
feature of IO_CACHE that fills in the internal buffer and while doing
so it could read what the reader is not supposed to see (the bytes
above MYSQL_BIN_LOG::binlog_end_pos).

The issue is fixed with constraining the IO_CACHE buffer fill to respect
the watermark.

An added unit test proves reading from file is bound to an external
parameter
passed to {IO_CACHE::end_of_file} cache member.

Author: Andrei Elkin
Author Date: 2018-03-18 19:01:41 UTC

MDEV-14014 Multi-Slave Replication Fail: bogus data in log event

MDEV-7257 made a dump thread to read from binlog concurrently with
writers as long as the read bytes are below a water-mark
(MYSQL_BIN_LOG::binlog_end_pos). However it appeared to be possible a
dump thread reader reach out for bytes past the water mark through a
feature of IO_CACHE that fills in the internal buffer and while doing
so it could read what the reader is not supposed to see (the bytes
above MYSQL_BIN_LOG::binlog_end_pos).

The issue is fixed with constraining the IO_CACHE buffer fill to respect
the watermark.
An added test simulates potentially unconstrained buffer fill and an
assert guards this is not the case anymore.

Author: Vicențiu Ciorbaru
Author Date: 2018-06-12 14:23:29 UTC

Fix merge

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-06-12 10:51:41 UTC

MDEV-14398 When innodb_encryption_rotate_key_age=0 is set,
   server won't encrypt tablespaces.

The following commit makes the dependency between
innodb-encryption-rotate-key-age and encryption/decryption.

commit 50eb40a2a8aa3af6cc271f6028f4d6d74301d030
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Tue Mar 14 12:56:01 2017 +0200

MDEV-11738: Mariadb uses 100% of several of my 8 cpus doing nothing

MDEV-11581: Mariadb starts InnoDB encryption threads
when key has not changed or data scrubbing turned off

Background: Key rotation is based on background threads
(innodb-encryption-threads) periodically going through
all tablespaces on fil_system. For each tablespace
current used key version is compared to max key age
(innodb-encryption-rotate-key-age). This process
naturally takes CPU. Similarly, in same time need for
scrubbing is investigated. Currently, key rotation
is fully supported on Amazon AWS key management plugin
only but InnoDB does not have knowledge what key
management plugin is used.

The above commit basically make use of innodb-encryption-rotate-key-age=0
to disable key rotation and background data scrubbing.
It only encrypts/decrypts for the newly created table.

One more issue is with above commit is that, even though the
innodb_encrypt_table value is changed at run time. It doesn't affect
the state of the old tablespace.

Different Solution:
===================

(1) Key rotation thread can iterate through tablespace list and check whether
it matches with innodb_encrypt_tables parameter. If it doesn't match then do
the operation based on the innodb_encrypt_tables parameter. InnoDB shouldn't
iterate the fil_system->space_list again and again. It increases the CPU usage.

(2) Key rotation thread should store lastly used tablespace id. If the value of
innodb-encryption-rotate-key-age is set to 0 then InnoDB should
start the traversion from lastly used space id. So that key rotation thread
only does the encryption/decryption for newly added tablespace.

    (i) If lastly used tablespace id is not found or dropped then InnoDB
 should traverse it from system tablespace again.

(3) If innodb_encrypt_tables value changed at runtime then InnoDB should
traverse the tablespace from system tablespace again.

Author: Vicențiu Ciorbaru
Author Date: 2018-06-11 21:19:22 UTC

Merge branch '10.0-galera' into bb-10.1-vicentiu

Author: Alexey Botchkov
Author Date: 2018-06-11 19:42:13 UTC

MDEV-14668 ADD PRIMARY KEY IF NOT EXISTS on composite key

Author: Oleksandr Byelkin
Author Date: 2018-01-31 08:35:38 UTC

MDEV-15113: Hang in Aria loghandler

Added unregistering writers in case of log error.
Added more debugging control about adding/removing writers to the buffers.

Author: Vicențiu Ciorbaru
Author Date: 2018-06-11 15:49:48 UTC

Merge branch '5.5' into 10.0

Author: Rutuja Surve
Author Date: 2018-06-10 08:19:39 UTC

MDEV-15021: mysqldump --tables --routines generates non importable dump file

The order of outputting stored procedures is important. Stored
procedures must be available on view creation, for views which make use
of them. Make sure to print them before outputting tables.

Author: Alexander Barkov
Author Date: 2018-06-09 09:38:22 UTC

MDEV-16451 Split Item_equal::add_const() into a virtual method in type_handler()
MDEV-16452 Split TIME and DATETIME handling in Item_func_between, in_temporal, cmp_item_internal

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-06-08 07:27:13 UTC

MDEV-15772 Potential list overrun during XA recovery

- Create an api called prepare_count for counting the number of prepared
transaction. So that server layer can allocate the exact number of prepared
transaction.

Author: Vladislav Vaintroub
Author Date: 2018-06-07 07:56:47 UTC

wip

Author: varun
Author Date: 2018-06-06 16:39:52 UTC

MDEV-16191: Analyze format=json gives incorrect value for r_limit inside a dependent
            subquery when ORDER BY is present

Currently for setting r_limit we divide with the number of iterations we invoke the dependent subquery.
This is not needed for the case of limit. For varying limits we produce the output that the limit varies with
execution.
Also there is a type for filtered , we forgot to multiply by 100 as it is represented as a percent.

Author: Jan Lindström
Author Date: 2018-06-06 11:19:14 UTC

MDEV-16401: Apply review comments to MDEV-16005

Do not hold LOCK_thd_data during my_error or WSREP_DEBUG. Similarly,
release LOCK_thd_data before close_thread_tables() call.

Author: Vladislav Vaintroub
Author Date: 2018-06-05 19:45:17 UTC

MDEV-10246 ssl-* have no effect without mysql_ssl_set()

set mysql->options.use_ssl whenever one of SSL options is set.

Author: Sergey Vojtovich
Author Date: 2018-06-05 08:54:06 UTC

MDEV-16371 - Fix for memory write order inversion

my_atomic implementation for interruptable waits.

Author: sachin
Author Date: 2018-06-05 09:44:19 UTC

MDEV-16166 RBR breaks with HA_ERR_KEY_NOT_FOUND upon DELETE from table...
with spatial index

So the issue is since it is spatial index , at the time of searching index
for key (Rows_log_event::find_row) we use wrong field image we use
Field::itRAW while we should be using Field::itMBR

Author: Oleksandr Byelkin
Author Date: 2018-06-04 09:26:45 UTC

postreview code moving out of sql_yacc*.yy

Author: Sergey Vojtovich
Author Date: 2018-05-29 17:46:31 UTC

C++11 experiment: check if all builders support it

Author: Sergei Golubchik
Author Date: 2018-06-03 00:39:53 UTC

cleanup: ASSERT_COLUMN_MARKED_FOR_WRITE_OR_COMPUTED

restore its original semantics by allowing only columns
in the write_set. Generated columns work around the assert
by temporarily updating the write_set.

Author: varun
Author Date: 2018-05-23 21:39:42 UTC

MDEV-16225: wrong resultset from query with semijoin=on

For non-semi-join subquery optimization we do a cost based decision between
Materialisation and IN -> EXIST transformation. The issue in this case is that for IN->EXIST transformation
we run JOIN::reoptimize with the IN->EXISt conditions and we come up with a new query plan. But when we compare
the cost with Materialization, we make the decision to chose Materialization so we need to restore the query plan
for Materilization. The saving and restoring for keyuse array and join_tab keyuse is only done when we have atleast
one element in the keyuse_array , we are now changing to do it even for 0 elements to main the generality.

Author: Sachin Setiya
Author Date: 2018-05-30 10:55:44 UTC

MDEV-9266 Creating index on temporaray table breaks replication

Problem:- Create/drop index was logged into binlog.

Goal:- Operation on temporary table should not be binlog when binlog format
is row.

Solution:-
We should add CF_FORCE_ORIGINAL_BINLOG_FORMAT when there is ddl on temp
table.
For optimize, analyze, repair and rename we wont change anything ,Then will
be logged in binlog , But they also dont throw any error if operation fails
Since slave wont be having any temp table , but these operation on tmp
table will be processed without breaking replication.

Author: Vladislav Vaintroub
Author Date: 2018-05-29 23:07:02 UTC

rocksdb backup

Author: varun
Author Date: 2018-05-29 09:36:45 UTC

MDEV-15253: Default optimizer setting changes for MariaDB 10.4

Results updated part 2

Author: Sergey Petrunia
Author Date: 2018-05-25 08:51:15 UTC

Buildbot pass #3

Author: Andrei Elkin
Author Date: 2018-05-22 17:19:13 UTC

MDEV-13727 top-level query timestamp reset at stored func/trigger internal statements

Being executed under slow_log is ON the test revealed a "side-effect"
in MDEV-8305 implementation which inadvertently made the trigger or
stored function statements to reset the top-level query's
THD::start_time et al. (Details of the test failure analysis are footnoted).
Unlike the SP case the SF and Trigger's internal statement should not
do that.

Fixed with revising the MDEV-8305 decision to backup/reset/restore
the session timestamp inside sp_instr_stmt::execute(). The timestamp
actually remains reset in the SP case by its caller per statement basis by ever
existing logics.

Timestamps related tests are extended to cover the trigger and stored function case.

Note, commit 3395ab73244 is reverted as its struct QUERY_START_TIME_INFO
declaration is not in use anymore after this patch.

Footnote:
--------
Specifically to the failing test, a query on the master was logged
okay with a timestamp of the query's top-level statement but its post
update trigger managed to compute one more (later) timestamp which got
inserted into another table. The latter table master-vs-slave
no fractional part timestamp discrepancy became evident
thanks to different execution time of the trigger combined with the
fact of the logged with micro-second fractional part master timestamp
was truncated on the slave. On master when the fractional part was
close to 1 the trigger execution added up its own latency to overflow
to next second value. That's how the master timestamp surprisingly
turned out to bigger than the slave's one.

Author: Vicențiu Ciorbaru
Author Date: 2018-05-22 18:57:14 UTC

MDEV-15578: MyRocks: support zstandard compression where the distro allows it

Add libzstd-dev as a build dependency to the server and libzstd1 as a
runtime dependency for rocksdb. libzstd is practially a mandatory
compression library to ensure adequate performance for RocksDB.

Author: Monty
Author Date: 2018-05-24 13:20:31 UTC

Extend debug_assert_on_not_freed_memory

Don't check global_memory_used if
debug_assert_on_not_freed_memory is not set

Author: Elena Stepanova
Author Date: 2018-05-23 20:31:21 UTC

List of unstable tests for 10.3.7 release

The list was created based on 10.2.15 list, with the addition
of failures and modifications which happened during the last week
before the tentative 10.3.7 release commit

Author: Monty
Author Date: 2018-05-22 20:05:01 UTC

MDEV-15308 Assertion `ha_alter_info->alter_info->drop_list.elements

Problem was that handle_if_exists_options() didn't correct
alter_info->flags when things was removed from the list.

Author: Jacob Mathew
Author Date: 2018-05-22 00:30:39 UTC

MDEV-12900: spider tests failed in buildbot with valgrind

The failures with valgrind occur as a result of Spider sometimes using the
wrong transaction for operations in background threads that send requests to
the data nodes. The use of the wrong transaction caused the networking to the
data nodes to use the wrong thread in some cases. Valgrind eventually
detects this when such a thread is destroyed before it is used to disconnect
from the data node by that wrong transaction when it is freed.

I have fixed the problem by correcting the transaction used in each of these
cases.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Vladislav Vaintroub
Author Date: 2018-05-21 10:32:39 UTC

update C/C

Author: varun
Author Date: 2018-05-18 12:12:12 UTC

MDEV-14623: Output of show function code does not show FETCH GROUP NEXT ROW for custom aggregates

The print() function was missing from the FETCH GROUP NEXT ROW instrunction class, so there was no
output for this particular instruction when we use the query SHOW FUNCTION CODE function_name

Author: Sachin Setiya
Author Date: 2018-05-18 12:05:33 UTC

MDEV-10259 mysqld crash with certain statement length and...
order with Galera and encrypt-tmp-files=1

Problem:- If trans_cache (IO_CACHE) uses encrypted tmp file
then on next DML server will crash.

Case:-
 Lets take a case , we have a table t1 , We try to do 2 inserts in t1
  1. A really long insert so that trans_cache has to use temp_file
  2. Just a small insert

Analysis:- Actually server crashes from inside of galera
library.
/lib64/libc.so.6(abort+0x175)[0x7fb5ba779dc5]
/usr/lib64/galera/libgalera_smm.so(_ZN6galera3FSMINS_9TrxHandle5State...
mysys/stacktrace.c:247(my_print_stacktrace)[0x7fb5a714940e]
sql/signal_handler.cc:160(handle_fatal_signal)[0x7fb5a715c1bd]
sql/wsrep_hton.cc:257(wsrep_rollback)[0x7fb5bcce923a]
sql/wsrep_hton.cc:268(wsrep_rollback)[0x7fb5bcce9368]
sql/handler.cc:1658(ha_rollback_trans(THD*, bool))[0x7fb5bcd4f41a]
sql/handler.cc:1483(ha_commit_trans(THD*, bool))[0x7fb5bcd4f804]

but actual issue is not in galera but in mariadb, because for 2nd
insert we should never call rollback. We are calling rollback because
log_and_order fails it fails because write_cache fails , It fails
because after reinit_io_cache(trans_cache) , my_b_bytes_in_cache says 0
so we look into tmp_file for data , which is obviously wrong since temp
was used for previous insert and it no longer exist.
wsrep_write_cache_inc() reads the IO_CACHE in a loop, filling it with
my_b_fill() until it returns "0 bytes read". Later
MYSQL_BIN_LOG::write_cache() does the same. wsrep_write_cache_inc()
assumes that reading a zero bytes past EOF leaves the old data in the
cache

Solution:- There is two issue in my_b_encr_read
1st we should never equal read_end to info->buffer. I mean this
does not make sense read_end should always point to end of buffer.
2nd For most of the case(apart from async IO_CACHE) info->pos_in_file
should be equal to info->buffer position wrt to temp file , since
in this case we are not changing info->buffer it should remain
unchanged.

Author: Vladislav Vaintroub
Author Date: 2018-05-17 23:23:15 UTC

Do not use UTF8 on the command line for mysql client, on Windows.

It only worked by accident in the past, with client not being Unicode safe.
It stopped working with VS2017 15.7 release.

Author: Anel Husaković
Author Date: 2018-04-20 07:06:25 UTC

Add error message in case of the `field` `check` constraints

One can create table with the same name for `field` and `table` `check` constraint.
For example:

create table t(a int check(a>0), constraint a check(a>10));
But when inserting new rows same error is always raised.
For example with
insert into t values (-1);
insert into t values (10);
same error `ER_CONSTRAINT_FAILED` is returned for both queries.
By the assumption that the previous error should be raised only in case of
`table` constraints, this patch will distinguish between `field` and `table`
error message by adding newly created `ER_FIELD_CONSTRAINT_FAILED` error which
occurs only when `field` constraint is violated.

Author: sachin
Author Date: 2018-04-26 14:20:30 UTC

MDEV-15127 AddressSanitizer: stack-buffer-overflow in
 base_list::push_back upon creating invisible index

A commit message ....

Author: Vladislav Vaintroub
Author Date: 2018-05-17 23:23:15 UTC

Do not use UTF8 on the command line for mysql client, on Windows.

It only worked by accident in the past, with client not being Unicode safe.
It stopped working with VS2017 15.7 release.

Author: Oleksandr Byelkin
Author Date: 2018-05-17 17:17:28 UTC

MDEV-12465: Server crashes in my_scan_weight_utf8_bin upon collecting stats for RocksDB table

Do not use "only index read" in analyzing indices if there is a field which present in the index only partially.

Author: Sachin Setiya
Author Date: 2018-05-17 10:29:43 UTC

Fix rpl_000011.test

Instead of real value use delta value , Since flush status wont flush
LONGLONG variable.

Author: Sergey Vojtovich
Author Date: 2018-05-16 17:01:26 UTC

(almost) sane core handling in mtr

Analyze core independently of max-save-datadir and max-save-core setting.

Increment $num_saved_cores only if core was actually saved.

"Move any core files from e.g. mysqltest" independently of
max-save-datadir setting. Note: it may overwrite core from mysqld, which
might not be desired (it did work this way even before).

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-07 11:33:47 UTC

MDEV-15855 Use MDL in FULLTEXT INDEX sync

- fts sync thread allows takes MDL lock on the table instead of
dict_operation_lock.

Author: varun
Author Date: 2018-04-20 17:28:45 UTC

MDEV-15777:Support Early NULLs filtering-like restrictions in the range optimizer

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-15 05:46:51 UTC

MDEV-13626 Merge InnoDB test cases from MySQL 5.7

Imported the following test case from mysql to MariaDB

1) innodb.alter_kill
2) innodb.alter_foreign_crash
3) innodb.alter_rename_files
4) innodb.analyze_table
5) Appended the case in innodb-online-alter-gis

Author: Jacob Mathew
Author Date: 2018-05-11 21:45:09 UTC

MDEV-16101: ADD PARTITION on table partitioned by list does not work with more than 32 list values.

This problem occured because the reorganization of the list of values when the
number of elements exceeds 32 was not handled correctly. I have fixed the
problem by fixing the way that the list values are reorganized when the number
of list values exceeds 32.

Author:
  Jacob Mathew.

Reviewer:
  Alexey Botchkov.

Author: varun
Author Date: 2018-05-14 20:14:03 UTC

MDEV-14695: Assertion `n < m_size' failed in Bounds_checked_array<Element_type>::operator

In this issue we hit the assert because we are adding addition fields to the field JOIN::all_fields list. This
is done because HEAP tables can't index BIT fields so we need to use an additional hidden field for grouping because later it will be
converted to a LONG field. Original field will remain of the BIT type and will be returned. This happens when we convert DISTINCT to
GROUP BY.

The solution is to take into account the number of such hidden fields that would be added to the field
JOIN::all_fields list while calculating the size of the ref_pointer_array.

Author: Sachin Setiya
Author Date: 2018-05-14 11:59:06 UTC

MDEV-9266 Creating index on temporaray table breaks replication

Problem:- Create index was logged into binlog.

Goal:- Operation on temporary table should not be binlog when binlog format
is row.

Solution:-
1st- We should add CF_FORCE_ORIGINAL_BINLOG_FORMAT when there
 is ddl on temp table.
2nd- For optimize, analyze and repair we dont check if binlog format is row
 and this is tmp table, we dont need to log that.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-14 07:45:15 UTC

MDEV-15874 CREATE TABLE creates extra transaction

InnoDB does not allow FOREIGN KEY constraints to exist for TEMPORARY TABLE.
InnoDB introduced a dedicated tablespace for temporary tables, and actually
stopped creating persistent metadata and data for temporary tables.

row_table_add_foreign_constraints(): Do not create a persistent
transaction.

dict_create_foreign_constraints_low(): Add the persistent transaction to
the update the foreign key relation in dictionary.

dict_create_foreign_constraints_low(): Remove a duplicated check for
partitioned tables.

Author: Sachin Setiya
Author Date: 2018-05-14 06:45:38 UTC

MDEV-14472 Assertion `is_current_stmt_binlog_format_row()' failed...
in THD::binlog_write_table_map

try 1 patch

Author: Galina Shalygina
Author Date: 2018-05-13 16:28:40 UTC

Merge branch 'bb-10.3-mdev12387' into 10.4

Author: Marko Mäkelä
Author Date: 2018-05-12 07:28:54 UTC

dict_create_index_tree_in_mem(): Remove dead code

In InnoDB, CREATE TEMPORARY TABLE does not allow FULLTEXT INDEX.
Replace a condition with a debug assertion, and add a test.

Author: Sergey Petrunia
Author Date: 2018-05-11 11:50:36 UTC

Tentatively enable a few myrocks tests

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-09 14:14:13 UTC

- Fixed compilation issue and merging error.

Author: Jan Lindström
Author Date: 2018-05-09 06:16:20 UTC

MDEV-15351: wsrep_sst_xtrabackup is broken in 10.1.31

Remove the setup_ports function call. This is related to
https://github.com/MariaDB/server/pull/717

Thanks to Daniel Black and Bart S.

Author: Vladislav Vaintroub
Author Date: 2018-05-08 14:08:08 UTC

MDEV-16105: Mariabackup does not support SSL

The reason is the missing HAVE_OPENSSL define for mariabackup.

Author: Galina Shalygina
Author Date: 2018-05-06 19:51:22 UTC

Post merge changes

Author: Anel Husaković
Author Date: 2018-04-03 12:41:13 UTC

MDEV-14474 information_schema.check_constraints

Implement according to standard SQL specification 2008.
The check_constraints table is used for fetching metadata about
the constraints defined for tables in all databases.

Author: Daniel Bartholomew
Author Date: 2018-05-03 14:23:36 UTC

bump the VERSION

Author: Jacob Mathew
Author Date: 2018-05-01 21:14:06 UTC

MDEV-15697: Remote user used by Spider needs SUPER privilege

The remote users need the SUPER privilege because by default Spider sends a
'SET SQL_LOG_OFF' statement to the data nodes. This is controlled by the
spider_internal_sql_log_off configuration setting on the Spider node, which
can only be set to 0 or 1, with a default value of 1.

I have fixed the problem by changing this configuration setting so that if it
is NOT SET, which is the most likely case, the Spider node DOES NOT SEND the
'SET SQL_LOG_OFF' statement to the data nodes. However if the
spider_internal_sql_log_off setting IS EXPLICITLY SET to either 0 or 1, then
the Spider node DOES SEND the 'SET SQL_LOG_OFF' statement, requiring a remote
user with the SUPER privilege. The Spider documentation will be updated to
reflect this change.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Jan Lindström
Author Date: 2018-04-30 04:40:17 UTC

Merge branch 'codership-MDEV-15803' into 10.1

Author: Jan Lindström
Author Date: 2018-04-27 06:28:14 UTC

Merge branch 'codership-MDEV-15794' into 10.1

Author: Oleksandr Byelkin
Author Date: 2018-04-26 17:58:43 UTC

MDEV-13024: Server crashes in my_store_ptr upon DELETE from sequence in multi-table format

Make operation possition() dummy for sequences (should not be used really)

Author: Elena Stepanova
Author Date: 2018-04-25 16:19:44 UTC

Add a test case which is known to fail, to check failure handling

Not to be merged to the main tree!

Author: Jacob Mathew
Author Date: 2018-04-14 00:51:51 UTC

MDEV-15698: Spider ignores syntax errors in connection string in COMMENT field

When a comma separator is missing between COMMENT fields, Spider ignores the
parameter values that are beyond the last expected parameter value. There are
also some error messages that Spider does generate on COMMENT fields that are
incorrectly formed.

I have introduced additional infrastructure in Spider to fix these problems.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Jan Lindström
Author Date: 2018-04-24 11:43:41 UTC

MDEV-15607: mysqld crashed few after node is being joined with sst

This is a typical systemd response where it tries to shutdown the
joiner (due to "timeout") before the joiner manages to complete SST.

wsrep_sst_wait
wsrep_SE_init_wait
 While waiting the operation to finish use mysql_cond_timedwait
 instead of mysql_cond_wait and if operation is not finished
 extend systemd timeout (if needed).

Author: Jan Lindström
Author Date: 2018-04-24 10:58:42 UTC

MariaDB adjustments.

Author: Jacob Mathew
Author Date: 2018-04-24 05:00:27 UTC

MDEV-15712: If remote server used by Spider table is unavailable, some operations hang for a long time

When an attempt to connect to the remote server fails, Spider retries to
connect to the remote server 1000 times or until the connection attempt
succeeds. This is perceived as a hang if the remote server remains
unavailable.

I have introduced changes in Spider's table status handler to fix this problem.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-04-21 03:27:38 UTC

Problem:
=======
InnoDB cleans all temporary undo logs during commit. During rollback
of secondary index entry, InnoDB tries to build the previous version
of clustered index. It leads to access of freed undo page during
previous transaction commit and it leads to undo log corruption.

Solution:
=========
During rollback, temporary undo logs should not try to build
the previous version of the record.

Author: Jan Lindström
Author Date: 2018-04-18 08:35:31 UTC

MDEV-15308: Assertion `ha_alter_info->alter_info->drop_list.elements > 0' failed in ha_innodb::prepare_inplace_alter_table

Problem was thet when items were removed from drop_list alter_info
flags were not adjusted accordingly in all cases.

Author: Vladislav Vaintroub
Author Date: 2018-04-15 14:29:55 UTC

Innodb cleanup - make Innodb merge temp tables use pfs_os_file_t for
file IO, rather than int.

On Windows, it is suboptimal to depend on C runtime, as it has limited
number of file descriptors. This change eliminates
os_file_read_no_error_handling_int_fd(), os_file_write_int_fd(),
OS_FILE_FROM_FD() macro.

Author: Jan Lindström
Author Date: 2018-04-16 12:06:41 UTC

MDEV-13516: encryption.create_or_replace test fails in buildbot with InnoDB assertion failure

fil_crypt_rotate_pages
 If tablespace is marked as stopping stop also page rotation

fil_crypt_flush_space
 If tablespace is marked as stopping do not try to read
 page 0 and write it back.