Author: Varun Gupta
Author Date: 2019-04-23 18:46:56 UTC

MDEV-15837: Assertion `item1->type() == Item::FIELD_ITEM && item2->type() == Item::FIELD_ITEM'
            failed in compare_order_elements function

The issue here is the function compare_order_lists() is called for the order by list of the window functions
so that those window function that can be computed together are adjacent.
So in the function compare_order_list we iterate over all the elements in the order list of the two functions and
compare the items in their order by clause.
The function compare_order_elements() is called for each item in the
order by clause. This function assumes that all the items that are in the order by list would be of the type
Item::FIELD_ITEM.

The case we have is that we have constants in the order by clause. We should ignore the constant and only compare
items of the type Item::FIELD_ITEM in compare_order_elements()

Author: Sujatha Sivakumar
Author Date: 2019-04-24 06:10:52 UTC

MDEV-17260: Memory leaks in mysqlbinlog

Problem:
========
The mysqlbinlog tool is leaking memory, causing failures in various tests when
compiling and testing with AddressSanitizer or LeakSanitizer like this:

cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source
make -j$(nproc)
cd mysql-test
ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog

CURRENT_TEST: rpl.rpl_row_mysqlbinlog

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87)
#1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10
#2 0x5300dd in Log_event::read_log_event(char const*, unsigned int, char const**,
   Format_description_log_event const*, char) /mariadb/5.5/sql/log_event.cc:1568:
#3 0x564a9c in dump_remote_log_entries(st_print_event_info*, char const*)
/mariadb/5.5/client/mysqlbinlog.cc:1978:17

Analysis:
========
'mysqlbinlog' tool is being used to read binary log events from a remote server.
While reading binary log, if a fake rotate event is found following actions are
taken.

If 'to-last-log' option is specified, then fake rotate event is processed.
In the absence of 'to-last-log' skip the fake rotate event.

In this skipped case the fake rotate event object is not getting cleaned up
resulting in memory leak.

Fix:
===
Cleanup the fake rotate event.

This issues is already fixed in MariaDB 10.0.23 and higher versions as part of
commit c3018b0ff4fb02c029787d03867adf0530607bab

Author: Rasmus Johansson
Author Date: 2019-04-24 03:04:43 UTC

Another comment to cause a file change for buildbot

Author: Anel Husakovic
Author Date: 2019-04-23 20:15:14 UTC

Add condition to handle only HA_OPEN_FOR_ALTER To init_frm_from_image()

- In this case `select * from mysql_json;` will raise an error to rebuild
the table
- `alter table mysql_json force;` will successed, but we have to change
frm representation from native data to string representation

Author: Varun Gupta
Author Date: 2019-04-23 18:46:56 UTC

MDEV-15837: Assertion `item1->type() == Item::FIELD_ITEM && item2->type() == Item::FIELD_ITEM'
            failed in compare_order_elements function

The issue here is the function compare_order_lists() is called for the order by list of the window functions
so that those window function that can be computed together are adjacent.
So in the function compare_order_list we iterate over all the elements in the order list of the two functions and
compare the items in their order by clause.
The function compare_order_elements() is called for each item in the
order by clause. This function assumes that all the items that are in the order by list would be of the type
Item::FIELD_ITEM.

The case we have is that we have constants in the order by clause. We should ignore the constant and only compare
items of the type Item::FIELD_ITEM in compare_order_elements()

Author: Sergei Golubchik
Author Date: 2019-04-19 10:48:47 UTC

MDEV-15907 ASAN heap-use-after-free in strnmov / .. / fill_effective_table_privileges on concurrent GRANT and CREATE VIEW

rename a test file.

Closes #1253

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-04-23 14:51:58 UTC

- Addressed marko's review comments.

Author: Sujatha Sivakumar
Author Date: 2019-04-23 14:17:59 UTC

MDEV-17260: Memory leaks in mysqlbinlog

Problem:
========
The mysqlbinlog tool is leaking memory, causing failures in various tests when
compiling and testing with AddressSanitizer or LeakSanitizer like this:

cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source
make -j$(nproc)
cd mysql-test
ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto

Analysis:
=========
Two types of leaks were observed during above execution.

1) Leak in Log_event::read_log_event(char const*, unsigned int, char const**,
   Format_description_log_event const*, char)
   File: sql/log_event.cc:2150

For all row based replication events the memory which is allocated during
read_log_event is not freed after the event is processed. The event specific
memory has to be retained only when flashback option is enabled with
mysqlbinlog tool. In this case all the events are retained till the end
statement is received and they are processed in reverse order and they are
destroyed. But in the existing code all events are retained irrespective of
flashback mode. Hence the memory leaks are observed.

2) read_remote_annotate_event(unsigned char*, unsigned long, char const**)
   File: client/mysqlbinlog.cc:194

In general the Annotate event is not printed immediately because all
subsequent rbr-events can be filtered away. Instead it will be printed
together with the first not filtered away Table map or the last rbr will be
processed. While reading remote annotate events memory is allocated for event
buffer and event's temp_buf is made to point to the allocated buffer as shown
below. The TRUE flag is used for doing proper cleanup using free_temp_buf().
i.e at the time of deletion of annotate event its destructor takes care of
clearing the temp_buf.

/*
  Ensure the event->temp_buf is pointing to the allocated buffer.
  (TRUE = free temp_buf on the event deletion)
*/
 event->register_temp_buf((char*)event_buf, TRUE);

But existing code does the following when it receives a remote annotate_event.

if (remote_opt)
  ev->temp_buf= 0;

That is code immediately sets temp_buf=0, because of which free_temp_buf()
call will return empty handed as it has lost the reference to the allocated
temporary buffer. This results in memory leak

Fix:
====
1) If not in flashback mode, destroy the memory for events once they are
processed.

2) Remove the ev->temp_buf=0 code for remote option. Let the proper cleanup to
be done as part of free_temp_buf().

Author: Alexander Barkov
Author Date: 2019-04-23 09:45:28 UTC

MDEV-9234 Add Type_handler::union_element_finalize()

Author: Alexander Barkov
Author Date: 2019-04-23 09:45:28 UTC

MDEV-9234 Add Type_handler::union_element_finalize()

Author: Alexander Barkov
Author Date: 2019-04-23 09:45:28 UTC

MDEV-9234 Add Type_handler::union_element_finalize()

Author: Alexander Barkov
Author Date: 2019-04-23 05:11:42 UTC

MDEV-9465 The constructor StringBuffer(const char *str, size_t length, const CHARSET_INFO *cs) looks suspicious

Removing the suspicious constructor, it's not used in the code anyway.

Author: Kentoku SHIBA
Author Date: 2019-04-22 23:43:19 UTC

MDEV-18988 Wrong result when query with group by x order by y limit n

Author: Kentoku SHIBA
Author Date: 2019-04-22 23:43:19 UTC

MDEV-18988 Wrong result when query with group by x order by y limit n

Author: Monty
Author Date: 2019-04-15 15:16:02 UTC

MDEV-17841 S3 storage engine

S3 storage engine

Add support for calling S3 (still in progress)

Author: Monty
Author Date: 2019-01-26 15:27:20 UTC

MDEV-18465 Logging of DDL statements during backup

Many of the changes was needed to be able to collect and print engine
name and table version id's in the ddl log.

Other things:
- Removed not used flag NO_FRM_RENAME
- Backup START now waits for running or waiting DDL's to complete
- Added test that CREATE VIEW is blocked by BLOCK_DDL
- ha_resolve_storage_engine_name() now also works for views

Author: Sergey Vojtovich
Author Date: 2019-04-21 20:04:14 UTC

Let prepared XA persists over disconnect

TODO: find out how to reset connection properly without calling
ha_rollback_trans().

Part of MDEV-7974 - backport fix for mysql bug#12161 (XA and binlog)

Author: Alexander Barkov
Author Date: 2019-04-21 08:07:30 UTC

MDEV-19239 ERROR 1300 (HY000): Invalid utf8 character string in 10.3.13-MariaDB

A sequence of <digits>e<mbhead><mbtail>, e.g.:

  SELECT 123eXYzzz FROM t1;

was not scanned correctly (where XY is a multi-byte character).

The multi-byte head byte X was appended to 123e separately from
the multi-byte tail byte Y, so a pointer to "Yzzz" was passed
into scan_ident_start(), which failed on a bad multi-byte sequence.

After this change, scan_ident_start() gets a pointer to "XYzzz",
so it correctly sees the whole multi-byte character.

Author: Sergei Golubchik
Author Date: 2017-06-21 14:07:54 UTC

MDEV-9531 GROUP_CONCAT with ORDER BY inside takes a lot of memory while it's executed

group concat tree is allocated in a memroot, so the only way to free
memory is to copy a part of the tree into a new memroot.

track the accumilated length of the result, and when it crosses
the threshold - copy the result into a new tree, free the old one.

Author: Igor Babaev
Author Date: 2019-04-19 23:17:51 UTC

MDEV-19255 Server crash in st_join_table::save_explain_data or assertion
           `sel->quick' failure in JOIN::make_range_rowid_filters upon query
           with rowid_filter=ON

Index ranges can be defined using conditions with inexpensive subqueries.
Such a subquery is evaluated when some representation of a possible range
sequence is built. After the evaluation the JOIN structure of the subsquery is distroyed.
Any attempt to build the above representation may fail because the
function that checks whether a subquery is inexpensive in some cases uses
the join structure of the subquery.
When a range rowid filter is built by a range sequence constructed out of
a range condition that uses an inexpensive subquery the representation of
the the sequence is built twice. Building the second representation fails
due to the described problem with the execution of Item_subselect::is_expensive().
The function was corrected to return the result of the last its invocation
if the Item_subselect object has been already evaluated.

Author: Andrei Elkin
Author Date: 2019-04-17 12:32:30 UTC

MDEV-18096 The server would crash when has configs rpl_semi_sync_master_enabled = OFF rpl_semi_sync_master_wait_no_slave = OFF

The patch fixes a fired assert in the semisync master module. The assert
caught attempt to switch semisync off (per rpl_semi_sync_master_wait_no_slave = OFF)
when it was not even initialized (per rpl_semi_sync_master_enabled = OFF).
The switching-off execution branch is relocated under one that executes
enable_master() first.

A minor cleaup is done to remove the int return from two functions that
did not return anything but an error which could not happen in the functions.

Author: Monty
Author Date: 2019-04-19 10:22:01 UTC

MDEV-19224 Assertion `marked_for_read()' failed

Problem was that wrong key_info variable was used, which caused UNIQUE
key to be used as a covering key

Author: Sergey Petrunia
Author Date: 2019-04-18 17:56:56 UTC

MDEV-17297: stats.records=0 for a table of Archive engine when it has rows, when we run ANALYZE command

Archive storage engine assumed that any query that attempts to read from
the table will call ha_archive::info() beforehand. ha_archive would flush
un-written data in that call (this would make it visible for the reads).

Break this assumption. Flush the data when the table is opened for reading.

This way, one can do multiple write statements without causing a flush, but
as soon as we might need the data, we flush it.

Author: Sergey Petrunia
Author Date: 2019-04-18 15:56:14 UTC

MDEV-19266: Crash in EITS code when enabling 128 indexes

Do not attempt to set param->table->with_impossible_ranges if the
range optimizer is using pseudo-indexes (which is true when we are
computing EITS selectivity estimates or doing partition pruning).

Author: Vladislav Vaintroub
Author Date: 2019-04-18 04:50:59 UTC

MDEV-19274 mariadb does not build on OSes that do not have HAVE_POOL_OF_THREADS

Do not try to compile threadpool_common.cc, if threadpool is not available
on current OS.

Also introduced undocumented/uncached CMake variable DISABLE_THREADPOOL,
to emulate builds on exotic OSes.

Author: Vladislav Vaintroub
Author Date: 2019-04-17 12:57:03 UTC

For testing purposes, test MAX_INDEXES=128. Do no push that into main tree

Author: Kentoku SHIBA
Author Date: 2019-04-17 12:25:12 UTC

MDEV-19238 Mariadb spider - crashes on where null

Author: Sujatha Sivakumar
Author Date: 2019-04-17 10:00:09 UTC

MDEV-17260: Memory leaks in mysqlbinlog

Problem:
========
The mysqlbinlog tool is leaking memory, causing failures in various tests when
compiling and testing with AddressSanitizer or LeakSanitizer like this:

cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source
make -j$(nproc)
cd mysql-test
ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog

CURRENT_TEST: rpl.rpl_row_mysqlbinlog

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87)
#1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10
#2 0x5300dd in Log_event::read_log_event(char const*, unsigned int, char const**,
   Format_description_log_event const*, char) /mariadb/5.5/sql/log_event.cc:1568:
#3 0x564a9c in dump_remote_log_entries(st_print_event_info*, char const*)
/mariadb/5.5/client/mysqlbinlog.cc:1978:17

Analysis:
========
'mysqlbinlog' tool is being used to read binary log events from a remote server.
While reading binary log, if a fake rotate event is found following actions are
taken.

If 'to-last-log' option is specified, then fake rotate event is processed.
In the absence of 'to-last-log' skip the fake rotate event.

In this skipped case the fake rotate event object is not getting cleaned up
resulting in memory leak.

Fix:
===
Cleanup the fake rotate event.

This issues is already fixed in MariaDB 10.0.23 and higher versions as part of
commit c3018b0ff4fb02c029787d03867adf0530607bab

Author: Vladislav Vaintroub
Author Date: 2019-04-17 08:52:06 UTC

Apply patch by Sergei Petrunia that fixes a crash main.range_vs_index_merge
with MAX_INDEXES=128

Author: Kentoku SHIBA
Author Date: 2019-03-12 22:40:33 UTC

MDEV-16508 spider: sql_mode not maintained between spider node and data nodes
Add the following parameter.

- spider_sync_sql_mode
  Local sql_mode synchronous existence to remote server.
   0 : It doesn't synchronize.
   1 : It synchronizes.
  The default value is 1

Author: Alexander Barkov
Author Date: 2019-04-16 04:20:57 UTC

MDEV-19256 sql_acl.cc does not compile with WITH_VALGRIND with gcc 8.0

Turning initializing code into constructors.

Author: Vladislav Vaintroub
Author Date: 2019-04-15 14:54:48 UTC

Fix test case

Author: Oleksandr Byelkin
Author Date: 2019-04-15 15:00:37 UTC

untouch read patch

Author: Vladislav Vaintroub
Author Date: 2019-04-15 11:28:10 UTC

threadpool : Make throttling interval depend on thread_pool_stall_limit

A thread_pool_stall_limit which is smaller than default would result
in quicker creation of threads.

Author: Kentoku SHIBA
Author Date: 2019-04-11 09:03:22 UTC

MDEV-19003 ignore send <cache> to remote
It's just added regression tests.

Author: Alexander Barkov
Author Date: 2019-04-04 12:36:08 UTC

MDEV-274 The data type for IPv6/IPv4 addresses in MariaDB

Author: Sergei Golubchik
Author Date: 2019-04-08 21:22:45 UTC

cmake: pass CMAKE_BUILD_TYPE into src.rpm

and don't pass BUILD_CONFIG twice, once is enough.

Author: Kentoku SHIBA
Author Date: 2019-04-08 22:54:20 UTC

MDEV-18995 Some bugs in direct join
Add const_table support to the direct join feature and condition pushdown feature

Author: Alexey Botchkov
Author Date: 2019-04-08 11:33:28 UTC

MDEV-7974 SA transactions.

Failing tests added.

Author: Sergei Golubchik
Author Date: 2019-04-07 19:32:55 UTC

cmake: check for individual boost files

if a module needs to include specific boost files, check for them
explicitly, in addition to `FIND_PACKAGE(Boost)`

this will record correct boost dependency for srpm builds

Author: Robert Bindar
Author Date: 2019-02-24 19:00:36 UTC

Fix default_password_lifetime message typo

Closes #1212

Author: Kentoku SHIBA
Author Date: 2019-04-06 16:39:54 UTC

MDEV-18987 bug in "load data local infile xxx replace into "
It's just added regression tests.

Author: Varun Gupta
Author Date: 2019-03-28 12:07:41 UTC

MDEV-18300: ASAN error in Field_blob::get_key_image upon UPDATE with subquery

For single table updates and multi-table updates , engine independent statistics were not being
read even if the statistics were collected.
Fixed it, so when the optimizer_use_condition_selectivity > 2 then we would read the available
statistics for update queries.

Author: Kentoku SHIBA
Author Date: 2019-04-04 21:23:57 UTC

MDEV-7795 Merge vertical partitioning storage engine

Author: Robert Bindar
Author Date: 2019-04-04 13:02:03 UTC

MDEV-17978 Server crash in SHOW CREATE SEQUENCE on a broken view

The crashed was caused by an invalid access for TABLE_SHARE::table
in mysqld_show_create_get_fields.

Author: Vladislav Vaintroub
Author Date: 2019-04-04 12:10:13 UTC

MDEV-17610 Unexpected connection abort after certain operations from within stored procedure

Always set SERVER_MORE_RESULTS_EXIST when executing stored procedure statements

If statements produce a result, EOF packet needs this flag (SP ends
with an OK packet). IF statetement does not produce a result, affected rows
count are part of the final OK packet.

Author: Robert Bindar
Author Date: 2019-04-04 08:58:50 UTC

MDEV-13010 NEXTVAL should increment only once for a given row

According to the standard, multiple increment operations in a single
SQL statement should advance the sequence only once.

Author: Sujatha Sivakumar
Author Date: 2019-04-02 11:26:45 UTC

MDEV-11095: rpl.rpl_row_mysqlbinlog test fails if row annotation enabled

Problem:
=======
Whel rpl.rpl_row_mysqlbinlog test is executed as shown below it fails with
result content mismatch.

perl mtr rpl_row_mysqlbinlog --mysqld=--binlog-annotate-row-events=1

Analysis:
=========
When row annotations are enabled the actual query is written into the binlog
which helps users to understand the query, even when row based replication is
enabled.

For example: Simple insert in row based replication looks like shown below.

#190402 16:31:27 server id 1 end_log_pos 526 Annotate_rows:
#Q> insert into t values (10)
#190402 16:31:27 server id 1 end_log_pos 566 Table_map: `test`.`t` mapped to number 19
# at 566
#190402 16:31:27 server id 1 end_log_pos 600 Write_rows: table id 19 flags: STMT_END_F

BINLOG '
B0GjXBMBAAAAKAAAADYCAAAAABMAAAAAAAEABHRlc3QAAXQAAQMAAQ==
B0GjXBcBAAAAIgAAAFgCAAAAABMAAAAAAAEAAf/+CgAAAA==
'/*!*/;
# at 600

The test creates some binary log events and redirects them into a SQL file.
Executes RESET MASTER and sources the SQL file back on clean master and verifies
that the data is available. Please refer following steps.

../client/mysqlbinlog ./var/mysqld.1/data/master-bin.000001 > test.sql
../client/mysql -uroot -S./var/tmp/mysqld.1.sock -Dtest < test.sql
../client/mysqlbinlog ./var/mysqld.1/data/master-bin.000001 -v > row.sql

When the row based replication specific SQL file is sourced once again on master
the newly generated binlog will treat the entire "BASE 64" encoded event as
query and write it into the binary log.

Output from 'row.sql':

#Q> BINLOG '
#Q> B0GjXBMBAAAAKAAAADYCAAAAABMAAAAAAAEABHRlc3QAAXQAAQMAAQ==
#Q> B0GjXBcBAAAAIgAAAFgCAAAAABMAAAAAAAEAAf/+CgAAAA==
#190402 16:31:27 server id 1 end_log_pos 657 Table_map: `test`.`t` mapped to number 23
# at 657
#190402 16:31:27 server id 1 end_log_pos 691 Write_rows: table id 23 flags: STMT_END_F

BINLOG '
B0GjXBMBAAAAKAAAAJECAAAAABcAAAAAAAEABHRlc3QAAXQAAQMAAQ==
B0GjXBcBAAAAIgAAALMCAAAAABcAAAAAAAEAAQH+CgAAAA==
### INSERT INTO `test`.`t`
### SET
### @1=10
'/*!*/;
# at 691

This is expected behaviour as we cannot extract query from BASE 64 encoded
input. This causes more number of binary logs to be generated when the test is
executed with row annotations.

The following lines from test assumes that only two binary logs will contain
entire data.

 --echo --- Test 4 Second Remote test --
---exec $MYSQL_BINLOG --read-from-remote-server --user=root --host=127.0.0.1
    --port=$MASTER_MYPORT master-bin.000001 > $MYSQLTEST_VARDIR/tmp/remote.sql
---exec $MYSQL_BINLOG --read-from-remote-server --user=root --host=127.0.0.1
    --port=$MASTER_MYPORT master-bin.000002 >> $MYSQLTEST_VARDIR/tmp/remote.sql

In a case when row annotations are enabled the data gets spread across four
binary logs. As test uses only the first two binary log files, data available in
other binary logs gets missed. Hence test fails with result content mismatch as
less data is available.

Fix:
====
Use "-to-the-last" option of "mysqlbinlog" tool which will ensure that all the
available binary log specific contents are included in .sql file.

Author: Elena Stepanova
Author Date: 2019-04-01 13:58:37 UTC

Updated list of unstable tests for 10.3.14 release

Author: Robert Bindar
Author Date: 2019-04-01 08:54:29 UTC

MDEV-15907 ASAN heap-use-after-free

This patch fixes an invalid read in fill_effective_table_privileges
triggered by a grant_version increase between a PREPARE for a
statement creating a view from I_S and EXECUTE.
A tmp table was created and free'd while preparing the statement,
TABLE_LIST::table_name was set to point to the tmp table
TABLE_SHARE::table_name which no longer existed after preparing was
done.
The grant version increase made fill_effective_table_privileges
called during EXECUTE to try fetch the updated grant info and
this is where the dangling table name was used.

Author: Varun Gupta
Author Date: 2019-04-01 04:36:29 UTC

tests updated

Author: Andrei Elkin
Author Date: 2019-03-30 16:45:46 UTC

Review of 05cae92e524: last_used_log_number increment is made to follow last_binlog_id pattern.

Author: Sergey Vojtovich
Author Date: 2019-03-29 15:08:22 UTC

MDEV-16060 - InnoDB: Failing assertion: ut_strcmp(index->name, key->name)

A sequel to 9180e86 and 149b754.

ALTER TABLE ... ADD FOREIGN KEY may crash if parent table is updated
concurrently.

Block FK parent table updates even earlier, before intermediate child
table is created.

Use proper charset info for my_casedn_str() and don't update original
identifiers so that lower_cast_table_names == 2 is honoured.

Author: Sujatha Sivakumar
Author Date: 2019-03-29 15:17:17 UTC

MDEV-18970: uninited var can be read in gtid_delete_pending()

Problem:
========
gcc 8 -O2 seems to indicate a real error for this code:

direct_pos= table->file->ha_table_flags() & HA_PRIMARY_KEY_REQUIRED_FOR_POSITION;

the warning: /mariadb/10.4/sql/rpl_gtid.cc:980:7:
warning: 'direct_pos' may be used uninitialized in this function [-Wmaybe-uninitialized]

Analysis:
=========
'direct_pos' is a variable which holds 'table_flags'. If this flag is set it means
that a record within a table can be directly located by using its position. If
this flag is set to '0' means there is no direct access is available, hence
index scan must be initiated to locate the record. This direct_pos is used to
locate a row within mysql.gtid_slave_pos table for deletion.

Prior to the initialization of 'direct_pos' following steps take place.

1. mysql.gtid_slave_pos table is opened and 'table_opened' flag is set to true.
2. State check for mysql.gtid_slave_pos table is initiated.

If there is a failure during step2 code will be redirected to the error handling
part. This error handling code will access uninitialized value of 'direct_pos'.
This results in above mentioned warning.

Another issue found during analysis is the error handling code uses '!direct_pos'
to identify if the index is initialized or not. This is incorrect.

The index initialization code is shown below.

  if (!direct_pos && (err= table->file->ha_index_init(0, 0)))
    {
      table->file->print_error(err, MYF(0));
      goto end;
    }

In case there is a failure during ha_index_init code will be redirected to end
part which tries to close the uninitialized index. It will result in an assert

10.4/sql/handler.h:3186: int handler::ha_index_end(): Assertion `inited==INDEX'
failed.

Fix:
===
Introduce a new variable named 'index_inited'. Set this variable upon successful
initialization of index initialization otherwise by default it is false. Use
this variable during error handling.

Author: Sergei Golubchik
Author Date: 2019-03-27 15:35:19 UTC

cleanup: move rbr-only test to rpl_row.test

Author: Marko Mäkelä
Author Date: 2019-03-29 06:32:41 UTC

Re-enable WITH_WSREP=ON by default

This partially reverts commit f903a4213438a1ed1b72ce55897f7332785406be.

The Debian packaging assumes that WITH_WSREP=ON is enabled.
The script debian/autobake-deb.sh is editing
debian/mariadb-server-10.2.install before it invokes cmake
via debian/rules. We would know the value of WITH_WSREP only
after invoking cmake.

Also, startup on systemd-based platforms could fail
due to the systemd scripts assuming WITH_WSREP=ON.

Author: Sergey Vojtovich
Author Date: 2019-03-27 21:58:02 UTC

fixup! Make connect speed great again

Author: Sergei Golubchik
Author Date: 2019-03-22 18:28:59 UTC

MDEV-18466 Unsafe to log updates on tables referenced by foreign keys with triggers in statement format

ignore FK-prelocked tables when looking for write-prelocked tables
with auto-increment to complain about "Statement is unsafe because
it invokes a trigger or a stored function that inserts into an
AUTO_INCREMENT column"

Author: Sujatha Sivakumar
Author Date: 2019-03-27 11:39:07 UTC

MDEV-13895 - Merge testing

Author: Marko Mäkelä
Author Date: 2019-03-27 09:34:53 UTC

MDEV-18417/MDEV-18656/MDEV-18417: Work around compiler ASAN bug

In a Ubuntu Xenial build environment, the compiler identified as
g++-5.real (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
seems to be emitting incorrect code for the compilation unit
trx0rec.cc, triggering a bogus-looking AddressSanitizer report
of an invalid read of something in the function trx_undo_rec_get_pars().
This is potentially affecting any larger tests where the InnoDB
purge subsystem is being exercised.

When the optimization level of trx0rec.cc is limited to -O1, no
bogus failure is being reported. With -O2 or -O3, a lot of things
seemed to be inlined in the function, and the disassembly of the
generated code did not make sense to me.

Author: Vladislav Vaintroub
Author Date: 2019-03-25 15:55:33 UTC

MDEV-17008 prepare with datadir, on Windows, does not set ACL on tablespace files

Fix is to always add Full Control for NetworkService account, for every
file that copyback/moveback copies around.

Author: Alexander Barkov
Author Date: 2019-03-25 15:19:48 UTC

MDEV-18319 BIGINT UNSIGNED Performance issue

Author: Sujatha Sivakumar
Author Date: 2019-03-22 08:27:38 UTC

MDEV-13895: GTID and Master_Delay causes excessive initial delay

Problem:
========
When attempting to delay a Slave attached with GTID, there appears to be an
extra delay applied initially. For example, this output reflects a Slave that is
already delayed by 43200 seconds. When switching to GTID replication,
replication is paused until SQL_Remaining_Delay counts down to 0:

CHANGE MASTER TO master_use_gtid=current_pos; CHANGE MASTER TO
MASTER_DELAY=43200;

Seconds_Behind_Master: 44847
Using_Gtid: Current_Pos
SQL_Delay: 43200
SQL_Remaining_Delay: 43089
Slave_SQL_Running_State: Waiting until MASTER_DELAY seconds after master
executed event

Analysis:
=========
When slave initiates a GTID based connection request to master, the master sends
two GTID_LIST events. The first one is actual GTID_LIST event and the second
one is a fake GTID_LIST event. This is sent by master to provide its current
binlary log file position. The fake GTID_LIST events will have their ev->when=0.
'when' (the timestamp) is set to 0 so that slave could distinguish between real
and fake Rotate events.

On slave side when MASTER_DELAY is configured to "X" the applier will ensure
that there is a time delay of "X" seconds before the event is applied.

General behaviour of MASTER_DELAY example:-

Master
timestamp of event e1=10
timestamp of event e2=11

On slave MASTER_DELAY=5
Event e1 will be applied at = 15
e2 will be applied at =16

In bug scenario:-

On Master: With GTIDs
timestamp of event e1=10
timestamp of event e2=0

On Slave:
e1 will be applied at = 10 + 5 =15
For e2, since "e2->when=0" e2->when is set to current timestamp.
i.e since the e2->when and current timestamp on slave is the same applier waits
for additional master_delay=5 seconds. the ev->when contributes to
"rli->last_master_timestamp".

rli->last_master_timestamp= ev->when + (time_t) ev->exec_time;

Fake events should not update the "ev->when" to "current timestamp" on slave.

Fix:
===
Remove the assignment of current timestamp to "ev->when" when "ev->when=0".

Author: Alexander Barkov
Author Date: 2019-03-19 18:14:37 UTC

Fixing "mtr func_math" failure in the test for MDEV-17643

Adding an intermediate volatile variable to avoid using co-processor registers
on some platforms (e.g. 32-bit x86).
This change makes test results stable accross all platforms.

Author: Oleksandr Byelkin
Author Date: 2018-12-20 08:52:34 UTC

MDEV-16240: Assertion `0' failed in row_sel_convert_mysql_key_to_innobase

Set table in row ID position mode before using this function.

Author: Sujatha Sivakumar
Author Date: 2019-03-18 10:27:44 UTC

MDEV-18913: typo in error log

Problem:
========
Following typo in error log:

2019-03-13 15:58:10 0 [Note] Reading of all Master_info entries succeded

Should be 'succeeded'

Fix:
===
Fixed the typo with the right word 'succeeded'.

Author: Marko Mäkelä
Author Date: 2019-03-15 11:49:18 UTC

Merge branch '10.4-MDEV-18726-large-page-overallocate' of https://github.com/grooverdan/mariadb-server into HEAD

Author: Vladislav Vaintroub
Author Date: 2019-03-14 15:59:27 UTC

MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup

Author: Sergey Vojtovich
Author Date: 2019-03-12 02:53:33 UTC

Cleanups

Fixed warnings after shutdown in test cases.
Removed mysql_admin_shutdown_wait_for_slaves references - never defined.
No more return value from kill_thread().
warn_threads_still_active() integrated into warn_threads_active_after_phase_1().
warn_dump_thread_is_active() integrated into warn_threads_active_after_phase_2().
Don't check if (thd->is_binlog_dump_thread()) in the second phase.
Empty line between kill_mysql() and close_connections().

Author: Sujatha Sivakumar
Author Date: 2019-03-08 05:58:04 UTC

Version 2

Author: Oleksandr Byelkin
Author Date: 2019-03-07 15:18:31 UTC

ANALYZE SELECT with PS fix

Author: Roman Nozdrin
Author Date: 2019-03-04 07:13:31 UTC

    MCOL-2178 Added columnstore as submodule.

Author: Oleksandr Byelkin
Author Date: 2019-03-01 07:30:40 UTC

Merge branch '10.0' into 10.1

Author: Marko Mäkelä
Author Date: 2019-02-25 13:35:00 UTC

MDEV-18719 Assertion (c.prtype ^ o->prtype) & ... failed on ALTER TABLE

The prtype & DATA_LONG_TRUE_VARCHAR flag only plays a role when
converting between InnoDB internal format and the MariaDB SQL layer
row format. Ideally this flag would never have been persisted in the
InnoDB data dictionary.

There were bogus assertion failures when an instant ADD, DROP, or
column reordering was combined with a change of extending a VARCHAR
from less than 256 bytes to more than 255 bytes. Such changes are
allowed starting with MDEV-15563 in MariaDB 10.4.3.

dict_table_t::instant_column(), dict_col_t::same_format(): Ignore
the DATA_LONG_TRUE_VARCHAR flag, because it does not affect the
persistent storage format.

Author: Alexander Barkov
Author Date: 2018-03-20 09:02:44 UTC

Backporting MDEV-15597 Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection

This is a part of "MDEV-18045 Backporting the MDEV-15497 changes to 10.2 branch"

Author: Marko Mäkelä
Author Date: 2019-02-20 20:42:18 UTC

WIP MDEV-17805: Remove InnoDB cache for temporary tables

The intention is to link dict_table_t to TABLE_SHARE.

FIXME: Implement ha_innobase::delete_table() for temporary tables.
FIXME: Implement rollback of ha_innobase::create() for temporary tables.

FIXME: Currently, DBUG_ASSERT(s) fails in ha_innobase::open() because
we fail to pass the InnoDB_share from ha_innobase::create().
This seems to happen for any ALTER TABLE that uses ALGORITHM=COPY

(Old note from December, maybe not true any more:)
An assignment to TABLE_SHARE::ha_share would not work either, because
create() and open() will use different TABLE_SHARE.

Author: Vlad Lesin
Author Date: 2019-02-18 07:14:21 UTC

MDEV-18611: mariabackup silently ended during xtrabackup_copy_logfile()

log_t::files::read_log_seg() can return true without changing
*start_lsn, what can cause an error in xtrabackup_copy_logfile() retry logic.

Author: Vicențiu Ciorbaru
Author Date: 2019-02-18 21:48:07 UTC

Cleanup statistics test

Author: Sergey Petrunia
Author Date: 2019-02-18 10:29:01 UTC

MDEV-18608: Defaults for 10.4: histogram size should be set

Followup: update test results

Author: Sergei Golubchik
Author Date: 2019-02-15 19:31:24 UTC

Merge branch '10.4' into bb-10.4-mdev16188

Author: Vladislav Vaintroub
Author Date: 2019-02-13 09:57:54 UTC

MDEV-18531 : remove extra/yassl

Author: Vlad Lesin
Author Date: 2019-02-13 13:01:38 UTC

MDEV-18573: avoid backup inconsistency in 10.2

--no-lock and --lock-ddl-per-table options deprecared, the corresponing
code is removed. aria_log_control is copied first and aria_log.# files last
under FTWRL.

Author: Igor Babaev
Author Date: 2019-02-13 22:59:34 UTC

Merge branch '10.4' into bb-10.4-mdev17096

Author: Vladislav Vaintroub
Author Date: 2019-02-12 23:31:38 UTC

WIP

Author: Vicențiu Ciorbaru
Author Date: 2019-02-09 23:43:15 UTC

Default Bernoulli Sampling implementation

Author: Vicențiu Ciorbaru
Author Date: 2019-02-09 23:43:15 UTC

Default Bernoulli Sampling implementation

Author: Marko Mäkelä
Author Date: 2019-02-08 12:55:00 UTC

Remove a potentially hazardous fil_system.mutex exit

Also, atomically update the DICT_HDR page with the mini-transaction
that logs MLOG_FILE_DELETE or MLOG_FILE_CREATE2.

FIXME: Review the file creation carefully. See fil_space_create().

srv_replace_log_files(): Revert the changes (do not add this function).

fil_system_t::crypt_enlist(), fil_space_t::crypt_enlist(),
fil_node_t::read_page0(), fil_node_t::prepare_for_io(),
fil_space_t::detach(), fil_node_open_file(), fil_space_get_space():
Return whether dict_hdr_crypt_status_update() needs to be called.

fil_node_t::prepare_for_io(): Renamed from fil_node_prepare_for_io()

fil_space_t::detach(): Renamed from fil_space_detach().

fil_delete_tablespace(): Write MLOG_FILE_DELETE in the same
mini-transaction with the update of the DICT_HDR page.

fil_space_set_crypt_data(): Remove, and merge with the callers.

fil_parse_write_crypt_data(): Return early if the file was not found.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-02-05 10:15:01 UTC

MDEV-14398 When innodb_encryption_rotate_key_age=0 is set, server won't encrypt tablespaces

- Fixed mariabackup test case failure.

Author: Daniel Bartholomew
Author Date: 2019-02-04 21:49:23 UTC

bump the VERSION

Author: Igor Babaev
Author Date: 2019-02-03 20:25:17 UTC

MDEV-16188: cleaup of the previous commit.

Author: Alexey Botchkov
Author Date: 2019-02-03 17:23:35 UTC

MODIFY idx_read_map

Author: Kentoku SHIBA
Author Date: 2018-12-24 06:38:56 UTC

MDEV-16279 Spider crashes on CHECKSUM TABLE with spider_quick_mode=3
add tests

Author: Vladislav Vaintroub
Author Date: 2019-02-02 09:02:03 UTC

MDEV-18281 COM_RESET_CONNECTION changes the connection encoding

Store original charset during client authentication, and restore it for
COM_RESET_CONNECTION

Author: Alexey Botchkov
Author Date: 2019-02-01 22:06:05 UTC

MDEV-14005

Author: Daniel Bartholomew
Author Date: 2019-02-01 15:47:27 UTC

bump the VERSION

Author: Andrei Elkin
Author Date: 2019-02-01 15:27:50 UTC

/binlog_mysqlbinlog_row_frag fixes.

Author: Anel Husakovic
Author Date: 2019-01-24 11:06:56 UTC

Fix is_check_constraints.result to be compatibile with 10.3

The patch is done according to the original patch for MDEV 14474
1edd09c325525cba33152 and not one which is merged on server
d526679efd108478cc2af07578
This patch includes:
- Rename from `is_check_constraint` to `is_check_constraints` to tests
and results
- Change `get_check_constraints_record` to be consistent to `10.3`
- Change the order of fields in IS check_constraints table according to
the standard and MDEV 14474
- Original patch and one in `10.3` supports embedded server this patch doesn't
support (embedded not included in test) but could-TBD?

Author: Andrei Elkin
Author Date: 2019-01-31 16:09:57 UTC

ulonglong fixes - get_table_id

Author: Sergei Golubchik
Author Date: 2019-01-02 11:03:15 UTC

fix the test for 2019

Author: Varun Gupta
Author Date: 2019-01-29 12:52:53 UTC

MDEV-15950: LOAD DATA INTO compex_view crashed

For multi-table views with LOAD, updates are not allowed, so
we should just throw an error.