Author: Sergey Vojtovich
Author Date: 2019-05-18 16:43:29 UTC

Simplified away wake_thread

cached_thread_count can handle it alone.

Added "fast path": when thread is being added to the cached and there's
queued connection request, serve it immediately.

Part of MDEV-19515 - Improve connect speed

Author: Andrei Elkin
Author Date: 2019-05-18 19:26:30 UTC

MDEV-7974: slave side groupping with XA_prepare, mixed engines and few mtr tests update with 5.7 are added.

Author: Sergei Golubchik
Author Date: 2019-05-18 18:55:14 UTC

Merge branch '10.3' into 10.4

Author: Sergei Golubchik
Author Date: 2019-05-11 14:56:41 UTC

cleanup: replace a magic constant with a define

Author: Vladislav Vaintroub
Author Date: 2019-05-18 16:22:15 UTC

fix

Author: Monty
Author Date: 2019-05-17 13:34:35 UTC

Temporary patch to catch problem in aria_chk

Author: Sergei Golubchik
Author Date: 2019-05-18 09:38:43 UTC

update a test result, followup fae6539ef72

Author: Oleksandr Byelkin
Author Date: 2019-05-18 07:11:47 UTC

TVC fix

Author: Marko Mäkelä
Author Date: 2019-05-18 06:24:42 UTC

Merge bb-10.4-merge

Author: Rasmus Johansson
Author Date: 2019-05-18 06:11:01 UTC

MDEV-17591 Create MariaDB named commands/symlinks

Author: Varun Gupta
Author Date: 2019-05-17 16:43:28 UTC

MDEV-15777: Support Early NULLs filtering-like restrictions in the range optimizer

Author: Sergey Petrunia
Author Date: 2019-05-17 16:17:19 UTC

Better comment from Monty for code in make_join_select

Author: Jan Lindström
Author Date: 2019-05-14 07:50:49 UTC

MDEV-16021: galera mtr test galera_evs_suspect_timeout crashed

Crash was timeout crash. Add correct waits for connections, wsrep
sync waits and auto increment offset save and restore.

Author: Sergei Golubchik
Author Date: 2019-05-17 15:23:01 UTC

Merge branch '10.2' into 10.3

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-05-17 15:02:51 UTC

MDEV-19509 InnoDB skips the tablespace in rotation list

- If one of the encryption threads already started the initialization
of the tablespace then don't remove the other uninitialized tablespace
from the rotation list.

- If there is a change in innodb_encrypt_tables then
don't remove the processed tablespace from rotation list.

Author: Robert Bindar
Author Date: 2019-05-14 14:19:43 UTC

MDEV-307 review minor edits, add yacc_ora support

Author: Sergei Golubchik
Author Date: 2019-05-11 14:56:41 UTC

cleanup: replace a magic constant with a define

Author: Varun Gupta
Author Date: 2019-05-17 07:57:11 UTC

MDEV-16214: Incorrect plan taken by the optimizer , uses INDEX instead of ref access with ORDER BY

The issue in this case is that we take in account the estimates from quick keys instead of rec_per_key.
The estimates for quick keys are better than rec_per_key only if we have ref(const), so we need to check
that all keyparts in the ref key are of the type ref(const).

Author: Sujatha
Author Date: 2019-05-17 07:41:49 UTC

MDEV-11094: Blackhole table updates on slave fail when row annotation is enabled

Problem:
=======
rpl_blackhole.test fails when executed with following options
mysqld=--binlog_annotate_row_events=1, mysqld=--replicate_annotate_row_events=1

Test output:
------------
worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
rpl.rpl_blackhole_bug 'mix' [ pass ] 791
rpl.rpl_blackhole_bug 'row' [ fail ]
Replicate_Wild_Ignore_Table
Last_Errno 1032
Last_Error Could not execute Update_rows_v1 event on table test.t1; Can't find
record in 't1', Error_code: 1032; handler error HA_ERR_END_OF_FILE; the event's
master log master-bin.000001, end_log_pos 1510

Analysis:
=========
Enabling "replicate_annotate_row_events" on slave, Tells the slave to write
annotate rows events received from the master to its own binary log. The
received annotate events are applied after the Gtid event as shown below.
thd->query() will be set to the actual query received from the master, through
annotate event. Annotate_rows event should not be deleted after the event is
applied as the thd->query will be used to generate new Annotate_rows event
during applying the subsequent Rows events. After the last Rows event has been
applied, the saved Annotate_rows event (if any) will be deleted.

master-bin.000001 | 457 | Gtid | BEGIN GTID 0-1-2
master-bin.000001 | 495 | Annotate_rows | insert into t values (10)
master-bin.000001 | 539 | Table_map | table_id: 19 (test.t)
master-bin.000001 | 579 | Write_rows_v1 | table_id: 19 flags: STMT_END_F
master-bin.000001 | 613 | Xid | COMMIT /* xid=7 */

In balckhole engine all the DML operations are noops as they donot store any
data. They simply return success without doing any operation. But the existing
strictly expects thd->query() to be 'NULL' to identify that row based
replication is in use. This assumption will fail when row annotations are
enabled as the query is not 'NULL'. Hence various row based operations like
'update', 'delete', 'index lookup' will fail when row annotations are enabled.

Fix:
===
Extend the row based replication check to include row annotations as well.
i.e Either the thd->query() is NULL or thd->query() points to query and row
annotations are in use.

Author: Jan Lindström
Author Date: 2019-05-17 06:17:41 UTC

Merge 10.1 into 10.2

Author: Sujatha
Author Date: 2019-05-16 11:06:20 UTC

MDEV-19076: rpl_parallel_temptable result mismatch '-33 optimistic'

Problem:
========
The test now fails with the following trace:

CURRENT_TEST: rpl.rpl_parallel_temptable
--- /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.result
+++ /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.reject
@@ -194,7 +194,6 @@
 30 conservative
 31 conservative
 32 optimistic
-33 optimistic

Analysis:
=========
The part of test which fails with result content mismatch is given below.

CREATE TEMPORARY TABLE t4 (a INT PRIMARY KEY) ENGINE=InnoDB;
INSERT INTO t4 VALUES (32);
INSERT INTO t4 VALUES (33);
INSERT INTO t1 SELECT a, "optimistic" FROM t4;

slave_parallel_mode=optimistic

The expectation of the above test script is, INSERT FROM SELECT should read both
32, 33 and populate table 't1'. But this expectation fails occasionally.

All three INSERT statements are handed over to three different slave parallel
workers. Temporary tables are not safe for parallel replication. They were
designed to be visible to one thread only, so have no table locking. Thus there
is no protection against two conflicting transactions committing in parallel and
things like that.

So anything that uses temporary tables will be serialized with anything before
it, when using parallel replication by using a "wait_for_prior_commit" function
call. This will ensure that the each transaction is executed sequentially.

But there exists a code path in which the above wait doesn't happen. Because of
this at times INSERT from SELECT doesn't wait for the INSERT (33) to complete
and it completes its executes and enters commit stage. Hence only row 32 is
found in those cases resulting in test failure.

The wait needs to be added within "open_temporary_table" call. The code looks
like this within "open_temporary_table".

Each thread tries to open temporary table in 3 different ways:

case 1: Find a temporary table which is already in use by using
         find_temporary_table(tl) && wait_for_prior_commit()
case 2: If above failed then try to look for temporary table which is marked for
        free for reuse. This internally calls "wait_for_prior_commit()" if table
        is found.
         find_and_use_tmp_table(tl, &table)
case 3: If none of the above open a new table handle from table share.
         if (!table && (share= find_tmp_table_share(tl)))
         { table= open_temporary_table(share, tl->get_table_name(), true); }

At present the "wait_for_prior_commit" happens only in case 1 & 2.

Fix:
====
On slave add a call for "wait_for_prior_commit" for case 3.

The above wait on slave will solve the issue. A more detailed fix would be to
mark temporary tables as not safe for parallel execution on the master side.
In order to do that, on the master side, mark the Gtid_log_event specific flag
FL_TRANSACTIONAL to be false all the time. So that they are not scheduled
parallely.

Author: Alexander Barkov
Author Date: 2019-05-17 04:08:11 UTC

MDEV-8919 Wrong result for CAST(9999999999999999999.0)

Author: Jan Lindström
Author Date: 2019-05-16 11:01:29 UTC

Add flush status.

Author: Monty
Author Date: 2019-05-16 09:56:02 UTC

Merge remote-tracking branch 'origin/10.4' into 10.5

Author: Sergey Petrunia
Author Date: 2019-05-10 09:47:44 UTC

MDEV-19134: EXISTS() slower if ORDER BY is defined

Step #2: "[ORDER BY ...] LIMIT n" should not prevent EXISTS-to-IN
conversion, as long as
- the LIMIT clause doesn't have OFFSET
- the LIMIT is not "LIMIT 0".

Author: Sujatha
Author Date: 2019-05-16 07:42:21 UTC

MDEV-18970: uninited var can be read in gtid_delete_pending()

Problem:
========
gcc 8 -O2 seems to indicate a real error for this code:

direct_pos= table->file->ha_table_flags() & HA_PRIMARY_KEY_REQUIRED_FOR_POSITION;

the warning: /mariadb/10.4/sql/rpl_gtid.cc:980:7:
warning: 'direct_pos' may be used uninitialized in this function [-Wmaybe-uninitialized]

Analysis:
=========
'direct_pos' is a variable which holds 'table_flags'. If this flag is set it means
that a record within a table can be directly located by using its position. If
this flag is set to '0' means there is no direct access is available, hence
index scan must be initiated to locate the record. This direct_pos is used to
locate a row within mysql.gtid_slave_pos table for deletion.

Prior to the initialization of 'direct_pos' following steps take place.

1. mysql.gtid_slave_pos table is opened and 'table_opened' flag is set to true.
2. State check for mysql.gtid_slave_pos table is initiated.

If there is a failure during step2 code will be redirected to the error handling
part. This error handling code will access uninitialized value of 'direct_pos'.
This results in above mentioned warning.

Another issue found during analysis is the error handling code uses '!direct_pos'
to identify if the index is initialized or not. This is incorrect.

The index initialization code is shown below.

  if (!direct_pos && (err= table->file->ha_index_init(0, 0)))
    {
      table->file->print_error(err, MYF(0));
      goto end;
    }

In case there is a failure during ha_index_init code will be redirected to end
part which tries to close the uninitialized index. It will result in an assert

10.4/sql/handler.h:3186: int handler::ha_index_end(): Assertion `inited==INDEX'
failed.

Fix:
===
Introduce a new variable named 'index_inited'. Set this variable upon successful
initialization of index initialization otherwise by default it is false. Use
this variable during error handling.

Author: Anel Husakovic <Anel Husakovic>
Author Date: 2019-02-23 23:48:55 UTC

Fix echo message

Author: Varun Gupta
Author Date: 2019-05-14 10:24:48 UTC

Added a 32 bit rdiff for myisam_mrr instead of a 64 bit rdiff

Author: Galina Shalygina
Author Date: 2019-05-14 20:44:04 UTC

MDEV-11588 Support for ONLY_FULL_GROUP_BY functional dependency

Implement a simple case when INNER join is used.
Support cases when primary key or unique keys are used in GROUP BY (then
all fields of this table can be used in SELECT list).
Support a case when virtual column is used. If it is defined with GROUP BY
fields then it can be used in SELECT list.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-05-14 14:11:07 UTC

MDEV-19435 buf_fix_count > 0 for corrupted page when it exits the LRU list

Problem:
=========
One of the purge thread access the corrupted page and tries to remove from
LRU list. In the mean time, other purge threads are waiting for same page
in buf_wait_for_read(). Assertion(buf_fix_count == 0) fails for the
purge thread which tries to remove the page from LRU list.

Solution:
========
- Set the page id as FIL_NULL to indicate the page is corrupted before removing
the block from LRU list. Acquire hash lock for the particular page id and
wait for the other threads to release buf_fix_count for the block.

- Added the error check for btr_cur_open() in row_search_on_row_ref().

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-05-10 12:24:41 UTC

MDEV-19435 buf_fix_count > 0 for corrupted page when it exits the LRU list

Problem:
=========
One of the purge thread access the corrupted page and tries to remove from
LRU list. In the mean time, other purge threads are waiting for same page
in buf_wait_for_read(). Assertion(buf_fix_count == 0) fails for the
purge thread which tries to remove the page from LRU list.

Solution:
========
- Set the page id as FIL_NULL to indicate the page is corrupted before removing
the block from LRU list. Acquire hash lock for the particular page id and
wait for the other threads to release buf_fix_count for the block.

- Added the error check for btr_cur_open() in row_search_on_row_ref().

Author: Oleksandr Byelkin
Author Date: 2019-05-14 12:01:15 UTC

MDEV-16932: ASAN heap-use-after-free in my_charlen_utf8 / my_well_formed_char_length_utf8 on 2nd execution of SP with ALTER trying to add bad CHECK

In case of error the SP can be executed without re-comilation and so will reuse constructed constaint name, so the name should be allocated in the statement memory.

Author: Jan Lindström
Author Date: 2019-05-14 08:34:22 UTC

MDEV-19423: Galera test failure on galera.MDEV-16509

Make sure that SIGNALs are not overwritten before they
are received.

Author: Sergei Golubchik
Author Date: 2019-05-13 12:19:10 UTC

MDEV-15458 Segfault in heap_scan() upon UPDATE after ADD SYSTEM VERSIONING

* Versioning tests support

Closes #1043

Author: Monty
Author Date: 2019-04-15 15:16:02 UTC

MDEV-17841 S3 storage engine

A read-only storage engine that stores it's data in (aws) S3

To store data in S3 one could use ALTER TABLE:
ALTER TABLE table_name ENGINE=S3

libmarias3 integration done by Sergei Golubchik
libmarias3 created by Andrew Hutchings

Author: Monty
Author Date: 2019-04-15 15:16:02 UTC

MDEV-17841 S3 storage engine

A read-only storage engine that stores it's data in (aws) S3

To store data in S3 one could use ALTER TABLE:
ALTER TABLE table_name ENGINE=S3

libmarias3 integration done by Sergei Golubchik
libmarias3 created by Andrew Hutchings

Author: Monty
Author Date: 2019-05-13 09:58:47 UTC

Removed obsolete file maria_rename.sh

Author: Sachin Setiya
Author Date: 2019-05-13 06:29:11 UTC

empty commit 3

Author: Sergei Golubchik
Author Date: 2019-05-12 09:52:19 UTC

win

Author: Vicențiu Ciorbaru
Author Date: 2019-05-11 18:29:06 UTC

Update FSF Address

* Update wrong zip-code

Author: Sergey Vojtovich
Author Date: 2019-05-10 19:19:05 UTC

MDEV-19439 - Revert orig_thd hack

This patch is to be squashed with previous one when MDEV-19439 is fixed.
Causes assertion failurs currently.

Author: Roman Nozdrin
Author Date: 2019-05-10 15:07:36 UTC

MDEV-XXX find_select_handler now tries its best to find a handlerton that
processes the whole query. find_select_handler traverses all tables in all
SELECT_LEX_UNITs for the purpose.

Author: Monty
Author Date: 2019-05-10 12:48:33 UTC

Fixed compiler warning in pcregrep.c

Author: Sujatha
Author Date: 2019-05-10 12:37:46 UTC

Master + Slave fixes

Author: Ubuntu
Author Date: 2018-04-15 23:46:54 UTC

changed mysql-client so as to not exit upon receiving SIGINT, windows needs work

Author: Anel Husakovic
Author Date: 2019-05-08 13:40:37 UTC

MDEV 1930 Sphinx unable to connect using a host name

- Enable the test `sphinx.sphinx` which was disabled by MDEV 10986,
  comit ee0094d2fd48dac0c
- ADd test case to `sphinx.sphinx` to cover host as localhost instead of 127.0.0.1
- Add result file for single test

Author: Daniel Bartholomew
Author Date: 2019-05-07 20:41:07 UTC

bump the VERSION

Author: Vladislav Vaintroub
Author Date: 2019-05-07 17:05:58 UTC

MDEV-19403 Remove mysql_secure_installation.pl

Author: Jan Lindström
Author Date: 2019-05-07 09:51:59 UTC

MDEV-19405: Galera test failure on galera_parallel_autoinc_largetrx

Test case was not stable. Fixed also galera_parallel_autoinc_manytrx
as it has the same problem.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-05-07 08:52:15 UTC

MDEV-13542 Crashing on a corrupted page is unhelpful

Problem:
=========
One of the purge thread access the corrupted page and tries to remove from
LRU list. In the mean time, other purge threads are waiting for same page
in buf_wait_for_read(). Assertion(buf_fix_count == 0) fails for the
purge thread which tries to remove the page from LRU list.

Solution:
========
- Set the page id as FIL_NULL to indicate the page is corrupted before removing
the block from LRU list. Acquire hash lock for the particular page id and
wait for the other threads to release buf_fix_count for the block.

- Added the error check for btr_cur_open() in row_search_on_row_ref().

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-05-07 07:23:50 UTC

MDEV-13893 encryption.innodb-redo-badkey failed in buildbot with page cannot be decrypted

- Remove the warning that shows "copy of doublewrite buffer page is
corrupted" from buf_dblwr_process().

Author: Alexey Botchkov
Author Date: 2019-05-07 06:26:55 UTC

MDEV-18661

lock_atomic initialization added.

Author: Jan Lindström
Author Date: 2019-05-07 06:10:56 UTC

MDEV-19404: Assertion failure on !is_thread_specific || (mysqld_server_initialized && thd)

In wsrep_plugins_post_init we iterate all theads and if they are
galera appliers (wsrep_applier) we init session variables. However,
current_thd was not set and recent changes on session variables
require holding LOCK_gloal_system_variables mutex.

Author: Oleksandr Byelkin
Author Date: 2019-05-06 20:31:46 UTC

Let us close library and only then free defaults.

Author: Igor Babaev
Author Date: 2019-05-06 18:14:39 UTC

MDEV-18689 Simple query with extra brackets stopped working

Parenthesis around table names and derived tables should be allowed
in FROM clauses and some other context as it was in earlier versions.

Returned test queries that used such parenthesis in 10.3 to their
original form. Adjusted test results accordingly.

Author: Alexey Botchkov
Author Date: 2019-05-05 19:48:52 UTC

MDEV-18661 oading the audit plugin causes performance regression.

LOCK_plugin mutex changed to be rwlock.

Author: Varun Gupta
Author Date: 2019-05-03 21:51:42 UTC

MDEV-18373: DENSE_RANK is not calculated correctly

Need to call split_sum_func if an aggregate function is part of order by
or partition by clause so that we have the required fields inside the temporary
table, as all the fields inside the partition by and order by clause of the
window function needs to be there in the temp table used for window function
computation.

Author: Kentoku SHIBA
Author Date: 2019-05-01 05:46:23 UTC

MDEV-18990 Wrong result when binary column is used as a condition in hexadecimal mode

Author: seppo
Author Date: 2019-05-03 07:13:32 UTC

MDEV-18552 MDEV-18699 allowing SR only in galera 4 cluster (#1293)

Streaming replication must be allowed only in a cluster, where all nodes
have Galera 4 capability

Author: Kentoku SHIBA
Author Date: 2019-05-02 19:10:35 UTC

MDEV-18994 Fix the bug encountered when the size of (v1,v2,v3...) value list in “select * from tb where id in (v1, v2, v3...)” is greater than 1000
Some engines need to avoid in optimization.

Author: Kentoku SHIBA
Author Date: 2019-05-02 19:10:35 UTC

MDEV-18994 Fix the bug encountered when the size of (v1,v2,v3...) value list in “select * from tb where id in (v1, v2, v3...)” is greater than 1000
Some engines need to avoid in optimization.

Author: Jan Lindström
Author Date: 2019-05-02 11:07:24 UTC

MDEV-17883: CREATE TABLE IF NOT EXISTS locking changes in 10.3.10

Based on pull request https://github.com/MariaDB/server/pull/999
by mkaruza@galeracluster.com

Author: Anel Husakovic
Author Date: 2018-11-09 14:12:43 UTC

MDEV-17654 Incorrect syntax returned for column with CHECK constraint in the "SHOW CREATE TABLE ..." result

Prepend COMMENT before CHECK constraint in SHOW CREATE

Closes #924

Author: Vladislav Vaintroub
Author Date: 2019-02-13 09:57:54 UTC

MDEV-18531 : remove extra/yassl

Author: Kentoku SHIBA
Author Date: 2019-04-30 17:04:37 UTC

MDEV-17204 Mariadb 10.3.9 Spider DB SQL Alias no execute

Author: midenok
Author Date: 2019-04-30 10:29:40 UTC

MDEV-19349 mysql_install_db: segfault at tmp_file_prefix check

Author: Anel Husakovic
Author Date: 2019-04-24 10:21:08 UTC

Enable reading Mysql json type only for alter force

- Used ALTER_RECREATE flag from lex
- Added test case
- Problem: changed .frm file with alter force HOW and WHY ?

Author: Robert Bindar
Author Date: 2019-04-24 06:00:59 UTC

MDEV-17709 Remove handlerton::state

Author: Vladislav Vaintroub
Author Date: 2019-04-29 20:57:21 UTC

MDEV-19243 Fix timezone handling on Windows to report standard timezone names

Author: Sergei Golubchik
Author Date: 2019-04-29 20:15:56 UTC

MDEV-14938 make buildbot to include galera into bintars

Author: Kentoku SHIBA
Author Date: 2019-04-29 15:47:40 UTC

MDEV-17402 slave_transaction_retry_errors="12701" won't be enabled
error code 12701 is already included in default value, but other plugin specific error codes are ignored because of checking with ER_ERROR_LAST. ER_ERROR_LAST does not include plugin specific error codes. So I just removed it for fixing this issue.

Author: Alexander Barkov
Author Date: 2019-04-04 12:36:08 UTC

MDEV-274 The data type for IPv6/IPv4 addresses in MariaDB

Author: Jan Lindström
Author Date: 2019-04-27 06:18:11 UTC

Fix compiler errors/warnings and use os_wait_event for
key rotation list.

Author: Vladislav Vaintroub
Author Date: 2019-04-25 16:51:28 UTC

MDEV-19265 Server should throw warning if event is created and event_scheduler = OFF

Author: Vlad Lesin
Author Date: 2019-04-25 20:36:42 UTC

One more compilation error fix for c++11 in runtime code

Author: Marko Mäkelä
Author Date: 2019-04-26 14:55:35 UTC

WIP: MDEV-17603 REPLACE and INSERT…ON DUPLICATE KEY UPDATE are deadlock-prone

Implement an alternative fix for the bug whose original fix
mysql/mysql-server@c93b0d9a972cb6f98fd445f2b69d924350f9128a
in MySQL 5.7.4 caused problems.

This is based on
mysql/mysql-server@e0e4bacddf421550baca3578bc0db13693874fdb
in MySQL 5.7.26.

When performing a rollback to the start of the current row
operation in REPLACE or INSERT...ON DUPLICATE KEY UPDATE
we were not maintaining serializability, because we would
release implicit locks that could already have been acquired
for some of the indexes.

lock_rec_convert_impl_to_expl_for_trx(): Declare globally.

undo_node_t::convert_impl_to_expl(): Convert an implicit lock
to an explicit one during a partial rollback.

row_insert_for_mysql(): Set trx->duplicates=ULINT_UNDEFINED
for rolling back the current row operation. This will allow
undo_node_t::convert_impl_to_expl() to be effective only
for this use case, not for other scenarios, such as
rolling back to the start of the statement, or
ROLLBACK TO SAVEPOINT.

FIXME: Neither innodb.auto_increment_dup,log-bin nor the
upstream fix (which we did not add) innodb.iodku pass.
While the undo_node_t::convert_impl_to_expl() is working
as intended, what happens in innodb.auto_increment_dup,log-bin
is that the newly created explicit record lock for the record
heap number 6 on the PRIMARY key root page (3) will be released
when that record is deleted moments later, with the following
stack trace:

lock_rec_reset_nth_bit
lock_rec_reset_and_release_wait_low
lock_rec_reset_and_release_wait
lock_update_delete
btr_cur_optimistic_delete_func
row_undo_ins_remove_clust_rec
row_undo_ins
row_undo
row_undo_step
que_thr_step
que_run_threads_low
que_run_threads
trx_rollback_to_savepoint_low
trx_rollback_to_savepoint
row_mysql_handle_errors
row_insert_for_mysql

The idea might work with predicate locks, which we do not have.
This entire scenario could also be fixed by MDEV-16232, which
could allow the entire operation to be protected with page latches.

Author: Sergei Golubchik
Author Date: 2019-04-26 06:55:37 UTC

fix the test for embedded

Author: Alexander Barkov
Author Date: 2019-04-25 05:50:01 UTC

MDEV-18452 ASAN unknown-crash in Field::set_default upon SET bit_column = DEFAULT

Field_bit for BIT(20) uses 2 full bytes in the record,
with additional 4 uneven bits in the "null bit area".

Field::set_default() called from Field_bit::set_default() erroneously
copied 3 bytes instead of 2 bytes from the record with default values.

Changing Field::set_default() to copy pack_length_in_rec() bytes
instead of pack_length() bytes.

Author: Jani
Author Date: 2019-04-24 15:09:36 UTC

Merge branch '10.3' of github.com:MariaDB/server into bb-10.3-jani

Author: Thirunarayanan Balathandayuthapani
Author Date: 2019-04-24 11:31:42 UTC

MDEV-19229 Increase the undo log tablespace during startup

Basically it avoids the accessing of TRX_SYS page before reading the
redo log. I have to change few test case failure.

Todo:
=====
- Remove the duplicate code in fill_metadata and read_page0 of fil_node_t
- Remove the parameter in srv_validate_undo_tablespaces()
- Remove the un-necessary code in srv_undo_tablespaces_init()
- Name the newly introduced function properly.
- Working on dynamic change of innodb_undo_tablespaces.

Author: Rasmus Johansson
Author Date: 2019-04-24 03:04:43 UTC

Another comment to cause a file change for buildbot

Author: Alexander Barkov
Author Date: 2019-04-23 09:45:28 UTC

MDEV-9234 Add Type_handler::union_element_finalize()

Author: Monty
Author Date: 2019-01-26 15:27:20 UTC

MDEV-18465 Logging of DDL statements during backup

Many of the changes was needed to be able to collect and print engine
name and table version id's in the ddl log.

Other things:
- Removed not used flag NO_FRM_RENAME
- Backup START now waits for running or waiting DDL's to complete
- Added test that CREATE VIEW is blocked by BLOCK_DDL
- ha_resolve_storage_engine_name() now also works for views

Author: Andrei Elkin
Author Date: 2019-04-17 12:32:30 UTC

MDEV-18096 The server would crash when has configs rpl_semi_sync_master_enabled = OFF rpl_semi_sync_master_wait_no_slave = OFF

The patch fixes a fired assert in the semisync master module. The assert
caught attempt to switch semisync off (per rpl_semi_sync_master_wait_no_slave = OFF)
when it was not even initialized (per rpl_semi_sync_master_enabled = OFF).
The switching-off execution branch is relocated under one that executes
enable_master() first.

A minor cleaup is done to remove the int return from two functions that
did not return anything but an error which could not happen in the functions.

Author: Sergey Petrunia
Author Date: 2019-04-18 17:56:56 UTC

MDEV-17297: stats.records=0 for a table of Archive engine when it has rows, when we run ANALYZE command

Archive storage engine assumed that any query that attempts to read from
the table will call ha_archive::info() beforehand. ha_archive would flush
un-written data in that call (this would make it visible for the reads).

Break this assumption. Flush the data when the table is opened for reading.

This way, one can do multiple write statements without causing a flush, but
as soon as we might need the data, we flush it.

Author: Sergey Petrunia
Author Date: 2019-04-18 15:56:14 UTC

MDEV-19266: Crash in EITS code when enabling 128 indexes

Do not attempt to set param->table->with_impossible_ranges if the
range optimizer is using pseudo-indexes (which is true when we are
computing EITS selectivity estimates or doing partition pruning).

Author: Vladislav Vaintroub
Author Date: 2019-04-18 04:50:59 UTC

MDEV-19274 mariadb does not build on OSes that do not have HAVE_POOL_OF_THREADS

Do not try to compile threadpool_common.cc, if threadpool is not available
on current OS.

Also introduced undocumented/uncached CMake variable DISABLE_THREADPOOL,
to emulate builds on exotic OSes.

Author: Kentoku SHIBA
Author Date: 2019-04-17 12:25:12 UTC

MDEV-19238 Mariadb spider - crashes on where null

Author: Sujatha Sivakumar
Author Date: 2019-04-17 10:00:09 UTC

MDEV-17260: Memory leaks in mysqlbinlog

Problem:
========
The mysqlbinlog tool is leaking memory, causing failures in various tests when
compiling and testing with AddressSanitizer or LeakSanitizer like this:

cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source
make -j$(nproc)
cd mysql-test
ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog

CURRENT_TEST: rpl.rpl_row_mysqlbinlog

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87)
#1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10
#2 0x5300dd in Log_event::read_log_event(char const*, unsigned int, char const**,
   Format_description_log_event const*, char) /mariadb/5.5/sql/log_event.cc:1568:
#3 0x564a9c in dump_remote_log_entries(st_print_event_info*, char const*)
/mariadb/5.5/client/mysqlbinlog.cc:1978:17

Analysis:
========
'mysqlbinlog' tool is being used to read binary log events from a remote server.
While reading binary log, if a fake rotate event is found following actions are
taken.

If 'to-last-log' option is specified, then fake rotate event is processed.
In the absence of 'to-last-log' skip the fake rotate event.

In this skipped case the fake rotate event object is not getting cleaned up
resulting in memory leak.

Fix:
===
Cleanup the fake rotate event.

This issues is already fixed in MariaDB 10.0.23 and higher versions as part of
commit c3018b0ff4fb02c029787d03867adf0530607bab

Author: Kentoku SHIBA
Author Date: 2019-03-12 22:40:33 UTC

MDEV-16508 spider: sql_mode not maintained between spider node and data nodes
Add the following parameter.

- spider_sync_sql_mode
  Local sql_mode synchronous existence to remote server.
   0 : It doesn't synchronize.
   1 : It synchronizes.
  The default value is 1

Author: Alexander Barkov
Author Date: 2019-04-16 04:20:57 UTC

MDEV-19256 sql_acl.cc does not compile with WITH_VALGRIND with gcc 8.0

Turning initializing code into constructors.

Author: Vladislav Vaintroub
Author Date: 2019-04-15 14:54:48 UTC

Fix test case

Author: Vladislav Vaintroub
Author Date: 2019-04-15 11:28:10 UTC

threadpool : Make throttling interval depend on thread_pool_stall_limit

A thread_pool_stall_limit which is smaller than default would result
in quicker creation of threads.

Author: Kentoku SHIBA
Author Date: 2019-04-11 09:03:22 UTC

MDEV-19003 ignore send <cache> to remote
It's just added regression tests.

Author: Alexey Botchkov
Author Date: 2019-04-08 11:33:28 UTC

MDEV-7974 SA transactions.

Failing tests added.

Author: Kentoku SHIBA
Author Date: 2019-04-06 16:39:54 UTC

MDEV-18987 bug in "load data local infile xxx replace into "
It's just added regression tests.

Author: Kentoku SHIBA
Author Date: 2019-04-04 21:23:57 UTC

MDEV-7795 Merge vertical partitioning storage engine

Author: Robert Bindar
Author Date: 2019-04-04 13:02:03 UTC

MDEV-17978 Server crash in SHOW CREATE SEQUENCE on a broken view

The crashed was caused by an invalid access for TABLE_SHARE::table
in mysqld_show_create_get_fields.

Author: Vladislav Vaintroub
Author Date: 2019-04-04 12:10:13 UTC

MDEV-17610 Unexpected connection abort after certain operations from within stored procedure

Always set SERVER_MORE_RESULTS_EXIST when executing stored procedure statements

If statements produce a result, EOF packet needs this flag (SP ends
with an OK packet). IF statetement does not produce a result, affected rows
count are part of the final OK packet.

Author: Robert Bindar
Author Date: 2019-04-04 08:58:50 UTC

MDEV-13010 NEXTVAL should increment only once for a given row

According to the standard, multiple increment operations in a single
SQL statement should advance the sequence only once.