Author: Jan Lindström
Author Date: 2018-04-24 10:34:57 UTC

Merge tag 'mariadb-5.5.60' into 5.5-galera

Author: Marko Mäkelä
Author Date: 2018-04-24 10:16:08 UTC

Merge 10.2 into 10.3

Author: Oleksandr Byelkin
Author Date: 2018-04-24 10:04:59 UTC

MDEV-13695: INTERSECT precedence is not in line with Oracle even in SQL_MODE=Oracle

Switch off automatic INTERSECT priority for ORACLE MODE

Author: Marko Mäkelä
Author Date: 2018-04-24 10:00:09 UTC

Pull request #522: Remove C++ register keyword

Author: Alexey Botchkov
Author Date: 2018-04-24 09:17:16 UTC

PCRE2 used.

Author: Oleksandr Byelkin
Author Date: 2018-04-23 10:09:10 UTC

MDEV-15079: Parameter array operation inserts wrong values in autoincrement field if indicator was specified

test added (bug is fixed)

Author: Oleksandr Byelkin
Author Date: 2018-04-24 08:06:31 UTC

Merge branch '10.3' into bb-10.3-MDEV-10814

Author: Marko Mäkelä
Author Date: 2018-04-24 06:26:40 UTC

Merge 10.0 into 10.1

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-04-24 06:18:22 UTC

MDEV-14168 Unconditionally allow ALGORITHM=INPLACE for setting a column NOT NULL

- Allow NOT NULL constraint to replace the NULL value in the row with
explicit or implicit default value.

- If the default value is non-const value then inplace alter won't
support it.

- ALTER IGNORE will ignore the error if the concurrent DML contains
NULL value.

Author: Jacob Mathew
Author Date: 2018-04-24 05:00:27 UTC

MDEV-15712: If remote server used by Spider table is unavailable, some operations hang for a long time

When an attempt to connect to the remote server fails, Spider retries to
connect to the remote server 1000 times or until the connection attempt
succeeds. This is perceived as a hang if the remote server remains
unavailable.

I have introduced changes in Spider's table status handler to fix this problem.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Sergei Golubchik
Author Date: 2018-04-16 21:10:23 UTC

MDEV-14853 Grant does not work correctly when table contains SYSTEM_I…
…NVISIBLE or COMPLETELY_INVISIBLE

don't check privileges on INVISIBLE_SYSTEM columns,
they're always accessible

Author: Sergei Golubchik
Author Date: 2018-04-18 12:29:48 UTC

MDEV-14820 System versioning is applied incorrectly to CTEs

Make sure that SELECT_LEX_UNIT::derived, behaves as documented
(points to the "TABLE_LIST representing this union in the
embedding select"). For recursive CTE this was not necessarily
the case, it could've pointed to the TABLE_LIST inside the CTE,
not in the embedding select.

To fix:
* don't update unit->derived in mysql_derived_prepare(), pass derived
  as an argument to st_select_lex_unit::prepare()
* prefer to set unit->derived in TABLE_LIST::init_derived()
  to the TABLE_LIST in the embedding select, not to the recursive
  reference. Fail if there are many TABLE_LISTs in the embedding
  select with conflicting FOR SYSTEM_TIME clauses.

cleanup:
* remove redundant THD* argument from st_select_lex_unit::prepare()

Author: Daniel Bartholomew
Author Date: 2018-04-23 16:25:03 UTC

bump the VERSION

Author: Galina Shalygina
Author Date: 2018-04-23 15:50:11 UTC

MDEV-12387 Push conditions into materialized subqueries

The method join_equalities_after_optimize_cond() changed and renamed.
Some comments changed.

Author: Marko Mäkelä
Author Date: 2018-04-23 13:19:50 UTC

MDEV-15723 Crash in INFORMATION_SCHEMA.INNODB_SYS_TABLES when accessing corrupted record

dict_load_table_low(): When flagging an error, assign *table = NULL.
Failure to do so could cause a crash if an error was flagged when
accessing INFORMATION_SCHEMA.INNODB_SYS_TABLES.

Author: Jan Lindström
Author Date: 2018-04-23 05:11:21 UTC

Merge branch 'codership-MDEV-15948' into 10.1

Author: Sergei Golubchik
Author Date: 2018-04-22 11:13:10 UTC

Merge tracking branch 'merge-perfschema-5.6' into 10.0

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-04-21 03:27:38 UTC

Problem:
=======
InnoDB cleans all temporary undo logs during commit. During rollback
of secondary index entry, InnoDB tries to build the previous version
of clustered index. It leads to access of freed undo page during
previous transaction commit and it leads to undo log corruption.

Solution:
=========
During rollback, temporary undo logs should not try to build
the previous version of the record.

Author: varun
Author Date: 2018-04-20 16:59:02 UTC

MDEV-15777: Support Early NULLs filtering-like restrictions in the range optimizer

Introduced a null_rejecting_cond field inside TABLE structure, which would hold the
null rejecting condition created for each of the table for range analysis.

Author: Oleksandr Byelkin
Author Date: 2018-04-18 17:34:12 UTC

MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info

Added metadate info after prepare EXPLAIN/ANALYZE.

Author: Sergei Golubchik
Author Date: 2018-04-19 23:04:43 UTC

Merge branch 'merge/merge-xtradb-5.5' into 5.5

Author: Sergey Petrunia
Author Date: 2018-04-19 13:28:05 UTC

Post-merge fixes: make rocksdb.allow_to_start_after_corruption pass

Author: Andrei Elkin
Author Date: 2018-04-18 10:04:46 UTC

MDEV-13727 rpl.rpl_concurrency_error failed

The test actually revealed a flaw in MDEV-8305
which inadvertently enrolled the trigger and
stored function into slow query reporting aimed exclusively
to the stored procedure.
Specifically to the test, a query on the master was logged
with a timestamp of the query's top-level statement but its (post
update) trigger computed one more (later) timestamp which got
inserted into another table.

Master-vs-slave discrepancy became evident thanks to
different execution time of the trigger combined with the fact of the
logged master timestamp in the micro-second fraction format was
truncated on the slave. The latter means the slave execution of the query
always started earlier than on the master as far as the timestamp was concerned.
And when the fractional part was close to 1 the 2nd timestamp acquired by
MDEV-8305 piece of logics could overflow to next integer value.
That's how the master table appeared to be temporarly behind the slave's one.

Fixed with restoring the pre-MDEV-8305 behavior not to reset
the current statement's timestamp when the query is not from a stored procedure.
That is the trigger's or stored function's queries continue to use
the top-level statement's timestamp as they are supposed to.

Author: Jan Lindström
Author Date: 2018-04-18 08:35:31 UTC

MDEV-15308: Assertion `ha_alter_info->alter_info->drop_list.elements > 0' failed in ha_innodb::prepare_inplace_alter_table

Problem was thet when items were removed from drop_list alter_info
flags were not adjusted accordingly in all cases.

Author: Michael Widenius
Author Date: 2018-04-12 06:28:29 UTC

Change read_to_buffer to use ulong instead of uint

This is mostly to document that read_to_buffer can read more than 65K.
Also changed merge_buffers to return bool instead of int

Author: Sergei Golubchik
Author Date: 2018-04-16 21:14:28 UTC

MDEV-15746 ASAN heap-use-after-free in Item_change_list::rollback_item_tree_changes on ALTER executed as PS

don't try to convert a default value string from a user character set
into a column character set, if this particular default value string did
not came from the user at all (that is, if it's an ALTER TABLE and the
default value string is the *old* default value of the unaltered
column).

This used to crash, because old defaults are allocated on the old
table's memroot, which is freed mid-ALTER when the old table is closed.
So thd->rollback_item_tree_changes() at the end of the ALTER was writing
into the freed memory.

Author: Sergei Golubchik
Author Date: 2018-04-16 22:44:34 UTC

ASAN error in is_stat_table()

don't memcmp beyond the first argument's end

Also:
  use my_strcasecmp(table_alias_charset), like elsewhere, not memcmp

Author: Vladislav Vaintroub
Author Date: 2018-04-15 14:29:55 UTC

Innodb cleanup - make Innodb merge temp tables use pfs_os_file_t for
file IO, rather than int.

On Windows, it is suboptimal to depend on C runtime, as it has limited
number of file descriptors. This change eliminates
os_file_read_no_error_handling_int_fd(), os_file_write_int_fd(),
OS_FILE_FROM_FD() macro.

Author: Jan Lindström
Author Date: 2018-04-16 12:06:41 UTC

MDEV-13516: encryption.create_or_replace test fails in buildbot with InnoDB assertion failure

fil_crypt_rotate_pages
 If tablespace is marked as stopping stop also page rotation

fil_crypt_flush_space
 If tablespace is marked as stopping do not try to read
 page 0 and write it back.

Author: Jacob Mathew
Author Date: 2018-04-14 00:51:51 UTC

MDEV-15698: Spider ignores syntax errors in connection string in COMMENT field

When a comma separator is missing between COMMENT fields, Spider ignores the
parameter values that are beyond the last expected parameter value. There are
also some error messages that Spider does generate on COMMENT fields that are
incorrectly formed.

I have introduced additional infrastructure in Spider to fix these problems.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Sergei Golubchik
Author Date: 2018-04-13 19:46:12 UTC

disable failing galera test for now

Author: Sergei Golubchik
Author Date: 2018-04-13 19:46:12 UTC

disable failing galera test for now

Author: Daniel Black
Author Date: 2018-01-19 08:09:05 UTC

MDEV-13336: mysqldump --ignore-database address review comments

Author: Jan Lindström
Author Date: 2018-04-13 09:44:11 UTC

Merge branch 'codership-10.2-fix-mtr-wait' into 10.2

Author: Oleksandr Byelkin
Author Date: 2018-04-12 12:55:43 UTC

MDEV-13699: Assertion `!new_field->field_name.str || strlen(new_field->field_name.str) == new_field->field_name.length' failed in create_tmp_table on 2nd execution of PS with semijoin

The problem was that SJ (semi-join) used secondary list (array) of subquery select list. The items there was prepared once then cleaned up (but not really freed from memory because it was made in statement memory).
Original list was not prepared after first execution because select was removed by conversion to SJ.
The solution is to use original list but prepare it first.

Author: Vladislav Vaintroub
Author Date: 2018-04-11 22:07:23 UTC

MDEV-15780 : Mariabackup with absolute paths in innodb_data_file_path

System tablespace can be specified with absolute path, if innodb_data_home_dir
is empty.

This was not handled well by mariabackup

1. In backup phase, empty innodb_data_home_dir variable from server was
not recognized. full paths were stored in backup-my.ini, even if
it stored all files locally. thus prepare phase would not find the system
tablespace files.

2. In copy-back phase, copy would not be done to the absolute destination
path, as path would be stripped with trim_dotslash

This patch fixes the above defects.

Author: Vicențiu Ciorbaru
Author Date: 2018-04-12 00:30:43 UTC

Merge remote-tracking branch 'origin/10.3' into bb-10.3-vicentiu

Author: Brauge
Author Date: 2018-03-30 09:23:28 UTC

MDEV-15739 sql_mode=ORACLE: Make LPAD and RPAD return NULL instead of empty string

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-04-10 13:58:20 UTC

MDEV-13134 Introduce ALTER TABLE attributes ALGORITHM=NOCOPY and ALGORITHM=INSTANT

- Introduced new algorithm type called NOCOPY & INSTANT for
inplace alter operation.

NOCOPY - Algorithm refuses any alter operation that would
rebuild the clustered index. It is a subset of INPLACE algorithm.

INSTANT - Algorithm allow any alter operation that would
modify only meta data. It is a subset of NOCOPY algorithm.

- Introduce new variable called alter_algorithm. The values are
DEFAULT(0), COPY(1), INPLACE(2), NOCOPY(3), INSTANT(4)

- Message for deprecate old_alter_table variable and make alias
to alter_algorithm.

Author: Vicențiu Ciorbaru
Author Date: 2018-04-09 21:54:58 UTC

Update test cases and fix innodb merge problem with trx_roll_report_progress

Author: Vicențiu Ciorbaru
Author Date: 2018-04-09 17:00:42 UTC

Fix printing of line numbers when using addr2line

When starting a binary that's inside the PATH variable without
specifying a complete path, dladdr will return just that binary name,
without any extra path information. Make use of /proc/self/exe if it's
available to resolve it.

Author: sachin
Author Date: 2018-04-08 16:55:37 UTC

MDEV-15611 Due to the failure of foreign key detection, Galera...
slave node killed himself.

Problem:- If we try to delete table with foreign key and table whom it is
referring with wsrep_slave_threads>1 then galera tries to execute both
Delete_rows_log-event in parallel, which should not happen.

Solution:- This is happening because we do not have foreign key info in
write set. Upto version 10.2.7 it used to work fine. Actually it happening
because of issue in commit 2f342c4. wsrep_must_process_fk has changed to
make it similar to original condition.

Author: Alexey Botchkov
Author Date: 2018-04-08 03:57:44 UTC

FIX2

Author: Vicențiu Ciorbaru
Author Date: 2018-04-07 05:50:04 UTC

Merge branch '10.1' into bb-10.1-vicentiu

Author: Vladislav Vaintroub
Author Date: 2018-04-05 12:17:17 UTC

MDEV-15707 : deadlock in Innodb IO code, caused by change buffering.

In async IO completion code, after reading a page,Innodb can wait for
completion of other bufferpool reads.
This is for example what happens if change-buffering is active.

Innodb on Windows could deadlock, as it did not have dedicated threads
for processing change buffer asynchronous reads.

The fix for that is to have windows now has the same background threads,
including dedicated thread for ibuf, and log AIOs.

The ibuf/read completions are now dispatched to their threads with
PostQueuedCompletionStatus(), the write and log completions are processed
in thread where they arrive.

Author: Michael Widenius
Author Date: 2018-04-05 12:16:20 UTC

MDEV-14762 Server crashes in MDL_ticket::has_stronger_or_equal_type upon inserting into temporary sequence

Fix is to not upgrade MDL locks for temporary tables

Author: Jan Lindström
Author Date: 2018-04-06 04:31:44 UTC

Merge pull request #557 from grooverdan/10.0-galera-wsrep_sst_mysqldump-safety

MDEV-15023 - wsrep_sst_mysqldump: safer test of version != 5

Author: Jacob Mathew
Author Date: 2018-04-05 21:23:31 UTC

MDEV-15692: install_spider.sql can fail with some collations

The error occurs because of how the character set and collation are chosen for
stored procedure parameters that have a character data type. If the character
set and collation are not explicitly stated in the declaration, the server
chooses the database character set and collation in effect at routine creation
time.

To fix the problem, I added explicit character set and collation attributes
for the stored procedure parameters in the install_spider.sql script.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Vladislav Vaintroub
Author Date: 2018-04-05 20:39:28 UTC

MDEV-77 : deadlock in Innodb IO code, caused by change buffering.

In async IO completion code, after reading a page,
Innodb can do other async reads, and wait for completion of these reads.
This is for example what happens when change-buffering changes need to be
merged during page load.

Innodb on Windows could deadlock, as it did not have dedicated threads
for processing change buffer asynchronous reads.

The fix for that is to have windows now has the same background threads,
including dedicated thread for ibuf, and log AIO. As before, all IO
completions arrive to write threads. From there they are dispatched via
PostQueuedCompletionStatus to read/buf/log processing threads.

Author: Sergey Vojtovich
Author Date: 2018-04-05 13:36:59 UTC

Fix misuse of MY_CHECK_CXX_COMPILER_FLAG

- compile_flags already include from top CMakeLists.txt
- MY_CHECK_CXX_COMPILER_FLAG() accepts only one parameter
- output variable of MY_CHECK_CXX_COMPILER_FLAG() is have_CXX__Wa__nH
- same check for mariabackup

Based on contribution by satanson (PR#466).

Author: varun
Author Date: 2018-04-04 13:34:14 UTC

MDEV-15241: make SIGNAL maximum MESSAGE_TEXT length a larger value

Increasing the length of MESSAGE_TEXT from 128 to MYSQL_ERRMSG_SIZE which is the max length of the
error message

Author: Jan Lindström
Author Date: 2018-04-04 09:47:23 UTC

MDEV-15566: System tablespace does not easily key rotate to unencrypted

Problem was that key rotation from encrypted to unecrypted was skipped
when encryption is disabled.

fil_crypt_needs_rotation
 If encryption is disabled and there is tablespaces using
 default encryption (e.g. system tablespace) that are still
 encrypted state we need to rotate them from encrypted state
 to unencrypted state.

Author: Jacob Mathew
Author Date: 2018-04-02 22:25:08 UTC

MDEV-7914: spider/bg.ha, spider/bg.ha_part crash server sporadically in buildbot

The crash occurs when a thread that is closing its connection attempts to
access Spider transaction information when another thread has freed that memory
while processing Spider plugin deinit. This occurs because Spider does not
adjust the plugin's reference count when it sets a transaction information
pointer for the plugin.

The fix I implemented changes the way Spider sets the transaction information
pointer to use thd_set_ha_data() so that Spider's plugin reference counter is
adjusted as well.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Vicențiu Ciorbaru
Author Date: 2018-04-03 15:08:30 UTC

Merge branch '5.5' into 10.0

Author: Vicențiu Ciorbaru
Author Date: 2018-04-02 21:36:01 UTC

Force rebuild

Author: Vicențiu Ciorbaru
Author Date: 2018-04-02 21:07:58 UTC

Force build?

Author: Sergey Vojtovich
Author Date: 2018-04-02 17:18:04 UTC

fixup! increase upper value of max_prepared_stmt_count to UINT32_MAX

Author: varun
Author Date: 2018-04-02 10:14:30 UTC

MDEV-9744: session optimizer_use_condition_selectivity=5 causing SQL Error (1918):
           Encountered illegal value '' when converting to DECIMAL

The issue was that EITS data was allocated but then not read for some reason (one being to avoid a deadlock),
then the optimizer was using these bzero'ed buffers as EITS statistics.
This should not be allowed, we should use statistcs for a table only when we have successfully loaded/read
the stats from the statistical tables.

Author: Igor Babaev
Author Date: 2018-04-01 22:23:12 UTC

Refactored some code.

Author: Jan Lindström
Author Date: 2018-03-28 13:07:52 UTC

Merge branch 'MDEV-13549-fixes-for-galera_gtid_slave' of https://github.com/codership/mariadb-server into codership-MDEV-13549-fixes-for-galera_gtid_slave

Author: Jan Lindström
Author Date: 2018-03-28 05:55:06 UTC

Merge branch 'codership-MDEV-13549-fixes-for-galera_as_master' into 10.1

Author: varun
Author Date: 2018-03-28 05:54:35 UTC

MDEV-14592: Custom Aggregates Usage Status Variable

Introduced new status variable for custom aggregate functions

Author: Vladislav Vaintroub
Author Date: 2018-03-27 20:10:17 UTC

MDEV-15694 Windows : use GetSystemTimePreciseAsFileTime if available for high resolution time

Use high accuracy timer on Windows 8.1+ for system versioning,it needs
accurate high resoution start query time.

Continue to use the inaccurate (but much faster timer function)
GetSystemTimeAsFileTime() where accuracy does not matter, e.g in
set_timespec_time_nsec(),or my_time()

Author: Jan Lindström
Author Date: 2018-03-27 14:11:09 UTC

Merge branch 'codership-MDEV-13549-fixes-for-galera_suspend_slave' into 10.1

Author: Oleksandr Byelkin
Author Date: 2018-03-27 06:42:31 UTC

Walking throuch query tables ON expression added.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-03-27 05:53:27 UTC

MDEV-15325 Incomplete validation of missing tablespace during recovery

Problem:
=======
 During validation of missing tablespace, missing tablespace id is
being compared with hash table of redo logs (recv_sys->addr_hash). But if the
hash table ran out of memory then there is a possibility that it will not contain
the redo logs of all tablespace. In that case, Server will load the InnoDB
even though there is a missing tablespace.

Solution:
========
 If the recv_sys->addr_hash hash table ran out of memory then InnoDB needs
to scan the remaining redo log again to validate the missing tablespace.

Author: sachin
Author Date: 2018-03-26 22:26:10 UTC

MDEV-10259 mysqld crash with certain statement length and...
order with Galera and encrypt-tmp-files=1

Problem:- If trans_cache (IO_CACHE) uses encrypted tmp file
then on next DML server will crash.

Case:-
 Lets take a case , we have a table t1 , We try to do 2 inserts in t1
  1. A really long insert so that trans_cache has to use temp_file
  2. Just a small insert

Analysis:- Actually server crashes from inside of galera
library.
/lib64/libc.so.6(abort+0x175)[0x7fb5ba779dc5]
/usr/lib64/galera/libgalera_smm.so(_ZN6galera3FSMINS_9TrxHandle5State...
mysys/stacktrace.c:247(my_print_stacktrace)[0x7fb5a714940e]
sql/signal_handler.cc:160(handle_fatal_signal)[0x7fb5a715c1bd]
sql/wsrep_hton.cc:257(wsrep_rollback)[0x7fb5bcce923a]
sql/wsrep_hton.cc:268(wsrep_rollback)[0x7fb5bcce9368]
sql/handler.cc:1658(ha_rollback_trans(THD*, bool))[0x7fb5bcd4f41a]
sql/handler.cc:1483(ha_commit_trans(THD*, bool))[0x7fb5bcd4f804]

but actual issue is not in galera but in mariadb, because for 2nd
insert we should never call rollback. We are calling rollback because
log_and_order fails it fails because write_cache fails , It fails
because after reinit_io_cache(trans_cache) , my_b_tell says 0 so we
look into tmp_file for data , which is obviously wrong since temp
was used for previous insert and it no longer exist.

Solution:- There is two issue in my_b_encr_read
1st we should never equal read_end to info->buffer. I mean this
does not make sense read_end should always point to end of buffer.
2nd For most of the case(apart from async IO_CACHE) info->pos_in_file
should be equal to info->buffer position wrt to temp file , since
in this case we are not changing info->buffer it should remain unchanged.

Author: varun
Author Date: 2018-03-26 21:18:55 UTC

MDEV-9959: A serious MariaDB server performance bug

Step #2: If any field in the select list of the derived tables is present in the group by list also , then we are again guaranteed that ref access to the derived table would always produce one row per key.

Author: Monty
Author Date: 2018-03-25 10:38:12 UTC

disable some galera tests that fails regurarly

Author: varun
Author Date: 2018-03-23 22:01:18 UTC

MDEV-11274: Executing EXPLAIN of complex query over join limit causes server to crash

For this case we have a view that is mergeable but we are not able to merge it in the
parent select because that would exceed the maximum tables allowed in the join list, so we
materialise this view
TABLE_LIST::dervied is NULL for such views, it is only set for views which have ALGORITHM=TEMPTABLE
Fixed by making sure TABLE_LIST::derived is set for views that could not be merged

Author: Sergei Golubchik
Author Date: 2018-03-25 11:02:52 UTC

Merge branch '10.1' into 10.2

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-03-23 12:14:57 UTC

MDEV-15325 Incomplete validation of missing tablespace during recovery

Problem:
=======
 During validation of missing tablespace, missing tablespace id is
being compared with hash table of redo logs (recv_sys->addr_hash). But if the
hash table ran out of memory then there is a possibility that it will not contain
the redo logs of all tablespace. In that case, Server will load the InnoDB
even though there is a missing tablespace.

Solution:
========
 If the recv_sys->addr_hash hash table ran out of memory then InnoDB needs
to scan the remaining redo log again to validate the missing tablespace.

Author: Jan Lindström
Author Date: 2018-03-22 06:51:43 UTC

MDEV-14616: WSREP has not yet prepared node for application use error

MariaDB adjustments.

mysqltest.cc : Allow 12 error codes at --error

wait_until_connected_again.inc: Replace numeric error codes with symbols

mysqltest.test: Add error codes to test that tests too many errorcodes

Author: Jan Lindström
Author Date: 2018-03-21 07:38:23 UTC

Fix test failure on galera_var_reject_queries.

Author: Alexey Botchkov
Author Date: 2018-03-20 20:28:19 UTC

MDEV-14533 Provide information_schema tables using which hardware
information can be obtained.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-03-20 15:43:50 UTC

MDEV-13561 Mariabackup is incompatible with retroactively
   created innodb_undo_tablespaces

- Mariabackup supports undo tablespace id which is greater than 1.

Author: Michael Widenius
Author Date: 2018-03-15 10:31:59 UTC

Added flush tables to acl_load_mutex-5170.test

This is needed as otherwise a lot of MyISAM tables may be marked
as crashed, depending on in which order tests are run

Author: Sergey Vojtovich
Author Date: 2018-03-20 13:25:49 UTC

MDEV-10269 - Killed queries from I_S stay in 'Killed' state for long
             time and don't let server shut down

Queries from I_S in "Filling schema table" state didn't check killed
flag. For large tables this phase may take a while to complete.

Fixed by adding thd->killed flag check for each processed row.

Author: Andrei Elkin
Author Date: 2018-03-19 13:56:01 UTC

MDEV-14014

Follow-up patch optimizes the fixes idea to combine an introduced new
new member to IO_CACHE also to serve as a flag more to a int value holder.

Author: varun
Author Date: 2018-03-19 13:03:04 UTC

MDEV-12737: tokudb_mariadb.mdev6657 fails in buildbot with different plan, and outside with valgrind warnings

Fixing the test by adding replace column for the rows column in the explain.

Author: Jacob Mathew
Author Date: 2018-03-17 02:07:32 UTC

MDEV-10991: Server crashes in spider_udf_direct_sql_create_conn - tests in spider/oracle* suites crash the server

The crash occurs due to code that is #ifdef'd out with HAVE_ORACLE_OCI that
pertains to the use of Spider with an Oracle data tier. Enabling this code
eliminates the crash.

The reason that MariaDB needs to support Oracle storage at the data tier is
to help customers migrate from Oracle. It is necessary to build Spider with
the additional build flag -DHAVE_ORACLE_OCI, and install and start Oracle
before running the Oracle test suite or any tests within it. Nevertheless,
if Spider is built normally and Oracle has not been started, these tests
should not cause the MariaDB server to crash. The bug fix replaces the
crash with the following error:
  ERROR 12501 (HY000) at line 4: The connect info 'ORACLE' is invalid

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Sergey Petrunia
Author Date: 2018-03-14 22:32:09 UTC

Apply this commit to bb-10.2-compatibility-mdev15509-debug:

commit 5511e8ed5941e3b5a7687f87a1fb4fa75815ee7b
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date: Mon Mar 5 17:43:30 2018 +0100

    MDEV-15328: MariaDB 10.2.13 Crashes upon CALL PROCEDURE PARAM LAST_INSERT_ID ()

    There is not current SELECT during assigning SP parameters, do not use it if current_select is empty.

Author: Jan Lindström
Author Date: 2018-03-14 14:13:14 UTC

MDEV-13103: InnoDB crash recovery fails to decompress a page in buf_dblwr_process()

There were several problems. Firstly, page decompression code did not handle
possible decompression errors correctly. Secondly, not all compression methods
tolerate corrupted input (e.g. lz4 did not tolerate input that was compressed
using snappy method). Finally, if page is actually also encrypted we can't
decompress page. Solutions: Add proper error handling to decompression code
and add post compression checksum to page. As whole page including page checksum
is compressed we can reuse the original checksum field for post compression
checksum. With post compression checksum we can detect most of the corruptions.
If no corruption is detected hopefully decompression code can detect
remaining problems.

Doublewrite buffer page recovery for page compressed pages require
that post compression checksum matches. For pages from old releases
supporting page compression checksum must be BUF_NO_CHECKSUM_MAGIC.

Upgrade from older versions is supported as post compression
checksum check accepts the BUF_NO_CHECKSUM_MAGIC that they stored
in checksum filed.

Downgrade to older versions is not supported (assuming that there
were some changes to compressed tables) as page compression code
would not tolerate any other checksum except BUF_NO_CHECKSUM_MAGIC.

innochecksum.cc is_page_corrupted:
    If page is compressed verify post compression checksum

buf_page_decrypt_after_read
     Return DB_PAGE_CORRUPTED if page is found to be corrupted
     after post compression checksum check.

buf_page_io_complete
     If page is found corrupted after buf_page_decrypt_after_read
     there is no need to continue page check.

buf_page_decrypt_after_read
     Verify post compression checksum before decompression and
     if it does not match mark page corrupted. Note that old
     compressed pages do not really have post compression
     checksum so they are treated as not corrupted and then
     we need to hope that decompression code can handle the
     possible corruptions by returning error.

buf_calc_compressed_crc32
     New function to calculate post compression checksum
     so that necessary compression metadata fields are
     included.

buf_dblwr_decompress
     New function that handles post compression checksum check
     and page decompression if it is ok.

buf_dblwr_process
     Verify post compression checksum before trying to decompress
     page.

fil_space_verify_crypt_checksum
     Remove incorrect code as compressed and encrypted pages
     do have post encryption checksum.

fil_compress_page
     Calculate and store post compression checksum to FIL_SPACE_OR_CHKSUM
     field as original value is stored on compressed image.

fil_decompress_page
     Add error handling if decompression fails.

fil_verify_compression_checksum
     New function to verify post compression checksum.
     Compressed tablespaces before this change have BUF_NO_CHECKSUM_MAGIC
     in checksum field and they must be treated as not corrupted.

fil_iterate
     Add post compression checksum check before actual decompression.

convert_error_code_to_mysql
      Handle also page corruptions DB_PAGE_CORRUPTED as HA_ERR_CRASHED.
      Note that there are cases when we do not know for certain
      is page corrupted, corrupted and compressed, or still encrypted
      after failed decrypt, thus tablespace could be marked just corrupted.

Tests modified
      innodb-page_compression_[zip, lz4, lzma, lzo, bzip2, snappy]
            to use innodb-page-compression.inc
      innodb-page-compression.inc add innochecksum and intentional tablespace
            corruption tests.
      innodb-force-corrupt, innodb_bug14147491 add new error
            messages to mtr suppression and new error codes.

New tests
      encryption/innodb-corrupted.test test intentionally corrupted
            tablespaces containing encryption and compression.
      doublewrite-compressed test doublewrite recovery for page
            compressed tables
      innodb-import import files from both big_endian and little_endian
            machine

Author: Jan Lindström
Author Date: 2018-03-14 08:29:47 UTC

Merge pull request #637 from grooverdan/5.5-galera

MDEV-8743: use CLOEXEC to protect mariadb files from sst script touching

Author: Jacob Mathew
Author Date: 2018-03-13 23:15:37 UTC

Merge branch '10.2' into bb-10.2-MDEV-14019

Author: Alexander Barkov
Author Date: 2018-03-13 10:22:28 UTC

Merge pull request #652 from halfspawn/bb-10.2-ext

MDEV-10574 / SUBSTR - sql_mode=Oracle: return null instead of empty string

Author: Jan Lindström
Author Date: 2018-03-13 08:12:24 UTC

MDEV-15032: Encrypted database created on big endian machine cannot be used on little endian machine

Problem was that uc_crc32 was not byte order agnostic.

fil_iterate
    Check post encryption checksum before actual decryption.

Add test case to import both little-endian and big-endian tables that
use encryption.

Author: Oleksandr Byelkin
Author Date: 2018-03-12 13:46:00 UTC

Optimize charset tracking a bit.

Author: Sergei Golubchik
Author Date: 2017-10-24 18:59:54 UTC

MDEV-13968 sst fails with "WSREP_SST_OPT_PORT: readonly variable"

followup for 4c2c057d404

fix broken script (set -u)

Author: Alexey Botchkov
Author Date: 2018-03-11 21:09:55 UTC

MDEV-15217

Author: Sergey Petrunia
Author Date: 2018-03-08 10:43:55 UTC

MDEV-15245: Assertion `false' failed in myrocks::ha_rocksdb::position

Don't call handler->position() if the last call to read a row did
not succeed.

Author: Jan Lindström
Author Date: 2018-03-08 10:25:01 UTC

MDEV-13935: INSERT INTO stuck at state "Unlocking tables"

There were some differences on MariaDB compared with MySQL.
Fix these differences.

Author: Marko Mäkelä
Author Date: 2018-02-23 20:26:26 UTC

Allocate buf_pool statically

buf_pool_t::create(): Replaces buf_pool_init().

buf_pool_t::close(): Replaces buf_pool_free().

FIXME: Do not add buf_pool_t::is_initialised()

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-02-27 11:42:46 UTC

MDEV-15053 Split buf_pool_t::mutex

Used atomic operations for
  - srv_buf_pool_old_size
  - srv_buf_pool_size
  - srv_buf_pool_curr_size
  - srv_buf_pool_base_size
  - buf_pool_t::buddy_stat[].used
  - buf_pool_t::curr_size
  - buf_pool_t::n_chunks_new

Author: Alexander Barkov
Author Date: 2017-08-18 19:36:42 UTC

MDEV-11952 Oracle-style packages: stage#5

- CREATE PACKAGE [BODY] statements are now
  entirely written to mysql.proc with type='PACKAGE' and type='PACKAGE BODY'.
- CREATE PACKAGE BODY now supports IF NOT EXISTS
- DROP PACKAGE BODY now supports IF EXISTS
- CREATE OR REPLACE PACKAGE [BODY] is now supported
- CREATE PACKAGE [BODY] now support the DEFINER clause:

    CREATE DEFINER user@host PACKAGE pkg ... END;
    CREATE DEFINER user@host PACKAGE BODY pkg ... END;

- CREATE PACKAGE [BODY] now supports SQL SECURITY and COMMENT clauses, e.g.:

    CREATE PACKAGE p1 SQL SECURITY INVOKER COMMENT "comment" AS ... END;

- Package routines are now created from the package CREATE PACKAGE BODY
  statement and don't produce individual records in mysql.proc.

- CREATE PACKAGE BODY now supports package-wide variables.
  Package variables can be read and set inside package routines.
  Package variables are stored in a separate sp_rcontext,
  which is cached in THD on the first packate routine call.

- CREATE PACKAGE BODY now supports the initialization section.

- All public routines (i.e. declared in CREATE PACKAGE)
  must have implementations in CREATE PACKAGE BODY

- Only public package routines are available outside of the package

- {CREATE|DROP} PACKAGE [BODY] now respects CREATE ROUTINE and ALTER ROUTINE
  privileges

- "GRANT EXECUTE ON PACKAGE BODY pkg" is now supported

- SHOW CREATE PACKAGE [BODY] is now supported

- SHOW PACKAGE [BODY] STATUS is now supported

- CREATE and DROP for PACKAGE [BODY] now works for non-current databases

- mysqldump now supports packages

- "SHOW {PROCEDURE|FUNCTION) CODE pkg.routine" now works for package routines

- "SHOW PACKAGE BODY CODE pkg" now works (the package initialization section)

- A new package body level MDL was added

- Recursive calls for package procedures are now possible

- Routine forward declarations in CREATE PACKATE BODY are now supported.

- Package body variables now work as SP OUT parameters

- Package body variables now work as SELECT INTO targets

- Package body variables now support ROW, %ROWTYPE, %TYPE

Author: Marko Mäkelä
Author Date: 2018-02-24 20:04:11 UTC

Merge 10.3 into bb-10.3-MDEV-15058

Author: Jan Lindström
Author Date: 2018-02-24 16:25:34 UTC

MDEV-14814: encryption.innodb_encryption-page-compression failed in buildbot with timeout on wait condition

Fix wrong wait condition.

Author: Sergei Golubchik
Author Date: 2018-02-22 09:15:27 UTC

Merge branch '10.0' into 10.1

Author: Sergei Golubchik
Author Date: 2018-02-22 08:22:03 UTC

Merge branch '5.5' into 10.0

Author: Sergey Petrunia
Author Date: 2018-02-21 14:27:46 UTC

Change MyRocks Maturity Level from Beta to Gamma (RC)