Author: Vladislav Vaintroub
Author Date: 2018-05-21 16:34:45 UTC

Merge branch '10.3' into bb-10.3-cc

Author: Sergei Golubchik
Author Date: 2018-05-21 13:59:14 UTC

Merge branch 'github/10.2' into 10.3

Author: Sergei Golubchik
Author Date: 2018-05-21 13:44:54 UTC

MDEV-15627 debian packages install /etc/mysql/mariadb.cnf however its not read by default

Author: Monty
Author Date: 2018-05-20 11:19:14 UTC

Fixes for Aria transaction handling with lock tables

MDEV-10130 Assertion `share->in_trans == 0' failed in storage/maria/ma_close.c
MDEV-10378 Assertion `trn' failed in virtual int ha_maria::start_stmt

The problem was that maria_handler->trn was not properly reset
at commit/rollback and ha_maria::exernal_lock() could get confused
because.

There was some old code in ha_maria::implicit_commit() that tried
to take care of this, but it was not bullet proof.

Fixed by adding list of all tables that is part of the maria transaction to
TRN.

A nice side effect was of the fix is that loops in
ha_maria::implict_commit() got to be much simpler.

Other things:
- Fixed a bug in mysql_admin_table() where argument open_for_modify
  was wrongly reset for the next table in the chain
- rollback admin command also in case of fatal error.
- Split _ma_set_trn_for_table() to three version to simplify code
  and debugging.
- Several new asserts to detect the original problem (that file was
  not properly removed from trn before calling ma_close())

Author: Sergey Petrunia
Author Date: 2018-05-21 10:43:50 UTC

Set MyRocks plugin version to Stable

Author: Sergey Petrunia
Author Date: 2018-05-21 10:43:50 UTC

Set MyRocks plugin version to Stable

Author: Vladislav Vaintroub
Author Date: 2018-05-21 10:32:39 UTC

update C/C

Author: Sergei Golubchik
Author Date: 2018-05-20 18:26:40 UTC

.gitignore

Author: Alexey Botchkov
Author Date: 2018-05-20 15:14:46 UTC

MDEV-14024

Author: Sergey Vojtovich
Author Date: 2018-05-20 10:04:38 UTC

OS X warnings fixes

Author: Sergei Golubchik
Author Date: 2018-05-19 14:30:36 UTC

Merge branch '10.0' into 10.1

Author: Sergei Golubchik
Author Date: 2018-05-19 14:30:36 UTC

Merge branch '10.0' into 10.1

Author: Sergei Golubchik
Author Date: 2018-05-19 13:38:34 UTC

Merge branch '5.5' into 10.0

Author: Sergei Golubchik
Author Date: 2018-05-19 13:38:34 UTC

Merge branch '5.5' into 10.0

Author: Vladislav Vaintroub
Author Date: 2018-05-17 23:23:15 UTC

MDEV-16220 MTR - do not pass UTF8 on the command line for mysql client.

It should work ok on all Unixes, but on Windows ,only worked by accident
in the past, with client not being Unicode safe.

It stopped working with Visual Studio 2017 15.7 update now.

Author: Andrei Elkin
Author Date: 2018-05-18 17:42:27 UTC

This is a failure exploring commit (https://internal.askmonty.org/buildbot/builders/kvm-deb-xenial-x86/builds/667.

Author: varun
Author Date: 2018-05-18 12:12:12 UTC

MDEV-14623: Output of show function code does not show FETCH GROUP NEXT ROW for custom aggregates

The print() function was missing from the FETCH GROUP NEXT ROW instrunction class, so there was no
output for this particular instruction when we use the query SHOW FUNCTION CODE function_name

Author: Sachin Setiya
Author Date: 2018-05-18 12:05:33 UTC

MDEV-10259 mysqld crash with certain statement length and...
order with Galera and encrypt-tmp-files=1

Problem:- If trans_cache (IO_CACHE) uses encrypted tmp file
then on next DML server will crash.

Case:-
 Lets take a case , we have a table t1 , We try to do 2 inserts in t1
  1. A really long insert so that trans_cache has to use temp_file
  2. Just a small insert

Analysis:- Actually server crashes from inside of galera
library.
/lib64/libc.so.6(abort+0x175)[0x7fb5ba779dc5]
/usr/lib64/galera/libgalera_smm.so(_ZN6galera3FSMINS_9TrxHandle5State...
mysys/stacktrace.c:247(my_print_stacktrace)[0x7fb5a714940e]
sql/signal_handler.cc:160(handle_fatal_signal)[0x7fb5a715c1bd]
sql/wsrep_hton.cc:257(wsrep_rollback)[0x7fb5bcce923a]
sql/wsrep_hton.cc:268(wsrep_rollback)[0x7fb5bcce9368]
sql/handler.cc:1658(ha_rollback_trans(THD*, bool))[0x7fb5bcd4f41a]
sql/handler.cc:1483(ha_commit_trans(THD*, bool))[0x7fb5bcd4f804]

but actual issue is not in galera but in mariadb, because for 2nd
insert we should never call rollback. We are calling rollback because
log_and_order fails it fails because write_cache fails , It fails
because after reinit_io_cache(trans_cache) , my_b_bytes_in_cache says 0
so we look into tmp_file for data , which is obviously wrong since temp
was used for previous insert and it no longer exist.
wsrep_write_cache_inc() reads the IO_CACHE in a loop, filling it with
my_b_fill() until it returns "0 bytes read". Later
MYSQL_BIN_LOG::write_cache() does the same. wsrep_write_cache_inc()
assumes that reading a zero bytes past EOF leaves the old data in the
cache

Solution:- There is two issue in my_b_encr_read
1st we should never equal read_end to info->buffer. I mean this
does not make sense read_end should always point to end of buffer.
2nd For most of the case(apart from async IO_CACHE) info->pos_in_file
should be equal to info->buffer position wrt to temp file , since
in this case we are not changing info->buffer it should remain
unchanged.

Author: Vladislav Vaintroub
Author Date: 2018-05-17 23:23:15 UTC

Do not use UTF8 on the command line for mysql client, on Windows.

It only worked by accident in the past, with client not being Unicode safe.
It stopped working with VS2017 15.7 release.

Author: Anel Husaković
Author Date: 2018-04-20 07:06:25 UTC

Add error message in case of the `field` `check` constraints

One can create table with the same name for `field` and `table` `check` constraint.
For example:

create table t(a int check(a>0), constraint a check(a>10));
But when inserting new rows same error is always raised.
For example with
insert into t values (-1);
insert into t values (10);
same error `ER_CONSTRAINT_FAILED` is returned for both queries.
By the assumption that the previous error should be raised only in case of
`table` constraints, this patch will distinguish between `field` and `table`
error message by adding newly created `ER_FIELD_CONSTRAINT_FAILED` error which
occurs only when `field` constraint is violated.

Author: sachin
Author Date: 2018-04-26 14:20:30 UTC

MDEV-15127 AddressSanitizer: stack-buffer-overflow in
 base_list::push_back upon creating invisible index

A commit message ....

Author: Jacob Mathew
Author Date: 2018-05-18 04:03:33 UTC

MDEV-12900: spider tests failed in buildbot with valgrind

The failures with valgrind occur as a result of Spider sometimes using the
wrong transaction for operations in background threads that send requests to
the data nodes. The use of the wrong transaction caused the networking to the
data nodes to use the wrong thread in some cases. Valgrind eventually
detects this when such a thread is destroyed before it is used to disconnect
from the data node by that wrong transaction when it is freed.

I have fixed the problem by correcting the transaction used in each of these
cases.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Vladislav Vaintroub
Author Date: 2018-05-17 23:23:15 UTC

Do not use UTF8 on the command line for mysql client, on Windows.

It only worked by accident in the past, with client not being Unicode safe.
It stopped working with VS2017 15.7 release.

Author: Oleksandr Byelkin
Author Date: 2018-05-17 17:17:28 UTC

MDEV-12465: Server crashes in my_scan_weight_utf8_bin upon collecting stats for RocksDB table

Do not use "only index read" in analyzing indices if there is a field which present in the index only partially.

Author: Sergei Golubchik
Author Date: 2018-05-14 08:47:13 UTC

MDEV-16157 federated corrupts timestamps

do "set time_zone='+00:00'" on remote server
after connecting.

temporarily reset local time zone to '+00:00'
whenever Field::val_str() or Field::store()
methods are used.

Author: Sachin Setiya
Author Date: 2018-05-17 10:29:43 UTC

Fix rpl_000011.test

Instead of real value use delta value , Since flush status wont flush
LONGLONG variable.

Author: Sergei Golubchik
Author Date: 2018-05-16 09:15:08 UTC

MDEV-16183 TokuDB tests fail on Fedora 28

jemalloc > 5.0.0 doesn't like to be linked with
a dlopen-ed module.

Don't link tokudb with jemalloc on Fedora 28,
LD_PRELOAD it instead with mysqld_safe
and with systemd.

Author: Sergey Vojtovich
Author Date: 2018-05-16 17:01:26 UTC

(almost) sane core handling in mtr

Analyze core independently of max-save-datadir and max-save-core setting.

Increment $num_saved_cores only if core was actually saved.

"Move any core files from e.g. mysqltest" independently of
max-save-datadir setting. Note: it may overwrite core from mysqld, which
might not be desired (it did work this way even before).

Author: Marko Mäkelä
Author Date: 2018-05-16 14:37:23 UTC

Merge 10.2 into 10.3

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-07 11:33:47 UTC

MDEV-15855 Use MDL in FULLTEXT INDEX sync

- fts sync thread allows takes MDL lock on the table instead of
dict_operation_lock.

Author: Galina Shalygina
Author Date: 2018-05-15 21:45:59 UTC

MDEV-12387 Push conditions into materialized subqueries

The logic and the implementation scheme are similar with the
MDEV-9197 Pushdown conditions into non-mergeable views/derived tables

How the push down is made on the example:

select * from t1
where a>3 and b>10 and
 (a,b) in (select x,max(y) from t2 group by x);

-->

select * from t1
where a>3 and b>10 and
  (a,b) in (select x,max(y)
            from t2
            where x>3
            group by x
            having max(y)>10);

The implementation scheme:

1. Search for the condition cond that depends only on the fields
   from the left part of the IN subquery (left_part)
2. Find fields F_group in the select of the right part of the
   IN subquery (right_part) that are used in the GROUP BY
3. Extract from the cond condition cond_where that depends only on the
   fields from the left_part that stay at the same places in the left_part
   (have the same indexes) as the F_group fields in the projection of the
   right_part
4. Transform cond_where so it can be pushed into the WHERE clause of the
   right_part and delete cond_where from the cond
5. Transform cond so it can be pushed into the HAVING clause of the right_part

The optimization is made in the
Item_in_subselect::pushdown_cond_for_in_subquery() and is controlled by the
variable condition_pushdown_for_subquery.

New test file in_subq_cond_pushdown.test is created.

There are also some changes made for setup_jtbm_semi_joins().
Now it is decomposed into the 2 procedures: setup_degenerate_jtbm_semi_joins()
that is called before optimize_cond() for cond and setup_jtbm_semi_joins()
that is called after optimize_cond().
New setup_jtbm_semi_joins() is made in the way so that the result of its work is
the same as if it was called before optimize_cond().

The code that is common for pushdown into materialized derived and into materialized
IN subqueries is factored out into pushdown_cond_for_derived(),
Item_in_subselect::pushdown_cond_for_in_subquery() and
st_select_lex::pushdown_cond_into_where_clause().

Author: varun
Author Date: 2018-04-20 17:28:45 UTC

MDEV-15777:Support Early NULLs filtering-like restrictions in the range optimizer

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-15 05:46:51 UTC

MDEV-13626 Merge InnoDB test cases from MySQL 5.7

Imported the following test case from mysql to MariaDB

1) innodb.alter_kill
2) innodb.alter_foreign_crash
3) innodb.alter_rename_files
4) innodb.analyze_table
5) Appended the case in innodb-online-alter-gis

Author: Jacob Mathew
Author Date: 2018-05-11 21:45:09 UTC

MDEV-16101: ADD PARTITION on table partitioned by list does not work with more than 32 list values.

This problem occured because the reorganization of the list of values when the
number of elements exceeds 32 was not handled correctly. I have fixed the
problem by fixing the way that the list values are reorganized when the number
of list values exceeds 32.

Author:
  Jacob Mathew.

Reviewer:
  Alexey Botchkov.

Author: varun
Author Date: 2018-05-14 20:14:03 UTC

MDEV-14695: Assertion `n < m_size' failed in Bounds_checked_array<Element_type>::operator

In this issue we hit the assert because we are adding addition fields to the field JOIN::all_fields list. This
is done because HEAP tables can't index BIT fields so we need to use an additional hidden field for grouping because later it will be
converted to a LONG field. Original field will remain of the BIT type and will be returned. This happens when we convert DISTINCT to
GROUP BY.

The solution is to take into account the number of such hidden fields that would be added to the field
JOIN::all_fields list while calculating the size of the ref_pointer_array.

Author: Jan Lindström
Author Date: 2018-05-14 12:29:13 UTC

Fix merge error.

Author: Sachin Setiya
Author Date: 2018-05-14 11:59:06 UTC

MDEV-9266 Creating index on temporaray table breaks replication

Problem:- Create index was logged into binlog.

Goal:- Operation on temporary table should not be binlog when binlog format
is row.

Solution:-
1st- We should add CF_FORCE_ORIGINAL_BINLOG_FORMAT when there
 is ddl on temp table.
2nd- For optimize, analyze and repair we dont check if binlog format is row
 and this is tmp table, we dont need to log that.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-14 07:45:15 UTC

MDEV-15874 CREATE TABLE creates extra transaction

InnoDB does not allow FOREIGN KEY constraints to exist for TEMPORARY TABLE.
InnoDB introduced a dedicated tablespace for temporary tables, and actually
stopped creating persistent metadata and data for temporary tables.

row_table_add_foreign_constraints(): Do not create a persistent
transaction.

dict_create_foreign_constraints_low(): Add the persistent transaction to
the update the foreign key relation in dictionary.

dict_create_foreign_constraints_low(): Remove a duplicated check for
partitioned tables.

Author: Jan Lindström
Author Date: 2018-05-09 06:16:20 UTC

MDEV-15351: wsrep_sst_xtrabackup is broken in 10.1.31

Remove the setup_ports function call. This is related to
https://github.com/MariaDB/server/pull/717

Thanks to Daniel Black and Bart S.

Author: Sachin Setiya
Author Date: 2018-05-14 06:45:38 UTC

MDEV-14472 Assertion `is_current_stmt_binlog_format_row()' failed...
in THD::binlog_write_table_map

try 1 patch

Author: Galina Shalygina
Author Date: 2018-05-13 16:28:40 UTC

Merge branch 'bb-10.3-mdev12387' into 10.4

Author: Marko Mäkelä
Author Date: 2018-05-12 07:28:54 UTC

dict_create_index_tree_in_mem(): Remove dead code

In InnoDB, CREATE TEMPORARY TABLE does not allow FULLTEXT INDEX.
Replace a condition with a debug assertion, and add a test.

Author: Alexey Botchkov
Author Date: 2018-05-10 15:00:54 UTC

MDEV-15480 Audit plugin does not respect QUERY_DML for audit plugin.

QUERY_DML_NO_SELECT flag added.

Author: Sergey Vojtovich
Author Date: 2018-05-11 10:20:22 UTC

MDEV-15655: Add Linux abstract socket support

Less ifdefs, disable main.connect-abstract until libmariadb is updated.

Author: Sergey Petrunia
Author Date: 2018-05-11 11:50:36 UTC

Tentatively enable a few myrocks tests

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-05-09 14:14:13 UTC

- Fixed compilation issue and merging error.

Author: Jan Lindström
Author Date: 2018-05-09 06:16:20 UTC

MDEV-15351: wsrep_sst_xtrabackup is broken in 10.1.31

Remove the setup_ports function call. This is related to
https://github.com/MariaDB/server/pull/717

Thanks to Daniel Black and Bart S.

Author: Sergei Golubchik
Author Date: 2018-05-08 12:13:01 UTC

Merge branch '10.0' into 10.1

Author: Vladislav Vaintroub
Author Date: 2018-05-08 14:08:08 UTC

MDEV-16105: Mariabackup does not support SSL

The reason is the missing HAVE_OPENSSL define for mariabackup.

Author: Oleksandr Byelkin
Author Date: 2018-05-08 13:26:26 UTC

MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table

fix_length_and_dec now return result (error/OK)

Author: Michael Widenius
Author Date: 2018-04-12 06:28:29 UTC

Change read_to_buffer to use ulong instead of uint

This is mostly to document that read_to_buffer can read more than 65K.
Also changed merge_buffers to return bool instead of int

Author: Galina Shalygina
Author Date: 2018-05-06 19:51:22 UTC

Post merge changes

Author: Anel Husaković
Author Date: 2018-04-03 12:41:13 UTC

MDEV-14474 information_schema.check_constraints

Implement according to standard SQL specification 2008.
The check_constraints table is used for fetching metadata about
the constraints defined for tables in all databases.

Author: Daniel Bartholomew
Author Date: 2018-05-03 14:23:36 UTC

bump the VERSION

Author: Jacob Mathew
Author Date: 2018-05-01 21:14:06 UTC

MDEV-15697: Remote user used by Spider needs SUPER privilege

The remote users need the SUPER privilege because by default Spider sends a
'SET SQL_LOG_OFF' statement to the data nodes. This is controlled by the
spider_internal_sql_log_off configuration setting on the Spider node, which
can only be set to 0 or 1, with a default value of 1.

I have fixed the problem by changing this configuration setting so that if it
is NOT SET, which is the most likely case, the Spider node DOES NOT SEND the
'SET SQL_LOG_OFF' statement to the data nodes. However if the
spider_internal_sql_log_off setting IS EXPLICITLY SET to either 0 or 1, then
the Spider node DOES SEND the 'SET SQL_LOG_OFF' statement, requiring a remote
user with the SUPER privilege. The Spider documentation will be updated to
reflect this change.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Jan Lindström
Author Date: 2018-04-30 04:40:17 UTC

Merge branch 'codership-MDEV-15803' into 10.1

Author: Jan Lindström
Author Date: 2018-04-27 06:28:14 UTC

Merge branch 'codership-MDEV-15794' into 10.1

Author: Oleksandr Byelkin
Author Date: 2018-04-26 17:58:43 UTC

MDEV-13024: Server crashes in my_store_ptr upon DELETE from sequence in multi-table format

Make operation possition() dummy for sequences (should not be used really)

Author: Elena Stepanova
Author Date: 2018-04-25 16:19:44 UTC

Add a test case which is known to fail, to check failure handling

Not to be merged to the main tree!

Author: Jacob Mathew
Author Date: 2018-04-14 00:51:51 UTC

MDEV-15698: Spider ignores syntax errors in connection string in COMMENT field

When a comma separator is missing between COMMENT fields, Spider ignores the
parameter values that are beyond the last expected parameter value. There are
also some error messages that Spider does generate on COMMENT fields that are
incorrectly formed.

I have introduced additional infrastructure in Spider to fix these problems.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Jan Lindström
Author Date: 2018-04-24 11:43:41 UTC

MDEV-15607: mysqld crashed few after node is being joined with sst

This is a typical systemd response where it tries to shutdown the
joiner (due to "timeout") before the joiner manages to complete SST.

wsrep_sst_wait
wsrep_SE_init_wait
 While waiting the operation to finish use mysql_cond_timedwait
 instead of mysql_cond_wait and if operation is not finished
 extend systemd timeout (if needed).

Author: Jan Lindström
Author Date: 2018-04-24 10:58:42 UTC

MariaDB adjustments.

Author: Jacob Mathew
Author Date: 2018-04-24 05:00:27 UTC

MDEV-15712: If remote server used by Spider table is unavailable, some operations hang for a long time

When an attempt to connect to the remote server fails, Spider retries to
connect to the remote server 1000 times or until the connection attempt
succeeds. This is perceived as a hang if the remote server remains
unavailable.

I have introduced changes in Spider's table status handler to fix this problem.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-04-21 03:27:38 UTC

Problem:
=======
InnoDB cleans all temporary undo logs during commit. During rollback
of secondary index entry, InnoDB tries to build the previous version
of clustered index. It leads to access of freed undo page during
previous transaction commit and it leads to undo log corruption.

Solution:
=========
During rollback, temporary undo logs should not try to build
the previous version of the record.

Author: Jan Lindström
Author Date: 2018-04-18 08:35:31 UTC

MDEV-15308: Assertion `ha_alter_info->alter_info->drop_list.elements > 0' failed in ha_innodb::prepare_inplace_alter_table

Problem was thet when items were removed from drop_list alter_info
flags were not adjusted accordingly in all cases.

Author: Vladislav Vaintroub
Author Date: 2018-04-15 14:29:55 UTC

Innodb cleanup - make Innodb merge temp tables use pfs_os_file_t for
file IO, rather than int.

On Windows, it is suboptimal to depend on C runtime, as it has limited
number of file descriptors. This change eliminates
os_file_read_no_error_handling_int_fd(), os_file_write_int_fd(),
OS_FILE_FROM_FD() macro.

Author: Jan Lindström
Author Date: 2018-04-16 12:06:41 UTC

MDEV-13516: encryption.create_or_replace test fails in buildbot with InnoDB assertion failure

fil_crypt_rotate_pages
 If tablespace is marked as stopping stop also page rotation

fil_crypt_flush_space
 If tablespace is marked as stopping do not try to read
 page 0 and write it back.

Author: Jan Lindström
Author Date: 2018-04-13 09:44:11 UTC

Merge branch 'codership-10.2-fix-mtr-wait' into 10.2

Author: Vicențiu Ciorbaru
Author Date: 2018-04-12 00:30:43 UTC

Merge remote-tracking branch 'origin/10.3' into bb-10.3-vicentiu

Author: Brauge
Author Date: 2018-03-30 09:23:28 UTC

MDEV-15739 sql_mode=ORACLE: Make LPAD and RPAD return NULL instead of empty string

Author: Vicențiu Ciorbaru
Author Date: 2018-04-09 21:54:58 UTC

Update test cases and fix innodb merge problem with trx_roll_report_progress

Author: Vicențiu Ciorbaru
Author Date: 2018-04-09 17:00:42 UTC

Fix printing of line numbers when using addr2line

When starting a binary that's inside the PATH variable without
specifying a complete path, dladdr will return just that binary name,
without any extra path information. Make use of /proc/self/exe if it's
available to resolve it.

Author: sachin
Author Date: 2018-04-08 16:55:37 UTC

MDEV-15611 Due to the failure of foreign key detection, Galera...
slave node killed himself.

Problem:- If we try to delete table with foreign key and table whom it is
referring with wsrep_slave_threads>1 then galera tries to execute both
Delete_rows_log-event in parallel, which should not happen.

Solution:- This is happening because we do not have foreign key info in
write set. Upto version 10.2.7 it used to work fine. Actually it happening
because of issue in commit 2f342c4. wsrep_must_process_fk has changed to
make it similar to original condition.

Author: Alexey Botchkov
Author Date: 2018-04-08 03:57:44 UTC

FIX2

Author: Vicențiu Ciorbaru
Author Date: 2018-04-07 05:50:04 UTC

Merge branch '10.1' into bb-10.1-vicentiu

Author: Vladislav Vaintroub
Author Date: 2018-04-05 12:17:17 UTC

MDEV-15707 : deadlock in Innodb IO code, caused by change buffering.

In async IO completion code, after reading a page,Innodb can wait for
completion of other bufferpool reads.
This is for example what happens if change-buffering is active.

Innodb on Windows could deadlock, as it did not have dedicated threads
for processing change buffer asynchronous reads.

The fix for that is to have windows now has the same background threads,
including dedicated thread for ibuf, and log AIOs.

The ibuf/read completions are now dispatched to their threads with
PostQueuedCompletionStatus(), the write and log completions are processed
in thread where they arrive.

Author: Michael Widenius
Author Date: 2018-04-05 12:16:20 UTC

MDEV-14762 Server crashes in MDL_ticket::has_stronger_or_equal_type upon inserting into temporary sequence

Fix is to not upgrade MDL locks for temporary tables

Author: Jacob Mathew
Author Date: 2018-04-05 21:23:31 UTC

MDEV-15692: install_spider.sql can fail with some collations

The error occurs because of how the character set and collation are chosen for
stored procedure parameters that have a character data type. If the character
set and collation are not explicitly stated in the declaration, the server
chooses the database character set and collation in effect at routine creation
time.

To fix the problem, I added explicit character set and collation attributes
for the stored procedure parameters in the install_spider.sql script.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Sergey Vojtovich
Author Date: 2018-04-05 13:36:59 UTC

Fix misuse of MY_CHECK_CXX_COMPILER_FLAG

- compile_flags already include from top CMakeLists.txt
- MY_CHECK_CXX_COMPILER_FLAG() accepts only one parameter
- output variable of MY_CHECK_CXX_COMPILER_FLAG() is have_CXX__Wa__nH
- same check for mariabackup

Based on contribution by satanson (PR#466).

Author: Jan Lindström
Author Date: 2018-04-04 09:47:23 UTC

MDEV-15566: System tablespace does not easily key rotate to unencrypted

Problem was that key rotation from encrypted to unecrypted was skipped
when encryption is disabled.

fil_crypt_needs_rotation
 If encryption is disabled and there is tablespaces using
 default encryption (e.g. system tablespace) that are still
 encrypted state we need to rotate them from encrypted state
 to unencrypted state.

Author: Jacob Mathew
Author Date: 2018-04-02 22:25:08 UTC

MDEV-7914: spider/bg.ha, spider/bg.ha_part crash server sporadically in buildbot

The crash occurs when a thread that is closing its connection attempts to
access Spider transaction information when another thread has freed that memory
while processing Spider plugin deinit. This occurs because Spider does not
adjust the plugin's reference count when it sets a transaction information
pointer for the plugin.

The fix I implemented changes the way Spider sets the transaction information
pointer to use thd_set_ha_data() so that Spider's plugin reference counter is
adjusted as well.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Vicențiu Ciorbaru
Author Date: 2018-04-03 15:08:30 UTC

Merge branch '5.5' into 10.0

Author: Vicențiu Ciorbaru
Author Date: 2018-04-02 21:36:01 UTC

Force rebuild

Author: Vicențiu Ciorbaru
Author Date: 2018-04-02 21:07:58 UTC

Force build?

Author: Sergey Vojtovich
Author Date: 2018-04-02 17:18:04 UTC

fixup! increase upper value of max_prepared_stmt_count to UINT32_MAX

Author: varun
Author Date: 2018-04-02 10:14:30 UTC

MDEV-9744: session optimizer_use_condition_selectivity=5 causing SQL Error (1918):
           Encountered illegal value '' when converting to DECIMAL

The issue was that EITS data was allocated but then not read for some reason (one being to avoid a deadlock),
then the optimizer was using these bzero'ed buffers as EITS statistics.
This should not be allowed, we should use statistcs for a table only when we have successfully loaded/read
the stats from the statistical tables.

Author: Igor Babaev
Author Date: 2018-04-01 22:23:12 UTC

Refactored some code.

Author: Jan Lindström
Author Date: 2018-03-28 13:07:52 UTC

Merge branch 'MDEV-13549-fixes-for-galera_gtid_slave' of https://github.com/codership/mariadb-server into codership-MDEV-13549-fixes-for-galera_gtid_slave

Author: Jan Lindström
Author Date: 2018-03-28 05:55:06 UTC

Merge branch 'codership-MDEV-13549-fixes-for-galera_as_master' into 10.1

Author: varun
Author Date: 2018-03-28 05:54:35 UTC

MDEV-14592: Custom Aggregates Usage Status Variable

Introduced new status variable for custom aggregate functions

Author: Vladislav Vaintroub
Author Date: 2018-03-27 20:10:17 UTC

MDEV-15694 Windows : use GetSystemTimePreciseAsFileTime if available for high resolution time

Use high accuracy timer on Windows 8.1+ for system versioning,it needs
accurate high resoution start query time.

Continue to use the inaccurate (but much faster timer function)
GetSystemTimeAsFileTime() where accuracy does not matter, e.g in
set_timespec_time_nsec(),or my_time()

Author: Jan Lindström
Author Date: 2018-03-27 14:11:09 UTC

Merge branch 'codership-MDEV-13549-fixes-for-galera_suspend_slave' into 10.1

Author: Oleksandr Byelkin
Author Date: 2018-03-27 06:42:31 UTC

Walking throuch query tables ON expression added.

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-03-27 05:53:27 UTC

MDEV-15325 Incomplete validation of missing tablespace during recovery

Problem:
=======
 During validation of missing tablespace, missing tablespace id is
being compared with hash table of redo logs (recv_sys->addr_hash). But if the
hash table ran out of memory then there is a possibility that it will not contain
the redo logs of all tablespace. In that case, Server will load the InnoDB
even though there is a missing tablespace.

Solution:
========
 If the recv_sys->addr_hash hash table ran out of memory then InnoDB needs
to scan the remaining redo log again to validate the missing tablespace.

Author: sachin
Author Date: 2018-03-26 22:26:10 UTC

MDEV-10259 mysqld crash with certain statement length and...
order with Galera and encrypt-tmp-files=1

Problem:- If trans_cache (IO_CACHE) uses encrypted tmp file
then on next DML server will crash.

Case:-
 Lets take a case , we have a table t1 , We try to do 2 inserts in t1
  1. A really long insert so that trans_cache has to use temp_file
  2. Just a small insert

Analysis:- Actually server crashes from inside of galera
library.
/lib64/libc.so.6(abort+0x175)[0x7fb5ba779dc5]
/usr/lib64/galera/libgalera_smm.so(_ZN6galera3FSMINS_9TrxHandle5State...
mysys/stacktrace.c:247(my_print_stacktrace)[0x7fb5a714940e]
sql/signal_handler.cc:160(handle_fatal_signal)[0x7fb5a715c1bd]
sql/wsrep_hton.cc:257(wsrep_rollback)[0x7fb5bcce923a]
sql/wsrep_hton.cc:268(wsrep_rollback)[0x7fb5bcce9368]
sql/handler.cc:1658(ha_rollback_trans(THD*, bool))[0x7fb5bcd4f41a]
sql/handler.cc:1483(ha_commit_trans(THD*, bool))[0x7fb5bcd4f804]

but actual issue is not in galera but in mariadb, because for 2nd
insert we should never call rollback. We are calling rollback because
log_and_order fails it fails because write_cache fails , It fails
because after reinit_io_cache(trans_cache) , my_b_tell says 0 so we
look into tmp_file for data , which is obviously wrong since temp
was used for previous insert and it no longer exist.

Solution:- There is two issue in my_b_encr_read
1st we should never equal read_end to info->buffer. I mean this
does not make sense read_end should always point to end of buffer.
2nd For most of the case(apart from async IO_CACHE) info->pos_in_file
should be equal to info->buffer position wrt to temp file , since
in this case we are not changing info->buffer it should remain unchanged.

Author: varun
Author Date: 2018-03-26 21:18:55 UTC

MDEV-9959: A serious MariaDB server performance bug

Step #2: If any field in the select list of the derived tables is present in the group by list also , then we are again guaranteed that ref access to the derived table would always produce one row per key.

Author: Monty
Author Date: 2018-03-25 10:38:12 UTC

disable some galera tests that fails regurarly

Author: varun
Author Date: 2018-03-23 22:01:18 UTC

MDEV-11274: Executing EXPLAIN of complex query over join limit causes server to crash

For this case we have a view that is mergeable but we are not able to merge it in the
parent select because that would exceed the maximum tables allowed in the join list, so we
materialise this view
TABLE_LIST::dervied is NULL for such views, it is only set for views which have ALGORITHM=TEMPTABLE
Fixed by making sure TABLE_LIST::derived is set for views that could not be merged

Author: Thirunarayanan Balathandayuthapani
Author Date: 2018-03-23 12:14:57 UTC

MDEV-15325 Incomplete validation of missing tablespace during recovery

Problem:
=======
 During validation of missing tablespace, missing tablespace id is
being compared with hash table of redo logs (recv_sys->addr_hash). But if the
hash table ran out of memory then there is a possibility that it will not contain
the redo logs of all tablespace. In that case, Server will load the InnoDB
even though there is a missing tablespace.

Solution:
========
 If the recv_sys->addr_hash hash table ran out of memory then InnoDB needs
to scan the remaining redo log again to validate the missing tablespace.

Author: Jan Lindström
Author Date: 2018-03-22 06:51:43 UTC

MDEV-14616: WSREP has not yet prepared node for application use error

MariaDB adjustments.

mysqltest.cc : Allow 12 error codes at --error

wait_until_connected_again.inc: Replace numeric error codes with symbols

mysqltest.test: Add error codes to test that tests too many errorcodes