lp:maria

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-27 19:09:11 UTC

Merge branch '10.5' into 10.6

Author: Sergey Petrunia
Author Date: 2023-01-27 16:29:33 UTC

Optimizer Trace: make plan_prefix not show const/eliminated tables

Author: Anel Husakovic
Author Date: 2023-01-27 14:53:50 UTC

Testing Windows bb with skip-name-resolve

Author: Marko Mäkelä
Author Date: 2023-01-27 14:39:00 UTC

MDEV-30479 OPT_PAGE_CHECKSUM mismatch after innodb_undo_log_truncate=ON

page_recv_t::trim(): Do remove log records for mini-transactions
that end right at the threshold LSN. This will avoid an inconsistency
where a dirty page had been evicted from the buffer pool during
undo tablespace truncation, and recovery would attempt to apply
log records for which the last available copy in the data file is
too new. These changes would be discarded anyway.

Author: Nikita Malyavin
Author Date: 2022-11-21 15:49:08 UTC

MDEV-30021 FK actions are ignored after tc_purge and COMMIT

When a table is evicted, do not delete all relations from
referenced tables' set, but just NULL itself in a foreign key
structure.

foreign/referenced set element should only be removed if table is dropped,
and therefore a referencial constraint is removed.

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-27 12:54:14 UTC

Merge branch '10.4' into 10.5

Author: Jan Lindström
Author Date: 2023-01-27 08:40:07 UTC

MDEV-30473 : Do not allow GET_LOCK() / RELEASE_LOCK() in cluster

In 10.5 If WSREP_ON=ON do not allow RELEASE_ALL_LOCKS function.
Instead print clear error message.

Author: Jan Lindström
Author Date: 2023-01-27 08:40:07 UTC

MDEV-30473 : Do not allow GET_LOCK() / RELEASE_LOCK() in cluster

In 10.5 If WSREP_ON=ON do not allow RELEASE_ALL_LOCKS function.
Instead print clear error message.

Author: Jan Lindström
Author Date: 2023-01-26 12:34:12 UTC

MDEV-30473 : Do not allow GET_LOCK() / RELEASE_LOCK() in cluster

If WSREP_ON=ON do not allow GET_LOCK and RELEASE_LOCK functions.
Instead print clear error message.

Author: Jan Lindström
Author Date: 2023-01-26 12:34:12 UTC

MDEV-30473 : Do not allow GET_LOCK() / RELEASE_LOCK() in cluster

If WSREP_ON=ON do not allow GET_LOCK and RELEASE_LOCK functions.
Instead print clear error message.

Author: Vlad Lesin
Author Date: 2023-01-19 14:07:37 UTC

MDEV-27701 Race on trx->lock.wait_lock between lock_rec_move() and lock_sys_t::cancel()

Author: midenok
Author Date: 2023-01-25 20:56:21 UTC

MDEV-29544 SIGSEGV in HA_CREATE_INFO::finalize_locked_tables

On finalize_atomic_replace() even if we dropped the original table
because we could not rename it to backup we also may fail to rename
temporary table by the same reason.

DDL_LOG flag passed as rename param helps to force rename when the
miscellaneous operations fail (such as maintaining the statistics).

Author: Sergey Petrunia
Author Date: 2023-01-26 09:04:28 UTC

MDEV-30218: Incorrect optimization for rowid_filtering, correction

Enable use of Rowid Filter optimization with eq_ref access.
Use the following assumptions:
- Assume index-only access cost is 50% of non-index-only access cost.
- Take into account that "Eq_ref access cache" reduces the number of
  lookups eq_ref access will make.
  = This means the number of Rowid Filter checks is reduced also
  = Eq_ref access cost is computed using that assumption (see
    prev_record_reads() call), so we should use it in all cost '
    computations.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-25 07:06:57 UTC

MDEV-30429 InnoDB: Failing assertion: stat_value != UINT64_UNDEFINED in storage/innobase/dict/dict0stats.cc line 3647

In dict_stats_analyze_index(), InnoDB sets the maximum value for
index_stats_t to indicate the bulk under bulk insert operation.
But InnoDB fails to empty the statistics of the table in that case.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-25 07:06:57 UTC

MDEV-30429 InnoDB: Failing assertion: stat_value != UINT64_UNDEFINED in storage/innobase/dict/dict0stats.cc line 3647

In dict_stats_analyze_index(), InnoDB sets the maximum value for
index_stats_t to indicate the bulk under bulk insert operation.
But InnoDB fails to empty the statistics of the table in that case.

Author: Vladislav Vaintroub
Author Date: 2023-01-26 11:22:38 UTC

MDEV-30475 Windows, mtr - Remove outdated instructions on how to install post-mortem debugger

Also, use standard C:\symbols location for OS debugging symbols cache,
rather than own invention C:\cdb_symbols.

Author: Vladislav Vaintroub
Author Date: 2023-01-26 11:22:38 UTC

MDEV-30475 Windows, mtr - Remove outdated instructions on how to install post-mortem debugger

Also, use standard C:\symbols location for OS debugging symbols cache,
rather than own invention C:\cdb_symbols.

Author: Lena Startseva
Author Date: 2022-09-19 05:26:59 UTC

MDEV-29390: Improve coverage for UPDATE and DELETE statements in MTR test suites

Created tests for "delete" based on update_use_source.test

For the update_use_source.test tests, data recovery in the table has been changed
from a rollback transaction to a complete delete and re-insert of the data with
optimize table. Cases are now being checked on three engines.

Added tests for update/delete with LooseScan and DuplicateWeedout optimization strategies
Added tests for engine MEMORY on delete and update
Added tests for multi-update with JSON_TABLE
Added tests for multi-update and multi-delete for engine Connect

Author: Sergey Petrunia
Author Date: 2023-01-26 09:04:28 UTC

MDEV-30218: Incorrect optimization for rowid_filtering, correction

Enable use of Rowid Filter optimization with eq_ref access.
Use the following assumptions:
- Assume index-only access cost is 50% of non-index-only access cost.
- Take into account that "Eq_ref access cache" reduces the number of
  lookups eq_ref access will make.
  = This means the number of Rowid Filter checks is reduced also
  = Eq_ref access cost is computed using that assumption (see
    prev_record_reads() call), so we should use it in all cost '
    computations.

Author: Alexander Barkov
Author Date: 2022-12-12 13:45:48 UTC

MDEV-30151 parse error 1=2 not between/in

This patch fixes the problem by adding a new rule booleat_test.
This makes the grammar clearer and less conflicting.

Additionally, fixing %prec in this grammar branch:

- | boolean_test IS NULL_SYM %prec PREC_BELOW_NOT
+ | boolean_test IS NULL_SYM %prec IS

to have consistently "%prec IS" in all grammar branches starting
with "boolean_test IS ...".
It's not clear why these three rules needed different %prec before the fix:

- boolean_test IS TRUE
- boolean_test IS UNKNOWN
- boolean_test IS NULL

Author: Igor Babaev
Author Date: 2023-01-25 19:46:28 UTC

MDEV-28616 Crash when using derived table over union with order by clause

This bug manifested itself when the server processed a query containing
a derived table over union whose ORDER BY clause included a subquery
with unresolvable column reference. For such a query the server crashed
when trying to resolve column references in the ORDER BY clause used by
union.
For any union with ORDER BY clause an extra SELECT_LEX structure is created
and it is attached to SELECT_LEX_UNIT structure of the union via the field
fake_select_lex. The outer context for fake_select_lex must be the same as
for other selects of the union. If the union is used in the FROM list of
a derived table then the outer context for fake_select_lex must be set to
NULL in line with other selects of the union. It was not done and it
caused a crash when searching for possible resolution of an unresolvable
column reference occurred in a subquery used in the ORDER BY clause.

Approved by Oleksandr Byelkin <sanja@mariadb.com>

Author: Sergei Golubchik
Author Date: 2022-12-08 16:43:59 UTC

MDEV-28910 remove the 5.5.5- version hack

no longer needed, MySQL replication was fixed meanwhile.

client code still can recognize and strip the prefix though.

Author: Sergei Golubchik
Author Date: 2022-12-08 16:43:59 UTC

MDEV-28910 remove the 5.5.5- version hack

no longer needed, MySQL replication was fixed meanwhile.

client code still can recognize and strip the prefix though.

Author: Jan Lindström
Author Date: 2023-01-03 10:18:38 UTC

MDEV-30318 : galera error messages in mariadb log without galera enabled

Do not compile wsrep_provider plugin if WITH_WSREP is not enabled.
We should not enable wsrep_provider plugin if WSREP_ON=OFF and
at that case we can only print information that Plugin
'wsrep-provider' is disabled.

Make sure tests require Galera library 26.4.14 if needed.

Author: Jan Lindström
Author Date: 2023-01-25 08:01:00 UTC

MDEV-30465 : Galera test galera_sr.MDEV-27615 takes 5mins

After d7d3ad69 we should use KILL_CONNECTION_HARD to interrupt
debug_sync waits. Test case uses debug_sync and then disconnects
connection from cluster.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-25 07:06:57 UTC

MDEV-30429 InnoDB: Failing assertion: stat_value != UINT64_UNDEFINED in storage/innobase/dict/dict0stats.cc line 3647

In dict_stats_analyze_index(), InnoDB sets the maximum value for
index_stats_t to indicate the bulk under bulk insert operation.
But InnoDB fails to empty the statistics of the table in that case.

Author: Jan Lindström
Author Date: 2023-01-24 12:36:54 UTC

MDEV-27977 : galera.galera_UK_conflict fails with wrong result

Add wait_condition so that all rows expected are really
replicated before we check it.

Author: Angelique Sklavounos
Author Date: 2023-01-25 04:12:33 UTC

MDEV-29943: Check gtid_slave_pos and use sync_with_master_gtid (and remove superfluous semicolons)

Author: Yuchen Pei
Author Date: 2023-01-25 02:11:47 UTC

MDEV-30464 Adding a testsuite spider/unfixed with a readme.

Author: Yuchen Pei
Author Date: 2023-01-25 02:10:20 UTC

MDEV-29676 Adding a testcase for mdev-29676

Author: Yuchen Pei
Author Date: 2023-01-19 07:28:14 UTC

MDEV-30370 Fixing spider hang when server aborts

This is Kentoku's patch for MDEV-22979 (e6e41f04f4e + 22a0097727f),
which fixes 30370.

It changes the wait to a timed wait for the first sts thread, which
waits on server start to execute the init queries for spider. It also
flips the flag init_command to false when the sts thread is being
freed. With these changes the sts thread can check the flag regularly
and abort the init_queries when it finds out the init_command is
false. This avoids the deadlock that causes the problem in MDEV-30370.

It also fixes MDEV-22979 for 10.4, but not 10.5. I have not tested
higher versions for MDEV-22979.

A test has also been done on MDEV-29904 to avoid regression, given
MDEV-27233 is a similar problem and its patch caused the
regression. The test passes for 10.4-11.0.

However, this adhoc test only works consistently when placed in the
main testsuite. We should not place spider tests in the main suite, so
we do not include it in this commit. A patch for MDEV-27912 should fix
this problem and allow a proper test for MDEV-29904. See comments in
the jira ticket MDEV-30370/29904 for the adhoc testcase used for this
commit.

Author: Vladislav Vaintroub
Author Date: 2023-01-24 18:41:29 UTC

MDEV-30457 Windows, signtool error "No file digest algorithm specified."

Add /fd parameter. It is now mandatory for the recent versions of
signtool

Author: Roman Nozdrin
Author Date: 2023-01-24 19:28:21 UTC

Columnstore version is 6.4.7 now

Author: Andrei
Author Date: 2023-01-05 18:08:01 UTC

MDEV-30323 Some DDLs like ANALYZE can complete on parallel slave out of order

ANALYZE was observed to race over a preceding in binlog order DML
in updating the binlog and slave gtid states.

Tagging ANALYZE and other admin class commands in binlog by the fixes
of MDEV-17515 left a flaw allowing such race leading to
the gtid mode out-of-order error.
This is fixed now to observe by ADMIN commands the ordered access to
the slave gtid status variables and binlog.

Author: Elena Stepanova
Author Date: 2023-01-24 16:04:46 UTC

Test commit

Author: Marko Mäkelä
Author Date: 2023-01-24 13:17:39 UTC

Merge 10.10 into 10.11

Author: Marko Mäkelä
Author Date: 2023-01-24 13:17:10 UTC

Merge 10.9 into 10.10

Author: Marko Mäkelä
Author Date: 2023-01-24 12:59:42 UTC

Merge 10.8 into 10.9

Author: Roman Nozdrin
Author Date: 2023-01-24 12:59:34 UTC

Columnstore version is 6.4.7 now

Author: Marko Mäkelä
Author Date: 2023-01-24 12:52:25 UTC

Merge 10.7 into 10.8

Author: Marko Mäkelä
Author Date: 2023-01-24 12:35:36 UTC

Merge 10.6 into 10.7

Author: Sergey Petrunia
Author Date: 2023-01-24 11:30:22 UTC

Added comments re JOIN::all_fields, JOIN::fields_list

Author: Andrei
Author Date: 2023-01-05 18:08:01 UTC

MDEV-30323 Some DDLs like ANALYZE can complete on parallel slave out of order

ANALYZE was observed to race over a preceding in binlog order DML
in updating the binlog and slave gtid states.

Tagging ANALYZE and other admin class commands in binlog by the fixes
of MDEV-17515 left a flaw allowing such race leading to
the gtid mode out-of-order error.
This is fixed now to observe by ADMIN commands the ordered access to
the slave gtid status variables and binlog.

Author: Denis Protivensky
Author Date: 2022-12-05 14:03:32 UTC

MDEV-24623 Replicate bulk insert as table-level exclusive key

- introduce table key construction function in wsrep service interface
- don't add row keys when replicating bulk insert
- don't start bulk insert on applier or when transaction is not active
- don't start bulk insert for system versioned tables
- implement actual bulk insert table-level key replication

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

Author: Julius Goryavsky
Author Date: 2023-01-24 09:54:45 UTC

MDEV-30452: ssl error: unexpected EOF while reading

This commit contains a сorrection for a new behaviour was introduced
in OpenSSL after version 1.1.1e, when a peer does not send close_notify
before closing the connection.

Author: Nikita Malyavin
Author Date: 2023-01-24 09:24:54 UTC

MDEV-30415 PERIOD false positive overlap wtih utf8mb4_unicode_nopad_ci

A wrong UNIQUE violation is caused here by camparing strings
'def' and 'def ' (with space), under utf8mb4_unicode_nopad_ci collation,
which means "don't count in paddings when comparing".

Field::cmp_prefix uses a comparison through collation, so cmp_binary should
be used instead.

Author: Yuchen Pei
Author Date: 2023-01-19 07:28:14 UTC

MDEV-30370 MDEV-22979 MDEV-29904 MDEV-27912 Spider hang when abort

This is Kentoku's fix for MDEV-22979 (e6e41f04f4e + 22a0097727f),
which also fixes 30370. Adding a test for MDEV-29904 to avoid
regression, given MDEV-27233 is a similar problem.

Also update restart_spider.inc to allow passing restart_parameters, so
that the test of MDEV-29904 works (MDEV-27912).

Author: Yuchen Pei
Author Date: 2023-01-03 05:24:04 UTC

MDEV-29447 WIP Refactor spider_db_mbase_util::open_item_func

WIP: incorporating comments from
https://lists.launchpad.net/maria-developers/msg13283.html

spider_db_mbase_util::open_item_func() is a monster function.
It is difficult to maintain while it is expected that we need to
modify it when a new SQL function or a new func_type is added.

We split the function into two distinct functions: one handles the
case of str != NULL and the other handles the case of str == NULL.

This refactoring was done in a conservative way because we do not
have comprehensive tests on the function.

It also fixes a problem (MDEV-29447) where field items that are
arguments of a func item may be used before created / initialised.

Note this commit is a port of
3836098c29ef1b7ff9d5fbde99b690eab73a0df1 (MDEV-26285) to current
versions 10.3+.

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>

Author: Rex
Author Date: 2023-01-23 02:35:14 UTC

MDEV-28620, MDEV-28621, MDEV-28622 Server crash in /sql/item_subselect.cc *

            Optimizer has eliminated subquery for various reasons.
            Attempting to walk or access Item_subselect (and descendents)
            values causes issues for these removed Items. Fixed by setting
            either fixed_const, null_value or checking eliminated.

Author: Andrei
Author Date: 2023-01-19 17:42:24 UTC

MDEV-30423 Deadlock on Replica during BACKUP STAGE BLOCK_COMMIT on XA transactions

The user XA commit execution branch was caught not have been covered
with MDEV-21953 fixes.

The XA involved deadlock is resolved now to apply the former fixes
pattern.
Along the fixes the following changes have been implemented.
- MDL lock attribute correction
- dissociation of the externally completed XA from the current
  thread's xid_state in the error branches
- cleanup_context() preseves the prepared XA
- wait_for_prior_commit() is relocated to satisfy both
  the binlog ON (log-slave-updates and skip-log-bin)
  and OFF slave execution branches.

Author: Sergey Petrunia
Author Date: 2023-01-23 11:10:24 UTC

MDEV-15178: Filesort::make_sortorder: Assertion `pos->field != __null |

(Initial patch by Varun Gupta. Amended and added comments).

When the query has both
1. Aggregate functions that require sorting data by group, and
2. Window functions

we need to use two temporary tables. The first temp.table will hold the
join output. Then it is passed to filesort(). Reading it in sorted
order allows to compute the aggregate functions.

Then, we need to write their values into the second temp. table. Then,
Window Function computation step can pass that to filesort() and read
them in the order it needs.

Failure to create the second temp. table would cause an assertion
failure: window function could would not find where to get the values
of the aggregate functions.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-23 12:36:13 UTC

MDEV-30393 InnoDB: Assertion failure in dict0dict.cc upon ADD FULLTEXT INDEX

Problem:
========
- InnoDB fails to remove the newly created table or index from
data dictionary and table cache if the alter fails in commit phase

Solution:
========
- InnoDB should restart the transaction to remove the newly
created table and index when it fails in commit phase of an alter
operation. innodb_fts.misc_debug tests the scenario with the
help of debug point "stats_lock_fail"

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-23 05:09:20 UTC

MDEV-29975 InnoDB fails to release savepoint during bulk insert

- InnoDB does partial rollback of bulk operation alone when
it encounter the failure during bulk insert operation. But InnoDB does
rollback the transaction unnecessarily.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-23 04:43:10 UTC

MDEV-29975 InnoDB fails to release savepoint during bulk insert

- InnoDB does rollback the whole transaction and discards the
savepoint when there is a failure happens during bulk
insert operation. When server request to release the savepoint,
InnoDB should return DB_SUCCESS when it deals with bulk
insert operation

Author: Oleg Smirnov
Author Date: 2023-01-21 14:01:35 UTC

MDEV-29693 Fix review comments

Part2. Get rid of virtual functions in Shared_ptr

Author: Sergei Golubchik
Author Date: 2023-01-20 18:43:40 UTC

MDEV-29461 AddressSanitizer: stack-buffer-overflow in strxmov

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-20 18:31:41 UTC

Change maturity

Author: Vicențiu Ciorbaru
Author Date: 2023-01-19 04:52:54 UTC

Fix connect bson.cpp warning

The ptyp variable is unused.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-20 10:37:43 UTC

MDEV-30438 innodb.undo_truncate,4k fails when innodb-immediate-scrub-data-uncompressed is enabled

- InnoDB fails to clear the freed ranges during truncation of innodb
undo log tablespace. During shutdown, InnoDB flushes the freed page
ranges and throws the out of bound error.

mtr_t::commit_shrink(): clear the freed ranges while doing undo
tablespace truncation

Author: Igor Babaev
Author Date: 2023-01-19 20:43:29 UTC

MDEV-30052 Crash with a query containing nested WINDOW clauses

Use SELECT_LEX to save lists for ORDER BY and GROUP BY before parsing
WINDOW clauses / specifications. This is needed for proper parsing
of a nested WINDOW clause when a WINDOW clause is used in a subquery
contained in another WINDOW clause.

Fix assignment of empty SQL_I_List to another one (in case of empty list
next shoud point on first).

Author: Oleg Smirnov
Author Date: 2023-01-12 06:18:33 UTC

MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()' failed in Item_cond::remove_eq_conds on SELECT

Item_singlerow_subselect may be converted to Item_cond during
optimization. So there is a possibility of constructing nested
Item_cond_and or Item_cond_or which is not allowed (such
conditions must be flattened).
This commit checks if such kind of optimization has been applied
and flattens the condition if needed

Author: Yuchen Pei
Author Date: 2023-01-18 00:51:28 UTC

MDEV-27912 Add paramter $expect_file_name to shutdown_mysqld.inc

With this change we will not have to maintain a separate version of
restart_mysqld.inc for spider, that duplicates code, just because
spider tests use different names for expect files, and shutdown_mysqld
requires magical names for them.

With this change spider tests will also be able to use other features
provided by restart_mysqld.inc without code duplication, like the
parameter $restart_parameters (see e.g. the testcase mdev_29904.test
in commit ef1161e5d4f).

Author: Oleg Smirnov
Author Date: 2023-01-12 06:18:33 UTC

MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()' failed in Item_cond::remove_eq_conds on SELECT

Item_singlerow_subselect may be converted to Item_cond during
optimization. So there is a possibility of constructing nested
Item_cond_and or Item_cond_or which is not allowed (such
conditions must be flattened).
This commit checks if such kind of optimization has been applied
and flattens the condition if needed

Author: Alexander Barkov
Author Date: 2023-01-20 05:52:00 UTC

MDEV-27653 long uniques don't work with unicode collations

There are no source code changes in this commit!
This is an empty follow-up commit for
  284ac6f2b73650f138064c97a96c8e1d8846550b
to comment what was done, as the patch itself did not have
change comments.

Problems solved in this patch:

1. The function calc_hash_for_unique() erroneously takes into account
the string length, so equal strings (in terms of the collation)
with different lengths got different hash value.

For example:
- LATIN LETTER A - 1 byte
- LATIN LETTER A WITH ACUTE - 2 bytes

are equal in utf8_general_ci, but as their lengths
are different, calc_hash_for_unique() returned
different hash values.

2. calc_hash_for_unique() also erroneously used val_str()
result to calculate hashes. This may not be correct for
some data types, e.g. TIMESTAMP, as its string
value depends on the session environment (e.g. @@time_zone).

Change summary:

Instead of doing Item::val_str(), we should always call
Field::hash() of the underlying Field. It properly
handles both cases (equal strings with different
lengths, as well as tricky data types like TIMESTAMP).

Detailed change description:

Non-functional changes (make the code cleaner):

- Adding a helper class Hasher, to pass hash parts
  nr1 and nr2 through function arguments easier.
- Splitting virtual Field::hash() into non-virtual
  wrapper Field::hash() and virtual Field::hash_not_null().
  This helps to get rid of duplicate code handling SQL NULL,
  as it was equal in all Field_xxx implementations.
- Adding a new method THD::my_ok_with_recreate_info().

Actual fix changes (make new tables work properly):

- Adding a virtual method Item::hash_not_null()
  This helps to handle hashes on full fields (Item_field)
  and hashes on prefix fields (Item_func_left(Item_field))
  in a polymorphic way.
  Implementing overrides for Item_field and Item_func_left.

- Rewriting Item_func_hash::val_int() to use Item::hash_not_null(),
  instead of the combination of val_str() and alc_hash_for_unique().

Backward compatibility changes (make old tables work in the new server):

- Adding a new class Item_func_hash_mariadb_100403.
  Moving the old version of Item_func_hash::val_int()
  into Item_func_hash_mariadb_100403::val_int().
  The old class Item_func_hash_mariadb_100403 is still needed,
  to open old tables before upgrade is done.

- Adding TABLE_SHARE::old_long_hash_function() and
  handler::check_long_hash_compatibility() to test
  if a table is using an old hash function.

- Adding a helper method TABLE_SHARE::make_long_hash_func()
  to instantiate either Item_func_hash_mariadb_100403 (for old
  not upgraded tables) or Item_func_hash (for new tables).

Upgrade changes (make old tables upgrade in the new server properly):

Upgrading an old table to a new hash can be done using either
of these two statements:

  ALTER IGNORE TABLE t1 FORCE;
  REPAIR TABLE t1;

!!! These statements find and filter out erreneous duplicates!!!
The table after these statements will have less records
if there were erroneous duplicates (such and A and A WITH ACUTE).

The information about filtered out records is reported in both statements.

- Adding a new class Recreate_info to return out information
  about copied and duplucate rows from these functions:
  - mysql_alter_table()
  - mysql_recreate_table()
  - admin_recreate_table()
  This helps to print a warning during REPAIR:

MariaDB [test]> repair table mdev27653_100422_text;
+----------------------------+--------+----------+------------------------------------+
| Table | Op | Msg_type | Msg_text |
+----------------------------+--------+----------+------------------------------------+
| test.mdev27653_100422_text | repair | Warning | Number of rows changed from 2 to 1 |
| test.mdev27653_100422_text | repair | status | OK |
+----------------------------+--------+----------+------------------------------------+
2 rows in set (0.018 sec)

Author: Daniele Sciascia
Author Date: 2023-01-19 08:25:40 UTC

Correct assert_grep.inc params in galera gcache tests

Author: Yuchen Pei
Author Date: 2023-01-19 07:28:14 UTC

MDEV-30370 MDEV-22979 MDEV-29904 MDEV-27912 Spider hang when abort

This is Kentoku's fix for MDEV-22979 (e6e41f04f4e + 22a0097727f),
which also fixes 30370. Adding a test for MDEV-29904 to avoid
regression, given MDEV-27233 is a similar problem.

Also update restart_spider.inc to allow passing restart_parameters, so
that the test of MDEV-29904 works (MDEV-27912).

Author: Yuchen Pei
Author Date: 2023-01-12 02:41:49 UTC

MDEV-26541 Make UBSAN builds work with spider again.

When built with ubsan and trying to load the spider plugin, the hidden
visibility of mysqld compiling flag causes ha_spider.so to be missing
the symbol ha_partition. This commit fixes that, as well as some
memcpy null pointer issues when built with ubsan.

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>

Author: Yuchen Pei
Author Date: 2023-01-12 02:41:49 UTC

MDEV-26541 Make UBSAN builds work with spider again.

When built with ubsan and trying to load the spider plugin, the hidden
visibility of mysqld compiling flag causes ha_spider.so to be missing
the symbol ha_partition. This commit fixes that, as well as some
memcpy null pointer issues when built with ubsan.

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>

Author: Yuchen Pei
Author Date: 2023-01-12 02:41:49 UTC

MDEV-26541 Make UBSAN builds work with spider again.

When built with ubsan and trying to load the spider plugin, the hidden
visibility of mysqld compiling flag causes ha_spider.so to be missing
the symbol ha_partition. This commit fixes that, as well as some
memcpy null pointer issues when built with ubsan.

Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com>

Author: Marko Mäkelä
Author Date: 2023-01-19 14:05:14 UTC

Merge 10.6

Author: Alexander Barkov
Author Date: 2022-11-09 12:41:19 UTC

MDEV-23335 MariaBackup Incremental Does Not Reflect Dropped/Created Databases

Author: Daniel Black
Author Date: 2023-01-19 07:48:37 UTC

MDEV-30203: Move mysql symlinks to different package (script fix)

Move the scripts/CMakeLists.txt install links into INSTALL_SCRIPT.

As a result the linking of mariadb-install-db isn't needed.

INSTALL_SCRIPT components outside the scripts (like rocksdb)
now get the same attention.

Author: Daniel Black
Author Date: 2023-01-19 07:48:37 UTC

MDEV-30203: Move mysql symlinks to different package (script fix)

Move the scripts/CMakeLists.txt install links into INSTALL_SCRIPT.

As a result the linking of mariadb-install-db isn't needed.

INSTALL_SCRIPT components outside the scripts (like rocksdb)
now get the same attention.

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-19 06:43:51 UTC

Merge branch '10.11' into 11.0

Author: Yuchen Pei
Author Date: 2023-01-18 07:21:53 UTC

MDEV-30370 WIP extract init_queries to its own thread

Author: Sergey Petrunia
Author Date: 2023-01-18 17:17:51 UTC

MDEV-30052: SIGSEGV in subquery_types_allow_materialization, fix variant 2

remove_redundant_subquery_clauses() also removes elements from the
select list. It does so, because GROUP BY code might have added GROUP
BY columns there.

In this bug, it has tried to remove a select list element that was not
added, it was in the select list from the start.

Attempt to remove this element caused data corruption, as the current
select list (join->all_fields) shares elements with the original list
(join->fields_list).

Fixed by not attempting to remove elements that are in join->fields_list.

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-18 15:45:59 UTC

Merge branch '10.9' into 10.10

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-18 15:39:11 UTC

Merge branch '10.8' into 10.9

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-18 15:37:40 UTC

Merge branch '10.7' into 10.8

Author: Oleksandr "Sanja" Byelkin
Author Date: 2023-01-18 15:36:13 UTC

Merge branch '10.6' into 10.7

Author: Nikita Malyavin
Author Date: 2023-01-18 11:49:35 UTC

REfactor REPLACE!!!!

Author: Vladislav Vaintroub
Author Date: 2023-01-17 19:37:20 UTC

Skip optimizer_cost test, if perfschema is not compiled in.

The test is sensitive to number of engines that are statically compiled in.

Author: Vladislav Vaintroub
Author Date: 2023-01-17 19:37:20 UTC

Skip optimizer_cost test, if perfschema is not compiled in.

The test is sensitive to number of engines that are statically compiled in.

Author: Sergei Golubchik
Author Date: 2023-01-16 11:08:05 UTC

fix failures of main.func_json --ps

in normal execution, the item is wrapped in Item_func_conv_charset.

in --ps the whole is wrapped again in Item_direct_ref_to_item

Author: Sergei Golubchik
Author Date: 2023-01-17 09:58:00 UTC

MDEV-26506 Over-quoted JSON when combining JSON_ARRAYAGG with JSON_OBJECT

add the test case

Author: midenok
Author Date: 2022-12-10 11:25:55 UTC

MDEV-29831 Galera crashes when running CoR for a locked table after
    setting the minimum memory for a user session.

Failure happens when finalize_atomic_replace() was already finished
and we removed the table from locked tables list.
finalize_locked_tables() doesn't know about that, it doesn't add back
last deleted lock because operation_failed == true.
reopen_tables() doesn't reopen table and as a result we have NULL in
pos_in_locked_tables->table.

The fix adds the knowledge that the locked_tables_count changed since
the start of the command. And if that happened we
add_back_last_deleted_lock(). That makes MDEV-29544 fix with
locked_tables_decremented deprecated.

Alternative fix would add atomic_replace_finished to Atomic_info and
updated it on successful finalize_atomic_replace(). Then the condition
would look like this:

  if (atomic_replace_finished || !operation_failed)
  {
    /*
      Add back the deleted table and re-created table as a locked table
      This should always work as we have a meta lock on the table.
    */
    thd->locked_tables_list.add_back_last_deleted_lock(pos_in_locked_tables);
  }

Author: Andrei
Author Date: 2023-01-16 20:25:22 UTC

Poc for MDEV-21953++

Author: sjaakola
Author Date: 2022-06-30 08:39:05 UTC

MDEV-26391 BF abortable mariabackup execution

Forcing old style node desync and pause, despite of WSREP_MODE_BF_MARIABACKUP
if node is operating as SST donor.

Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>

Author: Daniel Black
Author Date: 2023-01-11 23:34:14 UTC

Use MariaDB as the project name in CMakeLists.txt (fix)

Partial revert of d29d915790f7da41cd89c469f0a4c6c9b8f8a5c3.

It seems from CI that lower case RPM names are generated without
explictly setting the package name to mixed case.

Author: Yuchen Pei
Author Date: 2023-01-13 07:23:09 UTC

Revert "MDEV-20502 Queries against spider tables return wrong values for columns following constant declarations."

This reverts commit 69c86abb646361c607a248f079f8fd4e600dcada.

Author: Jan Lindström
Author Date: 2023-01-15 10:55:57 UTC

Revert "Merge branch 10.4 into 10.5"

This reverts commit 179c2833721292a918280b7d114d94d81020105b, reversing
changes made to a44d896f98f2d2a3ebf0f1393bf84fd659ecd225.

Author: Jan Lindström
Author Date: 2023-01-15 10:01:50 UTC

Revert "Merge branch 10.4 into 10.5"

This reverts commit 179c2833721292a918280b7d114d94d81020105b, reversing
changes made to 981a6b704475176d032c13461baffcaf88802d34.

Author: Jan Lindström
Author Date: 2023-01-15 09:05:26 UTC

Merge 10.5 into 10.6

Author: Monty
Author Date: 2023-01-12 20:31:18 UTC

MDEV-30395 Wrong result with semijoin and Federated as outer table

The problem was that federated engine does not support comparable rowids
which was not taken into account by semijoin code.

Fixed by checking that we don't use semijoin with tables that does not
support comparable rowids.

Other things:
- Fixed some typos in the code comments

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2023-01-13 13:40:50 UTC

MDEV-30341 ASAN failure in row_merge_bulk_t::~row_merge_bulk_t()

- InnoDB fails to apply the bulk insert operation during fts_commit.

Author: Julius Goryavsky
Author Date: 2023-01-12 20:54:25 UTC

Merge 10.3 into 10.4

Author: Sergey Petrunia
Author Date: 2023-01-12 12:55:40 UTC

MDEV-30081: Crash with split_materialized over a VIEW

Consider a view and use of Split Materialized optimization to read it:

  create view v1 as (SELECT ... id1 FROM t1 GROUP BY id1);
  SELECT ... LEFT JOIN v1 ON v1.id1 = tbl2.col

Split Materialized will need to construct ref access inside the view:

  t1.id1= {outer reference to tbl2.col}

It will do so by cloning both parts of the equality (v1.id1 =tbl2.col)
and then "pushing it down" into subquery by calling

  item->walk(&Item::set_fields_as_dependent_processor, parent_join->select_lex)

for both parts of the equality.
The problem was that left part of the equality was "v1.id1", namely an
Item_direct_view_ref, which did not implement
set_fields_as_dependent_processor() function.

Failure to do that resulted in Item_direct_view_ref reporting invalid
used_tables() in some cases (the case we've hit required that
Item_direct_view_ref is inside an outer join, and the column it refers
to is marked as constant)

Fixed by implementing Item_direct_ref::set_fields_as_dependent_processor().

Author: Monty
Author Date: 2023-01-12 00:48:33 UTC

Fixed failing test main.func_json

Author: midenok
Author Date: 2023-01-11 12:37:27 UTC

Rebase fix

Author: Vladislav Vaintroub
Author Date: 2023-01-10 10:56:44 UTC

MDEV-26714 - fix mariadb-upgrade

mariadb-upgrade needs to accept credential-manager parameter.
At the moment, it would have no effect - all the credential manager logic
is encapsulated inside cli_connect, and mariadb-upgrade does not
connect to the server itself (instead invoking the cli)