Merge ~ltrager/maas:vcenter_creds_ui into maas:master

[Lee Trager]

Allow settings vCenter credentials on the settings page in the UI.

https://screenshots.firefox.com/Vtet15ZLjt2yDUEV/10.0.0.2

95e5c8e... by Lee Trager on 2019-04-14

s/windows/vcenter/g

[Björn Tillenius (bjornt)]

The code itself looks good. But i'd like to take the opportunity to clarify how this is expected to work.

Do we have the workflow written down somewhere?

I'm a bit concerned that the description says that the credentials are being sent to the deployed how. So how do we prevent a normal user to be able to access those credentials?

review: Needs Information

[Andres Rodriguez (andreserl)]

Those credentials are sent to the node via the bender data, the same way we
send other administrative data that no other users have access.

This is the same way you wouldn’t send landscape credentials via cloud-init
for auto config.

On Mon, Apr 15, 2019 at 3:44 AM Björn Tillenius <email address hidden> wrote:

> Review: Needs Information
>
> The code itself looks good. But i'd like to take the opportunity to
> clarify how this is expected to work.
>
> Do we have the workflow written down somewhere?
>
> I'm a bit concerned that the description says that the credentials are
> being sent to the deployed how. So how do we prevent a normal user to be
> able to access those credentials?
> --
> https://code.launchpad.net/~ltrager/maas/+git/maas/+merge/365985
> Your team MAAS Committers is subscribed to branch maas:master.
>
> Launchpad-Message-Rationale: Subscriber @maas-committers
> Launchpad-Message-For: maas-committers
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~maas-committers/maas/+git/maas:master
> Launchpad-Project: maas
>
--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

[Björn Tillenius (bjornt)]

So I think this deserves a write-up to discuss what attack vector we protect against, and which we don't. Sending anything to the nodes open up a range of attach vectors, and considering these are shared global credentials, we should be clear on how they can be exposed to users that shouldn't have access to them.

[Andres Rodriguez (andreserl)]

That however, sits outside of the scope of this branch!

On Mon, Apr 15, 2019 at 4:51 AM Björn Tillenius <email address hidden> wrote:

> So I think this deserves a write-up to discuss what attack vector we
> protect against, and which we don't. Sending anything to the nodes open up
> a range of attach vectors, and considering these are shared global
> credentials, we should be clear on how they can be exposed to users that
> shouldn't have access to them.
> --
> https://code.launchpad.net/~ltrager/maas/+git/maas/+merge/365985
> Your team MAAS Committers is subscribed to branch maas:master.
>
> Launchpad-Message-Rationale: Subscriber @maas-committers
> Launchpad-Message-For: maas-committers
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~maas-committers/maas/+git/maas:master
> Launchpad-Project: maas
>
--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

[Björn Tillenius (bjornt)]

We discussed this on the standup. As mentioned, my comments weren't on this branch in particular, but rather on the feature as whole.

So I'm approving this branch, and then Lee can update the spec and make it so that only admins and operators can deploy machines using these credentials.

review: Approve

diff --git a/src/maasserver/forms/__init__.py b/src/maasserver/forms/__init__.py
index d1e653c..4d90cea 100644
--- a/src/maasserver/forms/__init__.py
+++ b/src/maasserver/forms/__init__.py
@@ -62,6 +62,7 @@ __all__ = [
     "UpdateRaidForm",
     "UpdateVirtualBlockDeviceForm",
     "UpdateVolumeGroupForm",
+    "VCenterForm",
     "WindowsForm",
     "ZoneForm",
     ]
@@ -1736,6 +1737,14 @@ class WindowsForm(ConfigForm):
     windows_kms_host = get_config_field('windows_kms_host')
 
 
+class VCenterForm(ConfigForm):
+    """Settings page, VMware vCenter section."""
+    vcenter_server = get_config_field('vcenter_server')
+    vcenter_username = get_config_field('vcenter_username')
+    vcenter_password = get_config_field('vcenter_password')
+    vcenter_datacenter = get_config_field('vcenter_datacenter')
+
+
 class GlobalKernelOptsForm(ConfigForm):
     """Settings page, Global Kernel Parameters section."""
     kernel_opts = get_config_field('kernel_opts')
diff --git a/src/maasserver/templates/maasserver/settings_general.html b/src/maasserver/templates/maasserver/settings_general.html
index 636f153..5f5e97d 100644
--- a/src/maasserver/templates/maasserver/settings_general.html
+++ b/src/maasserver/templates/maasserver/settings_general.html
@@ -130,6 +130,22 @@
 
     <div class="p-strip is-bordered">
         <div class="row">
+            <div id="vcenter" class="col-8">
+                <h2 class="p-heading--four">VMware vCenter</h2>
+                <form action="{% url 'settings_general' %}" method="post">
+                    {% csrf_token %}
+                    <ul class="p-list">
+                        {% for field in vcenter_form %} {% include "maasserver/form_field.html" %} {% endfor %}
+                    </ul>
+                    <input type="hidden" name="vcenter_submit" value="1" />
+                    <button type="submit" class="p-button--positive u-float--right">Save</button>
+                </form>
+            </div>
+        </div>
+    </div>
+
+    <div class="p-strip is-bordered">
+        <div class="row">
             <div id="third_party_drivers" class="col-8">
                 <h2 class="p-heading--four">Third Party Drivers Configuration</h2>
                 <form action="{% url 'settings_general' %}" method="post">
diff --git a/src/maasserver/views/settings.py b/src/maasserver/views/settings.py
index 9d3ef97..d22f015 100644
--- a/src/maasserver/views/settings.py
+++ b/src/maasserver/views/settings.py
@@ -1,4 +1,4 @@
-# Copyright 2012-2018 Canonical Ltd.  This software is licensed under the
+# Copyright 2012-2019 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Settings views."""
@@ -47,6 +47,7 @@ from maasserver.forms import (
     SyslogForm,
     ThirdPartyDriversForm,
     UbuntuForm,
+    VCenterForm,
     WindowsForm,
 )
 from maasserver.models import (
@@ -283,6 +284,13 @@ def general(request):
     if response is not None:
         return response
 
+    # Process the VMware vCenter form.
+    vcenter_form, response = process_form(
+        request, VCenterForm, reverse('settings_general'), 'vcenter',
+        "Configuration updated.")
+    if response is not None:
+        return response
+
     # Process the Global Kernel Opts form.
     kernelopts_form, response = process_form(
         request, GlobalKernelOptsForm, reverse('settings_general'),
@@ -300,6 +308,7 @@ def general(request):
             'deploy_form': deploy_form,
             'ubuntu_form': ubuntu_form,
             'windows_form': windows_form,
+            'vcenter_form': vcenter_form,
             'kernelopts_form': kernelopts_form,
             'show_license_keys': show_license_keys(),
         })
diff --git a/src/maasserver/views/tests/test_settings.py b/src/maasserver/views/tests/test_settings.py
index d8d0ae0..5033c6e 100644
--- a/src/maasserver/views/tests/test_settings.py
+++ b/src/maasserver/views/tests/test_settings.py
@@ -1,4 +1,4 @@
-# Copyright 2012-2018 Canonical Ltd.  This software is licensed under the
+# Copyright 2012-2019 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Test maasserver settings views."""
@@ -243,6 +243,22 @@ class SettingsTest(MAASServerTestCase):
                 Config.objects.get_config('commissioning_distro_series'),
             ))
 
+    def test_settings_vcenter_POST(self):
+        self.client.login(user=factory.make_admin())
+        vcenter = {
+            'vcenter_server': factory.make_name('vcenter_server'),
+            'vcenter_username': factory.make_name('vcenter_username'),
+            'vcenter_password': factory.make_name('vcenter_password'),
+            'vcenter_datacenter': factory.make_name('vcenter_datacenter'),
+        }
+        response = self.client.post(
+            reverse('settings_general'),
+            get_prefixed_form_data(prefix='vcenter', data=vcenter),
+        )
+        self.assertEqual(http.client.FOUND, response.status_code)
+        self.assertDictEqual(
+            vcenter, Config.objects.get_configs(vcenter.keys()))
+
     def test_settings_hides_license_keys_if_no_OS_supporting_keys(self):
         self.client.login(user=factory.make_admin())
         response = self.client.get(reverse('settings_general'))