Merge ~ltrager/maas:vcenter_creds_ui into maas:master
Proposed by
Lee Trager
Status: | Merged |
---|---|
Approved by: | Lee Trager |
Approved revision: | 95e5c8e31c89c86b7928e9a01d5611af7128d31a |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~ltrager/maas:vcenter_creds_ui |
Merge into: | maas:master |
Diff against target: |
127 lines (+52/-2) 4 files modified
src/maasserver/forms/__init__.py (+9/-0) src/maasserver/templates/maasserver/settings_general.html (+16/-0) src/maasserver/views/settings.py (+10/-1) src/maasserver/views/tests/test_settings.py (+17/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Björn Tillenius | Approve | ||
Review via email: mp+365985@code.launchpad.net |
Commit message
Allow settings vCenter credentials on the settings page in the UI.
Description of the change
To post a comment you must log in.
The code itself looks good. But i'd like to take the opportunity to clarify how this is expected to work.
Do we have the workflow written down somewhere?
I'm a bit concerned that the description says that the credentials are being sent to the deployed how. So how do we prevent a normal user to be able to access those credentials?