Merge ~kissiel/checkbox-support:fix-1625926-pactl-db-missing into checkbox-support:master
Proposed by
Maciej Kisielewski
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | b57d46623217e4b803dce680e78688a251b754e9 |
Merged at revision: | bb54e6df53f117e27035fc0d9a95c11d2c803066 |
Proposed branch: | ~kissiel/checkbox-support:fix-1625926-pactl-db-missing |
Merge into: | checkbox-support:master |
Diff against target: |
15 lines (+2/-2) 1 file modified
checkbox_support/parsers/pactl.py (+2/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Larson | Approve | ||
Maciej Kisielewski | Needs Resubmitting | ||
Review via email: mp+325481@code.launchpad.net |
Description of the change
Fix jobs observing pactl output on systems that do not report volume in decibels.
TESTING:
On most systems nothing should change, so to verify that I used .*plug-detection jobs from plainbox-
`checkbox-cli run .*plug-detection`
To verify if the patch fixes this problem I used this somerville’s pactl_list_
To post a comment you must log in.
Oh, and should you be comparing the raw pyparsing output, keep in mind that value returned contains dicts, which can, and probably will differ in ordering, making the diff report irregularities.