Code review comment for ~kissiel/checkbox-support:fix-1625926-pactl-db-missing

Revision history for this message
Paul Larson (pwlars) wrote :

A couple of questions. I haven't looked exactly where/how this gets used yet, but I did a dumb test of the regex against your example and the groups returned look something like this:
('front-right: 31008 / 47% / -19.50 dB', ' / -19.50 dB', '19.50')
I'm not sure that second group would be very useful.

My first thought on looking at this though, made me wonder - "how much are we doing with pactl list sinks output that we need an entire parser for that!?"

It's perhaps outside the scope of this patch, and perhaps we really do need a parser for it, but if they don't keep the output consistent enough, then debugging and fixing stuff like this gets harder to trace.

review: Needs Information

« Back to merge proposal