Code review comment for ~kissiel/checkbox-support:fix-1625926-pactl-db-missing

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> how much are we doing with pactl list sinks output that we need an entire parser for that!?

Apparently not much, as the patch I proposed here messed up grouping (the optional group was not non-capturing) and it still worked.

I would like to propose "The Three Strikes" rule for those quite-complex-but-probably-not-needed solutions.

Oh, and BTW. I just amended the fix with making the group non-capturing.

review: Needs Resubmitting

« Back to merge proposal