Merge lp:~ki7mt/ubuntu-manual-tests/server-upgrade-cli into lp:ubuntu-manual-tests

Proposed by Greg Beam
Status: Merged
Merged at revision: 264
Proposed branch: lp:~ki7mt/ubuntu-manual-tests/server-upgrade-cli
Merge into: lp:ubuntu-manual-tests
Diff against target: 115 lines (+111/-0)
1 file modified
testcases/image/Server_Upgrade_CLI (+111/-0)
To merge this branch: bzr merge lp:~ki7mt/ubuntu-manual-tests/server-upgrade-cli
Reviewer Review Type Date Requested Status
Elfy (community) Approve
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+202185@code.launchpad.net

Description of the change

lp:1172452
https://bugs.launchpad.net/ubuntu-manual-tests/+bug/1172452

Test Case(s): server-upgrade (command-line) tests.

This needs a thorough review, as there are many test variables which affect the outcome.

See commit log for details.
.

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Both this and https://code.launchpad.net/~ki7mt/ubuntu-manual-tests/lp1168084-fix/+merge/201878 need a good looking at. Thanks for providing these testcases!

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I have some minor edits to suggest as far as grammar and layout go. Overall, I think this is ready to go. Make the tweaks and we'll merge. Remember to check spelling and grammar one last time when you are finished. Thanks again!

---
A couple tweaks in language. In general the expected results don't need to read "should". State the result as fact. Something like this example below.
<dd>Old packages should be removed</dd>

to

<dd>Old packages are removed</dd>

When prompting to run something on the command line I'd suggest using the <pre> tag to set it apart nicely. IE,
<dt>Check release-upgrade setting: <pre>grep '^Prompt=' /etc/update-manager/release-upgrades</pre></dt>

Use <em> to se apart prompts. For example,
<dt>When asked, <em>Restart services during package upgrades without asking</em>, select "Yes"</dt>

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Are you able to finish this? Just a couple minor edits are needed. Thanks!

262. By Greg Beam

updates from review comments

Revision history for this message
Elfy (elfy) wrote :

This testcase is still showing "should's" can we get those changed pleased.

Eg

<dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
        <dd>APT should update</dd>
        <dd>If asked to install files, type <em>Y</em></dd>
        <dd>New version files should install</dd>

needs to be

<dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
        <dd>APT updates</dd>
        <dd>If asked to install files, type <em>Y</em></dd>
        <dd>New version files install</dd>

You can put my name as the reviewer, I'll get these merged and synced as soon as I see it.

Revision history for this message
Elfy (elfy) wrote :

missed the review type ...

review: Needs Fixing
263. By Greg Beam

Fix syntax and edit grammer

264. By Greg Beam

add case names and descriptions

Revision history for this message
Elfy (elfy) wrote :

Thanks ki7mt - they look good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'testcases/image/Server_Upgrade_CLI'
2--- testcases/image/Server_Upgrade_CLI 1970-01-01 00:00:00 +0000
3+++ testcases/image/Server_Upgrade_CLI 2014-06-25 19:08:46 +0000
4@@ -0,0 +1,111 @@
5+Test-case name: server_upgrade_cli_NEVER
6+This will test protection from do-release-upgrade
7+<dl>
8+ <dt>Login into the system locally, or via SSH</dt>
9+ <dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
10+ <dd>APT will update</dd>
11+ <dd>If asked to install files, type <em>Y</em></dd>
12+ <dd>New version files install</dd>
13+ <dt>Check release-upgrade setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
14+ <dd>Return: Prompt=normal</dd>
15+ <dd>If Prompt=normal then: sudo sed -i 's/Prompt=never/Prompt=never/'</dd>
16+ <dd>If Prompt=lts then: sudo sed -i 's/Prompt=lts/Prompt=never/'</dd>
17+ <dt>Check release-setting again: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
18+ <dd>Return: Prompt=normal</dd>
19+ <dd> If sed command fails, edit manually, changing to: Prompt=never</dd>
20+ <dt>Start the upgrade: sudo do-release-upgrade</dt>
21+ <dd>Checking for new Ubuntu release</dd>
22+ <dd>No new release be found</dd>
23+ <dd>Return to the command prompt</dd>
24+</dl>
25+
26+Test-case name: server_upgrade_cli_NORMAL
27+This will test the next sequential release
28+<dl>
29+ <dt>Login into the system locally, or via SSH</dt>
30+ <dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
31+ <dd>APT will update</dd>
32+ <dd>If asked to install files, type <em>Y</em></dd>
33+ <dd>New version files install</dd>
34+ <dt>Check release-upgrade setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
35+ <dd>Return: Prompt=normal</dd>
36+ <dd>If Prompt=never then: sudo sed -i 's/Prompt=never/Prompt=normal/'</dd>
37+ <dd>If Prompt=lts then: sudo sed -i 's/Prompt=lts/Prompt=normal/'</dd>
38+ <dt>Re-Check release-setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
39+ <dd>Return: Prompt=normal</dd>
40+ <dd> If sed command fails, edit manually, changing to: Prompt=normal</dd>
41+ <dt>Check current release: lsb_release -r</dt>
42+ <dd>Note the release version</dd>
43+ <dt>Start the upgrade: sudo do-release-upgrade</dt>
44+ <dd>APT will check release data and update package list</dd>
45+ <dd>If a new release is found, APT will add repositories and upgrade</dd>
46+ <dt>When asked to start the upgrade, type <em>Y</em></dt>
47+ <dt>When asked, restart services during package upgrades without asking, select <em>Yes</em></dt>
48+ <dt>When asked, remove obsolete packages, type <em>Y</em></dt>
49+ <dt>Login into the system</dt>
50+ <dt>Check release version: lsb_release -r</dt>
51+ <dd>Compare results to step(5), will be the next sequential release.</dd>
52+</dl>
53+
54+Test-case name: server_upgrade_cli_LTS
55+This will test upgrading LTS to LTS
56+<dl>
57+ <dt>Login into the system locally, or via SSH</dt>
58+ <dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
59+ <dd>APT will update</dd>
60+ <dd>If asked to install files, type <em>Y</em></dd>
61+ <dd>New version files install</dd>
62+ <dt>Check release-upgrade setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
63+ <dd>Return: Prompt=normal</dd>
64+ <dd>If Prompt=normal then: sudo sed -i 's/Prompt=normal/Prompt=lts/'</dd>
65+ <dd>If Prompt=never then: sudo sed -i 's/Prompt=never/Prompt=lts/'</dd>
66+ <dt>Re-Check release-setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
67+ <dd>Return: Prompt=normal</dd>
68+ <dd> If sed command fails, edit manually, changing to: Prompt=LTS</dd>
69+ <dt>Check current release: lsb_release -r</dt>
70+ <dd>Note the release version</dd>
71+ <dt>Start the upgrade: sudo do-release-upgrade</dt>
72+ <dd>APT will check release data and update package list</dd>
73+ <dd>If a new release is found, APT will add repositories and upgrade</dd>
74+ <dt>When asked to start the upgrade, type <em>Y</em></dt>
75+ <dt>When asked, restart services during package upgrades without asking, select <em>Yes</em></dt>
76+ <dt>When asked, Remove obsolete packages, type <em>Y</em></dt>
77+ <dt>To finished the upgrade, restart required, type <em>Y</em></dt>
78+ <dd>The system will reboot.</dd>
79+ <dt>Login into the system</dt>
80+ <dt>Check the release version: lsb_release -r</dt>
81+ <dd>Compare results to step(5), will be the next sequential LTS release.</dd>
82+</dl>
83+
84+Test-case name: server_upgrade_cli_DEV
85+This will test upgrading to a development release
86+<dl>
87+ <dt>Login into the system locally, or via SSH</dt>
88+ <dt>In the terminal: sudo apt-get update && sudo apt-get upgrade</dt>
89+ <dd>APT will update</dd>
90+ <dd>If asked to install files, type <em>Y</em></dd>
91+ <dd>New version files install</dd>
92+ <dt>Check release-upgrade setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
93+ <dd>Return: Prompt=normal</dd>
94+ <dd>If Prompt=never then: sudo sed -i 's/Prompt=never/Prompt=normal/'</dd>
95+ <dd>If Prompt=LTS then: sudo sed -i 's/Prompt=lts/Prompt=normal/'</dd>
96+ <dt>Re-Check release-setting: grep '^Prompt=' /etc/update-manager/release-upgrades</dt>
97+ <dd>Return: Prompt=normal</dd>
98+ <dd> If sed command fails, edit manually, changing to: Prompt=LTS</dd>
99+ <dt>Check current release: lsb_release -r></dt>
100+ <dd>Note the release version</dd>
101+ <dt>Start the upgrade: sudo do-release-upgrade -d</dt>
102+ <dd>APT will check release data and update package list</dd>
103+ <dd>If a new release is found, APT will add new repositories and start the upgrade</dd>
104+ <dt>When asked to start the upgrade, type <em>Y</em></dt>
105+ <dd>The installation will continue</dd>
106+ <dt>When asked, restart services during package upgrades without asking, select <em>Yes</em></dt>
107+ <dt>When asked, remove obsolete packages, type <em>Y</em></dt>
108+ <dt>To finished the upgrade, restart required, type <em>Y</em></dt>
109+ <dd>The system will reboot.</dd>
110+ <dt>Login into the system</dt>
111+ <dt>Check the release version: lsb_release -r</dt>
112+ <dd>Compare results to step(5), will be the next development release.</dd>
113+</dl>
114+<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
115+ If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>

Subscribers

People subscribed via source and target branches