Code review comment for lp:~ki7mt/ubuntu-manual-tests/server-upgrade-cli

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I have some minor edits to suggest as far as grammar and layout go. Overall, I think this is ready to go. Make the tweaks and we'll merge. Remember to check spelling and grammar one last time when you are finished. Thanks again!

---
A couple tweaks in language. In general the expected results don't need to read "should". State the result as fact. Something like this example below.
<dd>Old packages should be removed</dd>

to

<dd>Old packages are removed</dd>

When prompting to run something on the command line I'd suggest using the <pre> tag to set it apart nicely. IE,
<dt>Check release-upgrade setting: <pre>grep '^Prompt=' /etc/update-manager/release-upgrades</pre></dt>

Use <em> to se apart prompts. For example,
<dt>When asked, <em>Restart services during package upgrades without asking</em>, select "Yes"</dt>

review: Needs Fixing

« Back to merge proposal