Merge lp:~ki7mt/ubuntu-manual-tests/lp1168084-fix into lp:ubuntu-manual-tests

Proposed by Greg Beam on 2014-01-16
Status: Merged
Merged at revision: 267
Proposed branch: lp:~ki7mt/ubuntu-manual-tests/lp1168084-fix
Merge into: lp:ubuntu-manual-tests
Diff against target: 83 lines (+74/-0)
2 files modified
testcases/image/Install_Minimal_System (+37/-0)
testcases/image/Install_Minimal_Virtual_System (+37/-0)
To merge this branch: bzr merge lp:~ki7mt/ubuntu-manual-tests/lp1168084-fix
Reviewer Review Type Date Requested Status
Elfy (community) Approve on 2014-06-25
Nicholas Skaggs (community) 2014-01-16 Needs Fixing on 2014-01-27
Review via email: mp+201878@code.launchpad.net

Description of the change

To post a comment you must log in.
262. By Greg Beam on 2014-01-16

Fixed a couple </dt> Tags to Orignal MP

Nicholas Skaggs (nskaggs) wrote :

I would make the same comments regarding grammar and tags on this merge as on the other merge; https://code.launchpad.net/~ki7mt/ubuntu-manual-tests/server-upgrade-cli/+merge/202185/comments/474664

A couple other thoughts;

1) Don't supply an example username and password; let the user choose
2) I'm confused by the keyboard layout step;

15 + <li>Select layout, "No"</li>
16 + <li>Select country</li>
17 + <li>Select layout</li>

What does this mean?

Overall, good work. Thanks!

review: Needs Fixing
Nicholas Skaggs (nskaggs) wrote :

Are you able to finish this? Just a couple minor edits are needed. Thanks!

Greg Beam (ki7mt) wrote :

Hi Nicholas,

I had forgotten about this actually. If you know what needs doing, go
ahead and fix it up, otherwise I'll have to dig into it again, as it's
been a while, and I certainly don't recall all the in's & out's.

Greg,

On 05/13/2014 05:54 PM, Nicholas Skaggs wrote:
> Are you able to finish this? Just a couple minor edits are needed. Thanks!

263. By Greg Beam on 2014-05-20

update from review comments

Elfy (elfy) wrote :

There are syntax errors in the Install_Minimal_System testcase - have a look at https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide/test_case_format_script

Typo "ncruses"

Not too sure what nskaggs comments re keyboard layout refer to, but it appears to be the same.

Virtual system testcase - ncruses typo.

Asa with the other MP - name me as reviewer and I'll get to it as soon as I can

Elfy (elfy) wrote :

missed the review type ...

review: Needs Fixing
264. By Greg Beam on 2014-06-25

Fix syntax and edit grammer

265. By Greg Beam on 2014-06-25

remove hostname, username and password suggestions

266. By Greg Beam on 2014-06-25

replace double quotes with <em>

267. By Greg Beam on 2014-06-25

fix more syntax errors

Elfy (elfy) wrote :

Thanks ki7mt - they look good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'testcases/image/Install_Minimal_System'
2--- testcases/image/Install_Minimal_System 1970-01-01 00:00:00 +0000
3+++ testcases/image/Install_Minimal_System 2014-06-25 10:54:40 +0000
4@@ -0,0 +1,37 @@
5+<dl>
6+ <dt>Boot up the server image</dt>
7+ <dt>Select language</dt>
8+ <dt>Press F4, arrow down, select <em>Install a minimal system</em></dt>
9+ <dt>Press Enter, selecting <em>Install FAMILY Server</em></dt>
10+ <dt>Choose the language</dt>
11+ <dt>Select your location</dt>
12+ <dt>Configure the keyboard</dt>
13+ <ul>
14+ <li>Select layout, <em>No</em></li>
15+ <li>Select country</li>
16+ </ul>
17+ <dt>Choose a hostname</dt>
18+ <dt>Choose a username</dt>
19+ <dt>Choose a password</dt>
20+ <dt>Re-enter password</dt>
21+ <dt>Encrypt your home directory, <em>No</em></dt>
22+ <dt>Is this time zone correct? <em>Yes</em> or <em>No</em> to setup</dt>
23+ <dt>Partitioning method, <em>Guided - Use entire disk</em></dt>
24+ <dt>Select disk to partition, use the listed device</dt>
25+ <dt>Write changes to disks, verify targets, if correct, <em>Yes</em> to start</dt>
26+ <dt>http proxy request, leave blank</dt>
27+ <dt>How do you want to manage upgrades on this system? <em>No automatic updates</em></dt>
28+ <dt>Choose software, Tab to <em>continue</em>, no additional selections</dt>
29+ <dt>Install the GRUB boot loader to the master boot record, <em>Yes</em></dt>
30+ <dt>Remove the installation media (CDROM or USB key), then <em>continue</em></dt>
31+ <dt>Wait for the system reboot, then login</dt>
32+ <dt>Verify Internet access: sudo apt-get update</dt>
33+ <dd>Provide sudo password</dd>
34+ <dd>apt-get will perform a normal update</dd>
35+ <dt>Verify access to tasksel: sudo tasksel</dt>
36+ <dd>ncurses GUI will render, listing upgrade options</dd>
37+ <dt>Select Tab, then <em>Ok</em> to exit</dt>
38+ <dt>Logout</dt>
39+</dl>
40+<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
41+ If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>
42
43=== added file 'testcases/image/Install_Minimal_Virtual_System'
44--- testcases/image/Install_Minimal_Virtual_System 1970-01-01 00:00:00 +0000
45+++ testcases/image/Install_Minimal_Virtual_System 2014-06-25 10:54:40 +0000
46@@ -0,0 +1,37 @@
47+<dl>
48+ <dt>Boot up the server image</dt>
49+ <dt>Select language</dt>
50+ <dt>Press F4, arrow down, select <em>Install a virtual minimal system</em>, press Enter</dt>
51+ <dt>Press Enter a 2nd time to <em>Install FAMILY Server</em></dt>
52+ <dt>Choose the language</dt>
53+ <dt>Select your location</dt>
54+ <dt>Configure the keyboard</dt>
55+ <ul>
56+ <li>Select layout, <em>No</em></li>
57+ <li>Select country</li>
58+ </ul>
59+ <dt>Choose a hostname</dt>
60+ <dt>Choose a username</dt>
61+ <dt>Choose a password</dt>
62+ <dt>Re-enter password</dt>
63+ <dt>Encrypt your home directory, <em>No</em></dt>
64+ <dt>Is this time zone correct? <em>Yes</em> if correct, <em>No</em> to setup</dt>
65+ <dt>Partitioning method, <em>Guided - Use entire disk</em></dt>
66+ <dt>Select disk to partition, use the listed device</dt>
67+ <dt>Write changes to disks, verify targets, if correct, <em>Yes</em> to start</dt>
68+ <dt>http proxy request, leave blank, <em>continue</em></dt>
69+ <dt>How do you want to manage upgrades on this system? <em>No automatic updates</em></dt>
70+ <dt>Choose software to install, Tab to <em>continue</em>, no additional selections</dt>
71+ <dt>Install the GRUB boot loader to the master boot record, <em>Yes</em></dt>
72+ <dt>Remove the installation media (CDROM or USB key), then <em>continue</em></dt>
73+ <dt>Wait for the system reboot and login</dt>
74+ <dt>Verify internet access with: sudo apt-get update</dt>
75+ <dd>When asked, add sudo password</dd>
76+ <dd>apt-get will perform a normal update</dd>
77+ <dt>Verify access to tasksel: sudo tasksel</dt>
78+ <dd>ncurses GUI will render, listing upgrade options</dd>
79+ <dt>Hit Tab, then <em>Ok</em> to exit.</dt>
80+ <dt>Logout by typing: <em>logout</em></dt>
81+</dl>
82+<strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
83+ If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result.</strong>

Subscribers

People subscribed via source and target branches