Merge lp:~jnsrch/bibcite/FormerCommitsUndone into lp:bibcite

Proposed by Jens Rauch
Status: Needs review
Proposed branch: lp:~jnsrch/bibcite/FormerCommitsUndone
Merge into: lp:bibcite
Diff against target: 66 lines (+19/-1) (has conflicts)
2 files modified
src/net/geoadel/bibcite/GUI/RelationManager.form (+8/-0)
src/net/geoadel/bibcite/GUI/RelationManager.java (+11/-1)
Text conflict in src/net/geoadel/bibcite/GUI/RelationManager.form
Text conflict in src/net/geoadel/bibcite/GUI/RelationManager.java
To merge this branch: bzr merge lp:~jnsrch/bibcite/FormerCommitsUndone
Reviewer Review Type Date Requested Status
BibCite-Team Pending
Review via email: mp+74130@code.launchpad.net

Description of the change

Could not get the trunk to run properly and had some issues after merging. So I uncommited your changes and only pushed mine into this new branch.

To post a comment you must log in.
Revision history for this message
Prunus dulcis (prunus-dulcis) wrote :

I had forgotten to add one new file - will have to remember to run
bzr add
after I create a new class, image or whatnot!

Can you test the latest revision, if it runs properly again? I will look
into the merging process now.

On 05/09/11 20:14, Jens Rauch wrote:
> The proposal to merge lp:~jnsrch/bibcite/FormerCommitsUndone into lp:bibcite has been updated.
>
> Description changed to:
>
> Could not get the trunk to run properly and had some issues after merging. So I uncommited your changes and only pushed mine into this new branch.
>
> For more details, see:
> https://code.launchpad.net/~jnsrch/bibcite/FormerCommitsUndone/+merge/74130

Revision history for this message
Prunus dulcis (prunus-dulcis) wrote :

Alright, I did a manual merge - my mistake for changing the JList variable names in my commit before.

Your suggested fix does not work for me (and why can I not attach pictures here).

jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);

leads for me to elements still being centered, but instead of just one column, the elements are now wrapped into several columns, making it visually closer to left-centered but not left centered.

You can create an element with a very short name (like 'a') to see what I mean, I hope. It is quite visible in trunk with the default dataset (if debug is set TRUE in BibCite.java). Trunk should work again, I hope I fixed the issues you had with it.

Unmerged revisions

214. By Jens Rauch

Fixes 840991

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/net/geoadel/bibcite/GUI/RelationManager.form'
--- src/net/geoadel/bibcite/GUI/RelationManager.form 2011-09-04 19:39:18 +0000
+++ src/net/geoadel/bibcite/GUI/RelationManager.form 2011-09-05 18:13:28 +0000
@@ -72,8 +72,13 @@
72 </Group>72 </Group>
73 <EmptySpace type="unrelated" max="-2" attributes="0"/>73 <EmptySpace type="unrelated" max="-2" attributes="0"/>
74 <Group type="103" groupAlignment="0" attributes="0">74 <Group type="103" groupAlignment="0" attributes="0">
75<<<<<<< TREE
75 <Component id="jScrollPane1" pref="275" max="32767" attributes="0"/>76 <Component id="jScrollPane1" pref="275" max="32767" attributes="0"/>
76 <Component id="jScrollPane2" alignment="0" pref="275" max="32767" attributes="0"/>77 <Component id="jScrollPane2" alignment="0" pref="275" max="32767" attributes="0"/>
78=======
79 <Component id="jScrollPane1" pref="271" max="32767" attributes="0"/>
80 <Component id="jScrollPane2" alignment="0" pref="271" max="32767" attributes="0"/>
81>>>>>>> MERGE-SOURCE
77 </Group>82 </Group>
78 <EmptySpace min="-2" max="-2" attributes="0"/>83 <EmptySpace min="-2" max="-2" attributes="0"/>
79 </Group>84 </Group>
@@ -120,6 +125,9 @@
120 <Events>125 <Events>
121 <EventHandler event="mouseClicked" listener="java.awt.event.MouseListener" parameters="java.awt.event.MouseEvent" handler="lRelatedMouseClicked"/>126 <EventHandler event="mouseClicked" listener="java.awt.event.MouseListener" parameters="java.awt.event.MouseEvent" handler="lRelatedMouseClicked"/>
122 </Events>127 </Events>
128 <AuxValues>
129 <AuxValue name="JavaCodeGenerator_InitCodePre" type="java.lang.String" value="jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);"/>
130 </AuxValues>
123 </Component>131 </Component>
124 </SubComponents>132 </SubComponents>
125 </Container>133 </Container>
126134
=== modified file 'src/net/geoadel/bibcite/GUI/RelationManager.java'
--- src/net/geoadel/bibcite/GUI/RelationManager.java 2011-09-04 19:39:18 +0000
+++ src/net/geoadel/bibcite/GUI/RelationManager.java 2011-09-05 18:13:28 +0000
@@ -6,7 +6,7 @@
66
7This file is part of bibcite.7This file is part of bibcite.
88
9bibcite free software: you can redistribute it and/or modify9bibcite free software you can redistribute it and/or modify
10it under the terms of the GNU General Public License as published by10it under the terms of the GNU General Public License as published by
11the Free Software Foundation, either version 3 of the License, or11the Free Software Foundation, either version 3 of the License, or
12(at your option) any later version.12(at your option) any later version.
@@ -118,7 +118,12 @@
118 });118 });
119 jScrollPane1.setViewportView(lNotRelated);119 jScrollPane1.setViewportView(lNotRelated);
120120
121<<<<<<< TREE
121 lRelated.setModel(new javax.swing.DefaultListModel() {122 lRelated.setModel(new javax.swing.DefaultListModel() {
123=======
124 jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);
125 jList2.setModel(new javax.swing.DefaultListModel() {
126>>>>>>> MERGE-SOURCE
122 String[] strings = { "Item 1", "Item 2", "Item 3", "Item 4", "Item 5" };127 String[] strings = { "Item 1", "Item 2", "Item 3", "Item 4", "Item 5" };
123 public int getSize() { return strings.length; }128 public int getSize() { return strings.length; }
124 public Object getElementAt(int i) { return strings[i]; }129 public Object getElementAt(int i) { return strings[i]; }
@@ -159,8 +164,13 @@
159 .addComponent(jLabel2))164 .addComponent(jLabel2))
160 .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)165 .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)
161 .addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)166 .addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
167<<<<<<< TREE
162 .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE)168 .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE)
163 .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE))169 .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE))
170=======
171 .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 271, Short.MAX_VALUE)
172 .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 271, Short.MAX_VALUE))
173>>>>>>> MERGE-SOURCE
164 .addContainerGap())174 .addContainerGap())
165 );175 );
166176

Subscribers

People subscribed via source and target branches

to all changes: