Merge lp:~jnsrch/bibcite/FormerCommitsUndone into lp:bibcite

Proposed by Jens Rauch
Status: Needs review
Proposed branch: lp:~jnsrch/bibcite/FormerCommitsUndone
Merge into: lp:bibcite
Diff against target: 66 lines (+19/-1) (has conflicts)
2 files modified
src/net/geoadel/bibcite/GUI/RelationManager.form (+8/-0)
src/net/geoadel/bibcite/GUI/RelationManager.java (+11/-1)
Text conflict in src/net/geoadel/bibcite/GUI/RelationManager.form
Text conflict in src/net/geoadel/bibcite/GUI/RelationManager.java
To merge this branch: bzr merge lp:~jnsrch/bibcite/FormerCommitsUndone
Reviewer Review Type Date Requested Status
BibCite-Team Pending
Review via email: mp+74130@code.launchpad.net

Description of the change

Could not get the trunk to run properly and had some issues after merging. So I uncommited your changes and only pushed mine into this new branch.

To post a comment you must log in.
Revision history for this message
Prunus dulcis (prunus-dulcis) wrote :

I had forgotten to add one new file - will have to remember to run
bzr add
after I create a new class, image or whatnot!

Can you test the latest revision, if it runs properly again? I will look
into the merging process now.

On 05/09/11 20:14, Jens Rauch wrote:
> The proposal to merge lp:~jnsrch/bibcite/FormerCommitsUndone into lp:bibcite has been updated.
>
> Description changed to:
>
> Could not get the trunk to run properly and had some issues after merging. So I uncommited your changes and only pushed mine into this new branch.
>
> For more details, see:
> https://code.launchpad.net/~jnsrch/bibcite/FormerCommitsUndone/+merge/74130

Revision history for this message
Prunus dulcis (prunus-dulcis) wrote :

Alright, I did a manual merge - my mistake for changing the JList variable names in my commit before.

Your suggested fix does not work for me (and why can I not attach pictures here).

jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);

leads for me to elements still being centered, but instead of just one column, the elements are now wrapped into several columns, making it visually closer to left-centered but not left centered.

You can create an element with a very short name (like 'a') to see what I mean, I hope. It is quite visible in trunk with the default dataset (if debug is set TRUE in BibCite.java). Trunk should work again, I hope I fixed the issues you had with it.

Unmerged revisions

214. By Jens Rauch

Fixes 840991

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/net/geoadel/bibcite/GUI/RelationManager.form'
2--- src/net/geoadel/bibcite/GUI/RelationManager.form 2011-09-04 19:39:18 +0000
3+++ src/net/geoadel/bibcite/GUI/RelationManager.form 2011-09-05 18:13:28 +0000
4@@ -72,8 +72,13 @@
5 </Group>
6 <EmptySpace type="unrelated" max="-2" attributes="0"/>
7 <Group type="103" groupAlignment="0" attributes="0">
8+<<<<<<< TREE
9 <Component id="jScrollPane1" pref="275" max="32767" attributes="0"/>
10 <Component id="jScrollPane2" alignment="0" pref="275" max="32767" attributes="0"/>
11+=======
12+ <Component id="jScrollPane1" pref="271" max="32767" attributes="0"/>
13+ <Component id="jScrollPane2" alignment="0" pref="271" max="32767" attributes="0"/>
14+>>>>>>> MERGE-SOURCE
15 </Group>
16 <EmptySpace min="-2" max="-2" attributes="0"/>
17 </Group>
18@@ -120,6 +125,9 @@
19 <Events>
20 <EventHandler event="mouseClicked" listener="java.awt.event.MouseListener" parameters="java.awt.event.MouseEvent" handler="lRelatedMouseClicked"/>
21 </Events>
22+ <AuxValues>
23+ <AuxValue name="JavaCodeGenerator_InitCodePre" type="java.lang.String" value="jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);"/>
24+ </AuxValues>
25 </Component>
26 </SubComponents>
27 </Container>
28
29=== modified file 'src/net/geoadel/bibcite/GUI/RelationManager.java'
30--- src/net/geoadel/bibcite/GUI/RelationManager.java 2011-09-04 19:39:18 +0000
31+++ src/net/geoadel/bibcite/GUI/RelationManager.java 2011-09-05 18:13:28 +0000
32@@ -6,7 +6,7 @@
33
34 This file is part of bibcite.
35
36-bibcite free software: you can redistribute it and/or modify
37+bibcite free software you can redistribute it and/or modify
38 it under the terms of the GNU General Public License as published by
39 the Free Software Foundation, either version 3 of the License, or
40 (at your option) any later version.
41@@ -118,7 +118,12 @@
42 });
43 jScrollPane1.setViewportView(lNotRelated);
44
45+<<<<<<< TREE
46 lRelated.setModel(new javax.swing.DefaultListModel() {
47+=======
48+ jList2.setLayoutOrientation(javax.swing.JList.VERTICAL_WRAP);
49+ jList2.setModel(new javax.swing.DefaultListModel() {
50+>>>>>>> MERGE-SOURCE
51 String[] strings = { "Item 1", "Item 2", "Item 3", "Item 4", "Item 5" };
52 public int getSize() { return strings.length; }
53 public Object getElementAt(int i) { return strings[i]; }
54@@ -159,8 +164,13 @@
55 .addComponent(jLabel2))
56 .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)
57 .addGroup(jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
58+<<<<<<< TREE
59 .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE)
60 .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 275, Short.MAX_VALUE))
61+=======
62+ .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 271, Short.MAX_VALUE)
63+ .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 271, Short.MAX_VALUE))
64+>>>>>>> MERGE-SOURCE
65 .addContainerGap())
66 );
67

Subscribers

People subscribed via source and target branches

to all changes: