Merge lp:~jbaudoux/anybox.recipe.openerp/1.8.5_relative_paths_jailroot into lp:anybox.recipe.openerp
Status: | Needs review |
---|---|
Proposed branch: | lp:~jbaudoux/anybox.recipe.openerp/1.8.5_relative_paths_jailroot |
Merge into: | lp:anybox.recipe.openerp |
Diff against target: |
311 lines (+141/-21) (has conflicts) 3 files modified
anybox/recipe/openerp/base.py (+54/-1) anybox/recipe/openerp/server.py (+47/-20) doc/configuration.rst (+40/-0) Text conflict in anybox/recipe/openerp/server.py Text conflict in doc/configuration.rst |
To merge this branch: | bzr merge lp:~jbaudoux/anybox.recipe.openerp/1.8.5_relative_paths_jailroot |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Anybox | Pending | ||
Review via email:
|
Description of the change
Improvement to be compliant with buildout option "relative_paths = true"
It allows the creation of a buildout that can be moved to a jail root and run OpenERP in that jail root without any modifications to any of the files in the buildout.
This replace my first MP here:
https:/
and includes improvements from this MP
https:/
as well as some rework of that latest MP to let it work on my current setup.
See the 2 previous MP for review history.
Unmerged revisions
- 435. By Jacques-Etienne Baudoux
-
[MOD] put base addons at the end of the addons path
- 434. By Jacques-Etienne Baudoux
-
[RFR] Rewrite paths for running OpenERP in a jailroot: make jailroot-dir explicit in buildout.cfg, do not guess based on eggs directory; include addons path rewrite; rewrite calls to runtime.session
- 433. By Jacques-Etienne Baudoux
-
[MRG] lp:~anybox/anybox.recipe.openerp/1.8, revno 570
- 432. By Jacques-Etienne Baudoux
-
[FIX] Error in start_openerp script in calling _relativitiez
- 431. By Stefan Rijnhart (Opener)
-
[MRG] lp:~anybox/anybox.recipe.openerp/1.8, revno 534
- 430. By Stefan Rijnhart (Opener)
-
[FIX] Remove call to debugger
- 429. By Stefan Rijnhart (Opener)
-
[FIX] Terminology
- 428. By Stefan Rijnhart (Opener)
-
[IMP] Comment
- 427. By Stefan Rijnhart (Opener)
-
[FIX] Typo
- 426. By Stefan Rijnhart (Opener)
-
[RFR] Terminology
Hi, I'm at last in shape (well me and the recipe) to look at this request seriously. Sorry for being so slow.
First, could you please clarify some generalities for me ?
- I'm a bit confused by the jailroot terminology. Do you have something specific and hard in mind (such as a chroot or lxc container), or is this just about promising not to leave some directory, and therefore be admissible for a chroot ?
- I'm not sure to understand the use-case for the she-bang change. I'm used to control the she-bang by bootstrapping with the intended python. What's the difference here ? I got the "no modification of files" and find it a great perspective, but how does it play with the custom shebang (maybe a concrete example making the difference between building and running would help).
For the record, I've been playing with debian repackaging of buildouts lately, and I wonder if it would not precisely been served well by such features. Could it allow, e.g, to build on a CI worker in a certain directory and then run transparently in another ?
This could also be exactly what SlapOS (a distributed cloud system based on zc.buildout) would need