Merge lp:~inkscape+alexander/inkscape/clones into lp:~inkscape.dev/inkscape/trunk

[Alexander Brock]

I added "Edit->Clone->Unlink Clones recursively": It recurses into groups and unlinks every clone it finds, including clones used as clipping paths.

This is one of the features from this branch: https://code.launchpad.net/~inkscape+alexander/inkscape/flatten/+merge/260791

[Mc (mc...)]

Looks mostly fine, but I'm not a big fan of the _functions which seems to duplicate the code a bit and double number of functions. I'd prefer a ", bool flash = true" or something like that in the already present function and "if(doflash) desktop->messageStack()->flash(whatever)"

I'll re-read the main new function during the week-end and extensively test it.

[Mc (mc...)]

Ok, so with the small change I did to the codebase, here's what I think should be done:

-> add a "bool skip_undo" flag to ::setMask(), ::unsetMask(), and ::unlink() similar to what's done in other methods in the file. (Also add it to your recursive method).

-> make a ObjectSet with no SPDesktop (just the SPDocument) containing the selection, so that it does not flash recursively.

-> make all the calls with the skip_undo flag on your ObjectSet.

review: Needs Resubmitting (code, refactor)

[Alexander Brock (brock-alexander)]

> Ok, so with the small change I did to the codebase, here's what I think should
> be done:
>
> -> add a "bool skip_undo" flag to ::setMask(), ::unsetMask(), and ::unlink()
> similar to what's done in other methods in the file. (Also add it to your
> recursive method).
>
> -> make a ObjectSet with no SPDesktop (just the SPDocument) containing the
> selection, so that it does not flash recursively.
>
> -> make all the calls with the skip_undo flag on your ObjectSet.

I tried to merge your changes with my branch, failed and restarted from scratch.
I added an unlinkRecursive method to ObjectSet, added the bool skip_undo where I needed it and force-pushed the code to the old location (lp:~inkscape+alexander/inkscape/clones).

[lp:~inkscape+alexander/inkscape/clones]

15194. By Jordi Mas on 2016-10-28

[Bug #1636086] Update Catalan translation for Inkscape 0.92.

15195. By Mc on 2016-10-28

allows for denser screens in zoom correction factors

15196. By FirasH on 2016-10-29

[Bug #1574561] Italian translation update.

15197. By Jabiertxof on 2016-11-02

Close the bounding box path LPE

15198. By Jabiertxof on 2016-11-02

Fix fill between many LPE to start up with current path

15199. By Jabiertxof on 2016-11-02

Update branding folder

15200. By Jabiertxof on 2016-11-02

Fix bug:1013141 crash deleting LPE

15201. By houz on 2016-11-02

fix none color in palettes with scrollbars

15202. By houz on 2016-11-02

fix prefs icon

15203. By Mc on 2016-11-02

Add some unit tests for object-set cppification

15204. By Mc on 2016-11-03

Revert two changes from r15177

[Mc (mc...)]

Good !
I did a merge proposal to your branch to propose a simpler version of the recursive function, though it can be improved and further simplified by putting the unclip/reclip business in the unlink() function where it probably belongs.
If you find the courage, you can also propose unit tests to test the function (see testfiles/src/object-set-test.cpp )

[lp:~inkscape+alexander/inkscape/clones]

15205. By Alexander Brock <email address hidden> on 2016-11-04

Add "Edit->Clone->Unlink Clones recursively" function (ObjectSet::unlinkRecursive)

15206. By Alexander Brock <email address hidden> on 2016-11-04

Preserve clips when unlinking clones

15207. By Alexander Brock <email address hidden> on 2016-11-04

Make ObjectSet::unlink() work for clones which are both clipped and masked

15208. By Alexander Brock <email address hidden> on 2016-11-06

Remove duplicate code from unlinkRecursive() and fix issue with clones of groups

15209. By Alexander Brock <email address hidden> on 2016-11-06

Fix selection issue with ObjectSet::unlinkRecursive() and add tests for it.

Unmerged revisions

=== modified file 'src/menus-skeleton.h'
--- src/menus-skeleton.h	2016-04-15 14:39:49 +0000
+++ src/menus-skeleton.h	2016-11-04 12:38:02 +0000
@@ -66,6 +66,7 @@
 "           <verb verb-id=\"EditClone\" />\n"
 "           <verb verb-id=\"DialogClonetiler\" />\n"
 "           <verb verb-id=\"EditUnlinkClone\" />\n"
+"           <verb verb-id=\"EditUnlinkCloneRecursive\" />\n"
 "           <verb verb-id=\"EditRelinkClone\" />\n"
 "           <verb verb-id=\"EditCloneSelectOriginal\" />\n"
 "           <verb verb-id=\"EditCloneOriginalPathLPE\" />\n"
 
=== modified file 'src/object-set.h'
--- src/object-set.h	2016-11-03 23:28:50 +0000
+++ src/object-set.h	2016-11-04 12:38:02 +0000
@@ -330,7 +330,19 @@
     void deleteItems();
     void duplicate(bool suppressDone = false, bool duplicateLayer = false);
     void clone();
-    void unlink();
+
+    /**
+     * @brief Unlink all directly selected clones.
+     * @param skip_undo If this is set to true the call to DocumentUndo::done is omitted.
+     * @return True if anything was unlinked, otherwise false.
+     */
+    bool unlink(bool skip_undo = false);
+    /**
+     * @brief Recursively unlink any clones present in the current selection,
+     * including clones which are used to clip other objects, groups of clones etc.
+     * @return true if anything was unlinked, otherwise false.
+     */
+    bool unlinkRecursive(const bool skip_undo = false);
     void relink();
     void cloneOriginal();
     void cloneOriginalPathLPE();
@@ -376,7 +388,7 @@
     void createBitmapCopy();
     void setMask(bool apply_clip_path, bool apply_to_layer = false, bool skip_undo = false);
     void editMask(bool clip);
-    void unsetMask(bool apply_clip_path);
+    void unsetMask(const bool apply_clip_path, const bool skip_undo = false);
     void setClipGroup();
     
     // moves
 
=== modified file 'src/selection-chemistry.cpp'
--- src/selection-chemistry.cpp	2016-11-02 23:08:41 +0000
+++ src/selection-chemistry.cpp	2016-11-04 12:38:02 +0000
@@ -124,8 +124,8 @@
         desktop->messageStack()->flash(msgType, msg);
     } else {
         if (msgType == Inkscape::IMMEDIATE_MESSAGE ||
-            msgType == Inkscape::WARNING_MESSAGE ||
-            msgType == Inkscape::ERROR_MESSAGE) {
+                msgType == Inkscape::WARNING_MESSAGE ||
+                msgType == Inkscape::ERROR_MESSAGE) {
             g_printerr("%s\n", msg.c_str());
         }
     }
@@ -273,8 +273,8 @@
     for(auto i = boost::rbegin(selList); i != boost::rend(selList); ++i) {
         SPItem *item = *i;
         if( item &&
-            !dt->isLayer(item) &&
-            (!item->isLocked()))
+                !dt->isLayer(item) &&
+                (!item->isLocked()))
         {
             items.push_back(item);
         }
@@ -378,19 +378,19 @@
 void ObjectSet::deleteItems()
 {
     if(desktop() && tools_isactive(desktop(), TOOLS_TEXT)){
-         if (Inkscape::UI::Tools::sp_text_delete_selection(desktop()->event_context)) {
+        if (Inkscape::UI::Tools::sp_text_delete_selection(desktop()->event_context)) {
             DocumentUndo::done(desktop()->getDocument(), SP_VERB_CONTEXT_TEXT,
                                _("Delete text"));
             return;
-         }
+        }
     }
     
-        if (isEmpty()) {
-            selection_display_message(desktop(),Inkscape::WARNING_MESSAGE, _("<b>Nothing</b> was deleted."));
+    if (isEmpty()) {
+        selection_display_message(desktop(),Inkscape::WARNING_MESSAGE, _("<b>Nothing</b> was deleted."));
         return;
     }
     std::vector<SPItem*> selected(items().begin(), items().end());
-    clear(); 
+    clear();
     sp_selection_delete_impl(selected);
     if(SPDesktop *d = desktop()){
         d->currentLayer()->requestDisplayUpdate(SP_OBJECT_MODIFIED_FLAG);
@@ -404,7 +404,7 @@
         tools_switch( d, tools_active( d ) );
     }
     if(document())
-            DocumentUndo::done(document(), SP_VERB_EDIT_DELETE,
+        DocumentUndo::done(document(), SP_VERB_EDIT_DELETE,
                            _("Delete"));
 
 }
@@ -430,7 +430,7 @@
         //TODO: understand why layer management is tied to desktop and not to document.
         return;
     }
-        
+
     SPDocument *doc = document();
     
     if(!doc)
@@ -586,11 +586,11 @@
     for (auto& child: from->children) {
         SPItem *item = dynamic_cast<SPItem *>(&child);
         if (item &&
-            !desktop->isLayer(item) &&
-            (!onlysensitive || !item->isLocked()) &&
-            (!onlyvisible || !desktop->itemIsHidden(item)) &&
-            (exclude.empty() || exclude.end() == std::find(exclude.begin(), exclude.end(), &child))
-            )
+                !desktop->isLayer(item) &&
+                (!onlysensitive || !item->isLocked()) &&
+                (!onlyvisible || !desktop->itemIsHidden(item)) &&
+                (exclude.empty() || exclude.end() == std::find(exclude.begin(), exclude.end(), &child))
+                )
         {
             list.insert(list.begin(),item);
         }
@@ -628,10 +628,10 @@
         inlayer = PREFS_SELECTION_ALL;
 
     switch (inlayer) {
-        case PREFS_SELECTION_LAYER: {
+    case PREFS_SELECTION_LAYER: {
         if ( (onlysensitive && dynamic_cast<SPItem *>(dt->currentLayer())->isLocked()) ||
              (onlyvisible && dt->itemIsHidden(dynamic_cast<SPItem *>(dt->currentLayer()))) )
-        return;
+            return;
 
         std::vector<SPItem*> all_items = sp_item_group_item_list(dynamic_cast<SPGroup *>(dt->currentLayer()));
 
@@ -649,17 +649,17 @@
             }
         }
 
-            break;
-        }
-        case PREFS_SELECTION_LAYER_RECURSIVE: {
-            std::vector<SPItem*> x;
-            items = get_all_items(x, dt->currentLayer(), dt, onlyvisible, onlysensitive, FALSE, exclude);
-            break;
-        }
-        default: {
-            std::vector<SPItem*> x;
-            items = get_all_items(x, dt->currentRoot(), dt, onlyvisible, onlysensitive, FALSE, exclude);
-            break;
+        break;
+    }
+    case PREFS_SELECTION_LAYER_RECURSIVE: {
+        std::vector<SPItem*> x;
+        items = get_all_items(x, dt->currentLayer(), dt, onlyvisible, onlysensitive, FALSE, exclude);
+        break;
+    }
+    default: {
+        std::vector<SPItem*> x;
+        items = get_all_items(x, dt->currentRoot(), dt, onlyvisible, onlysensitive, FALSE, exclude);
+        break;
     }
     }
 
@@ -787,7 +787,7 @@
     }
 
     auto item = items().begin(); // leaving this because it will be useful for
-                                                                        // future implementation of complex pop ungrouping
+    // future implementation of complex pop ungrouping
     SPItem *obj = *item;
     SPItem *parent_group = static_cast<SPItem*>(obj->parent);
     if (!SP_IS_GROUP(parent_group) || SP_IS_LAYER(parent_group)) {
@@ -806,7 +806,7 @@
     
     if(document())
         DocumentUndo::done(document(), SP_VERB_SELECTION_UNGROUP_POP_SELECTION,
-                       _("Pop selection from group"));
+                           _("Pop selection from group"));
     
 }
 
@@ -883,7 +883,7 @@
     ungroup_impl(this);
     if(document())
         DocumentUndo::done(document(), SP_VERB_SELECTION_UNGROUP,
-                       _("Ungroup"));
+                           _("Ungroup"));
 }
 
 // TODO replace it with ObjectSet::degroup_list
@@ -964,7 +964,7 @@
 bool sp_item_repr_compare_position_bool(SPObject const *first, SPObject const *second)
 {
     return sp_repr_compare_position(((SPItem*)first)->getRepr(),
-            ((SPItem*)second)->getRepr())<0;
+                                    ((SPItem*)second)->getRepr())<0;
 }
 
 void ObjectSet::raise(bool skip_undo){
@@ -1015,8 +1015,8 @@
     }
     if(document() && !skip_undo)
         DocumentUndo::done(document(), SP_VERB_SELECTION_RAISE,
-                       //TRANSLATORS: "Raise" means "to raise an object" in the undo history
-                       C_("Undo action", "Raise"));
+                           //TRANSLATORS: "Raise" means "to raise an object" in the undo history
+                           C_("Undo action", "Raise"));
 }
 
 
@@ -1042,7 +1042,7 @@
     }
     if (document() && !skip_undo) {
         DocumentUndo::done(document(), SP_VERB_SELECTION_TO_FRONT,
-                         _("Raise to top"));
+                           _("Raise to top"));
     }
 }
 
@@ -1096,8 +1096,8 @@
     }
     if(document() && !skip_undo)
         DocumentUndo::done(document(), SP_VERB_SELECTION_LOWER,
-                       //TRANSLATORS: "Lower" means "to lower an object" in the undo history
-                       C_("Undo action", "Lower"));
+                           //TRANSLATORS: "Lower" means "to lower an object" in the undo history
+                           C_("Undo action", "Lower"));
 }
 
 
@@ -1183,7 +1183,7 @@
         return NULL;
 
     if ((dynamic_cast<SPGroup *>(object) && object->firstChild()) ||
-        (dynamic_cast<SPText *>(object) && object->firstChild() && object->firstChild()->getNext() == NULL)) {
+            (dynamic_cast<SPText *>(object) && object->firstChild() && object->firstChild()->getNext() == NULL)) {
         // if this is a text with exactly one tspan child, merge the style of that tspan as well
         // If this is a group, merge the style of its topmost (last) child with style
         auto list = object->children | boost::adaptors::reversed;
@@ -1268,7 +1268,7 @@
     // check if something is selected
     if (isEmpty()) {
         if(desktop())
-        desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>object(s)</b> to remove live path effects from."));
+            desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>object(s)</b> to remove live path effects from."));
         return;
     }
     auto list= items();
@@ -1281,7 +1281,7 @@
 
     if(document())
         DocumentUndo::done(document(), SP_VERB_EDIT_REMOVE_LIVEPATHEFFECT,
-                       _("Remove live path effect"));
+                           _("Remove live path effect"));
 }
 
 void ObjectSet::removeFilter()
@@ -1300,7 +1300,7 @@
     sp_repr_css_attr_unref(css);
     if(document())
         DocumentUndo::done(document(), SP_VERB_EDIT_REMOVE_FILTER,
-                       _("Remove filter"));
+                           _("Remove filter"));
 }
 
 
@@ -1334,8 +1334,8 @@
             SPItem *oldparent = dynamic_cast<SPItem *>(item->parent);
             SPItem *newparent = dynamic_cast<SPItem *>(where);
             sp_item_group_ungroup_handle_clones(item,
-                    (oldparent->i2doc_affine())
-                    *((newparent->i2doc_affine()).inverse()));
+                                                (oldparent->i2doc_affine())
+                                                *((newparent->i2doc_affine()).inverse()));
         }
     }
 }
@@ -1345,7 +1345,7 @@
     if(!desktop())
         return;
     SPDesktop *dt=desktop(); //TODO make it desktop-independent
-        
+
     // check if something is selected
     if (isEmpty()) {
         dt->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>object(s)</b> to move to the layer above."));
@@ -1515,7 +1515,7 @@
  */
 
 void ObjectSet::applyAffine(Geom::Affine const &affine, bool set_i2d, bool compensate,
-                                bool adjust_transf_center)
+                            bool adjust_transf_center)
 {
     if (isEmpty())
         return;
@@ -1559,7 +1559,7 @@
             old_center = item->getCenter();
 
 #if 0 /* Re-enable this once persistent guides have a graphical indication.
-         At the time of writing, this is the only place to re-enable. */
+    At the time of writing, this is the only place to re-enable. */
         sp_item_update_cns(*item, desktop());
 #endif
 
@@ -1716,7 +1716,7 @@
 
     if(document())
         DocumentUndo::done(document(), SP_VERB_OBJECT_FLATTEN,
-                       _("Remove transform"));
+                           _("Remove transform"));
 }
 
 void ObjectSet::setScaleAbsolute(double x0, double x1,double y0, double y1)
@@ -1955,20 +1955,20 @@
             SPIPaint *iter_paint = (type == SP_FILL_COLOR) ? &(iter->style->fill) : &(iter->style->stroke);
             match = false;
             if (sel_paint->isColor() && iter_paint->isColor() // color == color comparision doesnt seem to work here.
-                && (sel_paint->value.color.toRGBA32(1.0) == iter_paint->value.color.toRGBA32(1.0))) {
+                    && (sel_paint->value.color.toRGBA32(1.0) == iter_paint->value.color.toRGBA32(1.0))) {
                 match = true;
             } else if (sel_paint->isPaintserver() && iter_paint->isPaintserver()) {
 
                 SPPaintServer *sel_server =
-                    (type == SP_FILL_COLOR) ? sel->style->getFillPaintServer() : sel->style->getStrokePaintServer();
+                        (type == SP_FILL_COLOR) ? sel->style->getFillPaintServer() : sel->style->getStrokePaintServer();
                 SPPaintServer *iter_server =
-                    (type == SP_FILL_COLOR) ? iter->style->getFillPaintServer() : iter->style->getStrokePaintServer();
+                        (type == SP_FILL_COLOR) ? iter->style->getFillPaintServer() : iter->style->getStrokePaintServer();
 
                 if ((dynamic_cast<SPLinearGradient *>(sel_server) || dynamic_cast<SPRadialGradient *>(sel_server) ||
                      (dynamic_cast<SPGradient *>(sel_server) && dynamic_cast<SPGradient *>(sel_server)->getVector()->isSwatch()))
-                    &&
-                    (dynamic_cast<SPLinearGradient *>(iter_server) || dynamic_cast<SPRadialGradient *>(iter_server) ||
-                     (dynamic_cast<SPGradient *>(iter_server) && dynamic_cast<SPGradient *>(iter_server)->getVector()->isSwatch()))) {
+                        &&
+                        (dynamic_cast<SPLinearGradient *>(iter_server) || dynamic_cast<SPRadialGradient *>(iter_server) ||
+                         (dynamic_cast<SPGradient *>(iter_server) && dynamic_cast<SPGradient *>(iter_server)->getVector()->isSwatch()))) {
                     SPGradient *sel_vector = dynamic_cast<SPGradient *>(sel_server)->getVector();
                     SPGradient *iter_vector = dynamic_cast<SPGradient *>(iter_server)->getVector();
                     if (sel_vector == iter_vector) {
@@ -2119,7 +2119,7 @@
                 for (int i = 0; i < len; i++) {
                     match = (sel_style->marker_ptrs[i]->set == iter_style->marker_ptrs[i]->set);
                     if (sel_style->marker_ptrs[i]->set && iter_style->marker_ptrs[i]->set &&
-                        (strcmp(sel_style->marker_ptrs[i]->value, iter_style->marker_ptrs[i]->value))) {
+                            (strcmp(sel_style->marker_ptrs[i]->value, iter_style->marker_ptrs[i]->value))) {
                         match = false;
                         break;
                     }
@@ -2652,13 +2652,59 @@
     }
 }
 
-
-void ObjectSet::unlink()
+bool ObjectSet::unlinkRecursive(const bool skip_undo) {
+    if(isEmpty()){
+        if(desktop())
+            desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>clones</b> to unlink."));
+        return false;
+    }
+    bool unlinked = false;
+    ObjectSet tmp_set(document());
+    std::vector<SPItem*> items_(items().begin(), items().end());
+    for (auto& it:items_){
+        if (SP_IS_GROUP(it)) {
+            std::vector<SPObject*> c = it->childList(false);
+            tmp_set.setList(c);
+            unlinked = tmp_set.unlinkRecursive(true) || unlinked;
+        }
+        tmp_set.set(it);
+        bool has_clip  = false;
+        bool has_mask  = false;
+        Inkscape::URIReference *clip = it->clip_ref;
+        Inkscape::URIReference *mask = it->mask_ref;
+        if ((NULL != clip) && (NULL != clip->getObject())) {
+            tmp_set.unsetMask(true,true);
+            has_clip = true;
+        }
+        if ((NULL != mask) && (NULL != mask->getObject())) {
+            tmp_set.unsetMask(false,true);
+            has_mask = true;
+        }
+        unlinked = tmp_set.unlink(true) || unlinked;
+        if (has_mask)
+            tmp_set.setMask(false,false,true);
+        if (has_clip)
+            tmp_set.setMask(true,false,true);
+    }
+    if (!unlinked) {
+        if(desktop())
+            desktop()->messageStack()->flash(Inkscape::ERROR_MESSAGE, _("<b>No clones to unlink</b> in the selection."));
+    }
+    if (!skip_undo) {
+        DocumentUndo::done(document(), SP_VERB_EDIT_UNLINK_CLONE_RECURSIVE,
+                                           _("Unlink clone recursively"));
+    }
+    return unlinked;
+}
+
+
+
+bool ObjectSet::unlink(bool skip_undo)
 {
     if (isEmpty()) {
         if(desktop())
             desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>clones</b> to unlink."));
-        return;
+        return false;
     }
 
     // Get a copy of current selection.
@@ -2715,8 +2761,11 @@
             desktop()->messageStack()->flash(Inkscape::ERROR_MESSAGE, _("<b>No clones to unlink</b> in the selection."));
     }
 
-    DocumentUndo::done(document(), SP_VERB_EDIT_UNLINK_CLONE,
-                       _("Unlink clone"));
+    if (!skip_undo) {
+        DocumentUndo::done(document(), SP_VERB_EDIT_UNLINK_CLONE,
+                           _("Unlink clone"));
+    }
+    return unlinked;
 }
 
 void ObjectSet::cloneOriginal()
@@ -2876,8 +2925,8 @@
 void ObjectSet::toMarker(bool apply)
 {
     // sp_selection_tile has similar code
-    if (desktop() == NULL) { // TODO: We should not need desktop for that. 
-                             //       Someone get rid of the dt2doc() call.
+    if (desktop() == NULL) { // TODO: We should not need desktop for that.
+        //       Someone get rid of the dt2doc() call.
         return;
     }
 
@@ -2901,7 +2950,7 @@
     Geom::Point doc_height( 0, doc->getHeight().value("px"));
 
     // calculate the transform to be applied to objects to move them to 0,0
-    Geom::Point corner( r->min()[Geom::X], r->max()[Geom::Y] ); // FIXME: Inverted Y coodinate  
+    Geom::Point corner( r->min()[Geom::X], r->max()[Geom::Y] ); // FIXME: Inverted Y coodinate
     Geom::Point move_p = doc_height - corner;
     move_p[Geom::Y] = -move_p[Geom::Y];
     Geom::Affine move = Geom::Affine(Geom::Translate(move_p));
@@ -3007,7 +3056,7 @@
 
 /*
  * Convert objects to <symbol>. How that happens depends on what is selected:
- * 
+ *
  * 1) A random selection of objects will be embedded into a single <symbol> element.
  *
  * 2) Except, a single <g> will have its content directly embedded into a <symbol>; the 'id' and
@@ -3033,9 +3082,9 @@
 
     // Check if something is selected.
     if (isEmpty()) {
-      if (desktop())
-          desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>objects</b> to convert to symbol."));
-      return;
+        if (desktop())
+            desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>objects</b> to convert to symbol."));
+        return;
     }
 
     doc->ensureUpToDate();
@@ -3108,9 +3157,9 @@
 
     // Move selected items to new <symbol>
     for (std::vector<SPObject*>::const_reverse_iterator i=items_.rbegin();i!=items_.rend();++i){
-      Inkscape::XML::Node *repr = (*i)->getRepr();
-      repr->parent()->removeChild(repr);
-      symbol_repr->addChild(repr,NULL);
+        Inkscape::XML::Node *repr = (*i)->getRepr();
+        repr->parent()->removeChild(repr);
+        symbol_repr->addChild(repr,NULL);
     }
 
     if( single_group && transform.isTranslation() ) {
@@ -3154,7 +3203,7 @@
     }
 
     SPObject* symbol = single();
- 
+
     // Make sure we have only one object in selection.
     // Require that we really have a <symbol>.
     if( symbol == NULL || !dynamic_cast<SPSymbol *>( symbol ))  {
@@ -3179,14 +3228,14 @@
         SPObject *object = children[0];
         if ( dynamic_cast<SPGroup *>( object ) ) {
             if( object->getAttribute("style") == NULL ||
-                object->getAttribute("class") == NULL ) {
+                    object->getAttribute("class") == NULL ) {
 
                 group->setAttribute("transform", object->getAttribute("transform"));
                 children = object->childList(false);
             }
         }
     }
-        
+
     for (std::vector<SPObject*>::const_reverse_iterator i=children.rbegin();i!=children.rend();++i){
         Inkscape::XML::Node *repr = (*i)->getRepr();
         repr->parent()->removeChild(repr);
@@ -3291,10 +3340,10 @@
     prefs->setInt("/options/clonecompensation/value", SP_CLONE_COMPENSATION_UNMOVED);
 
     gchar const *pat_id = SPPattern::produce(repr_copies, bbox, doc,
-                                       ( Geom::Affine(Geom::Translate(desktop()->dt2doc(Geom::Point(r->min()[Geom::X],
-                                                                                            r->max()[Geom::Y]))))
-                                         * parent_transform.inverse() ),
-                                       parent_transform * move);
+                                             ( Geom::Affine(Geom::Translate(desktop()->dt2doc(Geom::Point(r->min()[Geom::X],
+                                                                                              r->max()[Geom::Y]))))
+            * parent_transform.inverse() ),
+            parent_transform * move);
 
     // restore compensation setting
     prefs->setInt("/options/clonecompensation/value", saved_compensation);
@@ -3374,8 +3423,8 @@
                 Inkscape::XML::Node *copy = child.getRepr()->duplicate(xml_doc);
                 SPItem *i = dynamic_cast<SPItem *>(item->parent->appendChildRepr(copy));
 
-               // FIXME: relink clones to the new canvas objects
-               // use SPObject::setid when mental finishes it to steal ids of
+                // FIXME: relink clones to the new canvas objects
+                // use SPObject::setid when mental finishes it to steal ids of
 
                 // this is needed to make sure the new item has curve (simply requestDisplayUpdate does not work)
                 doc->ensureUpToDate();
@@ -3517,7 +3566,7 @@
     gchar *const basename = g_strdup_printf("%s-%s-%u.png",
                                             doc->getName(),
                                             items_[0]->getRepr()->attribute("id"),
-                                            current);
+            current);
     // Imagemagick is known not to handle spaces in filenames, so we replace anything but letters,
     // digits, and a few other chars, with "_"
     g_strcanon(basename, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_.=+~$#@^&!?", '_');
@@ -3622,12 +3671,12 @@
     // Do the export
     sp_export_png_file(doc, filepath,
                        bbox->min()[Geom::X], bbox->min()[Geom::Y],
-                       bbox->max()[Geom::X], bbox->max()[Geom::Y],
-                       width, height, res, res,
-                       (guint32) 0xffffff00,
-                       NULL, NULL,
-                       true,  /*bool force_overwrite,*/
-                       items_);
+            bbox->max()[Geom::X], bbox->max()[Geom::Y],
+            width, height, res, res,
+            (guint32) 0xffffff00,
+            NULL, NULL,
+            true,  /*bool force_overwrite,*/
+            items_);
 
     // Run filter, if any
     if (run) {
@@ -3699,7 +3748,7 @@
             desktop()->messageStack()->flash(Inkscape::WARNING_MESSAGE, _("Select <b>object(s)</b> to create clippath or mask from."));
         return;
     }
-        
+
     std::vector<Inkscape::XML::Node*> p(xmlNodes().begin(), xmlNodes().end());
     
     sort(p.begin(),p.end(),sp_repr_compare_position_bool);
@@ -3794,7 +3843,7 @@
  * If \a apply_clip_path parameter is true, clipPath is created, otherwise mask
  *
  */
- void ObjectSet::setMask(bool apply_clip_path, bool apply_to_layer, bool skip_undo)
+void ObjectSet::setMask(bool apply_clip_path, bool apply_to_layer, bool skip_undo)
 {
     if(!desktop() && apply_to_layer)
         return;
@@ -3960,7 +4009,7 @@
     }
 }
 
-void ObjectSet::unsetMask(bool apply_clip_path) {
+void ObjectSet::unsetMask(const bool apply_clip_path, const bool skip_undo) {
     SPDocument *doc = document();
     Inkscape::XML::Document *xml_doc = doc->getReprDoc();
 
@@ -4010,13 +4059,13 @@
 
         SPGroup *group = dynamic_cast<SPGroup *>(*i);
         if (ungroup_masked && group) {
-                // if we had previously enclosed masked object in group,
-                // add it to list so we can ungroup it later
+            // if we had previously enclosed masked object in group,
+            // add it to list so we can ungroup it later
 
-                // ungroup only groups we created when setting clip/mask
-                if (group->layerMode() == SPGroup::MASK_HELPER) {
-                    items_to_ungroup = g_slist_prepend(items_to_ungroup, group);
-                }
+            // ungroup only groups we created when setting clip/mask
+            if (group->layerMode() == SPGroup::MASK_HELPER) {
+                items_to_ungroup = g_slist_prepend(items_to_ungroup, group);
+            }
 
         }
     }
@@ -4082,10 +4131,12 @@
     // rebuild selection
     addList(items_to_select);
 
-    if (apply_clip_path) {
-        DocumentUndo::done(doc, SP_VERB_OBJECT_UNSET_CLIPPATH, _("Release clipping path"));
-    } else {
-        DocumentUndo::done(doc, SP_VERB_OBJECT_UNSET_MASK, _("Release mask"));
+    if (!skip_undo) {
+        if (apply_clip_path) {
+            DocumentUndo::done(doc, SP_VERB_OBJECT_UNSET_CLIPPATH, _("Release clipping path"));
+        } else {
+            DocumentUndo::done(doc, SP_VERB_OBJECT_UNSET_MASK, _("Release mask"));
+        }
     }
 }
 
 
=== modified file 'src/verbs.cpp'
--- src/verbs.cpp	2016-11-02 22:42:43 +0000
+++ src/verbs.cpp	2016-11-04 12:38:02 +0000
@@ -1009,6 +1009,9 @@
         case SP_VERB_EDIT_UNLINK_CLONE:
             dt->selection->unlink();
             break;
+        case SP_VERB_EDIT_UNLINK_CLONE_RECURSIVE:
+            dt->selection->unlinkRecursive();
+            break;
         case SP_VERB_EDIT_RELINK_CLONE:
             dt->selection->relink();
             break;
@@ -2530,6 +2533,8 @@
                  N_("Create a clone (a copy linked to the original) of selected object"), INKSCAPE_ICON("edit-clone")),
     new EditVerb(SP_VERB_EDIT_UNLINK_CLONE, "EditUnlinkClone", N_("Unlin_k Clone"),
                  N_("Cut the selected clones' links to the originals, turning them into standalone objects"), INKSCAPE_ICON("edit-clone-unlink")),
+    new EditVerb(SP_VERB_EDIT_UNLINK_CLONE_RECURSIVE, "EditUnlinkCloneRecursive", N_("Unlink Clones _recursively"),
+                 N_("Unlink all clones in the selection, even if they are in groups."), INKSCAPE_ICON("edit-clone-unlink")),
     new EditVerb(SP_VERB_EDIT_RELINK_CLONE, "EditRelinkClone", N_("Relink to Copied"),
                  N_("Relink the selected clones to the object currently on the clipboard"), NULL),
     new EditVerb(SP_VERB_EDIT_CLONE_SELECT_ORIGINAL, "EditCloneSelectOriginal", N_("Select _Original"),
 
=== modified file 'src/verbs.h'
--- src/verbs.h	2016-10-08 06:16:53 +0000
+++ src/verbs.h	2016-11-04 12:38:02 +0000
@@ -83,6 +83,7 @@
     SP_VERB_EDIT_DUPLICATE,
     SP_VERB_EDIT_CLONE,
     SP_VERB_EDIT_UNLINK_CLONE,
+    SP_VERB_EDIT_UNLINK_CLONE_RECURSIVE,
     SP_VERB_EDIT_RELINK_CLONE,
     SP_VERB_EDIT_CLONE_SELECT_ORIGINAL,
     SP_VERB_EDIT_CLONE_ORIGINAL_PATH_LPE,