Code review comment for lp:~inkscape+alexander/inkscape/clones

Revision history for this message
Mc (mc...) wrote :

Looks mostly fine, but I'm not a big fan of the _functions which seems to duplicate the code a bit and double number of functions. I'd prefer a ", bool flash = true" or something like that in the already present function and "if(doflash) desktop->messageStack()->flash(whatever)"

I'll re-read the main new function during the week-end and extensively test it.

« Back to merge proposal