Merge lp:~inkscape+alexander/inkscape/clones into lp:~inkscape.dev/inkscape/trunk
Proposed by
Alexander Brock
Status: | Superseded |
---|---|
Proposed branch: | lp:~inkscape+alexander/inkscape/clones |
Merge into: | lp:~inkscape.dev/inkscape/trunk |
Diff against target: |
184 lines (+80/-11) 5 files modified
src/menus-skeleton.h (+1/-0) src/object-set.h (+14/-2) src/selection-chemistry.cpp (+59/-9) src/verbs.cpp (+5/-0) src/verbs.h (+1/-0) |
To merge this branch: | bzr merge lp:~inkscape+alexander/inkscape/clones |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mc | code, refactor | Pending | |
Martin Owens | Pending | ||
Review via email: mp+310059@code.launchpad.net |
This proposal supersedes a proposal from 2016-10-27.
This proposal has been superseded by a proposal from 2016-11-04.
Commit message
Add "Edit->
Description of the change
I added "Edit->
Mc... rewrote the function and I improved it further.
To post a comment you must log in.
Looks mostly fine, but I'm not a big fan of the _functions which seems to duplicate the code a bit and double number of functions. I'd prefer a ", bool flash = true" or something like that in the already present function and "if(doflash) desktop- >messageStack( )->flash( whatever) "
I'll re-read the main new function during the week-end and extensively test it.