Merge lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp into lp:python-tx-tftp
Status: | Needs review |
---|---|
Proposed branch: | lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp |
Merge into: | lp:python-tx-tftp |
Diff against target: |
12 lines (+1/-1) 1 file modified
tftp/session.py (+1/-1) |
To merge this branch: | bzr merge lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella | Needs Information | ||
Andres Rodriguez (community) | Approve | ||
Review via email: mp+208862@code.launchpad.net |
Commit message
Increase MAX_BLOCK_SIZE to 8192
Description of the change
The current MAX_BLOCK_SIZE only allows files of up to ~87 MB in size.
Considering that a windows winpe ramdisk can grow to about ~270 MB,
it would just fail after block nr 65535. Increasing this constant
will allow larger files to be transmited.
It is not mandatory for the client to ask for a block size as large as this. It
is just a higher cap, up to which a client may negotiate.
Preferably, this would be configurable per backend, and not hardcoded
in session.py.
Unmerged revisions
- 39. By Gabriel Samfira
-
Increase MAX_BLOCK_SIZE to 8192
The current MAX_BLOCK_SIZE only allows files of up to ~87 MB in size.
Considering that a windows winpe ramdisk can grow to about ~270 MB,
it would just fail after block nr 65535. Increasing this constant
will allow larger files to be transmited.It is not mandatory for the client to ask for a block size as large as this. It
is just a higher cap, up to which a client may negotiate.Preferably, this would be configurable per backend, and not hardcoded
in session.py.
lgtm!