Code review comment for lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp

Revision history for this message
Gabriel Samfira (gabriel-samfira) wrote :

So, I implemented rollover. It works as well, but compared to just making MAX_BLOCK_SIZE bigger, its painfully slow. We can have both, to be honest...

I updated the pull request here:

https://github.com/shylent/python-tx-tftp/pull/17

Feel free to test the changes. They work well in my setup, but having someone else have a stab at it can not hurt.

« Back to merge proposal