Code review comment for lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp

Revision history for this message
Alessandro Pilotti (alexpilotti) wrote :

This is the way in which Windows handles the initial WinPE image deployment. SMB file transfer is used for the remaining steps.

As a comparison, the Microsoft TFTP service has a default block size of 16384.

A higher value then 1400 (in the UPD packet size limits) speeds up the deployment in scenarios where fragmentation is avoided (e.g. LAN) as the TFTP protocol expects an ACK for every UDP packet sent.

I agree that it looks like they preferred to stay in the default MTU safety margins.

We sent a pull request upstream as well: https://github.com/shylent/python-tx-tftp/pull/17

Thanks!

« Back to merge proposal